When downloading an app previously the pending icon would show the full color icon when it was in a folder preview. To fix, we consolidated the logic for pending icons in PreloadIconDrawable and moved the logic of the pending state to the ItemInfoWithIcon model to represent the state of a pending application inside the model instead of in views.
Bug: b/324629535
Test: ItemInfoWithIconTest.kt
Flag: None
Change-Id: I4ffab44ddead046adcc84911039c87ea7c304e63
* Previously we assume the split placeholder view shouldn't be
present in any states except launcher split selection, however
with contextual that changes.
* Now we only ensure that view isn't there in all apps when
we are not in split selection.
Test: Test runs and passes locally
Fixes: 323418145
Change-Id: Ida92030f9b139532ebb09c1d2646795bbb940bfc
Also adds a helper in popup data provider to provide categorized
suggestions. Used in follow up CL to update the UI.
Bug: 318410881
Test: WidgetsPredictionUpdateTaskTest and manual with follow up changes
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: Ie80e8ba7bbe874f7c4b0e579446edf571036555e
Widgets which were expected to be restored, were missing for apps which were pre-archived.
The fix adds checks for archived apps when processing widgets and ensures that icon with cloud overlay is present on the widget.
Test: Flashed device with build containing this fix.
Screenshot right after SuW- http://shortn/_LoLudMXEaT
Bug: 321297173
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: I32bc51ead2870670efc8eba24f17896aedcc3b9f
This reverts commit dd33b64a64.
Reason for revert: “DroidMonitor: Potential culprit for Bug b/323619378 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.”.
Bug:323619378
Change-Id: Iadaa80f2cc51f39ae3ab73cdd49a98d05835506e
This CL makes it so that LauncherAccessibilityDelegate properly calls snapToPage() when saving a new app pair.
Fixes: 322758994
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I9b571989761c36ce1c1de1e1eec6a4f559cb6428
This helps to ensure that the test doesn't proceed while the activity is
still stopping and it's state hasn't settled.
We introduce a count of STOP events and make sure it's 0 except for
cases where stops are safe to ignore or we have waited for them.
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I51c73c89854fcaa390d47a57389da18b2ce0ee6c
The filter was missing from the refactor in ag/25502473.
There aren't currently WidgetPicker tests that would catch this behavior
but there should be.
Bug: 317452407
Test: Ran existing widget tests, looking at adding work profile tests.
Flag: none
Change-Id: I2ce8464a1c76505bfe7ce8cf4280bb5b576cdb1d
The recycler view when displayed in single pane picker, for large screen
gets a larger padding. But when displayed in two pane picker, it is not
needed - so we override it.
Foldable's unfolded portrait doesn't seem to have screenshot test
- will look into if we can add one in follow up.
Bug: 322719955
Test: Screenshot test for existing modes & manual (see bug)
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT
Change-Id: Ibd72146e7e5230eec0d2ce01c3917819a73d8f32
* If we're in split selection state we disable the following
- G icon on PSB
- Lens icon on PSB
- Smartspace
- Widgets
Bug: 295467097
Test: Enter split contextual and observe split instructions
view going boing when tapping on unsupported target
Flag: com.android.wm.shell.enable_split_contextual
Change-Id: Ia7783472f3de9359c2784788be5f35596cbc8deb
Currently only the lock button in contianer
is tappable when PS is locked.
This change makes both the container and
button tappable.
In unlock state, the container is not tappable.
Bug: 313859437
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space TRUNKFOOD
Test: Launcher3 test.
Change-Id: I1ae267d50a999e723932136dffa3ae8243d439c0
* changes:
Fix small gap between widget resize frame and widget background.
Update TaplAddWidgetTest#testResizeWidget() and WidgetResizeFrame#resize() API to pass launcher's cellBoarderSpace and use its height to expand widget
To expand widget vertically, the drag distance has to be >= 0.66 * (cellHeight + cellBoarderSpace.y). The TAPL test should add cellBoarderSpace.y onto the vertical drag distance to make test less flaky.
Bug: 291104076
Test: Postsubmit passed https://android-build.corp.google.com/builds/abtd/run/L49100030001703948
Flag: NA
Change-Id: I602cf29b83df6875abd8eadfe255a2adb13f03cb
Updated the KQS overview launch animation to match the spec: open overview and scroll to the focused task in one fluid motion
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313608085
Test: Opened KQS from home and overview
Change-Id: I2d617db29ff46e89fab50bb6f8aee900b6fe649f
This Cl restricts item dragging for PS apps from
all launcher surfaces such as AllApps, AppPredictionRow, etc.
Video: https://photos.app.goo.gl/PKGw8n23hJVJMyUk7
Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_item_drag DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I2c5dbaa325095ec63aedf39b6b2c269f745d58ca
Andrew Cole
Helen Cheuk
Federico Baron
Vinit Nayak
Fengjiang Li
Shamali Patwa
Sunny Goyal
Priyanka Advani
Piyush Mehrotra
Jakob Schneider
Himanshu Gupta
Jeremy Sim
Cliff Wang
Vadim Tryshev
Zak Cohen
Tony Wickham
Rohit Goyal
Anushree Ganjam
Brandon Dayauon
Schneider Victor-tulias