Commit Graph

19940 Commits

Author SHA1 Message Date
Andy Wickham d4100bec42 Fix All Apps interpolators and blur.
Fixes an issue where leaving All Apps did not reverse interpolators,
causing blur to disappear too quickly.

In addition, the logic in BaseDepthController is updated to ensure
100% blur is applied upon reaching max depth. Previously we were
multiplying the depth by 3, but the intention was to reach 1 when
depth reached 0.3. So the blur was only at 90% the intended value in
All Apps (which has a depth of 0.3).

Finally, related to the 100% blur, we correctly end early wakeup
when that is reached, which means we also start it again when the
blur starts changing back towards 0 again. This spins up the GPU,
CPU, and SurfaceFlinger and should help avoid missed frames.

In order to avoid negative performance hits, reducing the max blur
radius from 34dp to 30dp, so that it matches what we were hitting
previously. (The full 34dp unfortunately does cause some regressions).

Bug: 415247657
Test: Open all apps, drag back down, view animation. Also try other
Launcher state transitions.
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ia5daa07525ac96c0597a25bb4320348f27a4ee56
2025-05-15 17:53:17 -07:00
Alex Chau 38efd382b7 Merge "Revert "Recreate Launcher activity when blur enabled changes"" into main 2025-05-15 13:07:22 -07:00
Sunny Goyal 1d4a457680 Merge "Adding repository for AppsList data" into main 2025-05-15 12:23:44 -07:00
Catherine Liang 00dbb434dd Fix incorrect widget layout when previewing grid
When previewing grid, actual widgets are updated. Revert grid changes
when preview binder dies to restore original widget layout in Launcher.

Flag: com.android.systemui.shared.new_customization_picker_ui
Bug: 408934352
Test: manually verified
Change-Id: I18f63fd1760b1188306defd2a8315fe5765dab01
2025-05-15 18:43:27 +00:00
Priyanka Advani (xWF) 1f891a6b67 Revert "Recreate Launcher activity when blur enabled changes"
Revert submission 33554447-b/414789280

Reason for revert: Droidmonitor created revert due to b/417614196. Will be verifying through ABTD before submission.

Fix: 417614196

Reverted changes: /q/submissionid:33554447-b/414789280

Change-Id: Idf349cd39a3f86910f597f0f9ab4d46fb03e945c
2025-05-15 11:12:05 -07:00
Alex Chau 6564f33184 Merge "Remove debug logs on a closed bug" into main 2025-05-15 06:37:49 -07:00
Alex Chau b7dd7bf1e0 Merge "Recreate Launcher activity when blur enabled changes" into main 2025-05-15 06:07:58 -07:00
Sunny Goyal 869b20cb27 Adding repository for AppsList data
Flag: com.android.launcher3.model_repository
Test: atest AppsListRepositoryTest
Bug: 390572144
Change-Id: I6e5993c91f77ed8f0b6f2c12c9d743c87a497134
2025-05-14 21:19:18 -07:00
Treehugger Robot 6bcd5d93de Merge "launcher3: Add error handling for drag preview bitmap creation." into main 2025-05-14 19:02:50 -07:00
Brandon Dayauon 11388a53f4 Merge "Make hotseatQsbShadowHeight public" into main 2025-05-14 17:48:57 -07:00
Adnan Begovic 0e41e168b2 launcher3: Add error handling for drag preview bitmap creation.
In some cases, the bitmap that is needed for FastBitmapDrawable
can fail to render. Return a placeholder in that case.

Bug: 416779946
Flag: EXEMPT Bug fix
Test: manual
Change-Id: I188a820157f4ac43b8a13a99f3ac2c2348afbc13
2025-05-14 16:28:34 -07:00
Treehugger Robot 753ee52a18 Merge "Support desktop device category in grid options" into main 2025-05-14 13:30:52 -07:00
Brandon Dayauon 653b4b9b31 Make hotseatQsbShadowHeight public
This variable is used during layout of the psb in hotSeat.java. It is specifically
applied to calculate the qsbOffsetY()

bug: 413719316
Test: manually presubmit
Flag: com.google.android.apps.nexuslauncher.psb_aim_reskin
Change-Id: I9b4bd244a39de61e7ef23dbf477e1808f30f5401
2025-05-14 11:33:10 -07:00
Alex Chau a6fa3db580 Recreate Launcher activity when blur enabled changes
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles

Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I90ad724867283fe3c62a9073a6e072491533f774
2025-05-14 17:45:04 +01:00
Treehugger Robot 8cc0274fb0 Merge "Fixing leak in model repository" into main 2025-05-13 17:55:55 -07:00
Sunny Goyal 6e8b2bc95b Fixing leak in model repository
Bug: 417356788
Flag: com.android.launcher3.model_repository
Test: atest TaplDragTest
Change-Id: I4b11a521d66790637dfc05682fb1550f6cc9adcd
2025-05-13 15:15:11 -07:00
Daniel Akinola 6efff5eeac Update StatusBarTouchController to work on external display
Dragging on launcher background on external display didn't do anything
because there was no StatusBarTouchController. Now by adding it to
SecondaryDragLayer, we can open the shade on external display via
launcher drag

Bug: 362719719
Bug: 416511740
Test: manual testing
Flag: EXEMPT refactor only
Change-Id: I1a587fe85bf2e7c6f212b3358646d5d282019eef
2025-05-13 13:26:41 -07:00
Sunny Goyal 43841027b0 Merge "Removing some unnecessary launcher typecast" into main 2025-05-13 11:42:34 -07:00
Sunny Goyal b2315b69c2 Removing some unnecessary launcher typecast
Bug: 417227133
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ie794e4855441f86441d869d315699bf46fce0db5
2025-05-13 08:26:25 -07:00
Naresh Kumar Podishetty (xWF) b02666e592 Merge "Revert "Update All Apps sheet interpolators."" into main 2025-05-12 23:46:34 -07:00
Ana Salazar 501df846c4 Support desktop device category in grid options
Adds desktop enum value to grid option deviceCategory attribute type.
The device type is used for devices that have
`R.bool.desktop_form_factor` config value set.

Bug: 30153091
Flag: com.android.launcher3.enable_scalability_for_desktop_experience
Test: Manual
Change-Id: Ie4747b5bae3e124e914af51445778c9b6285ff66
2025-05-13 04:17:34 +00:00
Sunny Goyal fabe5b213d Merge "Adding support for diff in WorkspaceData, so that UI can apply incremental updates" into main 2025-05-12 18:27:05 -07:00
Treehugger Robot b478d366b5 Merge "Moving some static debug initialization out of Launcher to MainProcessInitializer" into main 2025-05-12 18:20:14 -07:00
Treehugger Robot cb527028ad Merge "launcher3: Avoid mutating model on collisions in Launcher3." into main 2025-05-12 18:17:18 -07:00
Priyanka Advani (xWF) 8e59df0bda Revert "Update All Apps sheet interpolators."
This reverts commit 28f422544e.

Reason for revert: Droidmonitor created revert due to Jank Regression b/415709038.

Bug: 415247657
Fix: 415709038
Change-Id: Iaf692dd2e054c548a6b40831ce6d51a546642ac4
2025-05-12 17:09:05 -07:00
Sunny Goyal aeeeb7e220 Moving some static debug initialization out of Launcher to MainProcessInitializer
Bug: 417227133
Test: Presubmit
Flag: EXEMPT refactor and debug code
Change-Id: If16878b6fb93333989897ce7d2f793395c8a14dd
2025-05-12 15:50:04 -07:00
Adnan Begovic 1ada2c53ea launcher3: Avoid mutating model on collisions in Launcher3.
Collisions should be handled prior to binding in the ui layer.

The following change adds extra logging to help identify cases
where this might occur.

Bug: 417021465
Flag: EXEMPT Bug fix
Test: manual
Change-Id: I5549c94fe81eb13088f8c56a5ff797d46d4bedb2
2025-05-12 15:49:02 -07:00
Treehugger Robot de9b62ed3e Merge "Fix All Apps fallback colors." into main 2025-05-12 14:02:18 -07:00
Treehugger Robot d89bd8d886 Merge "Split BlurStyle and BlurFallbackStyle for All Apps and Overview." into main 2025-05-12 14:02:09 -07:00
Treehugger Robot 8381d839f7 Merge "Use RecentsWindowFlags in DisplayController" into main 2025-05-12 13:58:24 -07:00
Treehugger Robot 70e3cd4b67 Merge "Simplifying startup latency logger by moving everything to a single class" into main 2025-05-12 12:41:47 -07:00
Liam Lee Pong Lam b2f178178e Merge "Remove navigate_to_child_preference flag" into main 2025-05-12 11:41:28 -07:00
Treehugger Robot dbce6aeefb Merge "Reduce combine() usage as it is expensive" into main 2025-05-12 11:15:52 -07:00
Sunny Goyal e40896639b Simplifying startup latency logger by moving everything to a single class
> Moving some latency logic out of Launcher and into logger
> This makes it easier to move the logger completely out of Launcher

Bug: 390572144
Test: atest StartupLatencyLoggerTest
Flag: EXEMPT refactor

Change-Id: I6f6d99e7ed6c77610534c64461ec34200780225f
2025-05-12 09:39:06 -07:00
Ajinkya Chalke 36a811aa57 Use RecentsWindowFlags in DisplayController
- Instead of using enableOverviewOnConnectedDisplays from aconfig
  directly, use WindowManagerProxy to use RecentsWindowFlags so that we
  can use DesktopExperiencesFlags version for dev option.

Bug: 413609179
Test: m
Flag: EXEMPT flag infra
Change-Id: Iaacf068be13282017f94360acce1eea9aa1b0e84
2025-05-12 15:44:08 +00:00
Uwais Ashraf da860e3d46 Reduce combine() usage as it is expensive
Flag: com.android.launcher3.enable_coroutine_threading_improvements
Bug: 416206104
Test: Perfetto trace comparison shows fewer continuations
Test: TaskViewModelTest
Change-Id: Id5c645afff9850453139b85dbcda907cd12c5d26
2025-05-12 12:54:11 +00:00
Brandon Dayauon ab84f60449 Merge "Change PS app behavior when clicking" into main 2025-05-10 03:11:55 -07:00
Treehugger Robot 0a38582ff6 Merge "Use dimen for GridSize_minDeviceWidth/Height" into main 2025-05-09 20:47:49 -07:00
Andy Wickham 58fd27a0cb Fix All Apps fallback colors.
Spec is linked in the bug.

Test: Manual
Fix: 415847439
Flag: com.android.launcher3.all_apps_blur
Change-Id: I805aff19bb3d15d479b7c2c026f041c35585efd2
2025-05-10 01:21:54 +00:00
Andy Wickham 359280ef2c Split BlurStyle and BlurFallbackStyle for All Apps and Overview.
Problem: We don't want to apply the blur style to All Apps if the
all_apps_blur flags are disabled. However, we want to still apply
the relevant colors for Overview when the Overview blur is enabled.

Solution: Split the styles into All Apps and Overview variants.
Unfortunately this creates quite a bit of extra code, but such is
the nature of flag permutations.

This is a more comprehensive color fix compared to ag/33356345,
which is reverted as part of this CL.

Note: enable_overview_background_wallpaper_blur is already broken
when disabled without this change (the live tile gets blurred),
presumably because it's already in nextfood and hasn't been tested
disabled. As such, I focused on testing All Apps blur flags both
enabled and both disabled, with the Overview flag always enabled.

Demo with All Apps flags disabled:
 - Blurs enabled (Overview should blur; All Apps unaffected):
   https://drive.google.com/file/d/1eb882JKSMF-Irc7Ls-iAClYfJIASzzXs/view?usp=drive_link&resourcekey=0-j5EafBfVHIh5oOSFzsYE4g
 - Blurs disabled (Overview should not blur; All Apps unaffected):
   https://drive.google.com/file/d/1toVHYUTj9FjpXCD7m8waeuFIwBbdy_Am/view?usp=drive_link&resourcekey=0-drqPVsELmgJVxhpgxLc-aQ

Demo with All Apps flags enabled:
 - Blurs enabled (Overview and All Apps should blur):
   https://drive.google.com/file/d/1se5yaPDYdDKcoBjZSjDSlqCiSfX0bmHv/view?usp=drive_link&resourcekey=0-U9fBJSVYY9na9r8J5xHXMw
 - Blurs disabled (Overview and All Apps should not blur):
   https://drive.google.com/file/d/1YmqlCdSJDZXGSgpeO5hk16V8Y-6tVpeW/view?usp=drive_link&resourcekey=0-rK4Zy7D8fFyPMA_1XXxwCQ
   (Note: All Apps fallback colors will change with ag/33405653)

Test: Above videos
Fix: 416248709
Flag: com.android.launcher3.all_apps_blur
Flag: com.android.launcher3.all_apps_sheet_for_handheld
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I9b5cf6b0dce4014053b27ea95a91d047262427b2
2025-05-10 01:21:43 +00:00
Treehugger Robot d506f0154b Merge "Adding support for generating a preview bitmap with an optional delay to allow widgets to be rendered" into main 2025-05-09 17:16:29 -07:00
Sunny Goyal 473bc9a06a Adding support for diff in WorkspaceData, so that UI can apply incremental updates
Bug: 390572144
Flag: com.android.launcher3.model_repository
Test: atest WorkspaceDataTest

Change-Id: I5fead4fdedfa2f6ac03ca106f7f0a5900af3760e
2025-05-09 15:26:09 -07:00
Brandon Dayauon 424d5686e4 Change PS app behavior when clicking
It should show the shortcuts upon tap and not animate like if you were to longpress to shortcuts on a regular app.

bug: 406724060
Test: manually video: https://drive.google.com/file/d/1ldodFhr00lTJ5583VxMe7PasZ0jre6wd/view?usp=sharing
Flag: android.multiuser.enable_moving_content_into_private_space
Change-Id: I5762689290b4078f9b1b4fdfd09fb2cef482744a
2025-05-09 14:59:45 -07:00
Treehugger Robot c9eb3511d2 Merge "Separate blur/fallback styles for all apps and overview" into main 2025-05-09 13:34:51 -07:00
Coco Duan b97962a927 Merge "Show all default widgets in glanceable hub widget picker" into main 2025-05-09 11:48:32 -07:00
Sunny Goyal 63fe0c779e Adding support for generating a preview bitmap with an optional delay to allow widgets to be rendered
> Adding a completionSignal when preview is generated so that callers can wait on it
> Also adding support for proving an optional screen-id for preview

Bug: 400403115
Test: atest GridPreviewTest
Flag: EXEMPT refactor and unused new API

Change-Id: I569e0ab318ad101e4f6dd808f2e1cfc39ba50bda
2025-05-09 10:42:39 -07:00
Uwais Ashraf 1ae9814920 Merge "Create separate worker threads for IO work and lighter BG work" into main 2025-05-09 09:45:40 -07:00
Alex Chau 61853619c0 Remove debug logs on a closed bug
Bug: 246283207
Test: presubmit
Flag: EXEMPT clean up
Change-Id: I54aa8ffe929494c4c0ea97c016f9d53f7e27024c
2025-05-09 16:17:07 +01:00
Will Osborn ddbce96536 Merge "Check for null display in DisplayController onDisplayAdded" into main 2025-05-09 05:50:00 -07:00
vinayjoglekar 3997f6ce4a Separate blur/fallback styles for all apps and overview
Fix: 415233763
Test: Manual. go to overview/all apps enable/disable battery saver mode.
Flag: com.android.launcher3.all_apps_blur
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I4fdb672feb34d4b4da74f430eb8ef9a86ec3adf2
2025-05-09 10:17:11 +01:00