Commit Graph

12831 Commits

Author SHA1 Message Date
Brian Isganitis d3ebc4c692 Merge "Adding support for logging wallpaper container info." into sc-v2-dev 2021-12-08 05:48:30 +00:00
Brian Isganitis 79efba935f Adding support for logging wallpaper container info.
Test: https://paste.googleplex.com/5350571797118976 shows logging carousel size and index of wallpaper tapped. If the wallpaper is a live wallpaper, we also log its application info.
Bug: 188222480
Change-Id: I6dd7ac20af7afd675d8a886d5b838263680f773e
Merged-In: I6dd7ac20af7afd675d8a886d5b838263680f773e
2021-12-08 00:22:59 +00:00
Tony Wickham 779879ce3d Merge "Remove LauncherState.TASKBAR visible element" into sc-v2-dev 2021-12-07 20:42:55 +00:00
Alex Chau 992db75dae Use percentage scaling for overview thumbnail size
- Limit overview to screen ratio to be at max 70%
- Tuned row spacing and page spacing
- Added 2 more test activities to testOverviewForTablet to avoid dismissing tasks at end of grid, as more grid tasks are now shown

Bug: 207350366
Test: manual
Change-Id: Id04871464bdb3ef2d6b046977b0ffd9bd51bc230
Merged-In: Id04871464bdb3ef2d6b046977b0ffd9bd51bc230
2021-12-07 14:50:40 +00:00
Tony Wickham 7af54403a3 Remove LauncherState.TASKBAR visible element
It's no longer used, so removing to cleanup code and reduce confusion

Test: no functional change
Fixes: 209512651
Change-Id: Ibd671bde7190df976b5365331731a55a9abdbb35
2021-12-06 15:59:39 -08:00
Jon Miranda 52ee4ec4aa Merge "Play return to icon animation if user swipes back to All Apps." into sc-v2-dev 2021-12-06 18:17:52 +00:00
Alex Chau 5656154f1a Merge "Add back screenshot button to Launcher3" into sc-v2-dev 2021-12-06 17:37:42 +00:00
TreeHugger Robot ad890ac5af Merge "Use getMeasuredWidth instead of getWidth in setSplitIconParams" into sc-v2-dev 2021-12-03 20:23:58 +00:00
Alex Chau 4bdf8c1754 Use getMeasuredWidth instead of getWidth in setSplitIconParams
Fix: 208647202
Test: Enter overview with app pairs, rotate and rotate back, check the task icon
Change-Id: I14914258a2508cf3f399312f4c88574b27a5e9fa
2021-12-03 18:28:38 +00:00
Alex Chau dc73072797 Constraint Snackbar's width to 504dp
Fix: 209005185
Test: manual
Change-Id: I512ddb575a9fced4bf2608806aef875fe34304e6
2021-12-03 16:20:42 +00:00
Alex Chau 1bf0fe1b70 Add back screenshot button to Launcher3
- Also make spacing between buttons always 36dp
- Updated screenshot button image for Launcher3

Fix: 208384949
Test: Start overview in Launcher3WithQuickStep, test screenshot button is working
Change-Id: Ieb60ce134813202c1d14137fff0a131e1f5f8c96
2021-12-03 12:32:29 +00:00
Alex Chau 683b4cd824 Merge "Destroy activity/view references to avoid memory leak" into sc-v2-dev 2021-12-03 12:30:49 +00:00
Vinit Nayak 573fca80f6 Destroy activity/view references to avoid memory leak
Bug: 204891006
Change-Id: If60ac1716c30ebe68fb6e7457d71f542d3075422
2021-12-02 16:05:52 -08:00
TreeHugger Robot 7f54d5cde4 Merge "Add icons for staged split" into sc-v2-dev 2021-12-02 23:00:48 +00:00
Alex Chau b31176c83b Merge "Fix switch access for overview grid" into sc-v2-dev 2021-12-02 22:32:01 +00:00
Vinit Nayak 455197bf41 Add icons for staged split
Fixes: 208649953
Change-Id: I8b7bb3a650e836608ebe6aa50631026f5f6a7c63
2021-12-01 14:58:53 -08:00
Brian Isganitis be388b8933 Merge "Make action optional for snackbar." into sc-v2-dev 2021-12-01 00:18:40 +00:00
Jonathan Miranda 199644c397 Merge "Fix NPE in FloatingIconView" into sc-v2-dev 2021-11-30 18:43:29 +00:00
TreeHugger Robot 96f34af124 Merge "Fling to close tasks in the GestureNav can be too small." into sc-v2-dev 2021-11-30 18:34:09 +00:00
TreeHugger Robot c5f18aa980 Merge "Resets taskSplitTranslation of inactive orientation" into sc-v2-dev 2021-11-26 18:23:43 +00:00
Alex Chau 9ead9ca226 Fix switch access for overview grid
- Removed overscroll checking in switch access, as overscroll isn't supported via snapToPage
- Don't show forward/backward action if no further scroll is possible
- When scrolling right in overveiw grid, snap to the next non-fully visible task
- When scrolling left in overview grid, snap to a position that next non-fully visible task is on the left of the screen

Fix: 204162346
Test: Use switch action in Workspace/Recents with and w/o RTL
Change-Id: I0d4f201edf2da543703e88420e6f3255fb2ba16f
2021-11-26 17:51:32 +00:00
Thales Lima d9d7f7214a Merge "launcher: use same icon size for all apps drawer in foldables" into sc-v2-dev 2021-11-26 15:10:03 +00:00
Thales Lima 6e0005af6b launcher: use same icon size for all apps drawer in foldables
For foldables, no matter the grid size, we use 60dp for icons sizes.
This also fix a bug where the icon size was always the minimum between
default and all apps, which means that for foldables it would always be
default.

Bug: 202708085
Test: visual, using HSV and Window
Change-Id: I315718a8ba7a0aaed2204ad12e6b184dda2be48e
2021-11-26 10:03:43 -03:00
Alex Chau 9a5f99bfe6 Resets taskSplitTranslation of inactive orientation
Fix: 204185003
Test: manual

Change-Id: I10e49994e8a9723f39d7f9159de7c1f8216ea77f
2021-11-26 12:04:47 +00:00
Jerry Chang 71b7d1537d Merge "Support to launch app pair from overview with recorded split ratio." into sc-v2-dev 2021-11-26 05:43:34 +00:00
TreeHugger Robot 32ebd9f94f Merge "Fix ClassCastException in QuickstepModelDelegate" into sc-v2-dev 2021-11-25 04:00:37 +00:00
Jerry Chang 279c3b7fa2 Support to launch app pair from overview with recorded split ratio.
Bug: 207479945
Test: Quickswitch back to app pair keep split ratio
Change-Id: Id24195c15fe59053cc51515a942f72c3b8e87ba7
2021-11-25 11:38:14 +08:00
Schneider Victor-tulias 380f8fd890 Fix ClassCastException in QuickstepModelDelegate
- Added a casting check as an immediate fix to b/173838775
- Added logging to help debug the corrupt state where an item of type other than FolderInfo is used as an other item's container.
- Added LoaderMemoryLogger for adding large logs that are only conditionally printed.

Bug: 173838775
Test: manually checked logs
Change-Id: I9491cb421b9fb807d5fb110b04ad069481de768f
2021-11-24 14:26:45 -08:00
Alex Chau 376b09ade2 Merge "Consider two panel in home to overview transition" into sc-v2-dev 2021-11-24 20:33:32 +00:00
Alex Chau 6095333370 Consider two panel in home to overview transition
- Get the value from DeviceProfile directly

Fix: 202444558
Test: manual
Change-Id: Ifadbbf34c8103d7275b8b4043dcae47d1168ae83
2021-11-24 18:11:45 +00:00
Tony Wickham b4aefc1277 Merge "Stash taskbar when IME is present, including during gestures" into sc-v2-dev 2021-11-24 17:54:18 +00:00
Tony Wickham 821e37b447 Stash taskbar when IME is present, including during gestures
- SysUI removes SYSUI_STATE_IME_SHOWING when starting a gesture from an app, but because unstashing has implications on the gesture transition (e.g. clips the bottom of the app), we defer handling the ime hiding until the gesture settles. Repurposed the flow that swaps the taskbar background during the gesture to support this case as well.
- Delay the unstash when IME is closing, to align with the end of the IME exit transition
- Remove TaskbarViewController.ALPHA_INDEX_IME now that we stash when IME is opening, since stashing already hides the taskbar icons
- Also support passing a starting progress to the stashed handle reveal animation, to allow it to be reversed when cancelled. For example, when returning to an app that has IME showing, we first start unstashing because we're in an app, but then we get the signal that IME is attached so we stash again almost immediately (within a frame or two).

Test: In both 3 button and fully gestural, open a keyboard in an app, ensure taskbar gets out of the way and then reappears at the end when the keyboard is dismissed
Bug: 202511986
Change-Id: I93c298a98ba369ea6310466ff3f802231c582687
2021-11-23 16:37:06 -08:00
Winson Chung c1afaa4042 Merge "Removing logs" into sc-v2-dev 2021-11-23 21:58:14 +00:00
Vinit Nayak 458832c09e Merge "Show multiple App Info A11y options for split app icons" into sc-v2-dev 2021-11-23 20:09:47 +00:00
Jon Miranda c4a99bff04 Play return to icon animation if user swipes back to All Apps.
Bug: 205187702
Test: open app in all apps, swipe back to go back to all apps
Change-Id: I9e79c8365fdf667321343aaac2f8d77cb60a316a
2021-11-23 11:27:42 -08:00
Alex Chau 48644c75b3 Merge "Consider launching task's position on screen in pivot calculation" into sc-v2-dev 2021-11-22 21:07:41 +00:00
Alex Chau 4f49c9ce62 Log the display state when number of screen bounds is inconsistent
- If the number of screen bounds a.k.a. number of displays has changed, it should be a bug from system and add a log for that

Bug: 198965093
Test: manual
Change-Id: I74612e6c0d2f3cfd52b509e43ea16adf0eec76de
2021-11-22 15:16:17 +00:00
Zak Cohen d95942132d Remove temporary logging for NO_SCREENSHOT bug/.
Bug: 202414125, 203583301
Test: Local
Change-Id: I8345bd9f1c3ee93971d64ed49cf613cfd09ce10c
2021-11-19 13:49:36 -08:00
Jon Miranda 73a7e1ce41 Fix NPE in FloatingIconView
Happens when view is reset before animation starts

Bug: 201946253
Test: manual
Change-Id: I62817f698996dc1c6bebcd038d01eb8d6923a305
2021-11-19 13:40:59 -08:00
Alex Chau 2998307cd6 Use only current density to check isTablet
- Removed DeviceProfile.allowRotation and use DeviceProfile.isTablet instead, which only uses current density to calculate its value
- Reverted default allow_rotation preference handling to before ag/14234761

Fix: 203817448
Test: isTablet is set correctly in different screen sizes
Change-Id: Ic6c8dfc774e7787f62d489ad27720a7644c1e8c7
2021-11-19 15:27:01 +00:00
Alex Chau 6499e83c57 Consider launching task's position on screen in pivot calculation
- Instead of using RecentsViewScroll, put task's position offset versus current scroll as TaskRect calculation, so it's considered when calculating for putting task to full screen
- Revert back RecentsViewScroll to apply before RecentsViewScale
- Added new property in PagedOrientationHandler to apply both primary/secondary param without clearing the other, and renamed an existing method

Fix: 206972618
Test: Quick switching
Test: Launch task from grid, launch side task from carousel overview
Change-Id: I5977975ed1e930ad70b81d83513d8f3a00c0aed4
2021-11-19 14:42:20 +00:00
Vinit Nayak f957244b88 Show multiple App Info A11y options for split app icons
* AccessibilityNode actions are required to have a
unique resourceId to show as an action in A11y dialog.
For now, only AppInfo option is shown for each app in split,
but moving forward we'll need to add resourceIDs for
each option that can show up for either app.

Fixes: 200609838
Test: Saw multiple options for App Info for each app
come up in talkback mode

Change-Id: I92b349347354ac639537021d775eea814c866a0e
2021-11-18 23:22:46 -08:00
Schneider Victor-tulias ce740c832c Merge "Add TODO to fix b/206508141 before removing or changing the default value to the feature flag ENABLE_LOCAL_COLOR_POPUPS" into sc-v2-dev 2021-11-18 18:45:16 +00:00
Thales Lima bd1aec6721 Merge "open grid task menu to the right of icon" into sc-v2-dev 2021-11-18 18:19:58 +00:00
TreeHugger Robot 160d85c815 Merge "Adding back the badges on widgets for widget recommendations." into sc-v2-dev 2021-11-18 17:44:50 +00:00
Brian Isganitis 49f25681ef Make action optional for snackbar.
Test: Manual
Bug: 188222480
Change-Id: I923dcf50633d8ba751d86095f43e97563a53b692
2021-11-18 10:22:41 -05:00
Thales Lima 45f2306ce9 open grid task menu to the right of icon
This makes the TaskMenuViewWithArrow open to the right of the icon if
there is enough space, and to the left if not. It also works correctly
in RTL, inverting the side to open by default.

Bug: 193432925
Test: open Overview and tap the app icon
Change-Id: Ib1098f48ed28d2e0758fb0e3fb733e86271fa1a0
2021-11-18 12:01:16 -03:00
TreeHugger Robot 5394db834f Merge "Use split thumbnail width/height directly" into sc-v2-dev 2021-11-18 04:42:27 +00:00
Vinit Nayak be7ce023de Use split thumbnail width/height directly
* When swiping to QS from home, the
bounds for the rect on screen are incorrect
because it's technically off-screen when
it's being queried

Fixes: 206155441
Change-Id: Ibb17f2ac291f867b6de06041c980e434ce92cf27
2021-11-17 19:05:29 -08:00
Tony Wickham 49da26f636 Merge changes I36871463,I691a5cbb,I62105c1c into sc-v2-dev
* changes:
  Update reorder and folder creation radii
  Fix misaligned folder creation drag over target
  Update CellLayout.DEBUG_VISUALIZE_OCCUPIED to include drag over targets
2021-11-17 22:08:28 +00:00