This CL substantially refactors folders to be able to take contents of type AppPairInfo. App pairs can now be moved in and out of folders, and launch from folders.
This CL contains only logic and model changes; animation and style changes (for dropping items into folders, color changes to app pair surfaces, etc.) will be in a following CL. Another CL (hopefully) will contain tests. I'm planning to submit them together, but this patch should also be able to stand alone with no issues (except janky transitions).
Bug: 315731527
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, more to follow in another CL.
Change-Id: I73732fcaefbdc61bf6e02a5be365962b8bbc3e41
(cherry picked from commit a596f589c4)
Merged-In: I73732fcaefbdc61bf6e02a5be365962b8bbc3e41
Previously, app pairs and folders shared a common data model, FolderInfo. Now we need to separate them, so a new type, CollectionInfo, will serve as the parent of both types.
Bug: 315731527
Fixes: 326664798
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, unit tests to follow
Change-Id: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
Merged-In: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true
Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device
Change-Id: Ia4944f8d23634bb92296938ea2d07a6babf6f77c
Merged-In: Ia4944f8d23634bb92296938ea2d07a6babf6f77c
Bug: 329012507
Flag: none
Test: trigger assistant, ensure bottom insets are removed in
gesture nav mode; also verify IME inset override correctly
applies in 3 button mode
Change-Id: I823d0d360a7e3b41cc291f6949d9371e0dc32efb
This is reversing a previous change from a few years ago
(ag/16325264) because we now clip the recent apps on the bottom
during gesture nav, whereas before we left them unclipped until
you swiped up.
Flag: none
Fixes: 305977350
Test: verified visuals manually in persistent, transient, and 3
button nav; also tested interactions with All Apps
Change-Id: Ib3823a9bd9aebf923ad481c010c7e8544bcb6a4d
(cherry picked from commit a6b29968a4)
* Mismatched animation durations were causing recents task
thumbnails to flash in at the end.
* Following a similar pattern started at ag/26378432, except
here we manually call all the steps to create launcherState
animation
Fixes: 321863575
Test: Repro steps from bug no longer occur.
Tested on phone and large screen, workspace, overview and all apps
Change-Id: I02696c0470bf4cfe6a278f0a2bc0786367a9fe37
(cherry picked from commit aeb9595b37)
This reverts commit 38bc885de9.
- Always request layout of action_buttons after changing visibility of its children
- Update Split button visibility based on DeviceProfile change in updateDimension() only
- Update Split button visibility based on 3P launcher in initialization only
- Also simplified action_buttons to wrap_content and layout in middle of parent
- Also removed the space between buttons and use marginStart
- Fixed TAPL to not expect save app pair button on phone. Before this CL actions_buttons are still on view hierarchy despite they're not visible on screen.
Fix: 321291049
Fix: 329255757
Test: Clear all tasks, fold, launch app, swipe up to Overivew; repeat in RTL
Test: OverviewImageTest
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7d0edb46ac0a09aa0c801598b46cd338d04886a9)
Merged-In: I9ecf872279f6f07d2d9bc33fb09031568023cb77
Change-Id: I9ecf872279f6f07d2d9bc33fb09031568023cb77
This changes (and cleans up) the way app pair icons are composed. Previously, the background and 2 icons were drawn individually and separately onto the canvas. Now, they are composed into a combined drawable first. This also allows the full icon drawable to be requested by external functions (which will be needed for display app pairs in folder previews).
Bug: 315731527
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Visually confirmed that app pairs loooks the same in all scenarios: rotation, disabled, themed, taskbar, pinned taskbar. Screenshot test to follow.
Change-Id: I7242e0c525ef578a54a06fb9137fcfc42c6f0e86
(cherry picked from commit b37faec287)
Merged-In: I7242e0c525ef578a54a06fb9137fcfc42c6f0e86
- http://ag/q/topic:%22b/329255757%22 caused a regression that in landscape, action_buttons shifted up when ShareTarget become visible, because OverviewActionsView become taller when this happens, and the topMargin is no longer valid to put actions_button at the position we want
- Bring back layout_gravity="bottom" solves the issue, as bottomMarign is always correct
Fix: 331517987
Test: manual as ShareTarget requires AiAi interaction and cannot easily be mocked
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6431d6e87910bc7c7767c40d42f51961dc462134)
Merged-In: Iadcdf5731485f42f9586703e34e55ed9b4121bf9
Change-Id: Iadcdf5731485f42f9586703e34e55ed9b4121bf9
This CL changes the save app pair menu icon to the latest spec. It looks good!
Fixes: 331525186
Flag: N/A
Test: Manual
Change-Id: Ic73f78a27372aca565fce2e3be3e9f3b8ef1d942
(cherry picked from commit 1d48159bd5)
This CL sets gravity="start" and ellipsize="end" so that longer strings in the Overview app dropdown menu are still left-aligned and ellipsized when they are longer than the container.
Fixes: 330426535
Flag: N/A
Test: Manual
Change-Id: I1e62412c9b8be41a8dbb6b0597a69a283a56e3f0
(cherry picked from commit 6867b18db2)
Will now repurpose the twolinetoggle flag to be the flag that will
make twoline text enabled/disabled.
bug: 316027081
Test: presubmit
manually: https://screenshot.googleplex.com/BsZGCm7DrTZLwG4
Flag: com.android.launcher3.enable_twoline_toggle Staging
Merged-In: Idef427bad6551ae56b13e35393e076b8e000af5a
Change-Id: Idef427bad6551ae56b13e35393e076b8e000af5a
This reverts commit 176f186a6d.
Reason for revert: DroidMonitor: Potential culprit for http://b/331438065 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
Change-Id: Ie375277ad2f65199749f0211ab50037d4b37e664
Merged-In: Ie375277ad2f65199749f0211ab50037d4b37e664
Taskbar All Apps exists regardless of the default launcher. Thus, we can
toggle it on large screen devices. This CL ties registering the system
action to default launcher and taskbar's enablement.
Test: adb shell input keyevent 117
Test: AllAppsActionManagerTest
Flag: LEGACY ENABLE_ALL_APPS_SEARCH_IN_TASKBAR ENABLED
Fix: 317259709
Change-Id: I26f0ed9e921beac762f3f9e6aaceb1002ad4801a
(cherry picked from commit c113b277e6)
- Removed the weight=3 space on left/right and replace with gracvity=central_horizontal
- Removed unused oav_three_button_space
- Removed irrelevant layout_gravity (gravity within parent), as the LinearLayout is already taking full parent width, and its vertical alignemnt si controlled by `updateVerticalMargin` in code
Bug: 329255757
Test: OverviewImageTest
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2cf1a0c08d41ee7a29ea920c93850d3914ed7cd8)
Merged-In: Ice087dde7d3c36b4536d36ce82c382c31c124855
Change-Id: Ice087dde7d3c36b4536d36ce82c382c31c124855
All the system bar can trigger insets resize animation before, but some
sources might not have the resize animation. The framework now will only
trigger insets resize animation for sources which apply
FLAG_ANIMATE_RESIZING. So this CL applies the flag for gesture taskbar
because it can toggle its size via "Always show Taskbar"
Bug: 291562764
Flag: NA
Test: Fold and unfold a foldable device and ensure that won't create
InsetsResizeAnimationRunner.
Merged-In: I0d915422d160a81f12c3992ffe53200fd957f6d7
Change-Id: I0d915422d160a81f12c3992ffe53200fd957f6d7
Now there is just 1 toggle for all entrypoints.
Bug: 324036308
Test: Manual and unit tests
Flag: NA
Change-Id: Id4463345c44fa4daba4eac67b5ad00aff7f3a606
Merged-In: Id4463345c44fa4daba4eac67b5ad00aff7f3a606
Otherwise, it clears MotionPauseDetector so isPaused returns false.
Fixes: 330186943
Flag: none
Test: manual
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:77802d6da48320e5f5cf5c420fe31a1aa14e478e)
Merged-In: I9e0982c18cc5264a1fab53077ac551d2880a6eae
Change-Id: I9e0982c18cc5264a1fab53077ac551d2880a6eae
24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
This CL adds a check so that app pairs can't be saved on 3p launchers. This affects the Overview icon dropdown menu and the Overview Actions Bar.
Fixes: 326155701
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, option does not show up when Nova Launcher is set as default home app, and shows up again for Pixel Launcher.
Change-Id: I60d6fd3b3eb39921edafb12faace743d16de270f
(cherry picked from commit 2b2d8cc90b)
Merged-In: I60d6fd3b3eb39921edafb12faace743d16de270f
* Un/Pinning taskbar re-creates controllers which led to
stale state for checking if we are allowing split selection
Test: Crash/immediately going into split no longer repros after
un/pinning taskbar in overview and trying to split
Fixes: 326356246
Change-Id: I06cfc4d1c3c7fe071f04414c3134eaff7960ade6
(cherry picked from commit 0adca26744)
This is a combination of two issues:
1. Widget updates are not passed to the holder when the launcher binding starts
2. Updates from widgetHost.startListening() are overriden by out-of-date info
Fix: 322919716
Test: Manual
Flag: N/A
Change-Id: I9665117412c87b19ed5d98263bb4f9b8da21c5c7
(cherry picked from commit f418b2e16d)
Bug: 326550571
Test: manually set computed task size to 0 simulating unset circumstance, and ran logs verifying infinite, added fix, and verified logs showing the same scale before and after with get tasksize set
Flag: none
(cherry picked from commit fca7ee23ba)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:9c4039e12dbc20dabf1d7e62b06bfd650706eaa7)
Merged-In: I0f928885e2fc6cfc0d6a064d6e9f1c614bf7a5af
Change-Id: I0f928885e2fc6cfc0d6a064d6e9f1c614bf7a5af
b/318394698 was fixed so we can now remove these logs.
Fix: 321837497
Test: N/A
Flag: NONE
Change-Id: Ifc8b18238778f6aa2c0ad1be5df627c07cbaf1d8
(cherry picked from commit 7e5d855886)
This allows the user to scroll as quickly as they want.
Fix: 328749622
Test: manual
Flag: NONE
Change-Id: I493841f11407e6fb9f15fd90b5a5e55fa4ed3ad3
(cherry picked from commit a9a11b47c3)
Vinit Nayak
Andreas Agvard
Treehugger Robot
Jeremy Sim
Bill Yi
Tony Wickham
Pat Manning
Alex Chau
Andy Wickham
Brandon Dayauon
Liana Kazanova
Brian Isganitis
Tiger Huang
Lynn Yeh
Sihua Ma
randypfohl
Federico Baron