Commit Graph

11720 Commits

Author SHA1 Message Date
Vinit Nayak 4b9ae54e1c Call FallbackRecentsView#init() before setContentView()
* Init sets mSplitSelectStateController which RecentsView
then uses in onAttachedToWindow(). That needs to be set
before it gets attached to the window, which happens in
RecentsActivity#setContentView()

Fixes: 332643607
Test: Only presubmit, issue not reproducible
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:aeecb1e8a5cabe9fc58af69f7b47764a96a08d76)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:eac1d34438209f266212b1bbe8c9704c2947dbcd)
Merged-In: Icc555cad17b734e2a9c035991c19bbdc6b02de5d
Change-Id: Icc555cad17b734e2a9c035991c19bbdc6b02de5d
2024-08-01 02:46:40 +00:00
Alex Chau 5fbc9a5d5d Perform state switch to Overview from -1 screen
- This fixed a regression caused by ag/27904180, where -1 is no longer considered `visibleLauncher`. -1 still have Launcher being top activity, and recents animation will always fail
- Added isInMinusOne in LauncherActivityInterface, and return Launcher in getVisibleLauncher for -1 case
- -1 should be the only case where Launcher is top activity, but is not started

Fix: 352254279
Test: Recents button from the following scenarios: Home, -1, apps, transparent apps, video from -1
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1cd3fe27f229da4f7bb80a2e04d1416cc050fc94)
Merged-In: I0898d202b9dd4742c0c7d2c0d6b340c748e8acf7
Change-Id: I0898d202b9dd4742c0c7d2c0d6b340c748e8acf7
2024-07-15 23:15:28 +00:00
Alex Chau 912edc94a1 focusTransitionScaleAndDimOut should always go from 1f to 0f
- Also updated AnimatedFloat to accept a Consumer<Float>, so a lambda can be used as updateCallback with refernce to udpated value
- Also updated PendingAnimation to accept Animator with TimedInterpolator without specifying SpringProperty

Fix: 352195519
Test: manual
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:c378e64b757dbb83b6024be462a6752bc6a2c5f2)
Merged-In: Ifb78c1bcd3ca215a5d214f986a107d0988bff13b
Change-Id: Ifb78c1bcd3ca215a5d214f986a107d0988bff13b
2024-07-12 03:52:35 +00:00
Vinit Nayak 1855ef15b9 Initialize SplitSelectStateController for 3P before setting content view
* RecentsView#onAttachedToWindow relies on splitSelectStateController
being initialized, so we now do it before RecentsActivity calls
setContentView()

Bug: 332643607
Test: Couldn't repro before or after :(
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4276ee4897f59cfb1a2e432adfe54196b1a0dd2d)
Merged-In: Ic26460e08ca74adcf6dcf31abc956ad57f4061c2
Change-Id: Ic26460e08ca74adcf6dcf31abc956ad57f4061c2
2024-07-09 02:41:34 +00:00
Saumya Prakash 62462a50ee Prevent Taskbar edu dismissal from touching outside of the window.
In an effort to encourage users to look at Taskbar edu more thoroughly,
this change makes it so users have to press the 'Done' button explicitly
to close the taskbar edu window. This change also adds the ability for
it to be dismissed by the back gesture. It only applies to the features
edu, and not other taskbar educations.

Fix: 349612575
Test: Manually run all versions of taskbar edu and ensure that the edu only goes away with back gesture, swipe up or clicking on the DONE button
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:17339843e76cb507413e1d22dcf0c7982e024379)
Merged-In: I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3
Change-Id: I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3
2024-07-04 03:14:55 +00:00
Schneider Victor-tulias cb2a1474a7 Fix icon flash on app launch
Flag: com.android.launcher3.enable_additional_home_animations
Fixes: 343051344
Test: temp logs, launched apps from home, quickly swiped home while quick switching
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:9fb1f8043573d5bc3376f0786354fc8f7a9cf2cd)
Merged-In: I91071d53f753eb7bc99305c46241de203bcfdc98
Change-Id: I91071d53f753eb7bc99305c46241de203bcfdc98
2024-06-27 03:45:11 +00:00
Alex Chau 396c95964a Disable Select mode from Menu in fake landscape
Fix: 349072279
Test: Verify that Select mode is only available from Menu in grid only Overview on tablets
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2026c800165865b3323f449a2d9cda22e9231598)
Merged-In: Icd0d8303547b45d3653696812c51ce2c2bfd410b
Change-Id: Icd0d8303547b45d3653696812c51ce2c2bfd410b
2024-06-25 00:27:42 +00:00
Alex Chau 35f30f2e11 Close floating views before fake rotation
- We do the same in Launcher for real rotation

Fix: 348113790
Test: manual
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:bde639236f8e73608e3fd14fecdbbe5267f4607e)
Merged-In: Ibd5f42db439cd94a389f7aaf6fe2db317c11cd67
Change-Id: Ibd5f42db439cd94a389f7aaf6fe2db317c11cd67
2024-06-25 00:27:27 +00:00
Jordan Silva 1a654c58dc Fix recents button not navigating to Overview
This CL prevents returning launcher in getVisibleLauncher method when isHomeVisible is true but Launcher is not started.

Bug: 337954957
Bug: 331947116
Flag: EXEMPT bugfix
Test: Manual. With 3-button-nav. Open a video from -1 scren (not in Youtube app), press recent button. More instructions in b/337954957#comment26.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6a4c142b5b77ccb8c439e29209b6dfd04a4690d0)
Merged-In: I40edafdab5457666474de2c0368158a9c1c05fb0
Change-Id: I40edafdab5457666474de2c0368158a9c1c05fb0
2024-06-21 23:23:01 +00:00
Jordan Silva 2f2429e565 Fix digital wellbeing banner position in portrait mode
The banner should be aligned to the start of the screen, not the center. This CL fixes DWB position for split tasks when device is unfolded.

Fix: 348200661
Bug: 345789862
Flag: EXEMPT bugfix
Test: Manual. Add a Digital Wellbeing (DWB) timer to 2 apps. Open these two apps in split mode. Unfold the device and go to Overview. The DWB banner should aligned correctly.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3d088e3899cfca516dfa8ae9699691ece2b914d9)
Merged-In: I0544b4a8eb85b00196373c8a4368e680abab222b
Change-Id: I0544b4a8eb85b00196373c8a4368e680abab222b
2024-06-21 03:22:37 +00:00
Fengjiang Li ff83f1c448 Merge "[Launcher Jank] Avoid making ContentResolver binder calls from GestureNavigationSettingsObserver" into main 2024-06-15 02:30:43 +00:00
Hongwei Wang 263932e729 Ignore the mismatched source rect hint
When the app provided source rect hint does not match the aspect ratio,
by a certain threshold, we ignore that and in turn apply content overlay
during the enter animation, to avoid size change at the end.

In button-navigation mode, some special logical's applied as to crop the
content to its shorter edge for this case, which is inconsistent and we
will address that later in a separate change set.

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/d4kLspMrqb7Xsc2JtkTW0m
Flag: NONE bug fix
Bug: 338616637
Test: Enter PiP from zoomed and non-zoomed video
Change-Id: I5059553cb9b6c02810e9638bfaf29dde9ab6140f
2024-06-14 13:27:06 -07:00
Jagrut Desai 55d101d15f Merge "Util classes for the Taskbar Customization Framework" into main 2024-06-14 17:25:39 +00:00
Uwais Ashraf d239b0d5ea Merge "Refresh overlay on new snapshot taken even if an old snapshot exists" into main 2024-06-14 10:00:11 +00:00
Mykola Podolian be4e591fac Merge "Animate bubble bar icon sizes and padding" into main 2024-06-14 03:39:10 +00:00
mpodolian 563c2101cf Animate bubble bar icon sizes and padding
Added animation for the updates of bubble bar icon sizes and padding

Fixes: 335575529
Flag: com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: BubbleBarViewAnimatorTest
Change-Id: I07d66b3a9d565f4fa6040c3c4bf4866e4d81a3a6
2024-06-14 01:25:05 +01:00
Jeremy Sim f37142f43e Merge "Fix flickering issues with divider during split animation" into main 2024-06-14 00:03:34 +00:00
Jeremy Sim 91fb2f2e5e Fix flickering issues with divider during split animation
This CL makes changes to the "split divider placeholder view", which was intended to cover up the backdrop a little during the split confirm animation. The placeholder view is now larger (fullscreen) and fades in with the animation movement, so there is no longer a period of time when it looks like an awkward rectangle.

New timings and interpolators confirmed with UX. Also renamed some variables and added comments for clarity.

Fixes: 344573331
Test: Manually verified that the visual bug no longer happens on large and small screen, and from desktop and Overview.
Flag: EXEMPT bugfix
Change-Id: I3b37f2b0478035d7a3181ae7c23962fe75a13b2c
2024-06-13 15:26:55 -07:00
Randy Pfohl 69092b41f6 Merge changes from topic "windowPrototype" into main
* changes:
  Fixing tests related to abstraction
  Abstracting StatefulActivity from StateManager
2024-06-13 22:11:49 +00:00
Uwais Ashraf d87d9e262b Refresh overlay on new snapshot taken even if an old snapshot exists
Bug: 302041971
Test: Manual checking of overlay refreshes in bug repro case - live tile and select
Test: Manual checking of no additional overlay refreshes on non-live tile select
Test: Manually ensured no additional overlay refreshes while scrolling
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: I5d455560d0bf816f86042078a662f06f5d1397bb
2024-06-13 21:14:05 +00:00
Saumya Prakash f3e12f2b31 Merge "Change Pinned taskbar corners to be fixed." into main 2024-06-13 20:17:37 +00:00
Jagrut Desai 3cddb5817d Util classes for the Taskbar Customization Framework
Test: Presubmit
Bug: 341146605
Flag: NONE Taskbar Customization
Change-Id: Ice9d2e6db2754ba75a1253da45dd28aa63cad58f
2024-06-13 11:46:29 -07:00
Mady Mellor 3c8253d0f3 Merge "Use main executor directly" into main 2024-06-13 17:58:34 +00:00
randypfohl 176ce85d27 Abstracting StatefulActivity from StateManager
Flag: NONE - abstraction with no logic changes.

Test: Built and ran locally, for launcher3 and third party launchers

Bug: 224595066

Change-Id: I9da15bdd649d3a20e98c6552bb9e9abaec72f97f
2024-06-13 10:26:12 -07:00
Mady Mellor f953c122fc Use main executor directly
In some tests runs mMainExector could be null, using it directly
resolves this.

Flag: com.android.wm.shell.enable_bubble_bar
Test: treehugger
Bug: 347010157
Change-Id: I05879da895739087971a5bfe920d8c1b190f0b44
2024-06-13 09:18:45 -07:00
Saumya Prakash d7820860f2 Merge "Fix gesture tutorial regression on tablets when rotating the screen" into main 2024-06-13 15:50:57 +00:00
Michał Brzeziński f24e6ad602 Merge "Disabling touchpad gestures in launcher for SYSUI_STATE_TOUCHPAD_GESTURES_DISABLED state" into main 2024-06-13 10:19:30 +00:00
Mykola Podolian c4111f06ff Merge "Add outline to the transient task bar background." into main 2024-06-13 01:00:32 +00:00
Fengjiang Li d89f9a8e03 [Launcher Jank] Avoid making ContentResolver binder calls from GestureNavigationSettingsObserver
Test: manual
Flag: NONE performance change
Bug: 333772683
Change-Id: Id6764315d9a2de959186785d4406a6b671e449f5
2024-06-12 22:17:57 +00:00
Himanshu Gupta cf3a0ef2f0 Merge "Prompting the user to set Pixel/Quickstep as default Home app." into main 2024-06-12 21:13:19 +00:00
Saumya Prakash 6b234217eb Fix gesture tutorial regression on tablets when rotating the screen
This change addresses a regression that would incorrectly show the
rotation prompt in the gesture navigation tutorial on tablets.

Fix: 339735651
Test: Run the gesture navigation tutorial in different types of devices
and ensure the rotate device prompt only shows up when necessary (ex.
portrait mode on a tablet).
Flag: EXEMPT bugfix

Change-Id: I82d90313917e4ffe478ee2babdc8dc0cb306504c
2024-06-12 19:49:52 +00:00
Brian Isganitis e59b640ffc Merge "Initial TaskbarUnitTestRule with example overlay controller tests." into main 2024-06-12 19:26:17 +00:00
mpodolian b8eb034271 Add outline to the transient task bar background.
Added outline to the transient task bar background.
Demo: http://recall/-/gx8ASgewUeUS3QYohfrd1J/gmJKD6VAuGXP8KOP1vLwad

Fixes: 330785041
Flag: NONE Trivial UI update
Test: Manual. Open transient task bar with the light and the dark
themes.

Change-Id: I69db4b40a1bd101471c2a2556a0621ac4494b8ec
2024-06-12 19:16:28 +01:00
Mykola Podolian 590e662d70 Merge "Add outline to the bubble bar background view." into main 2024-06-12 16:46:55 +00:00
Jon Miranda 1e0ec5ebeb Merge "Delay taskbar background fade in animation - Taskbar background will fade in based on 1. Velocity threshold 2. End target gesture destination" into main 2024-06-12 16:02:20 +00:00
Schneider Victor-tulias c4ed677501 Merge "Exclude home and recents activity types when overriding recents-excluded tasks" into main 2024-06-12 15:46:56 +00:00
Orhan Uysal 8f2a4e0854 Merge "Use RecentTasksListener to trigger TopTaskTracker" into main 2024-06-12 12:30:13 +00:00
Brian Isganitis 9eaae4b6a4 Initial TaskbarUnitTestRule with example overlay controller tests.
Flag: TEST_ONLY
Bug: 230027385
Test: TaskbarOverlayControllerTest
Change-Id: I858906ece7e67677962ec8b4432bfcca5ec30283
2024-06-11 23:48:13 -04:00
Tracy Zhou 80dbe9ae3e Merge "Initialize mRotationTouchHelper before onInputDeviceAdded" into main 2024-06-12 00:56:38 +00:00
Jon Miranda 4a4b7a8059 Delay taskbar background fade in animation
- Taskbar background will fade in based on
  1. Velocity threshold
  2. End target gesture destination

Bug: 298089923
Bug: 345768019
Test: swipe up fast to go home, note no taskbar bg
      swipe up slow to reveal taskhome, note taskbar bg shows immediately
Flag: com.android.launcher3.enable_scaling_reveal_home_animation DISABLED

Change-Id: I2c16352e1c0c52a8afc49900a39b80383bacde62
2024-06-11 15:39:55 -07:00
Saumya Prakash f9c602d1d9 Change Pinned taskbar corners to be fixed.
Based on new UX guidelines, the corners for the pinned taskbar should be 16 dp.

Fix: 337872323
Test: Put device in 3 button mode and pinned taskbar and observe
sharper, fixed corners. Transient taskbar remains unchanged.
Flag: EXEMPT bugfix

Change-Id: I2130e91dcdc0afb007fde93438f3fa603bc15af8
2024-06-11 22:18:09 +00:00
Jagrut Desai ec772f4995 Merge "Fix Taskbar All Apps Button to be Fixed in Minimal Taskbar State" into main 2024-06-11 21:27:27 +00:00
Tracy Zhou 16b2656ecf Merge "Fix crash from isTrackpadDevice" into main 2024-06-11 21:22:35 +00:00
Orhan Uysal c948537a82 Use RecentTasksListener to trigger TopTaskTracker
Currently launcher gets task stack updates through WM core. Ideally we
would like to migrate into a model where launcher gets these updates
through shell instead.

Test: Manually check that the correct task info is delivered to launcher
from shell
Bug: 341932484
Bug: 344684650
Flag: NONE Just adding a listener, no logic added

Change-Id: Iaf534a4bfee968138d4a4ff282a66e62759af2c0
2024-06-11 21:00:22 +00:00
Liran Binyamin 27471df69c Merge "Animate new bubble when the bar is expanded" into main 2024-06-11 20:25:15 +00:00
Tracy Zhou 70041c88ad Initialize mRotationTouchHelper before onInputDeviceAdded
There is dependency there that can cause npe from mRotationTouchHelper not initialized yet

Fixes: 345893434
Test: N/A
Change-Id: Ib9009f23d71eccf6b554e21c51ba640304250af0
2024-06-11 13:06:03 -07:00
Schneider Victor-tulias 3eb4efac95 Exclude home and recents activity types when overriding recents-excluded tasks
These tasks could point to overview itself, causing a very confusing screenshot. By excluding these tasks, we will default to using the task preview

Flag: NONE bug fix
Fixes: 336334715
Test: used circle to search from home, swiped to home, then pressed "select" overview action button. also checked temp logs
Change-Id: I0b0ca50585413b479e4830f06b57b8b5e19670a8
2024-06-11 16:01:09 -04:00
Himanshu Gupta 261a62219b Prompting the user to set Pixel/Quickstep as default Home app.
requestQuietMode API throws SecurityException in case its called
from a non-default Launcher app.
To mitigate this, we catch the exception and prompt the user
to set their default launcher to the current app.

Video(Pixel): https://photos.app.goo.gl/ni5X1c6vBbYW2JMJ9
Video(Pixel-aosp): https://photos.app.goo.gl/cYLJpTYW76Jnbonc9

Bug: 320446272
Test: Manual
Flag: NONE Bug fix tweak.
Change-Id: I6afb2ae85cabc038e1503e9c34eebd974c4f7a50
2024-06-11 19:11:21 +01:00
mpodolian 84f9cfabb9 Add outline to the bubble bar background view.
Added outline to the bubble bar background. Updated pointer
appearing/disappearing animation - now pointer moves into the bubble
bar background.
Demo: http://recall/-/gx8ASgewUeUS3QYohfrd1J/e1wZMrFZTILq73ik8wwrwx

Fixes: 345489039
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: Manual. Expand and collapse bubble bar with the light and the
dark theme.

Change-Id: I095fdc12337955aa21ee0eb622a924ad424ef186
2024-06-11 19:03:24 +01:00
Tracy Zhou 1deac6777b Fix crash from isTrackpadDevice
Apparently InputManager.getInputDevice can return null when a device is added

Fixes: 344902395
Test: N/A
Change-Id: I79c3dd3431b1d4b079b8a6863688a13ea2741602
2024-06-11 10:40:17 -07:00