Commit Graph

7863 Commits

Author SHA1 Message Date
Jon Miranda d26d5aaa6d Tweaks to app closing animation.
Change-Id: Ia2cbc1401a57ad8dc3e3553110497eb35c19fe64
2018-05-09 12:51:34 -07:00
android-build-team Robot 639b07178f Merge "Using surface rotation instead of insets to determine seascape configuration" into ub-launcher3-edmonton 2018-05-09 16:00:43 +00:00
Tony Wickham e3a968090a Merge "Cleanup swipe detector in case of double cancel" into ub-launcher3-edmonton 2018-05-09 16:00:02 +00:00
android-build-team Robot ad59f63aab Merge "Consuming launcher instets in multi-window mode" into ub-launcher3-edmonton 2018-05-08 22:08:17 +00:00
Sunny Goyal 9001b10771 Consuming launcher instets in multi-window mode
Bug: 79267409
Change-Id: I283f9eeffaf322cee9289bf90528c8c51d083a50
2018-05-08 14:57:36 -07:00
Sunny Goyal fe392da300 Merge "Chaniging all-apps scrim" into ub-launcher3-edmonton 2018-05-08 18:10:12 +00:00
Sunny Goyal a6616dec28 Fixing stateManager not correctly deduping existing animations
Bug: 79251716
Change-Id: I40c3ebf0ec4d49aa1fe1948ad3d83eb87cc1c5f1
2018-05-08 09:16:04 -07:00
Sunny Goyal 927447e71d Chaniging all-apps scrim
> Converting the scrim to View, to better avoid overdraw
> Overview and Spring loaded state have different scrim alpha
> When going from overview to all-apps, there is a color scrim drawn over the overview panel.
  The slef color is merged with this color to prevent overdraw, and the remaining screen is drawn
  with a cut-out round rect path

Bug: 79111591
Change-Id: I26801fde13dd6adb4b06110bbe8087e35cc31847
2018-05-08 08:29:43 -07:00
Sunny Goyal 59d086c3ce Using surface rotation instead of insets to determine seascape configuration
Insets may not correctly indicate seascape configuration in multi-window or
when the presence of device-cutouts

Bug: 79376298
Change-Id: I8268efca0001fe527a0ffefe48cc71e774fad01c
2018-05-07 17:32:46 -07:00
android-build-team Robot d10001b5d6 Merge "Improving "shortcuts" window for TalkBack users" into ub-launcher3-edmonton 2018-05-07 20:37:07 +00:00
Vadim Tryshev a50d99f1c1 Improving "shortcuts" window for TalkBack users
Using pane title, updating the description

Bug: 77633140
Test: Manual
Change-Id: Ia3a9ad75995a4cd3ada9b750e760161da70b9a7c
2018-05-07 13:25:39 -07:00
android-build-team Robot c247a00e22 Merge "Fixes an issue where on resetup of the FloatingHeaderView it defaulted to the main recyclerview even when the work recyclerview was active which resulted in the recyclerview not responding to scroll changes." into ub-launcher3-edmonton 2018-05-07 19:28:37 +00:00
Jon Miranda 717127186a Fix bug where launcher closing animation isn't run.
In some cases, we prematurely clear the force invisible flag before composing
the launcher animation, causing us to skip the animation.

Bug: 77205145
Change-Id: I4224741649a4fef34e255abac7b66bcf919c042f
2018-05-07 11:46:33 -07:00
Mario Bertschler 1a637bee18 Fixes an issue where on resetup of the FloatingHeaderView it defaulted
to the main recyclerview even when the work recyclerview was active which
resulted in the recyclerview not responding to scroll changes.

Bug: 72426657
Change-Id: I13c43137d69cd73ff7bdfe641f564f18f8443595
2018-05-07 20:43:11 +02:00
Sunny Goyal 39306af7d5 Fixing memory leak on rebind
Folder listeners were only cleared on activity destroy

Bug: 79322746
Change-Id: I5da98b864855303d21b86511de2e2982cd56f305
2018-05-07 09:50:10 -07:00
Tony Wickham fa6cbbe15b Cleanup swipe detector in case of double cancel
We manually dispatch cancel when returning to the previous state in
onDragEnd(), but could end in a bad state if getting a second,
external cancel (e.g. by pressing home). Thus, we restore the
onCancelListener after manually dispatching cancel.

Bug: 79258868
Change-Id: Idc4c33cede1d8af1829a4a744b9348d379bcf8f7
2018-05-04 13:17:46 -07:00
Sunny Goyal 18c699fbc5 Using the system color extraction logic instead of inbuild logic
> Moving the inbuild color extraction logic to the aosp flavor

Bug: 79111591
Change-Id: I766b0397da7224b424cd5f309cedf635d60a5e0f
2018-05-04 10:16:39 -07:00
Tony Wickham 4c7507571c Merge "Only detect swipe directions that lead to new states" into ub-launcher3-edmonton 2018-05-03 21:38:04 +00:00
Tony Wickham 52240a3aa0 Only detect swipe directions that lead to new states
This cleans up the code and ensures that the current state animation
is always initialized when we get drag events.

Also log when we pass through states.

Bug: 78017680
Change-Id: I54ab42923ed539940ea708973ad65f5793669c11
2018-05-03 14:04:25 -07:00
Mehdi Alizadeh 553de87c80 Merge "Refactors ButtonDropTarget to add extension data" into ub-launcher3-edmonton 2018-05-02 22:23:20 +00:00
android-build-team Robot 433ef09d29 Merge "Moving some callbacks from LauncherCallbacks to OverviewCallbacks" into ub-launcher3-edmonton 2018-05-02 22:06:10 +00:00
android-build-team Robot 145cb8420d Merge "Log OVERVIEW_ACTIVITY via MetricsLogger in quickstep Bug: 77920179" into ub-launcher3-edmonton 2018-05-02 21:53:59 +00:00
Hyunyoung Song a05860421f Log OVERVIEW_ACTIVITY via MetricsLogger in quickstep
Bug: 77920179

Change-Id: Id4c7dc3d535c7a8009d340183e640b04ab07408a
2018-05-02 14:34:23 -07:00
Mehdi Alizadeh bda47cf925 Refactors ButtonDropTarget to add extension data
Also fixes a bug where DeleteDropTarget was logging Remove instead of
Cancel.

Bug: 78793340
Test: Enable verbose logging and manual test
Change-Id: I0f0cfff070eab003ebb745292630bc6ce3243f4d
2018-05-02 14:20:09 -07:00
android-build-team Robot 9b83fe225d Merge "Quickstep onboarding backward compatibility for devices release with Android N & O." into ub-launcher3-edmonton 2018-05-02 20:51:37 +00:00
android-build-team Robot f1db5a0b81 Merge "Settling scrolls over clear-all button." into ub-launcher3-edmonton 2018-05-02 20:44:06 +00:00
Tracy Zhou 8b23c6f60b Quickstep onboarding backward compatibility for devices release with Android N & O.
Quickstep introduces swipe up gesture to open Overview and removes the
Recents button. We still want to show shelf bounce animation for Android
N & O users with Recents button because Overview is updated and swiping
up from there takes users to All Apps.

Test: manual test
Change-Id: I917c91564c47c78d2dc3883b8a7bf7824b5f5bc8
Fixes: 78647939
2018-05-02 13:41:28 -07:00
Vadim Tryshev a9283beebc Settling scrolls over clear-all button.
Per UX feedback, we divide the "overscroll area" 50/50 and settle to the
closest of the most recent task position and the fully scrolled
position.

Bug: 72222505
Test: Manual
Change-Id: Ic98fa5ae2f14f274f6a425ac687f13f7b3a4332e
2018-05-02 13:30:27 -07:00
android-build-team Robot cb83d8d9b4 Merge "Increase DELAY_MS for DiscoveryBounce." into ub-launcher3-edmonton 2018-05-02 18:04:46 +00:00
Tony Wickham 7a5d4ae64f Merge "Fix some state issues with user-controlled animations" into ub-launcher3-edmonton 2018-05-02 16:20:19 +00:00
Jorim Jaggi bbeedd1d2f Merge "Fix some jank with transitions" into ub-launcher3-edmonton 2018-05-02 13:17:42 +00:00
Jon Miranda 8d945e497f Increase DELAY_MS for DiscoveryBounce.
We need it to be longer, otherwise it interferes with the app closing
animation.

Change-Id: Id50e54362564eb8f7c083495fe8ca039c68fba3f
2018-05-01 21:21:48 -07:00
Sunny Goyal 8e1fbc5103 Moving some callbacks from LauncherCallbacks to OverviewCallbacks
Bug: 78780639
Change-Id: I90f868c741834efbe542367bdc3539f6d14f1939
2018-05-01 16:58:52 -07:00
android-build-team Robot cacf90cc48 Merge "Reusing the same bitmap and pixel array for shape detection" into ub-launcher3-edmonton 2018-05-01 23:32:17 +00:00
android-build-team Robot 4d9c414cdb Merge "Bound overscroll shift amount to avoid content from drawing on top (Y-val) of the QSB." into ub-launcher3-edmonton 2018-05-01 21:07:59 +00:00
android-build-team Robot 3adb0b9f2a Merge "Fade in LauncherRootView in finishFirstPageBind." into ub-launcher3-edmonton 2018-05-01 20:59:00 +00:00
Jon Miranda 5916709219 Bound overscroll shift amount to avoid content from drawing on top (Y-val)
of the QSB.

Bug: 77538324
Change-Id: Idabc4365c5fe5cb1894fa0eb84ea9309b85f99a3
2018-05-01 13:57:33 -07:00
Jon Miranda dbd9286abd Fade in LauncherRootView in finishFirstPageBind.
This ensures that the fade in animation will actually run, as DragLayer alpha
can be set by other means.

Bug: 72728697
Change-Id: I3ca0a6811b113e331119c74539a4421cfbdb51c9
2018-05-01 13:49:54 -07:00
Tony 31fbd4c08b Fix some state issues with user-controlled animations
Previously, user-controlled animations weren't properly being canceled when a
non-user-controlled animation started, e.g. when hitting home. Thus, we could
end in the wrong or inconsistent state because the user-controlled animation's
end runnable was still used. Now we add a cleanup callback for when we reset
the user-controlled animation for one that isn't user-controlled.

Also fixed a couple typos.

Tests (easier with animation durations extended):
- Swipe up and hit home before reaching overview -> land on home
- Go to overview, swipe down slightly (before threshold to go to workspace)
  and let go -> return to overview without flash (recents was resetting)
- Swipe up, press home while swiping -> goes home, stops responding to drag
- Start dismissing task and hit home before it finishes (or while dragging)
  -> goes home, stops responding to drag

Bug: 78249220
Change-Id: If11d8999e3fadba38c987b25af67cd2304cd859b
2018-05-01 13:45:27 -05:00
android-build-team Robot 1e0b98fa6e Merge "Fixes the incorrect hover icon color in drop bar when dark theme" into ub-launcher3-edmonton 2018-04-30 23:22:00 +00:00
Mehdi Alizadeh 3e024c0e1c Fixes the incorrect hover icon color in drop bar when dark theme
Bug: 78641863
Test: Manual test with dark and light wallpapers
Change-Id: Ic3fb68f5c5f746482a7f23b11284e30ac3e10168
2018-04-30 16:05:25 -07:00
Sunny Goyal 36d090df67 Adding a round rect background for the self in Overview
Bug: 78771910
Change-Id: I71460a284ed185e82d66fe65104402fb99d6b312
2018-04-30 15:37:39 -07:00
android-build-team Robot 1ea6d9cb8e Merge "Fixing Search box not getting aligned properly based on insets" into ub-launcher3-edmonton 2018-04-30 21:31:50 +00:00
Sunny Goyal df296898da Fixing Search box not getting aligned properly based on insets
Bug: 77893699
Change-Id: If195395af7858c3115d695a308810480474541a5
2018-04-30 12:35:40 -07:00
Vadim Tryshev 1c56935c30 Revert "a11y: disabling accessibility scrolling of the home screen"
This reverts commit 52b2b43c56.

Reason for revert: Per an email thread, this CL is considered a hack.

Change-Id: Id97fc9a398184ba18c2188d858218bc2d9ddc16e
(cherry picked from commit 310093d050)
2018-04-30 18:07:13 +00:00
Sunny Goyal 2e4596a448 Reusing the same bitmap and pixel array for shape detection
Bug: 76162466
Change-Id: I785d9b8673b2b8b0a56a146143b375c412e9322a
2018-04-30 09:23:29 -07:00
Vadim Tryshev 84b46f0257 Fixing task misalignment
Bug: 78793769
Test: Manual
Change-Id: I49f8213bf412f63fc296a8be5bd49950e4c01175
2018-04-27 18:00:14 -07:00
Mehdi Alizadeh 7ad04f35f8 Merge "Refactor initializing LauncherAccessibilityDelegate" into ub-launcher3-edmonton 2018-04-27 23:14:01 +00:00
Mehdi Alizadeh 8588fd0ea2 Refactor initializing LauncherAccessibilityDelegate
Bug: 77638406
Test: None
Change-Id: Ibf9f4fcabe42400abc91aa4b94417a8ff0449248
2018-04-27 15:38:52 -07:00
android-build-team Robot 15260fdd00 Merge "Enable Clear-all button by default" into ub-launcher3-edmonton 2018-04-27 20:44:02 +00:00