cfe4f2b7fc
Merge "Wire up the important conversation bit in BubbleBarController." into udc-dev am: a72094ad66 am: dbb218b0bd
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23039499
Change-Id: Icf4927c14ff52a0b1905d827b0727d0edea92927
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-09 19:19:21 +00:00
a72094ad66
Merge "Wire up the important conversation bit in BubbleBarController." into udc-dev
2023-05-09 18:02:53 +00:00
cc9375ce15
Merge "Taskbar All Apps Icon Shortcuts Popup Accesiiblity" into udc-dev am: 75109c7abc am: d015685ec7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23035380
Change-Id: I3fb8d59ac870ea0efcebe20d9c84162c008be59d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-09 17:38:22 +00:00
75109c7abc
Merge "Taskbar All Apps Icon Shortcuts Popup Accesiiblity" into udc-dev
2023-05-09 16:19:44 +00:00
2a077e73cf
Enable flag ENABLE_SPLIT_LAUNCH_DATA_REFACTOR am: b33a2e0762
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22958378
Change-Id: Iff36d989bdcaae465b2e9a59e3a0d67588b4da8b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-09 07:12:26 +00:00
b33a2e0762
Enable flag ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
...
Flag: ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Bug: 279494325
Change-Id: I9c58ba50f0269c69a12f548a1873c2d8251f6243
2023-05-08 17:27:03 -07:00
11ace3672a
Merge "Potential fix for end callback not being run in 3-button" into udc-dev am: 606c4bfc59
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23019205
Change-Id: Ie5f14a244232f96171e158932f4f4c06740b21de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-09 00:18:51 +00:00
29fcd9a636
Taskbar All Apps Icon Shortcuts Popup Accesiiblity
...
Before we were only applying the icon.clearAccessibilityFocus() only on normal popup and not material u popups, since the flag is turned on for udc, we can move it outside.
There seems to be a bug associated with either nested abstract floating views or the accessibility service where upon opening a nested abstract floating view from another the icon get the focus. This change make the bug littl less visible to use but users will still see this bug if they open the shortcut pop agian withought closing taskbar all apps.
The accessibility delegate was always null when using the TaskbarOverlayContext, now we use TaskbarActivityContext Delegate when in TaskbarOverlayContext.
Test: Manual
Bug: 280657266
Flag: not needed
Change-Id: I631e3aa6e54748c4c8ea2ac7daf5473b198e47d6
2023-05-08 16:25:53 -07:00
606c4bfc59
Merge "Potential fix for end callback not being run in 3-button" into udc-dev
2023-05-08 21:13:01 +00:00
4da033b59b
Merge "Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic." into udc-dev am: 35f5bfea4c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23058990
Change-Id: Ia43c7821f7ff4de0b489b64e8bd84d15bb797e6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-08 19:27:26 +00:00
35f5bfea4c
Merge "Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic." into udc-dev
2023-05-08 18:52:25 +00:00
1e898351ea
Merge "Fix null-pointers in SurfaceTransactionApplier constructor." into udc-dev am: a40de23f04
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22973611
Change-Id: I3b5ad1facf2ddf4ee7f17131f49e2f209898485c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-08 18:40:28 +00:00
c499df2142
Merge "Update QuickstepTransitionManager to allow remote transitions to be overridden" into udc-dev am: 39e28c9190
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22992541
Change-Id: Idedad51ef52dfb099ec07fdc52e18f5808b5dc2d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-08 17:41:48 +00:00
a40de23f04
Merge "Fix null-pointers in SurfaceTransactionApplier constructor." into udc-dev
2023-05-08 16:50:13 +00:00
39e28c9190
Merge "Update QuickstepTransitionManager to allow remote transitions to be overridden" into udc-dev
2023-05-08 14:20:36 +00:00
8b29c533ca
Merge "Adds BubbleControllers to TaskbarControllers" into udc-dev am: 764608263f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22534247
Change-Id: I32c85ead8fc190796847d9fe07698bdf5a4a7753
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-06 17:59:08 +00:00
442ce74f39
Merge "Add Bubbles and BubblesListener to SystemUiProxy and use it" into udc-dev am: b7dce64db5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22534246
Change-Id: I55366cf639ea62888d1689338617944e1a5ea43a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-06 17:58:58 +00:00
764608263f
Merge "Adds BubbleControllers to TaskbarControllers" into udc-dev
2023-05-06 17:22:21 +00:00
b7dce64db5
Merge "Add Bubbles and BubblesListener to SystemUiProxy and use it" into udc-dev
2023-05-06 17:22:06 +00:00
fe933305c3
Merge changes I35fe528b,Ia612c1b5 into udc-dev am: 0b53332c31
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22419061
Change-Id: Ia47f7ed39378ba4bc7b37026ff8d8feecb05b093
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-06 15:31:40 +00:00
0b53332c31
Merge changes I35fe528b,Ia612c1b5 into udc-dev
...
* changes:
Don't close AFVs when opening Taskbar folder.
Keep persistent Taskbar visible over Taskbar All Apps.
2023-05-06 14:42:54 +00:00
c0d4768083
Merge "Try to detect and handle delayed quickswitch task launch failure" into udc-dev am: 8e7e159645
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22841404
Change-Id: Ic56a7295e03f04c5b0f0613e9a025352929ac064
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-06 07:52:28 +00:00
8e7e159645
Merge "Try to detect and handle delayed quickswitch task launch failure" into udc-dev
2023-05-06 07:12:18 +00:00
1815a4c555
Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev am: 8b0fcbffb0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23066497
Change-Id: Ie0d5beaaedb14adba33ee1f24a6c5c867b5f0780
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-06 02:38:25 +00:00
8b0fcbffb0
Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev
2023-05-06 01:57:51 +00:00
c37bf46381
Adds BubbleControllers to TaskbarControllers
...
* BubbleControllers is optionally available (gated behind a flag).
* The bubble bar controllers follow init & onDestroy after the taskbar
controllers.
* Adds the relevant views used by the bubble controllers to the
transient taskbar layout.
Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I685163cdcc912768b1a720952762f4cbc602b14b
2023-05-05 17:02:38 -07:00
df51c1ada8
Try to detect and handle delayed quickswitch task launch failure
...
- The main issue arises when a task is successfully launched from
overview, but the activity later finishes (ie. during resume) which
prevents the usual logic of resetting Launcher to a good state
(ie. it can get stuck in overview with a blank or empty snapshot)
In this case, the Launch will "succeed" so that onTaskLaunchFailed
is not called, but then also silently fail (launched task finishes
and Launcher is again resumed) before Launcher stops, which does the
usual resetting of the state back to normal state after quickswitching.
This change checks for this case by listening for the activity and
transition state, and in the case where Launcher has not been stopped
or is resumed again after the transition finishes, returns the
user to the default home state.
This primarily only affects quickswitch for now, as other launch
failures leave the user in a valid state (ie. overview) while this
issue will leave the user in background state while quickswitching.
Bug: 268448123
Test: Quickswitch to an activity that finishes when resumed
Change-Id: I7d554f8fd521f7bc480dc06930ad91eeef0f1a1a
2023-05-05 23:55:22 +00:00
93a0cc9f01
Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev am: 958eabcd8f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23002490
Change-Id: I66a932e91d9969f284d6c978a3a901670acbf669
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-05 23:26:38 +00:00
63cf4d07a8
Updating SurfaceTransactionApplier to handle view not being attached
...
Bug: 278833389
Test: Presubmit
Flag: N/A
Change-Id: I88c240a1a7bdfe2e68c858c30e91cc5d06bc7bcf
2023-05-05 15:57:42 -07:00
958eabcd8f
Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev
2023-05-05 22:52:54 +00:00
d86c5657e0
Fix null-pointers in SurfaceTransactionApplier constructor.
...
A recurring class of null pointers are caused by using views with no view root implementation in SurfaceTransactionApplier from QuickstepTransitionManager. This can happen when we use launcher views after it has been destroyed.
- No longer using mDragLayer in getFallbackClosingWindowAnimators; simply applying the transaction immediately.
- Forcefully using getFallbackClosingWindowAnimators when launcher is destroyed.
Flag: not needed
Bug: 278833389
Test: launches and closed several apps in 3-button and gesture nav mode
Change-Id: I83b3aec1488fe9666bd0301a6044a181bb05dbdd
2023-05-05 21:53:50 +00:00
50e8d0ff60
Add Bubbles and BubblesListener to SystemUiProxy and use it
...
Adds a method to call into WMShell to set the listener and
indicate when a bubble is shown or when the expanded state
changes.
BubbleBarController sets or clears out the listener.
BubbleBarViewController calls SystemUiProxy when bubbles are shown
or when the expanded state changes.
Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I2364b9bbdea237fc268b0999d9c896585c194a86
2023-05-05 14:18:00 -07:00
b7d3d64d68
Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic.
...
https://kotlinlang.org/docs/coding-conventions.html#functions-vs-properties
go/kotlin/practices/properties#when
Bug: 281083629
Test: Verified on a physical device
Change-Id: I4c003c6633bf1913ee5e1e86224a679ff3442e2b
2023-05-05 19:43:43 +00:00
b4204df189
Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev am: 1aee68df56
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23063440
Change-Id: Ia2eb0ba323c37ccbd6694209f35695c80e9c4a21
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-05 19:34:38 +00:00
1aee68df56
Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev
2023-05-05 19:09:44 +00:00
2482c8dcd4
Revert "Revert "Listen for hover events over stashed taskbar.""
...
This reverts commit c27605099chttps://android-build.googleplex.com/builds/quarterdeck?branch=git_udc-dev&target=cf_x86_64_phone-userdebug&lkgb=10076607&lkbb=10076982&fkbb=10076788 >, bug <281093059>
Change-Id: I71e7fd07232c27a004243df0ffb0457fe53fe13b
2023-05-05 19:07:17 +00:00
611dca65e1
Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev am: 51669b612f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23048070
Change-Id: I7ae65fafd4fbab42b8137e25bd7b07e3ef4d94ac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-05 18:51:15 +00:00
51669b612f
Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev
2023-05-05 18:05:16 +00:00
54eafd482c
Merge "Enforce setting up SystemUIProxy on the main thread." into udc-dev am: 5882e97857
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23045938
Change-Id: Ie899a18dfcda9ea0f5bb6e7d9981f1cea87f1b99
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-05 17:55:33 +00:00
c27605099c
Revert "Listen for hover events over stashed taskbar."
...
This reverts commit c5882bcdfc
2023-05-05 17:22:21 +00:00
5882e97857
Merge "Enforce setting up SystemUIProxy on the main thread." into udc-dev
2023-05-05 16:56:10 +00:00
f3135fea05
Don't close AFVs when opening Taskbar folder.
...
Test: Manual
Fix: 276798702
Change-Id: I35fe528bf3ad7fb374b8d8ae83f0d525e131681e
2023-05-04 23:55:23 -04:00
9c311b2917
Keep persistent Taskbar visible over Taskbar All Apps.
...
Additionally, this CL fixes some touchable insets issues with the
overlay window. Dragging and dropping is now reliable from taskbar while
All Apps or EDU is also open.
Change-Id: Ia612c1b5266a8fb2b7005a773fbd2b00ec4824db
Bug: 279465803
Bug: 275890048
Bug: 264463659
Flag: PERSISTENT_TASKBAR_OVER_TASKBAR_ALL_APPS (Teamfood)
Test: Taskbar is functional over All Apps and EDU.
2023-05-04 23:54:27 -04:00
6d4b9b52a8
Merge "Listen for hover events over stashed taskbar." into udc-dev am: b6f64a4465
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22688404
Change-Id: I62fd6d6e1bfc420904457bd26fe1fc47a56cbc8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-05 00:00:52 +00:00
b6f64a4465
Merge "Listen for hover events over stashed taskbar." into udc-dev
2023-05-04 23:15:44 +00:00
e273753af4
Merge "Add header protection for Taskbar All Apps search bar." into udc-dev am: 64ee67c6b5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22466105
Change-Id: I9a75961ca892b36de5bd012d76589d2c480a8324
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-04 22:58:13 +00:00
672fa7a9a9
Enforce setting up SystemUIProxy on the main thread.
...
Bug: 280086782
Test: Added annotations and device did not crash under normal usage.
Change-Id: Ie587aafaaa018a3e6a5c33ca238e204f5cc0ea4e
2023-05-04 22:28:26 +00:00
64ee67c6b5
Merge "Add header protection for Taskbar All Apps search bar." into udc-dev
2023-05-04 22:20:46 +00:00
481da63b39
Wire up the important conversation bit in BubbleBarController.
...
Fixes: 269671451
Test: Tested on a physical device
Change-Id: Ice0bb081e19a817bd163141f38614ea7ecc21be9
2023-05-04 16:45:49 -04:00
f7c6db9021
Merge "Only close overlays onTaskMovedToFront for desktop prototype." into udc-dev am: cd7078372a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22975846
Change-Id: Ib728acfb1ad96c67fe9075495687a015d8d2d74b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-04 20:01:51 +00:00
Liran Binyamin
Jagrut Desai
Vinit Nayak
Winson Chung
TreeHugger Robot
Schneider Victor-tulias
Lucas Silva
Mady Mellor
Brian Isganitis
Treehugger Robot
Saumya Prakash
Sunny Goyal
Qiao Yang
Stefan Andonian
Pat Manning