Commit Graph

14374 Commits

Author SHA1 Message Date
Federico Baron cfa0f833f6 Add new flag for dot pagination
Here we add a flag for adding the dot pagination (same as currently in folders) to workspace

Bug: 254769710
Test: N/A
Change-Id: Id5fc33f61b9814f73afea8c5119c7d8d4ee24756
2022-10-25 18:00:03 +00:00
Holly Jiuyu Sun 381ba3319d Merge "Log a-z apps count." into tm-qpr-dev 2022-10-25 17:50:19 +00:00
Sihua Ma 4421353ce8 Merge "Get rid of setInteractionHandler call to the host in launcher" into tm-qpr-dev 2022-10-25 02:44:16 +00:00
Federico Baron f748755a4f Merge "Rename first page pinned widget to mFirstPagePinnedWidget" into tm-qpr-dev 2022-10-25 00:25:34 +00:00
Sihua Ma 8ca56fe1cd Get rid of setInteractionHandler call to the host in launcher
Bug: 235358918
Test: N/A
Change-Id: I0defac1831825bf0a13a601dd1502b4ca022bc2e
2022-10-24 14:56:11 -07:00
Federico Baron 2c97e58933 Merge "Set smartspace to 30% visibility on workspace edit for home gardening" into tm-qpr-dev 2022-10-24 19:17:29 +00:00
Sunny Goyal 0cf401d0eb Merge "Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""" into tm-qpr-dev 2022-10-24 17:38:42 +00:00
Mady Mellor b5c2565447 Merge "Hide launcher when freeform tasks are visible" into tm-qpr-dev 2022-10-24 16:04:59 +00:00
Sunny Goyal f34811d3a3 Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""
Test: ABTD
https://android-build.googleplex.com/builds/abtd/run/L52600000956969786

This reverts commit cee6ddf3de.

Reason for revert: Fixed in ag/20239136

Change-Id: I0e8446e66d9a86a94b40fcbd6de14da07abe8e5c
2022-10-22 15:37:47 +00:00
Ling Wo ac29981a42 Merge "Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion" into tm-qpr-dev 2022-10-21 21:44:35 +00:00
Federico Baron 0abfda8f2f Rename first page pinned widget to mFirstPagePinnedWidget
mQsb is the name used for the first page pinned widget. This variable name is bad since in some launchers the first page pinned widget is a qsb but sometimes it is a smartspace. Renaming the variable to mFirstPagePinnedWidget is a more accurate name for this variable.

Bug: 251259222
Test: N/A
Change-Id: I6d3c74163995d2267510ee546924917062c4955c
2022-10-21 13:01:24 -07:00
Federico Baron a56f08e677 Set smartspace to 30% visibility on workspace edit for home gardening
Here we set the smartspace to have 30% visibility to follow the guidelines set by https://docs.google.com/presentation/d/1FOmmCdmGmSMR77_901IOMbvbPVxPmjaAdxZjy-D9tw0/edit#slide=id.g159289e55db_0_229

Bug: 251259222
Test: Enter drag mode in workspace with SHOW_HOME_GARDENING flag on to see the changes
Change-Id: Ia2ef4f1a49549fef9f8fbea7c007db8b81972f71
2022-10-21 13:00:58 -07:00
Sunny Goyal 415fe0c183 Merge "Optimizing some icon generation code:" into tm-qpr-dev 2022-10-21 18:27:54 +00:00
Mady Mellor 9a90c2d521 Hide launcher when freeform tasks are visible
This CL introduces a new controller to manage the visibility of the
launcher workspace when desktop mode is active and freeform tasks
are visible.

This controller will be notified when the sysui state flag related
to freeform task visibility is changed.

The controller will modify the workspace visibility as well as
the flags on the activity indicating if it's been paused / resumed
based on freeform tasks being visible or not.

Bug: 245569277
Test: manual -  enable desktop mode and open some freeform tasks
             => observe that the contents of launcher is hidden and
                taskbar shows
             -  remove all of the freeform tasks
             => observe that the contents of launcher reappears along
                with the hotseat.
Change-Id: I378ab97b40cbb954a06f4e2426b195efddad905c
2022-10-21 10:06:54 -07:00
Vinit Nayak b9b7c38d55 Merge "Improve TaskMenuView layouts for split pairs" into tm-qpr-dev 2022-10-21 00:07:53 +00:00
Brian Isganitis 2bcc3f8599 Merge "Fix crash on long press of prediction row icons" into tm-qpr-dev 2022-10-20 22:54:06 +00:00
Vinit Nayak e690ef7f80 Merge "Scale screenWidth for split proportionally for thumbnail matrix" into tm-qpr-dev 2022-10-20 22:49:57 +00:00
Jeremy Sim 8edca84cd5 Merge "Prevent doubling up on split placeholder insets" into tm-qpr-dev 2022-10-20 20:59:49 +00:00
Sukesh Ram aee55077cc Fix crash on long press of prediction row icons
Changed icon long click listener to use secondary display's long
click listener instead of launcher's.

Bug: 239616635
Test: Manual
Change-Id: I9a4679ba82cacb5e2648481274876dbfc95d80ce
Merged-In: I9a4679ba82cacb5e2648481274876dbfc95d80ce
2022-10-20 18:11:15 +00:00
Brian Isganitis ddbe35cc87 Merge "Drag from appDrawer & pin onto secondary display homescreen" into tm-qpr-dev 2022-10-20 18:08:07 +00:00
Sunny Goyal fc1928e324 Optimizing some icon generation code:
1) Fixing missing shadow from shortcut icons
2) Chaning all-apps icon rendering to draw background/foreground separately
   This allows us to reuse the bitmap generated for themed icons, instead of
   creating a new everytime

Bug: 248308987
Test: Verified on device
Change-Id: Ia3cbefb21a2ce676d6bb2df3d9375d61b5bed61b
2022-10-20 10:40:54 -07:00
Vinit Nayak 981034687a Scale screenWidth for split proportionally for thumbnail matrix
* Instead of passing in screenWidth to be that
of entire screen when using split, scale screenWidth
to that of only the amount that the given split app
is taking.
* Created TODO(b/254378592) to consolidate different
SplitBounds classes

Fixes: 250817893
Test: Checked phone/tablet swiping quickswitching
portrait and landscape

Change-Id: I5c3b2076110e358366284b2c794fd8df8a79f034
2022-10-19 21:39:50 -07:00
TreeHugger Robot 821ef94974 Merge "Add scroll up and scroll down logging." into tm-qpr-dev 2022-10-19 20:31:54 +00:00
Federico Baron 41235d529b Merge changes I03636e28,I6cf6d52e into tm-qpr-dev
* changes:
  Fix page indicator dots height in workspace
  Change delightful pagination flag and use it for workspace
2022-10-19 19:33:18 +00:00
Sukesh Ram b066f41fa3 Drag from appDrawer & pin onto secondary display homescreen
Bug: 239246505
Test: Manual
Change-Id: I817d8ef700f2d7caec6fa63123935502f17f2d2f
Merged-In: I817d8ef700f2d7caec6fa63123935502f17f2d2f
2022-10-19 18:22:01 +00:00
Anushree Ganjam 0de35265c1 Add scroll up and scroll down logging.
Bug: 247601175
Test: Manual. https://paste.googleplex.com/5757099224072192

Change-Id: Iec1697e1580c75572c9e77ec349942301ee87694
2022-10-19 18:00:45 +00:00
Andy Wickham a57bff8473 Merge "More robust fix to BubbleTextViews appearing on multiple rows." into tm-qpr-dev 2022-10-19 17:40:52 +00:00
TreeHugger Robot c9928a1ddf Merge "Implement overlay window for Taskbar EDU and All Apps." into tm-qpr-dev 2022-10-19 14:01:56 +00:00
Pat Manning ded9a7485e Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev 2022-10-19 13:36:56 +00:00
Alex Chau 8dac89d235 Merge changes from topic "widget_blur" into tm-qpr-dev
* changes:
  Enable wallpaper blur for widget picker
  Fix STATE_DEPTH stuck at 1 after setting wallpaper
2022-10-19 09:37:39 +00:00
Holly Sun dbd01bf6f9 Log a-z apps count.
Test: manual
Bug: 247432075
Change-Id: I9538a75bc3cb3d1e8e9089fc5e27d5d770cafb62
2022-10-18 15:57:53 -07:00
Federico Baron 1028a726ef Get rid of spring loaded mode for home gardening design
For the new home gardening mode, we plan on not having a spring loaded mode where the overlay shrinks, so when we have the flag for home gardening on, we won't be having the workspace have the green overlay and the icons shrink

Bug: 251259222
Test: Hold on an icon in workspace to enter edit workspace mode, notice how we no longer shrink the workspace
Change-Id: Ibf1c38eecc117a838eca20a860d47c355955b513
2022-10-18 13:49:37 -07:00
TreeHugger Robot 7798fb6e30 Merge "Fixes ITEM_TYPE_SEARCH_ACTION to have a unique value." into tm-qpr-dev 2022-10-18 17:34:23 +00:00
Alex Chau 1852459977 Enable wallpaper blur for widget picker
Fix: 240580498
Test: Go to walppaper&style, set new wallpaper, then go to widget picker, wallpaper depth should transition smoothly
Change-Id: Iadabd0e755f861fb1e8967209dd647faed6e4916
2022-10-18 17:07:47 +01:00
Alex Chau 950a10738b Fix STATE_DEPTH stuck at 1 after setting wallpaper
- Made BaseDepthController.setDepth/mDepth private, all get/set should be done through STATE_DEPTH or WIDGET_DEPTH
- Generified ClampedDepthProperty into Utilities.ClampedProperty to apply on STATE_DEPTH

Bug: 240580498
Test: Go to walppaper&style, set new wallpaper, then go to widget picker, wallpaper depth should transition smoothly
Change-Id: I53cdedf970fd7ffba6a952c4edf4b34251b01f07
2022-10-18 17:07:17 +01:00
Andy Wickham 9345681737 Fixes ITEM_TYPE_SEARCH_ACTION to have a unique value.
It previously was the same as ITEM_TYPE_TASK.

Test: N/A
Bug: 254138853
Bug: 254140269
Change-Id: I6f09818e3c5c05cbcbb451147cf310d59c7064e0
2022-10-17 17:11:25 -07:00
Andy Wickham c17c3171c5 More robust fix to BubbleTextViews appearing on multiple rows.
This is the more comprehensive version of ag/20119299.
Improvements compared to that change:
 - Icons on the same row animate together (as opposed to the
   first icon on the row animating separately)
 - Multiple rows of predicted apps are supported (any beyond
   the first row are animated like everything else)

--- Original description ---

Example BubbleTextView: WhatsApp/Gmail conversation shortcuts.

The issue was we were treating these the same as the top app
row, but we were assuming there would only be 1 such row, which
messed up the measurement logic. At the same time, the logic
specific to that app row was redundant with the new logic for
rows containing mulitple items.

This solution does 2 things:
 - Removes special logic for app row (it now uses the same
   logic as other rows with multiple items, i.e. uses the span
   index to determine the height of the row)
 - Keeps the scale/alpha at 1 for the first row of app icons.
   This currently only applies to predicted apps, but if there
   were multiple app rows in the future, the additional rows
   would animate the same way as other rows (see demo videos
   for an example with double predicted apps in 0 state). In
   the conversation case, the other icons are deep shortcuts.

The result is the app row still does what it did before (stays
fixed at full size/opacity), and deep shortcuts like the ones
used for WhatsApp and Gmail animate like other rows of items,
such as screenshots.

Demo videos: https://drive.google.com/drive/folders/1GPQNIwMfuj9ZdAbRrh-K75C5xJYT4Gzo?resourcekey=0-ojO6VGetEBy5YTq4roFmlw&usp=sharing

Test: Manual with and without inject_web_top (which moves app row)
for WhatsApp and Gmail with AiAi fishfood.
Bug: 239927522

Change-Id: Ib2ca97b93798cb57eb55545eeba8be9322484f7d
2022-10-17 16:47:27 -07:00
Vinit Nayak 90eff11fee Merge "Landscape 3 button nav on taskbar phone supported" into tm-qpr-dev 2022-10-17 22:30:05 +00:00
Hui Kang 2a28ae8a3f Merge "Revert "Updating the scroll calculation from recyclerView to avoid view inflation"" into tm-qpr-dev 2022-10-17 21:20:09 +00:00
Vinit Nayak d6c5147524 Landscape 3 button nav on taskbar phone supported
* TODO: Seascape bar positioning, add tests

Change-Id: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
Merged-In: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
2022-10-17 13:59:18 -07:00
Hui Kang cee6ddf3de Revert "Updating the scroll calculation from recyclerView to avoid view inflation"
This reverts commit 20bbe95ddb.

Reason for revert: Causing flake in Ironwood test: b/248295569

Test: ABTD
Before: Flaky, 14/50 PASSED
https://android-build.googleplex.com/builds/abtd/run/L33900000956890639

Revert: 50/50 PASSED
https://android-build.googleplex.com/builds/abtd/run/L49200000956887317

Change-Id: I41f4428c74e581323f90c716a7852b5e553ae27d
2022-10-17 20:37:49 +00:00
TreeHugger Robot 126d178358 Merge "Revert "Enable taskbar in overview by default"" into tm-qpr-dev 2022-10-17 17:40:17 +00:00
Alex Chau 6f0b0fe742 Revert "Enable taskbar in overview by default"
This reverts commit 517131ae1c.

Reason for revert: Reverting until b/251747761 is addressed
Bug: 245320601

Change-Id: Ic5ebc071f092c8f91ff879a59d89c3be4326c90e
2022-10-17 14:38:09 +00:00
Pat Manning 5889bc3729 Add launcher metrics for tracking kids nav mode change events.
Fix: 241762670
Test: wwdebug && wwlogcat
Change-Id: I24432f2cd0dddbcc5991645b60a1a8e91dc431e5
2022-10-17 14:06:38 +01:00
Brian Isganitis 2d6371aa34 Implement overlay window for Taskbar EDU and All Apps.
Having EDU in the same window as Taskbar causes it to be above All Apps
and other system views such as the notification tray. This change
refactors the existing All Apps window to accomodate more AFVs so that
EDU can also exist in it.

Demo: http://shortn/_Qcki3gwvf7

Test: Manual
Fix: 232177330
Change-Id: I1bef31d798041a90a0c3e033e71be63898fa5fbc
2022-10-14 22:36:14 +00:00
Sebastián Franco 73b8ee9390 Merge "Moving the class LayoutParams to a file outside CellLayout" into tm-qpr-dev 2022-10-14 20:43:34 +00:00
Alex Chau 41ab3f3e14 Merge "Run setCurrentPage in applyLoadPlan after scroll initialized" into tm-qpr-dev 2022-10-14 00:31:32 +00:00
Vinit Nayak 0f6526e0c4 Improve TaskMenuView layouts for split pairs
* Instead of basing calculations on the TaskView view,
use the TaskThumbnailView as the anchor.
This helps us prevent having to re-calculate positions
that were already done to layout the thumbnails
* TODO: Gracefully handle re-positioning task menu view
on rotation

Bug: 249693334
Test: Manual, opening task menu view in
land/seascape in portrait, w/ and w/o home rotation

Change-Id: I02da96d2735657d5340e23056de69392ff8452c4
2022-10-13 14:15:14 -07:00
Vinit Nayak 0bc70442d6 Merge "Fix casts to Math.round() in real landscape" into tm-qpr-dev 2022-10-13 20:02:05 +00:00
Vinit Nayak b26664800e Fix casts to Math.round() in real landscape
Fixes: 248575056
Test: Wallpaper no longer bleeds through on split
animation in real landscape.

Change-Id: Ia59efda737de94a4b64f9d0a1f84cd116539107b
2022-10-13 13:01:39 -07:00