Commit Graph

3855 Commits

Author SHA1 Message Date
TreeHugger Robot ce629ff837 Merge "Handling Launcher configuration change between touchDown and Launcher.onStart" into ub-launcher3-rvc-dev 2020-06-22 18:04:14 +00:00
Samuel Fufa 6dac493218 Merge "Send app launch events from TaskSwitcher" into ub-launcher3-rvc-dev 2020-06-22 17:36:12 +00:00
TreeHugger Robot 845f135d17 Merge "Add depth animation when multiwindow mode changes." into ub-launcher3-rvc-dev 2020-06-22 17:31:35 +00:00
Sunny Goyal 6fe83da57c Handling Launcher configuration change between touchDown and Launcher.onStart
If activity rotation is allowed, Launcher/recents can rotate while swipe animation
is running leading to inconsistencies between deviceProfile and rotation
> Using activity configuration to determine the rotation instead of using display rotation
> Removing rotation watcher when rotation is enabled as it is not used anymore

Bug: 158781568
Change-Id: I107d856cae80af111c0514656fac7ab1fa0c21cb
2020-06-22 10:04:35 -07:00
Tony Wickham 698dfc03cb Merge "Don't reset GestureState when touching outside of swipe region" into ub-launcher3-rvc-dev 2020-06-22 16:20:22 +00:00
TreeHugger Robot b22655f8e1 Merge "Revert "Allow shortcut predictions in hybrid hotseat"" into ub-launcher3-rvc-dev 2020-06-21 07:24:25 +00:00
Winson Chung c46daa9572 Merge "Tweak quickswitch thresholds" into ub-launcher3-rvc-dev 2020-06-21 04:08:09 +00:00
Winson Chung 4941f65d52 Tweak quickswitch thresholds
- Reduce slop for gestural mode (and apply multiplier to slop
  at checktime)
- When quickswitch threshold is passed, reduce the total movement
  check and reduce the velocity needed to fling to the next page
  to accommodate short swipes
- Use touch slop to determine scrolling in paged view, and only
  use paging slop to determine flinging to the next page (when
  easy flings are disabled (which is the default))

Bug: 157165240
Test: Ensure the flings in normal overview/paged views don't change,
      check short flings from quickswitching
Change-Id: Idd04ce23f53c06759e84ac8ad73cf2cc6dff6975
2020-06-20 19:41:32 -07:00
TreeHugger Robot 5ec76de182 Merge "Deleting old cache images before saving new ones." into ub-launcher3-rvc-dev 2020-06-20 20:19:01 +00:00
Tony Wickham 61fa23ab3a Don't reset GestureState when touching outside of swipe region
We were setting mGestureState = DEFAULT_STATE when touching outside
of the swipe region. Instead, we should only set mGestureState when
starting a new gesture, and only set it to DEFAULT_STATE on reset.

This also makes it clearer that mGestureState always refers to the
current gesture state, rather than sometimes being the current
gesture and sometimes being the previous gesture depending on
where it was used. Now previousGestureState is passed when needed.

Bug: 159494933
Change-Id: Ib62278b7c591ca4c6b99b26e058a34772e6cec2a
2020-06-20 12:04:12 -05:00
Samuel Fufa 857c512987 Revert "Allow shortcut predictions in hybrid hotseat"
This reverts commit 2d8e882d2e.

Reason for revert: Moving this to master. 

Change-Id: I46cfbda92d74a1f9fa9f0c091811941fe74ce76b
2020-06-20 16:53:51 +00:00
Hyunyoung Song ac3f71269e Merge "Remove ConcurrentModificationException for snapshot logging Bug: 159282737" into ub-launcher3-rvc-dev 2020-06-20 06:27:01 +00:00
TreeHugger Robot d4b946dbe3 Merge "Workaround for activity manager crashing when trying to start an app It flakes when one of the tests starts calculator while there zero activities in the system." into ub-launcher3-rvc-dev 2020-06-20 06:13:48 +00:00
Samuel Fufa 9024c85742 Merge "Allow shortcut predictions in hybrid hotseat" into ub-launcher3-rvc-dev 2020-06-20 04:57:02 +00:00
Samuel Fufa 2d8e882d2e Allow shortcut predictions in hybrid hotseat
Screenshot: https://screenshot.googleplex.com/TckWKGYWwHW

Note: Shortcut predictions will not be cached.

Bug: 159500320
Test: Manual
Change-Id: Id8ec81544bddb8be87a5e748fd9f9e93aaaf8fea
2020-06-19 18:50:22 -07:00
vadimt 8914c51660 Workaround for activity manager crashing when trying to start an app
It flakes when one of the tests starts calculator while there zero
activities in the system.

Bug: 143488140
Change-Id: Id9d350f0de8a83eb50e35e9efa4226b8d45ca641
2020-06-20 01:12:50 +00:00
Sreyas ae74a618bd Deleting old cache images before saving new ones.
Change-Id: I5947fe43b0e1bfac35247bf64f08e49560d58cac
2020-06-19 17:28:19 -07:00
thiruram b53764bd4b Fixes folder logging.
Only LAUNCHER_FOLDER_LABEL_UPDATED events will have FromState, ToState
and FolderLabelInfo. Other folder events such as OPEN, DRAG etc will have
basic fields only populated.

Sample Log: https://paste.googleplex.com/5468394805526528
Screencast: http://rcll/hSUQjtQXfQM5i9DjjAQTf2/Zn5FeiVDONaQj0mK1JNjg

Bug: 159164315
Change-Id: I903fc7b62bcee748aa3ef695453be3e14d388712
2020-06-19 17:06:46 -07:00
Jon Miranda 36d1015997 Add depth animation when multiwindow mode changes.
This is a workaround until we can support app transitions when starting
an activity in mw mode.

Bug: 158613217
Change-Id: I843d6669722c543728ab532e1c4fbd4643f6f135
2020-06-19 16:36:57 -07:00
TreeHugger Robot 72ac78189f Merge "Fix RecentsView scroll linking" into ub-launcher3-rvc-dev 2020-06-19 23:28:55 +00:00
TreeHugger Robot f9ae1a838a Merge "Fixing fallback recents not getting proper insets on configuration change" into ub-launcher3-rvc-dev 2020-06-19 23:22:54 +00:00
Hyunyoung Song 5eae3c0a0a Remove ConcurrentModificationException for snapshot logging
Bug: 159282737

Change-Id: I37edcf6aa11272b488a0633716567c48e56e5433
2020-06-19 16:12:43 -07:00
Tony Wickham 94d1b4be17 Fix RecentsView scroll linking
- Reverts change from ag/11900651 that deferred setting
  mRecentsViewScrollLinked = true
- Instead, setCurrentPage(mCurrentPage) after updating layout rotation
  to ensure we recompute page scrolls before using them

Test:
- Auto rotate on, home rotation off, open Calculator in landscape,
  swipe up slowly and ensure it never turns invisible
- Quick switch from Calculator to Clock, start swiping directly up
  immediately after settling on Clock, ensure Calculator window
  remains at its scroll position to the side (b/159461591)

Fixes: 159461591
Change-Id: Iab92963cc6c33df42b77f5ccfa3932382e8f869a
2020-06-19 17:42:18 -05:00
Samuel Fufa 56b35b9d0a Send app launch events from TaskSwitcher
Sends AppTargetEvent with action launch and container CONTAINER_OVERVIEW to AppPredictor when user launches app form recents.

Bug: 155996363
Test: Manual
Change-Id: I3eb38f5737ecaeb07e59db460e8d809416132825
2020-06-19 14:14:52 -07:00
Tony Wickham e19b065c7c Merge "Remove progress != mFullscreenProgress optimization" into ub-launcher3-rvc-dev 2020-06-19 18:45:44 +00:00
Sunny Goyal 9d89f75ce4 Fixing fallback recents not getting proper insets on configuration change
> Using common code for Launcher and recents for insets dispatching
> Fixing recents auto closing when there is no running task

Bug: 158750568
Bug: 159133601
Change-Id: Iee25c603a77a1ac546ada1840f3afaf5797b8802
2020-06-19 11:41:53 -07:00
Zak Cohen aef8b86b4a Image actions - fix uri permissions.
Feedback wasn't working, also Share wasn't showing its preview.

Bug: 159122067
Test: built and run locally
Change-Id: Iccea012a8fc0009a6a980f6233f42c4e7619f4ec
2020-06-19 18:02:44 +00:00
Tony Wickham 6a8ba169f2 Remove progress != mFullscreenProgress optimization
Sometimes other methods modify things like icon scale that setting
the fullscreen progress should override.

Test: open Calculator, open Clock, quick switch to Calculator and
ensure its task icon is not showing

Bug: 157105795
Change-Id: Iaed3e42f540fdff3648e9db7e6d7dc0b0d0a75df
2020-06-19 12:20:38 -05:00
Vadim Tryshev 84aaecca64 Merge "Removing debug requests from non-debug test info handlers" into ub-launcher3-rvc-dev 2020-06-19 16:37:41 +00:00
TreeHugger Robot a5e45ad485 Merge "Fixing jump when swiping up in landscape and in waterfall cutout" into ub-launcher3-rvc-dev 2020-06-19 07:17:02 +00:00
Tony Wickham f13a51c4b8 Merge "Inline TaskView#resetVisualProperties() into RecentsView" into ub-launcher3-rvc-dev 2020-06-19 05:26:32 +00:00
TreeHugger Robot 5c33e250fc Merge "Follow up for ag/11916646" into ub-launcher3-rvc-dev 2020-06-19 01:42:09 +00:00
TreeHugger Robot 92b0b1d0a1 Merge "Add spring to workspace scale when going from Hint state to Normal state." into ub-launcher3-rvc-dev 2020-06-19 01:28:25 +00:00
Tony Wickham d2fffa6ea5 Inline TaskView#resetVisualProperties() into RecentsView
- This was only used in RecentsView#resetTaskVisuals() anyway
- Previously resetVisualProperties() just called resetViewTransforms()
  plus setFullscreenProgress(0) and setModalness(0)
- The latter 2, specificially setFullscreenProgress(0) led to problems
  such as the bug below. Instead, we should reset to the current
  mFullscreenProgress and mTaskModalness.

Bug: task view sometimes shifted up during quick switch
Steps:
- Do the quick switch gesture very quickly
- At the start of the gesture, we call getTasks(), which calls
  applyLoadPlan() asynchronously
- applyLoadPlan() calls resetTaskVisuals(), so if this happened
  after the gesture ended, we would setFullscreenProgress(0) on all
  the task views, hence the upwards shift (if the gesture was still in
  progress, it would reapply the real fullscreen progress)

Fixes: 157105795
Change-Id: Idb9d91ff89701d726838b47f955d4300f5ef13bd
2020-06-18 20:25:34 -05:00
Samuel Fufa 1d08cc681c Follow up for ag/11916646
- Fixes launcher breakage

Bug: 159170242
Change-Id: Ib21bfee8d5f63d31a8807ad87ac47d600fb62e7a
2020-06-18 17:57:39 -07:00
Jon Miranda 271638574f Add spring to workspace scale when going from Hint state to Normal state.
Bug: 151768994
Change-Id: If03d39e5ef6319355a7691d60fc0152de2fc3cec
2020-06-18 17:53:07 -07:00
Samuel Fufa a529cd0f5f Merge "Allow Users to migrate their hotseat when returning from AiAi" into ub-launcher3-rvc-dev 2020-06-19 00:51:18 +00:00
Samuel Fufa d25a112b0e Allow Users to migrate their hotseat when returning from AiAi
- If a user has mostly predicted hotseat, show a snack bar. otherwise, show migration option.
- Guard onboarding activity with permission `com.google.android.apps.nexuslauncher.permission.HOTSEAT_EDU`

Bug: 158569583
Test: Manual
Change-Id: Id0c1c812233fcf288a2f49848720199dedd2015d
2020-06-18 16:38:58 -07:00
TreeHugger Robot c471a9a6bb Merge "Show a snackbar on predicted icon longpress" into ub-launcher3-rvc-dev 2020-06-18 23:34:58 +00:00
thiruram ffb55ddece Deprecates LAUNCHER_ALL_APPS_RANKED event.
LauncherUiChanged.rank field is repurposed to store all apps rank.

Change-Id: Iabad98312589d8f53b6547433540f3ec9dff0b3f
2020-06-18 15:08:16 -07:00
TreeHugger Robot 8e9405d7cd Merge "Fix bug where All Apps Edu gets closed via user input before animation ends." into ub-launcher3-rvc-dev 2020-06-18 21:20:36 +00:00
TreeHugger Robot d4de6d4bba Merge "Avoid hotseat edu button overlapping" into ub-launcher3-rvc-dev 2020-06-18 21:06:44 +00:00
TreeHugger Robot 3b80398889 Merge "Add flag Intent.FLAG_ACTIVITY_NEW_TASK when launching suggestion settings" into ub-launcher3-rvc-dev 2020-06-18 20:48:52 +00:00
Jon Miranda 1bbd2831f3 Fix bug where All Apps Edu gets closed via user input before animation ends.
Also fixes bug where user continuously swipes to hint view causes count
to increase more than the max count which prevents all apps edu from showing.

Bug: 151768994
Change-Id: I3186398d441e723a2cfb6e396b03944502a65cf5
2020-06-18 13:40:33 -07:00
Samuel Fufa 9058e305e5 Avoid hotseat edu button overlapping
Screenshot: https://screenshot.googleplex.com/cCNn6hdrqu1
Bug: 158194467
Change-Id: I465ab73be2079f20994b3f2bbe57f64e46d05777
2020-06-18 13:32:17 -07:00
Samuel Fufa c376a1de2c Add flag Intent.FLAG_ACTIVITY_NEW_TASK when launching suggestion settings
Bug: 158604370
Test: Manual
Change-Id: I01e313d29cbc9b7ea2413547d9a7b4940d126ce8
2020-06-18 13:13:45 -07:00
Samuel Fufa 44c1b5e03d Show a snackbar on predicted icon longpress
The first time a user long presses a predicted icon, suppress drag/drop and show a snackbar about app predictions.

Bug: 159170242
Test: Manual
Change-Id: I5f853a9774b38ad9fad22ff55feff417a801f52c
2020-06-18 10:57:32 -07:00
TreeHugger Robot fcc4a2d83f Merge "Avoid Crash when longpressing disabled predicted item" into ub-launcher3-rvc-dev 2020-06-18 17:45:57 +00:00
Jonathan Miranda 42dd4f4afd Merge "Use screenSpaceBounds to position the target window for recents mw animation." into ub-launcher3-rvc-dev 2020-06-18 17:03:18 +00:00
Sunny Goyal b64fc6c26f Fixing jump when swiping up in landscape and in waterfall cutout
> Adding tests for TaskViewSimulator to ensure proper calculations
> Disabling orientation listener while user is interacting with quickstep

Bug: 158781568
Bug: 156891776
Change-Id: I299c3b1243ac0dbf28faee1b8566c77ea3954e33
2020-06-18 00:29:00 -07:00