Commit Graph

5620 Commits

Author SHA1 Message Date
Charlie Anderson 51c537ae15 Merge "prevent some clipping for popup shortcuts on small screens / landscape" into udc-dev 2023-03-30 21:12:10 +00:00
Andrew Cole d1c0d5c039 Merge "Fixing an issue with the drop target font becoming very small for removing and uninstalling. I also verified that this doesnt break a fix presented in b/264732627" into tm-qpr-dev am: 6cb7469564 am: 67f446827b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22338450

Change-Id: I27d4ed2572abc6b4bd4e445b56cc9348dcb88fb8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 18:02:59 +00:00
Andrew Cole 67f446827b Merge "Fixing an issue with the drop target font becoming very small for removing and uninstalling. I also verified that this doesnt break a fix presented in b/264732627" into tm-qpr-dev am: 6cb7469564
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22338450

Change-Id: I415ab087552478fe95d4055735300be1c77b01bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 16:47:29 +00:00
Charlie Anderson a2dc0a1a9c prevent some clipping for popup shortcuts on small screens / landscape
Test: run failing test
Bug: 275115239
Change-Id: I9278f6e1c1835a8ec6a4f363e237c64fd199716a
2023-03-30 15:08:36 +00:00
Sunny Goyal 1fc1cd002f Merge "Revert "Simplifying some page indicator dots attributes so that it can"" into udc-dev 2023-03-29 21:22:10 +00:00
Sunny Goyal 0263a679f2 Revert "Simplifying some page indicator dots attributes so that it can"
This reverts commit a5ead45967.

Reason for revert: b/274169859

Change-Id: Id214694ae4f61cd70796c6f7e932c1fdef82d746
2023-03-29 19:11:03 +00:00
Andrew Cole 3ae7be6293 Fixing an issue with the drop target font becoming very small for removing and uninstalling. I also verified that this doesnt break a fix presented in b/264732627
Fix: 274402490
Test: Manual
Change-Id: Id61cf7e33f83e0cb25c82b5e7b167b04657fd612
2023-03-29 17:21:34 +00:00
Jon Miranda a97dc04478 Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev am: 085c53869f am: 3cd39729dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22228076

Change-Id: I3cb2d462cef1df514c87418ed70ac624899c21fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 23:02:51 +00:00
Jon Miranda 3cd39729dc Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev am: 085c53869f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22228076

Change-Id: I687ea2a249e73036f8d4c4d187d999fd224b9f02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 22:02:13 +00:00
Jon Miranda 085c53869f Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev 2023-03-24 21:51:42 +00:00
Jon Miranda 9c478b6c29 Add taskbarIconSize to GridOption/DisplayOptions
- Renamed variables to make it more clear what they represent
- DeviceProfile will be source of truth for taskbar
  sizes

Bug: 265144213
Test: phone, multi-display, tablet
Change-Id: Id9c19d15a65894fd7645e0f876a4b6527b713c34
Flag: ENABLE_TRANSIENT_TASKBAR=true
2023-03-24 12:29:11 -07:00
Federico Baron 002317f60c Add subclass for two pane widget picker
Since the regular widget picker and the widget picker for tablet diverge quite a bit, we added a child class for it that extends WidgetsFullSheet.java
There should be no functionality changes with this CL, it's purely changes in code structure.

Bug: 256684299
Test: Turn on LARGE_SCREEN_WIDGET_PICKER flag and verify nothing changes compared to ag/20508230.
Change-Id: Ie0e93534d7b93017cc11a05f67728155d22951f9
2023-03-24 11:48:20 -07:00
Jagrut Desai 8e8017acf8 Merge "Make clear announcment for taskbar education." into tm-qpr-dev am: 601e0ff89c am: 9e4619e243
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22146024

Change-Id: I2c616ad0736f9345fc0d454bfbf7bbaa2b6cccbd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 00:56:17 +00:00
Jagrut Desai 9e4619e243 Merge "Make clear announcment for taskbar education." into tm-qpr-dev am: 601e0ff89c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22146024

Change-Id: I17dcffb5e72b672fedd2d54bbee6f09f99a395dc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 00:24:37 +00:00
Jagrut Desai 601e0ff89c Merge "Make clear announcment for taskbar education." into tm-qpr-dev 2023-03-23 23:52:24 +00:00
TreeHugger Robot 0607e6435e Merge "Update taskbar background color." into tm-qpr-dev am: 906ad8b853 am: 903ff4c926
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22211883

Change-Id: If2248c206b1d9a17c9f25af46bcdb48f2d224db8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 20:26:12 +00:00
TreeHugger Robot 903ff4c926 Merge "Update taskbar background color." into tm-qpr-dev am: 906ad8b853
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22211883

Change-Id: Ibd9988ac58efbc20fddeb9bb0e0f3b08040b5222
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 19:48:25 +00:00
Jagrut Desai ef1a9b798d Make clear announcment for taskbar education.
Test: Manual
Bug: 273393698
Bug: 273408584
Flag: not needed
Change-Id: I6c6eb1e1e1047a2e702592290bf5735e8bfa6ce2
2023-03-23 11:26:09 -07:00
TreeHugger Robot 199000e292 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-03-23 05:37:23 +00:00
Jon Miranda ec6fbb490a Update taskbar background color.
Bug: 259712417
Test: manual
Change-Id: I7eb207d420bcadc2cd37d206a0dbd96081741cad
2023-03-22 16:26:07 -07:00
Bill Yi b480a6ea12 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If3e4fac3a5465ca8d37783098939b959f35e020b
2023-03-22 06:28:20 -07:00
fbaron d11a9e1d08 Widget picker two pane polish
-increase width of two pane picker
-center widgets when they're too few to overflow
-make background stretch out all the way to the bottom even when there aren't multiple widgets
-fit many widgets in one row if they fit

Bug: 256684299
Test: open widget picker and notice that all the listed fixes match the last figma added in the bug
Change-Id: Id4e8445f4ffe484c24c04fd9d1b4ffbf93a00bb2
2023-03-21 16:49:45 -07:00
Federico Baron c3ab820144 Add test for widget picker on landscape mode for tablets
When we added widget picker two pane layout, it broke some tests with the flag on. Here we fix those tests.
Bug: 256684299
Test: AddWidgetsTest and TaplTestsLauncher3#testWidget

Change-Id: I383c754016d82fba51fa0b7b0459cd7e83b274d8
2023-03-21 16:48:12 +00:00
Jon Miranda 4202d43e48 Merge "Tune springs when app animates home into the hotseat on devices with a taskbar." into tm-qpr-dev am: fad8c1c449 am: 03bb5fe49c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22146526

Change-Id: I0adde19b10d0bf6c25c5025453fd361a0804cf62
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 22:12:54 +00:00
Jon Miranda 03bb5fe49c Merge "Tune springs when app animates home into the hotseat on devices with a taskbar." into tm-qpr-dev am: fad8c1c449
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22146526

Change-Id: Iaa1d5cf3e030398c97841fe604ad923cce4e25e7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 21:34:11 +00:00
Jon Miranda fad8c1c449 Merge "Tune springs when app animates home into the hotseat on devices with a taskbar." into tm-qpr-dev 2023-03-20 20:54:27 +00:00
Jon Miranda 4235a94958 Merge "New taskbar thresholds." into tm-qpr-dev am: d95c511b2c am: 5ce4bd3412
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22140107

Change-Id: I3a17fbf6d4969a2c991b30d8007bf1c33ddec8b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 18:22:49 +00:00
Jon Miranda 18c53ac26b Tune springs when app animates home into the hotseat on devices
with a taskbar.

Thought about using the Builder pattern here but the CL becomes
much larger due to SwipePipToHomeAnimator having its own
Builder.

Bug: 268026344
Test: swipe up to close app thats in hotseat
      swipe back to close app thats in hotseat

Change-Id: Idd0729224374579753fc91c7820f3b04a7d3e1a4
2023-03-20 10:56:43 -07:00
Jon Miranda 5ce4bd3412 Merge "New taskbar thresholds." into tm-qpr-dev am: d95c511b2c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22140107

Change-Id: Ia16e24ed47616868469f428638b999d20b5712b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 17:44:58 +00:00
Jon Miranda d95c511b2c Merge "New taskbar thresholds." into tm-qpr-dev 2023-03-20 17:16:22 +00:00
Sunny Goyal feca2d8700 Merge "Simplifying some page indicator dots attributes so that it can be easily modularized" into udc-dev 2023-03-17 19:02:01 +00:00
Jon Miranda 4a7569b1b0 New taskbar thresholds.
Nav threshold / App window threshold / Home overview threshold / Catch up threshold
Default: 40dp / 88dp / 156dp / 264dp
sw720dp: 30dp / 100dp / 180dp / 300dp

Bug: 267646355
Test: manual
Change-Id: Ic4e99820ca44d3f1bfc12f570d003d4062e6a2cd
2023-03-17 08:16:56 -07:00
Charlie Anderson 7c7ccbb2ad Merge "Fixes tests and issues when toggling new app shortcut popup flag." into tm-qpr-dev am: d4eed6ec90 am: cd6fd73639
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21992972

Change-Id: Id79a204f2f489e35829f2336743d1a06cd0d9908
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-17 01:21:16 +00:00
Charlie Anderson cd6fd73639 Merge "Fixes tests and issues when toggling new app shortcut popup flag." into tm-qpr-dev am: d4eed6ec90
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21992972

Change-Id: Ic4c29770d9b485252bc8e12e7666f8ab0598cdec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-17 00:45:25 +00:00
Charlie Anderson d4eed6ec90 Merge "Fixes tests and issues when toggling new app shortcut popup flag." into tm-qpr-dev 2023-03-17 00:15:54 +00:00
Sunny Goyal a5ead45967 Simplifying some page indicator dots attributes so that it can
be easily modularized

> Moving the color configuration to xml
> Moving auto-hide logic to a subclass as it doesn't
  need to be in the main library

Bug: 274011949
Test: Verified on device
Change-Id: Icf7bd5d1cbde3daa9441f2af51f98a931bcd6ee2
2023-03-16 15:57:06 -07:00
Charlie Anderson 3a2a69ab3d Fixes tests and issues when toggling new app shortcut popup flag.
Bug: 247880037
Test: manually tested app popup. Also ran Launcher tests locally with U flag on/off.
Change-Id: I93c04f9715d583376c36d823c23353619afd26b6
2023-03-16 12:37:14 -04:00
Charlie Anderson 787cd87ec8 Merge "polish for the app shortcut popup, fixing padding on several elements." into tm-qpr-dev am: da4e07812a am: d52925f9c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21791366

Change-Id: I615cd997eb02a7c6b3e43db556ed64ead68b402d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-15 22:20:10 +00:00
Charlie Anderson d52925f9c4 Merge "polish for the app shortcut popup, fixing padding on several elements." into tm-qpr-dev am: da4e07812a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21791366

Change-Id: I83ac6a587bf29869708958a86064b55b2f4f756f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-15 21:38:47 +00:00
TreeHugger Robot d7d58e2abe Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-03-15 21:24:12 +00:00
Bill Yi 519db9ba13 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie6bed63e03409e5a80eadd0e88cf53dbce4abbe4
2023-03-15 01:27:02 -07:00
Charlie Anderson 63be5b53db polish for the app shortcut popup, fixing padding on several elements.
Bug: 269343928
Test: manually verify against spec
Change-Id: Ib8dd7ab2778644e2220622d43f9774c1de6357e9
2023-03-14 11:33:38 -04:00
Sebastián Franco fef518da3d Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev am: 4122868216 am: b8614e298c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778872

Change-Id: I124c235e0dcdeab04b3fe2eb40083118778b9fa2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 20:32:00 +00:00
Sebastián Franco b8614e298c Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev am: 4122868216
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778872

Change-Id: I274f6eae4cda80ea45ee48328b6d2a5abfb1e648
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 19:47:55 +00:00
Sebastián Franco 4122868216 Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev 2023-03-10 19:19:42 +00:00
Brandon Dayauon 061cf0d4e9 Merge "Support two line text in AllApps/OnDeviceSearch w/ feature flag" into tm-qpr-dev am: 5ddc6ab4da am: e0bddb5b42
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898210

Change-Id: I097b55e72e2c07d75a45ff044f581b1f5d30af6c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 18:34:30 +00:00
Brandon Dayauon e0bddb5b42 Merge "Support two line text in AllApps/OnDeviceSearch w/ feature flag" into tm-qpr-dev am: 5ddc6ab4da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898210

Change-Id: Ibf5cb36dc8e5ec0def0012b17b14e848a33d9d83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 17:58:48 +00:00
Brandon Dayauon cf88ea1e62 Support two line text in AllApps/OnDeviceSearch w/ feature flag
Made separate feature flag for on device search
Add unit test to test twoLine string
- Unit tests for testing newStringThatShouldSupportTwoLineText() in BubbleTextView.java. This class tests a couple of strings
and uses the getLineCount() to determine if the test passes. Verifying with getLineCount() is sufficient since BubbleTextView can only be in one line or two lines,
and this is enough to ensure whether the string should be specifically wrapped onto the second line and to ensure truncation.

bug: 201388851
test: presubmit, ran locally on big and small device, before: https://screenshot.googleplex.com/3Q6pwveFDZqxDXL (ORIGINAL TWO LINE TEXT)
after:  https://screenshot.googleplex.com/7pkwUto6HGzMYoT

Change-Id: I93e6ed179e1081d5cdffc6db9c7ae34de8021c24
2023-03-09 15:13:04 -08:00
Sebastian Franco 239ae0a995 Making sure there is a propper Chrome icon for the test to long press
In some cases, the test was long pressing on a recommendation for
google chrome and not a regular chrome icon and the events didn't
match. I don't think is good to relly on chrome getting recommended
so I'm making sure there is always a chrome app icon on the hotseat

Fix: 269163620
Test: atest TaplTestsLauncher3:testWorkspace (run on pixel 7 pro)
Change-Id: Ic8ee744a9af18d60de9bbedd42043f5abbbd7356
2023-03-09 14:59:21 -08:00
Sihua Ma 27ce0f4212 Merge "Set the original drawable for floating widget view" into tm-qpr-dev am: 792dda2344 am: fc9d3a50ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20899726

Change-Id: I91904f267dbca7fc30b8ed5d17c8bcb1fd2a889b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 19:44:37 +00:00