PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
63,820 Commits 1 Branch 0 Tags
cda93a7c8ba3431f7369b2dfdc96d5a41c48eb9d
Commit Graph

16584 Commits

Author SHA1 Message Date
Treehugger Robot 4ae4cf973c Merge "Fix return condition in getWorkspacePageTranslationProvider" into udc-dev am: d756203fa7 am: e841687a7d 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24314473

Change-Id: Ic43435c66c9f6e95d03b8d6734ab84783448969c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-17 07:36:21 +00:00
Treehugger Robot e841687a7d Merge "Fix return condition in getWorkspacePageTranslationProvider" into udc-dev am: d756203fa7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24314473

Change-Id: Ieef8d4827efbd137c13066fb07f3ef0f75a0e625
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-17 06:45:47 +00:00
Treehugger Robot d756203fa7 Merge "Fix return condition in getWorkspacePageTranslationProvider" into udc-dev 2023-08-17 05:42:09 +00:00
Sunny Goyal adfbec8d4e Merge "Log appear animation's scale factor" into udc-dev am: 7a080a7e0f am: 0b1089978f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24154592

Change-Id: I23624392e6bcde0f97ee4302c75a6e5b7f3fa671
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-04 21:03:39 +00:00
Sunny Goyal 0b1089978f Merge "Log appear animation's scale factor" into udc-dev am: 7a080a7e0f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24154592

Change-Id: Ibf1f54176e73578fc9cd1cc2510022e3c6a84237
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-04 20:39:57 +00:00
Sunny Goyal 7a080a7e0f Merge "Log appear animation's scale factor" into udc-dev 2023-08-04 20:13:43 +00:00
Fengjiang Li 2303acd7d4 Log appear animation's scale factor 
Test: Grabbed a bug report b/291974797
Flag: N/A
Bug: 290320302
Change-Id: Ic33dc94806b838a03a2203bdd5701a1eeaeeb7bf
Merged-In: Ic33dc94806b838a03a2203bdd5701a1eeaeeb7bf
 2023-08-03 14:25:00 -07:00
Alex Chau 4bfc0ee720 Fix return condition in getWorkspacePageTranslationProvider 
- When EDIT_MODE was introduced, it added a wrong condition to make it always return DEFAULT_PAGE_TRANSLATION_PROVIDER

Bug: 294228521
Test: manual
Change-Id: If970949c8ab55bc67f98f987a7654ec2db89cdfb
(cherry picked from commit c325c686c7)
 2023-08-03 18:58:58 +00:00
Sunny Goyal 644d85ad0d Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-dev am: 343b896081 am: 9e10ffc553 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23447960

Change-Id: I9587890282eacc4cb29f626591aefedad9078208
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-02 22:00:22 +00:00
Sunny Goyal 9e10ffc553 Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-dev am: 343b896081 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23447960

Change-Id: I38c903a70bb637d78403a29a468d6722269553dd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-02 21:34:25 +00:00
Sunny Goyal 343b896081 Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-dev 2023-08-02 20:51:13 +00:00
Nick Chameyev 2e53f5ef97 [Unfold animation] Do not preemptively start the animation if it has run already 
Currently if we open an app, unfold the device and then go to home
screen we will start the unfold animation preemptively in Launcher
because Launcher activity will receive updated configuration change
(where isTablet = true) only after going back to home screen, not
when unfolding the device.

This causes a problem because SystemUI won't send the unfold animation
events after going back home as the animation has already run, so we
end up with wrongly started animation in Launcher.

This CL fixes the issues by checking if SystemUI has finished the
animation (or if it is currently running) to avoid preemptive animation
start in this case. This is done by subscribing to the original
unfold transition progress provider which emits progress events
sent through IPC from SystemUI.

Bug: 285150685
Bug: 293131586
Test: open an app on folded screen, unfold, go to home screen =>
  check that icons are not squished
Test: fold/unfold when launcher is open
Change-Id: Ic437ff4d19cbd5764635f3007d99880622150f5b
Merged-In: Ic437ff4d19cbd5764635f3007d99880622150f5b
(cherry picked from commit 6d756970e7)
 2023-08-02 11:41:53 +00:00
Sebastián Franco ed918f3935 Disable FOLDABLE_SINGLE_PAGE am: 8d606e89d3 am: 5e740e5d15 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24231346

Change-Id: Iacb206b6f17d81bc4fa8330d6d9b8e750bce5295
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-31 17:41:54 +00:00
Sebastián Franco 5e740e5d15 Disable FOLDABLE_SINGLE_PAGE am: 8d606e89d3 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24231346

Change-Id: I9aaf13f64be8fa29022a7107472735048560e0a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-31 16:58:41 +00:00
Sebastián Franco ce836c83a6 Disable FOLDABLE_SINGLE_PAGE am: 8d606e89d3 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24231346

Change-Id: I47ce4d7e6f88b2577f70db63e818c4f2566b5f10
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-31 16:57:30 +00:00
Sebastián Franco 8d606e89d3 Disable FOLDABLE_SINGLE_PAGE 
The functionality should go back to the same as with phones.
There shouldn't be issues with the reorder or similar behavior since we
are switching form using the MultipageCellLayout to the regular
CellLayout.

The things we need to pay attention to is the the behavior of having two
panels like adding the right number of panels when loading (folding, unfolding and rotating).

Bug: 291822492
Change-Id: I903873e32f35c5ee9e0f3da8581a37d4087d021f
Test: ReorderWidgets
Merged-In: I903873e32f35c5ee9e0f3da8581a37d4087d021f
 2023-07-28 22:16:52 +00:00
Federico Baron 9b77c7a59d Merge "Fix inability to remove or interact with folder when removing 2nd item from folder" into udc-dev am: 8002897694 am: 96e03b3edf 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24056558

Change-Id: I42538c7ba3fac95bb1914c0ef514b1f6c7b59822
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-17 18:39:13 +00:00
Federico Baron 96e03b3edf Merge "Fix inability to remove or interact with folder when removing 2nd item from folder" into udc-dev am: 8002897694 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24056558

Change-Id: Iff6b9ec51905ae3c724eed52f3ecedb7a547efeb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-17 17:58:50 +00:00
Federico Baron 893c0fddac Merge "Fix inability to remove or interact with folder when removing 2nd item from folder" into udc-dev am: 8002897694 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24056558

Change-Id: Ic7f5fbb344116f2c75fefb7391f59b72740433df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-17 17:54:11 +00:00
Federico Baron 8002897694 Merge "Fix inability to remove or interact with folder when removing 2nd item from folder" into udc-dev 2023-07-17 17:11:26 +00:00
Sebastián Franco 95f8e8f465 Merge "Creating a correctly populated mOccupied grid when reordering on foldables" into udc-dev am: be4a43c1d9 am: add37239db 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24060456

Change-Id: Ie7cc41b19a046a8b7b4d9892cd8868c459f801ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-15 00:30:57 +00:00
Sebastián Franco add37239db Merge "Creating a correctly populated mOccupied grid when reordering on foldables" into udc-dev am: be4a43c1d9 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24060456

Change-Id: I58ecf6e04aa29055e1a16b92adff8c2d9913215a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-14 23:50:00 +00:00
Sebastián Franco c0b3e59990 Merge "Creating a correctly populated mOccupied grid when reordering on foldables" into udc-dev am: be4a43c1d9 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24060456

Change-Id: I95bb45ab696c10e608fad20730f68c5da70536fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-14 23:45:32 +00:00
Treehugger Robot 6f59fcc079 Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-d1-dev am: 2a749f1e60 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23877939

Change-Id: I1723336f35a1bc75ef29743c02e8437b6959242d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-14 18:20:13 +00:00
Treehugger Robot 2a749f1e60 Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-d1-dev 2023-07-14 17:49:46 +00:00
Sebastian Franco 52d9d9780f Creating a correctly populated mOccupied grid when reordering on foldables 
On ag/21680045 I copy the previous mOccupied but the right thing to do is to
create a new one with all the views information.

Some test stoped running inadvertently that's why we didn't catch this issue.

There is a separate cl with the test to ensure we can catch it later on.

Fix: 289584301
Test: ReorderWidgets
Change-Id: I27b5a6e38a556d1c73ff8fbbdd552da6045e5b64
(cherry picked from commit 1c5514b566)
 2023-07-13 20:45:28 +00:00
Becky Qiu 0c24511d56 Fix the issue that on tablet/unfold, the allapps background color is wrong. am: aa6612d373 am: 64746f8a29 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24030571

Change-Id: Ie491c9dd58eb430917daffb7a8a47eac7c468bae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-13 20:07:49 +00:00
Becky Qiu eeabfc4ce8 Fix the issue that on tablet/unfold, the allapps background color is wrong. am: aa6612d373 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24030571

Change-Id: I30e50366185c508d4b307f4b3a017355901a4510
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-13 19:03:05 +00:00
Becky Qiu 64746f8a29 Fix the issue that on tablet/unfold, the allapps background color is wrong. am: aa6612d373 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24030571

Change-Id: I513daa1fdeb8d5582bd0cec9b8b2eb4d043f2543
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-13 19:02:27 +00:00
fbaron 326ec97ab6 Fix inability to remove or interact with folder when removing 2nd item from folder 
Fix: 289960317
Test: Verify in unfolded felix that going from 2 icon folder and dragging 2nd icon out of folder lets you open the app that remains where the folder was
Test: Verify in unfolded felix that going from 2 icon folder and dragging 2nd icon into remove droptarget removes the folder and turns it into a single clickable icon
flag: no flag
Change-Id: I26138ee9f8e7cdb45cafe2446dc4d1e3d6d8347f
(cherry picked from commit 5a7ea3069b)
 2023-07-13 18:06:33 +00:00
Becky Qiu aa6612d373 Fix the issue that on tablet/unfold, the allapps background color is wrong. 
As the new spec, it should use materialColorSurfaceDim for all devices.

Bug: 288493929
Test: manual, before: https://screenshot.googleplex.com/7YxpFGekwm6Gz6N, after: https://screenshot.googleplex.com/44Gr2dBfWSct7FK
Flag: no flag needed.
Change-Id: Ic33d9a758fe9fbaa0f735c874a545df711a18e2f
 2023-07-12 00:25:58 +00:00
Jagrut Desai 62dd220b69 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I2c06c2637c4d7fefab71ea87af677b210cd2829c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-06-30 23:45:46 +00:00
Jagrut Desai 982dacc7ef Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I5c4b401023efb9cd5fcdbff50819dc95ad6cc4c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-06-30 23:06:12 +00:00
Jagrut Desai d4b4e95bea Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I33a1ec0e54a662878f981bd599abb3f1d5c6f105
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-06-30 23:05:06 +00:00
Holly Sun 1a9a98005d [a11y] Fix crash when using talkback to add to home screen. 
1. Fix a crash from http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1928;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d. It can also be `ITEM_TYPE_SEARCH_ACTION`. Remove the `itemType` check and just use the `PendingAddItemInfo` class type.
2. Override `startConfigActivity` in `PinShortcutRequestActivityInfo`, so that `Launcher#onActivityResult` can be triggered properly from `Launcher#processShortcutFromDrop` (http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1939;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d )
3. Then we call to `Launcher#completeAdd` -> `completeAddShortcut`. The original `info` passed to `processShortcutFromDrop` doesn’t have a `componentName` (new code), so remove the component non-null check from `completeAddShortcut`.

Bug: 287166186
Bug: 287167527
Bug: 287166771
Test: manual
Flag: N/A
Change-Id: Id3e1444de188f2d2af760f58e3d9814a2b7abd88
Merged-In: Id3e1444de188f2d2af760f58e3d9814a2b7abd88
(cherry picked from commit 35b9960b63)
 2023-06-30 20:49:33 +00:00
Brandon Dayauon 8469cfab71 Merge "Fix custom buttons with translated string" into udc-d1-dev am: 206821cee6 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23849389

Change-Id: Ic819b40f9bd901de4823d36c2693b2bf96436581
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-06-29 22:56:08 +00:00
Brandon Dayauon dba7359d23 Fix custom buttons with translated string 
The reason why the buttons aren't being updated with the translated string is because the cache the views get the string from is not updated/loaded with the new language.
Rather, the update happens after the view has been inflated. With this change, when the string cache updates in bindStringCache(), we update the UI right then.

bug: 280958663
bug: 288442609
test: Manual
Change-Id: I7a49ee401d5a5f3268cfaef1abee8153e913a8ce
(cherry picked from commit 076dcdfd54)
 2023-06-28 21:49:25 +00:00
Jagrut Desai 53d953ccd2 Taskbar All Apps Shortcut Menu Acccessibility Focus 
Bug: 280657266
Test: manual
Flag: not needed
Change-Id: I2426636067ce3635b8b24b9f5d093dad7d9ddf4c
 2023-06-28 14:48:54 -07:00
Anvesh Renikindi d15a76629b Merge "Update renamed util function M3HCTToColor in launcher code" into udc-dev-plus-aosp am: d8af5abcfd 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23813693

Change-Id: I53dd898d0443dc1c596bec5ac475d73c28abced2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-06-27 15:52:57 +00:00
fbaron ed79206e4b Update renamed util function M3HCTToColor in launcher code 
Bug: 288120001
Test: none
Change-Id: If4c6783472d7fa05a1162e2f176a613d28f7bec3
Merged-In: If4c6783472d7fa05a1162e2f176a613d28f7bec3
(cherry picked from commit 911be164b3)
 2023-06-26 20:17:17 +00:00
Holly Sun c3127d29b2 [a11y] Add FLAG_NOT_PINNABLE and modify supportAddToWorkSpace. 
// play uninstalled app
Bug: 286998395
Bug: 287156208
Bug: 287157282
// contact
Bug: 287362865
Bug: 287370843
Bug: 287372663
// clock
Bug: 287166186
Bug: 287166771
Bug: 287167527
Test: manual
Flag: N/A

Change-Id: I859deba6218e232a232f009793044ca4be2cab19
 2023-06-26 16:52:53 +00:00
Winson Chung f2433f39eb Merge "Reset the static preloaded icon result once launcher is hidden" into udc-dev am: 7cd608594b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23697218

Change-Id: Ia9dc508fb9d9225e01d7bf627032a384e2d9324b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-06-15 04:19:57 +00:00
Winson Chung 7c500166b2 Reset the static preloaded icon result once launcher is hidden 
- In the case where the system does not play the requested animation
  we can still ensure that this doesn't result in a leak of the
  activity by resetting the result when launcher is hidden (which
  happens after the launch transition)

Bug: 285995223
Test: Presubmit
Test: Take heapdump after repro steps in b/285995223#comment6 and verify
      there are no lingering static icon load results

Change-Id: I1d169df158cfaab64fbe1f4ce597d8f73d86a1c1
 2023-06-14 19:39:58 +00:00
Holly Sun cd5d9a70b2 [Play] Enable play flag by default on client side for udc-d1-dev. 
Bug: 275082654
Test: N/A
Flag: ENABLE_SEARCH_UNINSTALLED_APPS
Change-Id: I22032f99dd0f3b84e34eb3ee5394901d10a4f9f4
 2023-06-13 22:55:48 +00:00
Anushree Ganjam ab58a0a005 Remove SEARCH_ONBOARDING_COUNT & QSB_SEARCH_ONBOARDING_CARD_DISMISSED. 
Launcher Search related educards is being sent from AiAi now and we
don't need to hold the count in launcher.

Flag: NA
Bug: 265476821
Test: Manual

Change-Id: I5374e7cab6551d44fc995adb3b3a46173169ab6c
Merged-In: I5374e7cab6551d44fc995adb3b3a46173169ab6c
 2023-06-09 13:51:42 +00:00
Jon Miranda 10b3e64d51 Merge "Update taskbar paddings/sizes to match spec." into udc-dev 2023-06-08 23:55:06 +00:00
Fengjiang Li 5d81dd2d77 Merge "Fix NPE where CellLayout is null when removing item out of folder" into udc-dev 2023-06-08 19:33:52 +00:00
Fengjiang Li d29db8ea4d Fix NPE where CellLayout is null when removing item out of folder 
Fix: 282249989
Test: create a folder of 2 app icons, remove one icon out of folder, no crash
Change-Id: I3c132ec8833c7cb14066cc403c0641d089bab8ab
 2023-06-07 15:36:54 -07:00
Treehugger Robot ffdcac46b6 Merge "Log UserManager users and cached users each time users accessed" into udc-dev 2023-06-07 22:08:03 +00:00
Vinit Nayak 9377e56f47 Log UserManager users and cached users each time users accessed 
Bug: 243688989
Change-Id: Ifa6eec39f9fc90a4871ac2ff010588c3a5cac531
 2023-06-07 11:32:01 -07:00