When swiping up to recents and creating the current tasks TaskView, we
were checking for proto 1 or proto 2 to be enabled. And if they were, we
were creating the DesktopTaskView object. The DesktopTaskView should
only be enabled in proto 2.
Updated the feature flag check.
Bug: 273950066
Test: enable proto 1 and gesture nav, have a desktop app open, swipe up
to recents, no desktop tile
Test: enable proto 2 and gesture nav, have a desktop app open, swipe up
to recents, see the desktop tile
Change-Id: I73a47347d60e0f57ad6cf6e363a6fe83ac8cc509
When desktop tasks become visible or hidden, we update a SysUI state
flag. This flag update gets processed in TouchInteractionService which
then calls DesktopVisibilityController to update launcher state based on
whether desktop tasks are visible or not.
We were getting a reference to the DesktopVisibilityController through
OverviewComponentObserver. This was causing issues when device was
unlocked with desktop tasks visible. And 3-button navigation was enabled.
In this scenario, we are immediately processing a SysUI flags update
that desktop tasks are visible again (they are hidden while device is
locked). When this update is processed, OverviewComponentObserver
returns the fallback launcher interface. And not the nexus launcher.
The fallback launcher interface does not contain the
DesktopVisibilityController. Since the fallback controller does not
return the visiblity controller, we skipped processing the update that
desktop tasks are visible. Which resulted in launcher remaining in a bad
state with home screen icons visible and desktop tasks on top.
Bug: 273594452
Test: enable 3-button nav and proto 2, move an app to desktop, lock
screen with desktop app visible, unlock screen, observe launcher icons
hidden
Test: enable gesture nav and proto 2, move and app to desktop and lock
screen with desktop app visible, unlock and observe launcher icons
hidden
Test: repeat the same steps with proto 1 enabled
Change-Id: Id52ac4cf2df151b2aee2070ee2eb14de3d74fead
When launcher rotates during the fold/unfold animation
we clear views registered for the animation but we don't
restore the original clipping options that might be set.
This causes lost of the original property values
as the map that stores original values will store
updated values (after the animation preparation).
Bug: 273554726
Test: manual
Change-Id: I9c44a7ce4867ba0c3d6d1dca728d7c4cd3b378db
This reverts commit 313a44039f.
Merging will reenable the TAPL suite TaplTestsSplitscreen.java, which was failing on phones due to a function call that only works on tablets.
Fixed by conditionally running the function only on tablet devices.
Fixes: 271852893
Test: Ran tests locally on phone and tablet.
Change-Id: If3e692924ed9c5ee113872e4f8ff0652890d1280
* This information comes up often enough in test failures, good
to have at the outset to rule out obvious issues.
Bug: 270214626
Change-Id: Iee70fffed7a742565f41d8bf5aa38cdabefca3b4
This patch fixes two issues that would arise when the user initiated split from Taskbar:
1) The Overview Actions View would animate out, then erroneously pop back in.
2) When initiating split from home repeatedly, the task thumbnail grid would not animate downward properly, instead staying in the wrong y-position.
Both issues were caused by the fact that we now have a new way to enter OverviewSplitSelect (directly from Taskbar/Home), which rendered some of our old assumptions incorrect. Namely:
1) When we finish transitioning to OverviewSplitSelect, we need to update OverviewActionsView visibility so that it stays hidden.
2) mSplitHiddenTaskView is no longer a good way to tell if we are in split select state or not.
Fixed by adding a new call to updateCurrentTaskActionsVisibility() to the end of the split staging animation, and by making sure translations get reset every time resetFromSplitSelect() is called.
Fixes: 271624078
Fixes: 261544937
Test: Manual, verified on large and small tablet screens with various types of split invocations and rotation combinations.
Change-Id: Ied0f4818ce6da599845ccd07e9dc96ef4ba030c3
Continue to use height to compute scale for two panel home.
Fix: 272735870
Test: manual. Swipe from home to overview.
Change-Id: If7da8c504c389eab3ca337a69eb60dfe28467ed2
Otherwise we position the taskbar in the center.
Bug: 259712417
Fixes: 267997547
Test: transient taskbar unaffected
persistent taskbar
- test on small tablet
- test on large tablet
- test LTR and RTL
Change-Id: Ieb0a304d9963ebf583bc4ef2deaab747019e8d6d
Ats Jenk
Pat Manning
Jeremy Sim
Vinit Nayak
Nick Chameyev
Jon Miranda
Brian Isganitis
Tony Wickham
Thales Lima
Hongwei Wang
Sihua Ma
Jagrut Desai