Commit Graph

1390 Commits

Author SHA1 Message Date
Schneider Victor-Tulias e4c3faa138 Update AbstractQuickStepTest to check non-recents states correctly
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/post submit
Change-Id: I7a4381bbc8214beea2e354df2851f0ba1aaddd5c
2025-05-12 10:28:53 -04:00
Schneider Victor-Tulias 82050b85fa Fix FallbackRecentsTest with recents in window enabled
- Added a workaround to listen to onNewIntent without RecentsActivity in TouchInteractionService, allowing us to clean up the recents window appropriately
- Updated LauncherInstrumentation.executeAndWaitForLauncherStop to expect a state change instead of activity stop in 3P + recents window

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I3756e268626d778a13be1f2c68f9d3157602534e
2025-05-12 10:27:41 -04:00
Treehugger Robot dadf9f45a3 Merge "Delete Ignored test" into main 2025-05-07 08:36:45 -07:00
Sam Cackett c81daa36ae Delete Ignored test
testOverviewForTablet was ignored for over a year and other tests cover
most of the test cases of the original test so removing

Add separate tests for grid re-balancing

Fix: 315376057
Flag: EXEMPT. Test
Test: TaplTestsQuickstep
Change-Id: I33016ccdb68b1c2039c626a6d32821de71509506
2025-05-07 11:33:21 +01:00
Sunny Goyal 53cc9a7806 Merge "Moving predicted items to ItemIdMap instead of extraItems" into main 2025-05-06 10:29:39 -07:00
Pat Manning 7c7167e2f2 Add screen recording to failing testOverview test.
Bug: 415773066
Test: TaplTestsQuickstep#testOverview
Flag: EXEMPT bugfix.
Change-Id: Ifb0bcd7fe3fa34bd4da911f0d943bf96db062828
2025-05-06 15:46:21 +01:00
Sunny Goyal aef6c7932e Moving predicted items to ItemIdMap instead of extraItems
> This allows the whole workspace model to be contained in itemIdMap instead of spread across multiple data containers
> Deprecating extraItems, all non-workspace data should use separate repositories
> Design: http://go/launchermodel-re-arch?#heading=h.5y8n4r164d5s

Bug: 390572144
Test: atest PredictionUpdateTaskTest
Flag: EXEMPT refactor
Change-Id: I886d0a8d5bbbf9f5c2054d4a2442bf03f9c4eab5
2025-05-05 15:52:37 -07:00
Sebastián Franco 24a321d835 Merge "Creating NexusLauncherE2ETests test suite, this cl only adds the Launcher3 part" into main 2025-05-05 14:30:04 -07:00
Sebastian Franco fc8537d5de Creating NexusLauncherE2ETests test suite, this cl only adds the Launcher3 part
The test don't run yet in presubmit, first I will have the NexusLauncherE2ETests
target ready and then I will add it to the presubmit.

Bug: 324261526
Flag: EXEMPT test only
Test: atest NexusLauncherE2ETests
Change-Id: I4daa204ec735456c481b0682ca518da381af7bb7
2025-05-05 18:53:08 +00:00
Liran Binyamin 00dc879e2c Merge "Send bubble bar distance to shell" into main 2025-05-02 14:35:40 -07:00
Sunny Goyal 46b13eb184 Moving WorkspaceItemFactory to dagger as PredictedItemFactory so that it can be reused
Bug: 390572144
Flag: EXEMPTY refactor
Test: Presubmit
Change-Id: I41c5fea73452d7f4c1fd9980a89bcb7199eb19d7
2025-05-02 08:55:21 -07:00
Liran Binyamin 34024fe26a Send bubble bar distance to shell
We previously sent the top coordinate of the bubble bar to shell.
However when the screen height changes, launcher takes a bit longer
to update than shell. So instead of calculating the top coordinate
on the launcher side, we now send the amount of space between the
bubble bar and the bottom of the screen to shell, where we can offset
that as needed.

Bug: 392893178
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual
       - send some bubbles
       - launch app
       - expand
       - swipe to home
       - fold and unfold
Change-Id: I57b96db49dab1e2304fde8dc55a99eaaf85e40f8
2025-05-02 10:54:39 -04:00
Schneider Victor-tulias 9b468c5b24 Merge changes Id95b36da,I6a2225be into main
* changes:
  Fix recents window activity leak
  Update TAPL tests to dismiss all tasks safely
2025-05-02 07:38:30 -07:00
Vadim Tryshev bc6b9ea148 Merge "Failures caught by launcher.checkForAnomaly did not produce screenshots." into main 2025-05-01 16:29:38 -07:00
Vadim Tryshev 9b0d61a803 Failures caught by launcher.checkForAnomaly did not produce screenshots.
Fix to handle failures caught by launcher.checkForAnomaly so that they
are also reported to the test watcher.

Bug: 406906811
Test: presubmit
Flag: NONE Not production code
Change-Id: I379fcf09e3cd2e6321be9f4bc3dd6f3272e9c2fd
2025-05-01 13:29:18 -07:00
Schneider Victor-Tulias a56aa0d539 Update TAPL tests to dismiss all tasks safely
Flag: EXEMPT test refactor
Bug: 377678992
Test: pre/post-submit tests
Change-Id: I6a2225bea4f004bdc598e2c67ce26da9fd42f7a6
2025-05-01 16:04:32 -04:00
Schneider Victor-Tulias 42d6c08d41 Move ExtendedLongPressTimeoutRule implementation to shared sysui test library
Flag: EXEMPT test fix
Fixes: 396862825
Test: TaskbarExpandCollapse
Change-Id: I950ed4ede8db150234d843422982792f5b6bfd8e
2025-05-01 11:38:27 -07:00
Mykola Podolian 5259038c6f Merge "Launcher TAPL test for dragging task bar icon to the bubble bar." into main 2025-04-30 09:29:47 -07:00
mpodolian 9764250b60 Launcher TAPL test for dragging task bar icon to the bubble bar.
Added a test and TAPL objects to check dragging taskbar icons to the
bubble bar.

Fixes: 388910897
Test: TaplTestTaskBarIconDrag
Flag: EXEMPT test
Change-Id: I8a3e64a83c72a9f6b89b2f8a875ca6565d501701
2025-04-29 15:32:41 -07:00
Schneider Victor-Tulias b8440b75ef Update AbstractLauncherUiTest to use recents window when possible
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: Id3ddc11aa9163df3f2914edba66e1db36fdde63b
2025-04-29 14:13:26 -07:00
Min Chen 31f5e79ffd Merge "Fix integration tests with multi-desks on" into main 2025-04-28 16:44:30 -07:00
Pat Manning 9fd78aa76d Merge "Drag tasks from center when perfoming dismiss cancel for tests." into main 2025-04-28 04:08:39 -07:00
minch 4e3d48e998 Fix integration tests with multi-desks on
Bug: 362720309
Test: Presubmit
Flag: EXEMPT tests failure fix
Change-Id: I381b8751083a7fb235cf597fd35314ca6f2c0a9b
2025-04-26 15:59:18 +00:00
Pat Manning 8eeaa6009c Drag tasks from center when perfoming dismiss cancel for tests.
Follow up to Change-Id: I14f3012973ddee0d850db5de284a0efde6122d2c

Fix: 412766455
Test: TaplTestsQuickstep#dismissCancel
Flag: EXEMPT bugfix.
Change-Id: Idcf17fe810a935c325d043519d2b8d216b3f5c13
2025-04-25 16:12:32 +01:00
Treehugger Robot 4b74cfa36d Merge "Fix tapl tests with multi-desks on" into main 2025-04-24 15:15:16 -07:00
minch 94d8fc6206 Fix tapl tests with multi-desks on
Bug: 362720309
Test: TaplTestsKeyboardQuickSwitch, TaplTestsQuickstep.testOverview
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: Ia670eb0f0ccf0ecbe08051f0fc1cd0a39b0089e2
2025-04-24 16:44:30 +00:00
Will Osborn 05e4134b73 Merge "Pass display id to startRecentsAnimation" into main 2025-04-23 02:23:40 -07:00
Will Osborn 50a1b9089c Pass display id to startRecentsAnimation
Test: local + unit
Bug: 392703464
Flag: com.android.launcher3.enable_overview_on_connected_displays
Change-Id: I7eb65a1d6b98703a19432b9fa24c3c4b262aa045
2025-04-22 17:46:01 +00:00
Treehugger Robot 8184e7116d Merge "Fix broken TaplStartLauncherViaGestureTests close activity flow" into main 2025-04-22 08:50:08 -07:00
Treehugger Robot fede3aee46 Merge "Don't blur workspace targets when dragging out of All Apps." into main 2025-04-18 16:28:27 -07:00
mpodolian 04bd5b49ea Stash the taskbar on every bubble bar expansion
Added logic to enable BubbleBarView to  notify BubbleBarViewController
of expanded state change. Also updated all the test that uses
BubbleBarView to pass empty Controller.

Fixes: 411304392
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Go to any app. Swipe up to show the taskbar. Trigger any
bubble. Observe taskbar is stashed on bubble bar expanded.

Change-Id: I88ad167eb0ed444629716df3672bbb06ca8adcc4
2025-04-18 11:16:40 -07:00
Andy Wickham c626620f74 Don't blur workspace targets when dragging out of All Apps.
Sorry for the whack-a-mole here. The intention is to only blur
going to All Apps or returning from All Apps to Normal. Added some
tests to help prevent regressions.

Test: DepthControllerTest#test_blurWorkspaceDepthTargets
Flag: com.android.launcher3.all_apps_blur
Bug: NA (noticed locally from a recent cl)
Change-Id: Ib0285dae42c41ba9eb2e747b272d40c228e0b035
2025-04-17 21:00:21 +00:00
Schneider Victor-Tulias a6951ba731 Fix broken TaplStartLauncherViaGestureTests close activity flow
When trying to destroy the launcher activity in TaplStartLauncherViaGestureTests test cases, we weren't cleaning up the recents window properly. This was also causing following tests to fail since they didn't expect the recents window to already be open.

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: Ibf568fd1e9abf946c3d3be933b575aa4501828de
2025-04-17 15:42:59 -04:00
Sebastián Franco 95aa4a3267 Merge "Revert "No-op change, remove methods from BaseLauncherActivityTe..."" into main 2025-04-16 09:58:09 -07:00
Treehugger Robot ef95172183 Merge "Fix broken -1 -> home transition with overview in window enabled" into main 2025-04-15 16:29:43 -07:00
Sebastián Franco a746ec8aa4 Revert "No-op change, remove methods from BaseLauncherActivityTe..."
Revert submission 32999330-activity-test-refactor-1

Reason for revert: b/410713970

Reverted changes: /q/submissionid:32999330-activity-test-refactor-1

Change-Id: Id9dd4692bc5c500fd8831a2edad80a034c4fa405
2025-04-15 15:55:35 -07:00
Treehugger Robot 0aa937de1a Merge "Enforce a mutex in all remote tapl tests" into main 2025-04-15 14:52:13 -07:00
Schneider Victor-Tulias d079748134 Enforce a mutex in all remote tapl tests
Flag: EXEMPT test fix
Fixes: 405849365
Test: TAPL tests; pre/postsubmit
Change-Id: Icf5b3c6b43b4d8ecc39246f3eb03e32738af7444
2025-04-15 15:05:26 -04:00
Treehugger Robot ba07ec67ab Merge "Dispose input monitor on the main thread in InputConsumerUtilsTest" into main 2025-04-15 10:19:06 -07:00
Schneider Victor-Tulias 3731a852bf Fix broken -1 -> home transition with overview in window enabled
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Fixes: 402147664
Test: pre/post-submit tests; attempted home gesture from -1 with flag on and off; attempted gestures from home after: 1P launcher -> -1 -> settings -> switch to 3P launcher
Change-Id: Ibd945e0c861e0fa59c16738da476be3c16454382
2025-04-15 10:15:31 -07:00
Schneider Victor-Tulias bfe39bdf36 Dispose input monitor on the main thread in InputConsumerUtilsTest
Flag: EXEMPT test fix
Fixes: 410599758
Test: InputConsumerUtilsTest
Change-Id: I2016d4711d5913e4e9baad1c394bcd1fb2f043ea
2025-04-15 10:37:27 -04:00
Sebastián Franco 526d80a550 Merge "No-op change, remove methods from BaseLauncherActivityTest into Utilities" into main 2025-04-14 16:21:19 -07:00
Sebastian Franco c08c7de5e3 No-op change, remove methods from BaseLauncherActivityTest into Utilities
Bug: 324261526
Test: all test that inherit BaseLauncherActivityTest
Flag: TEST_ONLY
Change-Id: I0851373d179f064721a3a618853a05796cc1379f
2025-04-14 13:38:20 -07:00
Shamali P 8fa26ebe5b Map timer info to ui state in TaskViewModel
Bug: 405359562
Flag: com.android.launcher3.enable_refactor_digital_wellbeing_toast
Test: Unit tests
Change-Id: I080e9c94a41c747210fa9621f913e43b9f584c29
2025-04-14 12:50:14 +00:00
samcackett 2244b633cc Add TaskContentView wrapper to TaskThumbnailView
- Keep TaskThumbnailViewDeprecated as-is
- Due to flag guarding and xml changes, added bottomright_snapshot id
- Remove redundant FrameLayout from task_header_view.xml and refactor
the view to handle alignment correctly
- Move feature flag logic to the state mapper
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
 similarly

This reverts commit df6dc455a7.
This reverts commit 714370a9bfb2e53738b0cd9958acd6540d8d649c.

Reason for revert: Reland previously reverted CL's with fixes

Fix: 408971730
Fix: 397889146
Fix: 401469907
Fix: 402277471
Fix: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest & TaskThumbnailViewScreenshotTest & TaskHeaderViewScreenshotTest & SwitchBetweenSplitPairsGesturalNavPortrait
Change-Id: I01758447ad1194ebbeab748113621b42f3384db8
2025-04-09 16:36:51 +01:00
Sebastián Franco 59ae5808c7 Merge "Use LauncherActivityScenarioRule in BaseLauncherActivityTest" into main 2025-04-08 15:28:11 -07:00
minch 42efd0c6cc Let TaskView.bind take GroupTask instead of Task
1. Introduce a `groupTask` property to `TaskView` and let all the
   `bind` functions take a type of `GroupTask` as the parameter
   instead of a `Task`.
2. Then let `RecentsView.removeGroupTaskInternal` take the
   `GroupTask` as the parameter instead of a `TaskView`.
3. Caches the `groupTask` before `removeGroupTaskInternal` then
   we can avoid the corresponding `deskId` being set to invalid
   on `removeViewInLayout` in the main thread, which might happen
   before `removeGroupTaskInternal`.

Bug: 408032417
Test: m
Flag: EXEMPT refactor
Change-Id: I51c5b810eb63bc1267b90b915f90164f7ca3cba5
2025-04-08 17:16:08 +00:00
Alex Chau 7dce980f9a Merge "Refactor RotationTouchHelper to be per-display" into main 2025-04-07 04:27:26 -07:00
Eghosa Ewansiha-Vlachavas 6665030709 Merge "[2/n] Isolate desktop entry point disabling from window exemptions" into main 2025-04-04 15:45:16 -07:00
Will Osborn d515f1a3ed Refactor RotationTouchHelper to be per-display
Bug: 398195845
Test: locally tested + ran unit tests
Flag: EXEMPT refactor
Change-Id: I2a5ae4171fd211650624291574f84f8bff8b8825
2025-04-04 12:59:34 +00:00