Commit Graph

1055 Commits

Author SHA1 Message Date
Sunny Goyal 5daac6fbfb Merge "Removing some unnecessary interfaces and merging them to ActivityContext" into tm-qpr-dev am: d31c8baef1 am: deffe8f8df
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20676568

Change-Id: I97e64fbb701249aef7268421943f0e174a59c3bf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 16:14:28 +00:00
Sunny Goyal 54fa110bba Removing some unnecessary interfaces and merging them to ActivityContext
Bug: 259733681
Test: Everything compiles
Change-Id: If6b530f6e589a851cf8554f5de0849843bd66dd4
2022-12-08 10:15:55 -08:00
Sebastián Franco bdee8e4313 Merge "Ignore all launcher3 flaky test so that they come back online" into tm-qpr-dev am: 878ae3fc85 am: 64d68ce0c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20647519

Change-Id: I255b21e3e06e93c90f7b718d265d166abc4b4e72
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 20:50:40 +00:00
Sebastian Franco 150e572e05 Ignore all launcher3 flaky test so that they come back online
Test dashboard: https://android-build.googleplex.com/builds/tests/search?filter=mediumFailureRate&filter=highFailureRate&query=config%3Av2%2Fgnl-eng%2Funbundled%2Flauncher%2Flauncher3_test_platform+latest%3A4d&tab=tests

Test: dashboard should not show flaky tests
Bug: 256832045
Change-Id: I06e879dec2703455b7be728c7afd3500d2edd54a
2022-12-06 17:08:45 -08:00
Sebastián Franco 8a1b517ad5 Merge "Creating a new alarm when drag X,Y change" into tm-qpr-dev am: 9adbab96b7 am: a3ac407d85
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20646376

Change-Id: I47537d6d811b1b3e4d723e2c7cc7efb387361e14
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-06 20:31:24 +00:00
Sebastian Franco 5356ff955c Creating a new alarm when drag X,Y change
If the user is changing the X and Y of the reorder, wich requires
the user to move at least one Workspace cell from the previous
position, then it doesn't make sense to wait for the previous alarm to finish
to start a new reorder.

Also, I added a new test to run on foldable devices.

Fix: 259995663
Fix: 259295374
Test: atest ReorderWidgets (it mostly fails on postsubmit)
Test: modify ReorderWidgets.fullReorder to run 20 times and it should work, before the chagne it would fail.
Change-Id: Ic6b436ea1088f8092c849e9791862947e9035c9f
2022-12-05 16:37:45 -08:00
TreeHugger Robot 1d4c44ce07 Merge "Make grid size migration less confusing for users." into tm-qpr-dev am: 33c348f573 am: a44e9370f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20388826

Change-Id: I5df1ed1b272876e6ce64b19cd42410b840c10688
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-05 19:22:22 +00:00
TreeHugger Robot 33c348f573 Merge "Make grid size migration less confusing for users." into tm-qpr-dev 2022-12-05 18:19:59 +00:00
Pinyao Ting cc90d1b767 Make grid size migration less confusing for users.
Grid size migration is a confusing experience for users because the
content of the grid is not predicatable to the user. Part of the reason
was the dedupe logic which merges items from new grid into old grid,
this mean if user removes an item, change to another grid and go back,
user will see that same item re-appears.

This CL keeps the content of target grid the same as source gird, i.e
user will will get the exact same set of app icons/shortcuts/folders and
widgets (if size permits) across grid sizes. The only difference being
their placement in the grid.

Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: I1732c91e441ad44bc43e0a943566a83563d12b07
2022-12-02 13:33:04 -08:00
Sebastián Franco 36e03bdf47 Merge "Ignore test while the solution for the flaky tests improve." into tm-qpr-dev am: f9d418b9f2 am: fb725e8223
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20621715

Change-Id: I5996eb29348d4992a3eacb4eb06fb0b700403304
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 20:45:40 +00:00
Sebastián Franco f9d418b9f2 Merge "Ignore test while the solution for the flaky tests improve." into tm-qpr-dev 2022-12-02 19:34:11 +00:00
Sebastian Franco ac53846195 Ignore test while the solution for the flaky tests improve.
Bug: 261178121
Test: atest ReorderWidgets
Change-Id: Id0c6594e00486695c63e2cda53b1a5ee39478a1f
2022-12-02 11:33:00 -08:00
TreeHugger Robot 69c1eb4a28 Merge "Adding screenrecord to debug themeIconTest" into tm-qpr-dev am: ed882317da am: 897a8d8e71
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20590312

Change-Id: I8ea6ff7c9a30d96a46757adcf56774e41150ff5c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-30 08:54:06 +00:00
Sunny Goyal d25f79c48f Adding screenrecord to debug themeIconTest
Bug: 260722220
Test: Updated
Change-Id: I20e590436e318f9a8914a8201d95584ab26de388
2022-11-29 09:31:13 -08:00
TreeHugger Robot 8e6fcd867f Merge "Fixing shortcuts not getting theme icons" into tm-qpr-dev am: 1330244f0a am: d813bddf99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20546011

Change-Id: I72835e139741384fe31bad16920c46dcabe9ee99
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-29 01:44:06 +00:00
Sunny Goyal ce4896cff5 Fixing shortcuts not getting theme icons
Bug: 238650110
Test: Updated ThemeIconsTest
Change-Id: I803cd6eefa4e393bf19901a44712622adac7f4b1
2022-11-28 09:48:50 -08:00
Pinyao Ting 55621f4001 Merge "Refactor GridSizeMigrationTaskV2" into tm-qpr-dev am: ad932045ac am: ff521c99ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20535959

Change-Id: Ic7a3f0ac4db6facf7ce17208133bf6b85dc25644
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-22 17:52:26 +00:00
Pinyao Ting ad932045ac Merge "Refactor GridSizeMigrationTaskV2" into tm-qpr-dev 2022-11-22 17:22:39 +00:00
Pinyao Ting dec4305d0c Refactor GridSizeMigrationTaskV2
The majority of the logic in grid size migration should be implemented
as static functions in the first place since (1) they only runs once
after instantiation and (2) they are executed immediately after they are
instantiated.

This CL removes most of the instance variables from grid size migration
in favor of static methods since the later is more efficient, more
testable and therefore considered better programming practice in
general.

Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: Ief4654d79ad5cfd636e6145fdcc9dfe5a39cdf62
2022-11-21 15:24:38 -08:00
TreeHugger Robot 7b022b93f8 Merge "Increase icon size to be closer to spec" into tm-qpr-dev am: 81a994e9a7 am: 1414f12c14
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20500530

Change-Id: Ic92db57de677e39bb299f7d175b9ed191992d7d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-21 19:26:39 +00:00
TreeHugger Robot 81a994e9a7 Merge "Increase icon size to be closer to spec" into tm-qpr-dev 2022-11-21 18:35:31 +00:00
Thales Lima ae0d7ef782 Increase icon size to be closer to spec
Also change paddings because spaces changed

Bug: 258463609
Test: DeviceProfileDumpTest
Change-Id: Iaee433ea3fb5ef633ad428699ce230317021b170
2022-11-18 12:38:14 +00:00
TreeHugger Robot a306c7a226 Merge "Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results." into tm-qpr-dev am: c5b5044aff am: 4f366af03e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20240749

Change-Id: I6ca3d72be87eadb858ec185b0bf413316bcfb9bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 02:02:32 +00:00
TreeHugger Robot c5b5044aff Merge "Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results." into tm-qpr-dev 2022-11-18 01:09:23 +00:00
Sihua Ma 460b85f101 Merge changes If022ec8d,I34341937 into tm-qpr-dev am: c6bd4ad21f am: 1d678ad179
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20418246

Change-Id: Ib5183feebded858d4ebce4693d47d62151bb2899
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 02:13:21 +00:00
Sihua Ma c6bd4ad21f Merge changes If022ec8d,I34341937 into tm-qpr-dev
* changes:
  Move LauncherWidgetHolder to widget package
  Move most of the functions in LauncherAppWidgetHost to LauncherWidgetHolder
2022-11-17 01:46:55 +00:00
Sihua Ma 8bbfcb6581 Move LauncherWidgetHolder to widget package
Making LauncherAppWidgetHost package-private as well

Bug: 235358918
Test: N/A
Change-Id: If022ec8d429579a972991872b2dc11db76719341
2022-11-16 14:31:14 -08:00
Sihua Ma aa2b872d1c Move most of the functions in LauncherAppWidgetHost to LauncherWidgetHolder
Test: N/A
Bug: 235358918
Change-Id: I343419376491203a195154f2766b12e5def38879
2022-11-16 14:30:08 -08:00
Holly Sun 0d69c8dde9 Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results.
Also add simple prefix matching method.

Bug: 255355348
Test: manual
Change-Id: I35f2089924d774f3bcc1c05638a5d6b45ed7443f
2022-11-15 16:55:29 -08:00
TreeHugger Robot 8a03be1880 Merge "Added Tests for Secondary Display Launcher" into tm-qpr-dev 2022-11-15 22:41:51 +00:00
Alex Chau 8aa9f9f25b Merge "Improve spaces for folders" into tm-qpr-dev am: 1feadf7d81 am: 60ae676568
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19866978

Change-Id: I4f196ef56f8ffaa70760464ac567fc8c7784e883
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-08 17:58:32 +00:00
Alex Chau 1feadf7d81 Merge "Improve spaces for folders" into tm-qpr-dev 2022-11-08 16:51:50 +00:00
Thales Lima b35faed6e7 Improve spaces for folders
Bug: 214582832
Test: DeviceProfileTest
Change-Id: I7c5cae0792d51baf111d0aec46be302ac6ca9994
2022-11-07 18:23:48 +00:00
TreeHugger Robot 5c7e880c9d Merge "Waiting for the apps-unfreeze flags instead of enforcing it" into tm-qpr-dev am: 5602b9e0ad am: 2f632f09e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20391177

Change-Id: I3bca43b9e8f1aa3190d9385dd67abe3f520e2e94
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-05 07:01:04 +00:00
Sunny Goyal 679ec33cc7 Waiting for the apps-unfreeze flags instead of enforcing it
Bug: 256898879
Test: Will wait for presubmit flakyness to clear
Change-Id: Ie2341338bbebfd892998e078d07d31f003ab8d43
2022-11-04 14:41:14 -07:00
TreeHugger Robot 66f4641846 Merge "Add unaudited exported flag to exposed runtime receivers" 2022-11-04 13:03:45 +00:00
TreeHugger Robot ee9102248b Merge "Waiting for app install to finish before procedding with the test" into tm-qpr-dev am: 12aec8aa29 am: cff01986b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20378370

Change-Id: Ic71d0eba16d284ca68baf6d90598760f6c852993
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-04 03:28:32 +00:00
TreeHugger Robot 12aec8aa29 Merge "Waiting for app install to finish before procedding with the test" into tm-qpr-dev 2022-11-04 02:04:10 +00:00
Sunny Goyal 50097ef272 Waiting for app install to finish before procedding with the test
Bug: 256659409
Test: Presubmit
Change-Id: Ia0f4cdd072c4c439d09070b0395fcfd6909c2a8f
2022-11-03 13:33:41 -07:00
Sebastián Franco ce6e5a3cb5 Merge "Wait in ReorderWidgets test for the workapce to load after changing it." into tm-qpr-dev am: 58502d0236 am: ac44f52134
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20305929

Change-Id: I6db34d93dee53196e086e042644e9819713ed55d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 20:16:20 +00:00
Sebastián Franco 58502d0236 Merge "Wait in ReorderWidgets test for the workapce to load after changing it." into tm-qpr-dev 2022-11-03 18:55:50 +00:00
TreeHugger Robot 6c9814a92b Merge "Add delay after installing dummy app" into tm-qpr-dev am: 9e1f6002e5 am: e0e2b02ad2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20363621

Change-Id: I87647e4585d9eec544e1436c37b4ddde8d869ee7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 18:43:28 +00:00
TreeHugger Robot 9e1f6002e5 Merge "Add delay after installing dummy app" into tm-qpr-dev 2022-11-03 17:17:09 +00:00
Winson Chung 38779f75da Add delay after installing dummy app
- Testing hypothesis that it's taking a while for the app to be
  properly installed and showing in all apps

Bug: 256659409
Test: com.android.launcher3.ui.TaplTestsLauncher3#testUninstallFromAllApps
Change-Id: Icb1bb8bb9d98751ac8c97b300ecc39372f39c345
2022-11-03 03:47:01 +00:00
Sunny Goyal a084dbd3bd Merge "Fixing background jump when closing a widget" into tm-qpr-dev am: 031ee4cbcb am: 6988b7b308
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20304438

Change-Id: I578ef759545b5bebcf314a2022f99e428bb7ee1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 02:02:24 +00:00
Sunny Goyal 39b07fd66c Fixing background jump when closing a widget
We do not add background animation when opening target is translucent
Added additional check to not animate background if launcher is not
closing (which is already a subset of all-targets-translucent)

Also removing reverse background animation from widgets, similar
to app-icons as it is never added for launcherNotClosing path

Bug: 242379946
Test: Added translucent activtiy and widget and verified manually
      that the behavior does not change
Change-Id: Icda8007c0063295bf8431c00a0f0b665ecdef109
2022-11-02 19:17:18 +00:00
David Saff 31aabd93ee Merge "Mark broken tests that are blocking presubmit" 2022-11-01 13:37:21 +00:00
Sunny Goyal 7550a67d90 Merge "Adding screenrecord for debug failing test" into tm-qpr-dev am: c93eb630e6 am: 4f5d276233
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20330482

Change-Id: I039c65677505a6e77b6d2b2e87ef0f21afad30f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 00:57:57 +00:00
Sunny Goyal c93eb630e6 Merge "Adding screenrecord for debug failing test" into tm-qpr-dev 2022-10-31 23:53:43 +00:00
Sunny Goyal d6e9c601d8 Adding screenrecord for debug failing test
Bug: 256659409
Test: n/a
Change-Id: I1d804a92f81069df8d86f5b4ee2f21179f390d98
2022-10-31 13:25:17 -07:00