Commit Graph

49925 Commits

Author SHA1 Message Date
thiruram 103ccf1d87 Populate LauncherUiChanged.search_attributes field.
Test: Manual
Bug: 199495917
Change-Id: I9a7f9696d44b5b2af8d11e7f537b5c4ed78db060
2022-02-10 08:29:39 -08:00
Riddle Hsu 53e864d118 Set launch source info for shell recents animation
In legacy animation, it was set in RecentsAnimation
#startRecentsActivity. Now because shell transition use
startActivity, it can be set directly to the options.

Bug: 218847872
Test: adb shell setprop persist.debug.shell_transit 1; reboot
      Enable statsd log: "adb shell cmd stats print-logs"
      Swipe up gesture navigation bar from an app.
      adb logcat | grep statsd | grep "(48)"
      The line may contain 0x100000->4[I] 0x110000->20[I]
      that means 4=by recents and 20=latency 20ms.
Change-Id: Ia7bef23f8dc6cbf371cd1cdfb42f1f68d88d0787
2022-02-11 00:08:27 +08:00
Vinit Nayak 25e61b2606 [automerge] Add null check for null task in getItemInfo() 2p: 73c6288038
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16828919

Change-Id: I205452840d664917ad1b61d3daec717f211a8ef2
2022-02-10 00:01:19 +00:00
Vinit Nayak 73c6288038 Add null check for null task in getItemInfo()
* Pass back an empty WorkspaceItemInfo with correct
itemType set on it so at least it can be identified
if remaining fields are missing.

Fixes: 218625473
Test: Wasn't able to repro crash
Change-Id: If20d8fa648edf6c210ad5398905bf78e173b23a1
2022-02-09 15:59:13 -08:00
Vinit Nayak 5c6173a8b9 [automerge] Add null check for mRemoteTargetHandles for side task launch 2p: 90e0fe3923
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16828915

Change-Id: I8d41d76a5178c15beca5028291fc0a314a580de3
2022-02-09 23:31:57 +00:00
Vinit Nayak 90e0fe3923 Add null check for mRemoteTargetHandles for side task launch
* Other checks haven't changed, only pulled them out into
separate block

Fixes: 215699962
Test: Unable to repro the crash, I tried ending the
activity and starting via adb shell, but I was never
able to get into the original if-block that triggered the NPE

Change-Id: I83320634f1d059de610176f9031682ca287bd589
2022-02-09 15:30:19 -08:00
Winson Chung 6992855742 Merge "Add basic return animation when drag is canceled" 2022-02-09 19:32:22 +00:00
Winson Chung d937831791 Add basic return animation when drag is canceled
Bug: 179390870
Test: Drag, but don't drop to split an app from the taskbar and
      check that Launcher animates the surface back into place
Change-Id: I726855ff5bdffd1fc58d2839b3cc44b3fdb131e9
2022-02-09 06:44:21 +00:00
TreeHugger Robot e8b200eb6b Merge "Fix NPE when mRecentsView is null" 2022-02-09 05:04:57 +00:00
Jon Miranda 32319bf166 Merge "Move All Apps button to the left in RTL." 2022-02-09 01:55:36 +00:00
TreeHugger Robot fb1e592020 Merge "Prediction icons in Taskbar were updating when dragging icon in the same place" 2022-02-08 19:54:08 +00:00
Hyunyoung Song 57810aefa4 Work folder name is only fetched from activity, not ActivityContext
Bug: 217872881
Test: builds
Change-Id: I36bc9c386772c20fce2d10bf1bfaad565046d38f
2022-02-08 10:25:21 -08:00
Kholoud Mohamed 6974d39a44 Merge "Expose action that allows landing on the work tab" 2022-02-08 17:12:18 +00:00
Yohei Yukawa 697ae451d4 Use config_imeDrawsImeNavBar in Launcher
With this CL, the Launcher starts checking

  config_imeDrawsImeNavBar [1]

instead of

  config_navBarInteractionMode

when determining whether the IME should render the back and IME
switcher buttons or not.

There should be no observable behavior change as long as

  config_navBarInteractionMode

is set to true when the gestural navigation is enabled.

Bug: 216118048
Test: presubmit
Change-Id: Ia8269e240e0b18e1c7b8bd550dbb197ad58a6dbc
2022-02-08 07:47:29 -08:00
Alex Chau 449cd7226d Merge "Use less steps for home gesture" 2022-02-08 10:51:38 +00:00
Tony Wickham b1c3f88185 Fix NPE when mRecentsView is null
The NPE was in an unused variable, so also address the TODO to use it as log rank.

Test: wwdebug, wwlogcat, quickswitch and check rank field
Fixes: 218216440
Change-Id: I173ae607e9f73e58880c0fb1b6e8f2352469816f
2022-02-08 00:35:43 +00:00
Jon Miranda daa3150b9c Move All Apps button to the left in RTL.
Bug: 205803230
Test: verify LTR
      force RTL using developer option
      verify All Apps button is in the left
      verify All Apps button moves left before fading out

Change-Id: I2a5be9b37f471bfaa1a92f6819e04274e4dfb7a1
2022-02-07 14:08:47 -08:00
Thiru Ramasamy 40570799b3 Merge changes from topic "SuggestedResultAttribute"
* changes:
  [OneSearch] Add direct_match to SearchAttributes.
  [OneSearch] Deprecate CorrectedDeviceSearchResultContainer with SearchAttributes.
2022-02-07 20:36:38 +00:00
Sebastian Franco 5a6e08c3cd Prediction icons in Taskbar were updating when dragging icon in the same place
When dragging an icon in the Taskbar and dropping
it in the same spot it triggers new predictions when
it shouldn't. Basically, it was thinking that the icon
was moved outside of the taskbar which should trigger
new predictions. To fix it, it simply required to change
the order of the events, sending the UNPIN event before
the PIN event.

Bug: 202922907
Test: Have at least two prediction icons in the Taskbar, drag an app icon in the Taskbar, and drop it in the same place the prediction icon shouldn't change
Change-Id: I6079ff6eb69d7b1cb3c22bebc84511c0abd61cec
2022-02-07 19:10:55 +00:00
kholoud mohamed ceec31b17c Expose action that allows landing on the work tab
Bug: 217385869
Bug: 203531272
Test: manual
Change-Id: I68a6add9f603105e0a2ee01ebdc3059e18c9a050
2022-02-07 18:53:49 +00:00
Thiru Ramasamy c33c574698 [OneSearch] Add direct_match to SearchAttributes.
Captures if user acted on a search result that is not directly matched with search query, but instead related/suggested result.

Bug: 199495917
Test: Manual - http://gpaste/5167163338915840
Change-Id: Ib38244b1a82c502f551e8eb24dd14c14d8b375f2
2022-02-07 09:35:42 -08:00
Winson Chung b4bbec80b8 Merge "Prevent lingering divider animators in AbsSwipeUpHandler" 2022-02-07 17:09:49 +00:00
TreeHugger Robot 31abf9b014 Merge "Enable split from workspace / all apps" 2022-02-07 06:43:21 +00:00
Winson Chung 26031b0dd2 Prevent lingering divider animators in AbsSwipeUpHandler
- Refactor the util method to create the animator and track the existing
  animation in AbsSwipeUpHandler to be able to cancel it if another call
  to change the visbility comes in.  Note that this doesn't address
  the case where the launch animation overlaps with swipe up (though that
  hopefully shouldn't happen in normal usage)

Bug: 213403679
Test: Tap in the gesture space while split
Change-Id: I078a7d0f22c2ef2ba847796ec79e740c789ce1ae
2022-02-05 04:55:52 +00:00
TreeHugger Robot e3dea3458e Merge "Adds ENABLE_FLOATING_SEARCH_BOX flag for All Apps." 2022-02-05 04:41:43 +00:00
TreeHugger Robot b607781dbd Merge "Add tracking for widget creation" 2022-02-05 04:21:01 +00:00
Tracy Zhou 963c4b064f Enable split from workspace / all apps
Bug: 216829535
Test: N/A
Change-Id: I19deeebf2ced6b55f2af3d20fa2fd9f7d006453d
2022-02-04 14:28:03 -08:00
Thiru Ramasamy 441461c95c [OneSearch] Deprecate CorrectedDeviceSearchResultContainer with SearchAttributes.
Loggin query_corrected signal as field is more scalable than separate CorrectedDeviceSearchResultContainer for future usecases.

Test: Manual - http://gpaste/6343087535161344
Bug: 199495917
Change-Id: I6b3a410f4d977db2a058f337d1684f78763acbd2
2022-02-04 11:51:59 -08:00
Thiru Ramasamy 529fa34650 Merge "[OneSearch] Extract logging event for all apps entry into separate method." 2022-02-04 19:21:16 +00:00
Thiru Ramasamy 5fbac637c6 [OneSearch] Extract logging event for all apps entry into separate method.
Add containerInfo to the AllApps entry events to track from which workspace
user entered into AllApps drawer

Bug: 217583896
Test: Manual http://gpaste/6272522430447616

Change-Id: I77069a350a7b0e88cb321485144e0d8b976c4da9
2022-02-04 19:20:59 +00:00
Thales Lima f7bad2c880 Use less steps for home gesture
Needed because when running tests in virtual devices is very slow. The previous number of steps was also greater than the default timeout for home gesture.

Fixes 215673732
Test: atest Launcher3Tests:RequestPinItemTest

Change-Id: I9b13d97deb158222ba0ebf3f6a536c5a7ae632cf
2022-02-04 19:00:23 +00:00
Andy Wickham cf462e879a Adds ENABLE_FLOATING_SEARCH_BOX flag for All Apps.
This defines how the All Apps screen should be laid out without
anchoring to the search bar at the top, as follows:
 - Header view aligns to the top instead of below search bar.
 - Same for A-Z list.
 - Scroller is aligned to the header view to receive the above
   adjustments automatically.
 - A-Z list is set above search bar to not peek from below.
 - Search bar is set to align parent bottom and translates up
   with the keyboard.
 - Button to disable work apps is raised above the search bar.

Bug: 213954333
Test: Manually with flag enabled/disabled, Always show keyboard
enabled/disabled, and work profile enabled/disabled.

Change-Id: If90bb39a890029fa7056367fe62bad0677f0b86e
2022-02-03 17:12:22 -08:00
Thales Lima 116b51a999 Tune homescreen paddings
Also change the number of hotseat icons back to 6 on large screens

Fixes 210118169
Test: visual, Window VQA and HSV

Change-Id: I9a408f17080a558c2030805dd822f26e3c846e5d
2022-02-03 16:19:47 +00:00
TreeHugger Robot 3ad9de373f Merge "Log LAUNCHER_ALLAPPS_CLOSE_TAP when dismissing via touching scrim" 2022-02-03 07:37:38 +00:00
Tracy Zhou 4acb718a5c Merge "Initial implementation of split from workspace and all apps" 2022-02-03 04:30:35 +00:00
TreeHugger Robot 47a39329ae Merge "Be forgiving with accidental horizontal scroll" 2022-02-03 00:41:54 +00:00
Tracy Zhou a0d4720815 Initial implementation of split from workspace and all apps
Bug: 216829535
Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/feb5db9c-9429-42c2-a124-777e66fd5f0b
Change-Id: I34118975d0d7e15eb46b483f5a05447f5391e6fd
2022-02-02 13:37:47 -08:00
TreeHugger Robot a19af85605 Merge "Add split action buttons to workspace icon menu" 2022-02-02 20:52:33 +00:00
Evan Rosky dce4693bff Use fixed-rotation by default for shell transitions
As explained in title. Temporarily use fixed-rotation
by default for shell transitions

Bug: 217560545
Test: manual + existing flicker
Change-Id: Ic7c70d9305fe62dc7b6da0a02c0e1ccad412a1e2
2022-02-02 11:28:19 -08:00
Alex Chau 391bb2dd93 Log LAUNCHER_ALLAPPS_CLOSE_TAP when dismissing via touching scrim
Bug: 208599118
Test: Check StatsLog
Change-Id: Id3ec0650555072985df742cd1e8b020186e81959
2022-02-02 18:30:41 +00:00
Treehugger Robot 24113e8a07 [automerger skipped] Merge "Fix licenses and license texts." am: 55ce0a918c am: e91aa3abf2 am: d04232931b -s ours am: bc4b55f97d -s ours
am skip reason: Merged-In I1d76cab983a7d1f9078c0e2f1252f5409692f300 with SHA-1 478abd32c3 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1964700

Change-Id: I7deee5146bb2bfe783ebc47fb601764b46d44e51
2022-02-02 18:10:56 +00:00
Treehugger Robot bc4b55f97d [automerger skipped] Merge "Fix licenses and license texts." am: 55ce0a918c am: e91aa3abf2 am: d04232931b -s ours
am skip reason: Merged-In I1d76cab983a7d1f9078c0e2f1252f5409692f300 with SHA-1 478abd32c3 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1964700

Change-Id: I452669183267f207f7112481554d96800efd9918
2022-02-02 17:34:19 +00:00
Treehugger Robot d04232931b Merge "Fix licenses and license texts." am: 55ce0a918c am: e91aa3abf2
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1964700

Change-Id: Id8b68a3951d1bbed8116536ad7286f11d7795b2c
2022-02-02 17:19:27 +00:00
Treehugger Robot e91aa3abf2 Merge "Fix licenses and license texts." am: 55ce0a918c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1964700

Change-Id: Ifd75b6b1c77fb40c42eb3209933d77a4b3a3289b
2022-02-02 17:04:22 +00:00
TreeHugger Robot 13ea683810 Merge "Don't apply nav bar insets in tablets" 2022-02-02 16:58:06 +00:00
Treehugger Robot 55ce0a918c Merge "Fix licenses and license texts." 2022-02-02 16:48:44 +00:00
Bob Badour 5b17ccb509 [automerger skipped] Fix licenses and license texts. am: 478abd32c3 -s ours
am skip reason: Merged-In Id941d93786882aca78f214ac692433a353b84ed3 with SHA-1 a7548b5871 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16772277

Change-Id: I5eeab466ebe6740eba19bb678ff555bb9deadf3c
2022-02-02 13:54:13 +00:00
Tracy Zhou c70fa777de Add split action buttons to workspace icon menu
Bug: 216829535
Test: https://screenshot.googleplex.com/BNu6iWHGKV9sX7u
Change-Id: Id7ef9093e24c0211cf9590b35399e1f4d5b55ecf
2022-02-01 21:37:24 -08:00
Bob Badour 596ebbc9fb Fix licenses and license texts.
Entire project is 1p.

Bug: 210912771

Test: m nothing

Change-Id: I1d76cab983a7d1f9078c0e2f1252f5409692f300
Merged-in: Id941d93786882aca78f214ac692433a353b84ed3
Merged-in: I1d76cab983a7d1f9078c0e2f1252f5409692f300
2022-02-02 03:02:50 +00:00
Bob Badour 478abd32c3 Fix licenses and license texts.
Entire project is 1p.

Bug: 210912771

Test: m nothing

Change-Id: I1d76cab983a7d1f9078c0e2f1252f5409692f300
Merged-in: Id941d93786882aca78f214ac692433a353b84ed3
Merged-in: I1d76cab983a7d1f9078c0e2f1252f5409692f300
2022-02-01 18:53:38 -08:00