Commit Graph

49925 Commits

Author SHA1 Message Date
Tony Wickham 0bf6a14a79 Log when calling disposeEventHandlers
Test: local logs
Bug: 210426498
Change-Id: If9dadcb45a03a81d9e82932997ba5297534e0b81
2022-03-23 13:39:57 -07:00
Sebastian Franco 12db27fe34 Task thumbnail background is spilling to the front, making the BK 1px smaller to fix it
This change ag/17003268 was meant as a solution for b/146521490 but
it's ineficient so this other solution is simpler and more performant.

This solution only makes the background 1px smaller and that prevents
it from spilling in the Anti Aliasing.

Test: Put Telegram in recent Task (shouldn't be the first one) and you won't see a white border. Also when a task was in multitask the backgroudn should be draw.
Fix: 223761979
Change-Id: I6855e9ecce1e06f7a9311c62a038d34b04fe2398
2022-03-23 13:11:20 -07:00
Sebastián Franco da297fb0f1 Merge "Revert "Combining the Thumbnail bitmap with the background to fix background spilling in the front."" into tm-dev 2022-03-23 20:01:42 +00:00
Sihua Ma 38bb3b0c5c Aligning Hotseat and Workspace icons in vertical bar mode
Changing the padding of the Hotseat Bar to align the hotseat icons with the Workspace icons.

Test: Manual
Fix: 223553482
Change-Id: I7939c3a900dfe22d2ce3f71d408f1d2778a0af2a
2022-03-23 18:27:41 +00:00
Schneider Victor-tulias c7dee917db Prevent removing the feedback view and callbacks when the user completes a gesture.
Touching the screen immediately removed the feedback view and any callbacks attached. When the user successfully completed a gesture, one of those callbacks progresses the tutorial to its next step.

Fixes: 226028473
Test: manual
Change-Id: Ic432a5b73aa4410cb0188f50a57e3df637afb52d
2022-03-23 11:08:08 -07:00
Sebastian Franco 5282efddc9 Brighten theme-icons when in Dark mode and add dark color for taskbar
Bug: 217247494
Test: change between dark and light mode and transition in and out of apps
Change-Id: Ia5e38d674a56eb95a48cb1e8c2688586594a69f9
2022-03-23 10:47:52 -07:00
Tracy Zhou f3d81b0a1c Merge "Fix thumbnail disappearing during staged split animation" into tm-dev 2022-03-23 16:06:37 +00:00
Vinit Nayak aa2f879c55 Merge "Null out mRemoteTargetHandles when swiping to home" into tm-dev 2022-03-23 14:58:19 +00:00
Pat Manning 85eeb4e62e Merge "Add workspace page translations for edit state." into tm-dev 2022-03-23 11:35:20 +00:00
Luca Zuccarini 6f962f9357 Merge "[Toast] Flip the QSB motion flag to true by default." into tm-dev 2022-03-23 10:27:05 +00:00
Tracy Zhou 67bc75a8a9 Fix thumbnail disappearing during staged split animation
Previous set the thumbnail view to be visible initially. After deciding not to do so, forgot to put the visibility statement back. Also the transform matrix needs to reset before posting new scales.

Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/6576df3a-6d14-4b7e-8fb2-1c0a335472e4
Fixes: 194414938
Change-Id: I25fe39ea99943a3c1e2257681df3eb379bc30e51
2022-03-22 22:01:27 -07:00
Vinit Nayak 1d6058c2cd Null out mRemoteTargetHandles when swiping to home
* Also all null check when trying to show divider
after swipe down animation from overview

Fixes: 223946009
Test: Steps in bug no longer cause crash
Change-Id: I2c8484c37b863c4cb6aba7e274c1eb76bce92b4a
2022-03-22 20:47:54 -07:00
Hongwei Wang 808d568367 Hide the Taskbar when user leaves PiP mode
This is to prevent the Taskbar from flickering when the app settles in
full-screen mode.

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/dIgvinb9yEB8MYfYDx0Ijy
Bug: 218450853
Test: see video
Change-Id: I9cfb0ca151dea6951561f78798bb16bafa48eba0
2022-03-22 18:45:31 -07:00
Tracy Zhou 53ad207008 Use topComponent to get package name
task.topActivity can be null

Fixes: 226232720
Test: manual
Change-Id: I7d0c928871d01402bf41bc96514aae7854045baf
2022-03-22 17:13:52 -07:00
Tracy Zhou 8d06bb8991 Merge "Update initial staged split UX." into tm-dev 2022-03-22 22:44:33 +00:00
TreeHugger Robot 6c7b0f7db8 Merge "Fix issue cauing the taskbar to show in the all set page of the SUW." into tm-dev 2022-03-22 20:25:32 +00:00
Hongwei Wang 1acabce45b Merge "Add auto-enter-pip support in FallbackSwipeHandler" into tm-dev 2022-03-22 20:07:55 +00:00
Schneider Victor-tulias c741210bb1 Merge "Reset the home settings activity when launching it" into tm-dev 2022-03-22 18:23:41 +00:00
Pat Manning b04dd608bf Add workspace page translations for edit state.
Bug: 202971709
Test: manual
Change-Id: Ic807d380053b8cc5aaf521513c308854e1b14a43
2022-03-22 17:58:19 +00:00
Schneider Victor-tulias 44aadeaef6 Fix issue cauing the taskbar to show in the all set page of the SUW.
Some missing state handling was causing the taskbar to show in the all set page of the SUW.

Fixes: 218507703
Test: build change, flashed and factory reset device
Change-Id: If3a280ef6416f0821cf6a9b1ab0a65d58c5c8221
2022-03-22 10:50:26 -07:00
Brian Isganitis 98214d072c Merge changes from topics "presubmit-am-08ca1fad1fe94bf3ace5a708c5584d55", "presubmit-am-3c6c58a0fa374b92b1a5f8d5f5788871", "presubmit-am-6939eac1469540108813bd4ed4c60a9b" into tm-dev
* changes:
  Have taskbar all apps extend ActivityAllAppsContainerView.
  Refactor ActivityAllAppsContainerView to depend on ActivityContext.
  Refactor allapps.search package to depend on ActivityContext.
2022-03-22 16:11:35 +00:00
Luca Zuccarini b21fd239a9 [Toast] Flip the QSB motion flag to true by default.
Bug:225749858
Test: manual with soong build as well as server build image with this
change

Change-Id: I5658bae753a7112a64fc89ae54c10c5af3a09654
2022-03-22 15:45:07 +00:00
Thales Lima 042482e94c Merge "Change size of All Apps bottom sheet" into tm-dev 2022-03-22 15:25:50 +00:00
Thales Lima b7ef569591 Change size of All Apps bottom sheet
This brings the size of the bottom sheet closer to the spec provided by UX. For that type of flexibility to be possible, more attributes are introduced and some calculations had to be changed.

This shouldn't affect phones.

Bug: 218638090
Test: visual, with dumpsys and HSV
Change-Id: Ieee7580d80d8e100837b1cdd7a1455c4d65612dc
2022-03-22 12:19:46 +00:00
Thales Lima 60dc19cb71 Merge "Fix height of hotseat" into tm-dev 2022-03-22 11:43:13 +00:00
Thales Lima f49dce6961 Merge "Reset the size of hotseat cells" into tm-dev 2022-03-22 10:06:22 +00:00
Vinit Nayak b85e0afe70 Merge "Keep live tile running when TaskMenuView is showing" into tm-dev 2022-03-22 04:48:43 +00:00
Tracy Zhou 4ff3615b23 Update initial staged split UX.
- Introduce inset to the staged split view
- Update width of the staged split view
- Introduce rounded corners to staged split view. It's tricky to animate it in with smooth transition considering the rounded corners. The best way to handle it is to draw content as if part of it is off the screen, so that when it's animated in, the rounded corners can slide in onto the screen correctly.

Fixes: 219085340
Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/09a99b75-3614-4d20-b6d4-a78108f769d8

Change-Id: I24d90cc9e2695d822cb2de8b21e2d5519f2e344d
2022-03-21 21:21:42 -07:00
Vinit Nayak a5addf0e89 Keep live tile running when TaskMenuView is showing
* Doesn't fix the bug, but a nicer UX to have

Bug: 223317893
Test: Live tile was running after tapping app icon.
Was able to enter split just fine

Change-Id: I50c5d5623546d19d216beae09b76c310e8b3c815
2022-03-21 18:15:28 -07:00
Becky Qiu fd6b0d5617 Merge "[OneSearch] Add a flag to guard QSB animations." into tm-dev 2022-03-22 00:58:07 +00:00
Jeremy Sim c789ade45e Merge "Fix crash condition by adding a null check in DigitalWellBeingToast" into tm-dev 2022-03-22 00:39:47 +00:00
Jeremy Sim c0422b8a48 Merge "Fix issue with split thumbnails overflowing during rotation" into tm-dev 2022-03-22 00:17:43 +00:00
Jeremy Sim 7a84442436 Merge "Fix UI overlap when rotating in split select mode" into tm-dev 2022-03-22 00:17:43 +00:00
Jeremy Sim 8746367f40 Merge "Fix paired icon placement in landscape/seascape" into tm-dev 2022-03-22 00:17:43 +00:00
Jeremy Sim cab1ef1a9d Merge "Fix small positioning bug with DWB banner in landscape" into tm-dev 2022-03-22 00:17:43 +00:00
Brian Isganitis 88319c4828 Add utility for isWallpaperSupported.
Test: Manual
Bug: 223549757
Change-Id: I910ad82ab12790f082525353dbdb86def93e3c04
2022-03-21 17:09:24 -07:00
Hongwei Wang ad9c83966b Add auto-enter-pip support in FallbackSwipeHandler
- Deprecate HomeAnimationFactory#supportSwipePipToHome and treat 3rd
  party Launcher supporting auto-enter-pip transition as well
- Add a new FallbackPipToHomeAnimationFactory if auto-enter-pip
  transition is to be launched
- Make sure Launcher is resumed at the end of auto-enter-pip transition
  to actually trigger the PiP task appearing

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/hMPkRXy4vAjC6sQYUIIWUP
Bug: 220665901
Test: `m -j Launcher3` and verify the auto-enter-pip transition \
      see also the video
Change-Id: I6d16f2559d173f695ccbc743eb55e964bf088d04
2022-03-21 14:39:23 -07:00
TreeHugger Robot f8137e5ecb Merge "Fix overriden deep shortcut titles and icons" into tm-dev 2022-03-21 20:56:13 +00:00
Sebastián Franco 02458386cf Revert "Combining the Thumbnail bitmap with the background to fix background spilling in the front."
This reverts commit 5a9dce518e.

Reason for revert: The solution is inefficient. There is already a solution in ag/17060224

Change-Id: I5b5862f1ae426c78062c5a0f481abfb13b3060cc
2022-03-21 20:26:21 +00:00
TreeHugger Robot 84c9d3ec90 Merge "Fix Proto compilation on M1 Macs" into tm-dev 2022-03-21 20:03:46 +00:00
Vinit Nayak 68d5dd82db Merge "Use ComponentCallbacks to recreate on fold/unfold" into tm-dev 2022-03-21 19:05:52 +00:00
Luca Zuccarini 24fab62d35 [OneSearch] Add a flag to guard QSB animations.
Bug: 225749858
Test: manual
Change-Id: Ib725b9bcec235d2e23cf93b2f86d0dc9cd0600cb
2022-03-21 19:00:23 +00:00
Vinit Nayak c55c94880e Merge "Limit the number of commands in OverviewCommandHelper" into tm-dev 2022-03-21 18:49:42 +00:00
Thales Lima 7d14923195 Fix height of hotseat
Hotseat size was going behind workspace unnecessarily, causing some issues and also had the wrong hotseat height which was cutting the icons in folders.

Fixes: 224713923
Fixes: 221101290
Test: manual
Change-Id: I2646abc4a6aaa5bf2ea85e55e2f3618f8d7efd9b
2022-03-21 18:32:22 +00:00
Brandon Dayauon 4f733127a7 Merge "Change Home screen to 'home screen' when it's in middle of a sentence" into tm-dev 2022-03-21 17:25:19 +00:00
Alex Chau c9f3cc36bb Merge "Update overview grid icon sizes and paddings" into tm-dev 2022-03-21 17:08:31 +00:00
TreeHugger Robot 016dd3656d Merge "Adjust edit state drop targets, workspace scaling, and margins per device type and orientation." into tm-dev 2022-03-21 17:07:10 +00:00
Jon Miranda d17cb2722c Merge "Allow depth animation when user swipes back to home." into tm-dev 2022-03-21 15:33:08 +00:00
Thales Lima c307cd137f Merge "Add more border space options" into tm-dev 2022-03-21 15:14:18 +00:00
Thales Lima 2017ee0208 Merge "Correct inline qsb for foldables" into tm-dev 2022-03-21 14:30:19 +00:00