Commit Graph

49925 Commits

Author SHA1 Message Date
Tony Wickham 61d9edf810 Merge "Consolidate two different onTransitionCancelled implementations" into sc-dev am: 029e930751
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14103181

Change-Id: I2c383f800a4904741103095ea2ab8c805764453a
2021-04-06 22:23:43 +00:00
Tony Wickham 0fa98f86fb Merge "Consolidate two different onTransitionCancelled implementations" into sc-dev am: 029e930751
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14103181

Change-Id: I6d871e1715644325455c5e6a4a635c17ca21d44e
2021-04-06 22:23:37 +00:00
Winson Chung 7cf7c31e46 Merge "Fix noisy log from sysui flag changes" into sc-dev 2021-04-06 21:48:43 +00:00
Tony Wickham 029e930751 Merge "Consolidate two different onTransitionCancelled implementations" into sc-dev 2021-04-06 21:44:53 +00:00
TreeHugger Robot 3ac5f45e05 Merge "Fix HINT_STATE not tracking the entire height of the screen" into sc-dev am: c07ad47255
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14104581

Change-Id: I3ee661bee2a263d078217035f4e1cce35e1d2572
2021-04-06 21:30:24 +00:00
TreeHugger Robot e3f96639fc Merge "Fix HINT_STATE not tracking the entire height of the screen" into sc-dev am: c07ad47255
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14104581

Change-Id: Idee949dd793e04b5b9416e52ba00151ac0281e56
2021-04-06 21:30:10 +00:00
TreeHugger Robot c07ad47255 Merge "Fix HINT_STATE not tracking the entire height of the screen" into sc-dev 2021-04-06 20:58:26 +00:00
Tony Wickham b6a26a846f Merge "Explicitly set which taskbar view is visible at each caller" into sc-dev am: fc3bc6098f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14094841

Change-Id: I728494cd1a8ae4c63be04c5d7d317d021c247bc5
2021-04-06 20:37:27 +00:00
Tony Wickham d6d2cda7e0 Merge "Ensure taskbar animation ends when running window animation does" into sc-dev am: 0b0c173ec0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14096849

Change-Id: I341b7ec1f47002be7090c4e38548ee33cf4d8377
2021-04-06 20:37:04 +00:00
Tony Wickham 655bf5ade9 Merge "Explicitly set which taskbar view is visible at each caller" into sc-dev am: fc3bc6098f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14094841

Change-Id: I216a2a826d6d6d2ddc1c2bfebf4e764bd43d2981
2021-04-06 20:34:02 +00:00
Tony Wickham d054d06099 Merge "Ensure taskbar animation ends when running window animation does" into sc-dev am: 0b0c173ec0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14096849

Change-Id: Icf9a904ddc34a8a474fdaad94de9b247ce16f3c5
2021-04-06 20:32:24 +00:00
Tony Wickham fc3bc6098f Merge "Explicitly set which taskbar view is visible at each caller" into sc-dev 2021-04-06 19:37:18 +00:00
Tony Wickham 0b0c173ec0 Merge "Ensure taskbar animation ends when running window animation does" into sc-dev 2021-04-06 19:35:38 +00:00
Tony Wickham b77fa8da52 Consolidate two different onTransitionCancelled implementations
There was previously two different onTransitionCancelled(), one in
BaseActivityInterface and one in AnimationFactory. They are pretty
similar and the differences seem subtle and not necessary. In this
bug, the AnimationFactory version was going to mStartState instead
of StateManager#getRestState() (which is the same, unless mStartState
disables restore). Instead, always use the mActivityInterface
implemenation, which seems more robust.

Test: Open app A, open app B, quick switch from B to A, swipe home
during that transition, then touch nav region during home transtion;
ensure we don't goToState(BACKGROUND_APP) in the subsequent
onTransitionCanceled().

Fixes: 184583037

Change-Id: I315a5087b12413d88c3ccc1e3245a55a76a73e62
2021-04-06 12:16:00 -07:00
Schneider Victor-tulias bf694d61ee Add logging for adding pending icons to the workspace.
Added logging to help track down b/168788486

Bug: 168788486

Test: manual
Change-Id: I96b38be7c02793f1b6649e6c0de5cdf47dca6edb
2021-04-06 12:10:50 -07:00
Tony Wickham 721a89d93a Merge "Cleanup taskbar touchableInsets" into sc-dev am: c9846dc6e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14096731

Change-Id: I5331b56137d960f1d5eea3622e8255bcf5f64937
2021-04-06 19:08:24 +00:00
Tony Wickham c9e3603fdd Merge "Cleanup taskbar touchableInsets" into sc-dev am: c9846dc6e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14096731

Change-Id: I6b32230933601805941ac13f6a63379cfe26d787
2021-04-06 19:07:29 +00:00
Tony Wickham c9846dc6e7 Merge "Cleanup taskbar touchableInsets" into sc-dev 2021-04-06 18:36:05 +00:00
Samuel Fufa 06702c00b9 Merge "[Search][Layout] Fix blank space when predictions are disabled" into sc-dev am: 50c6a37ea9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14102304

Change-Id: I7e4b49d72b7d4fadacaeba5a372b0305908c34aa
2021-04-06 17:57:57 +00:00
Zak Cohen be66b43c9f Merge "Overview - update Clear All and Empty message drawing" into sc-dev am: fd9af2f017
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14096074

Change-Id: I8cef2fa1301f7faa0e70a12978da3724aaa7397d
2021-04-06 17:57:52 +00:00
Samuel Fufa af45168c58 Merge "[Search][Layout] Fix blank space when predictions are disabled" into sc-dev am: 50c6a37ea9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14102304

Change-Id: Ibe1b37e7e2f2d998f8a5c0464986e397efbe598d
2021-04-06 17:57:39 +00:00
Zak Cohen 19c6a15527 Merge "Overview - update Clear All and Empty message drawing" into sc-dev am: fd9af2f017
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14096074

Change-Id: I157405a0932d036f3a41e0dfdae32c5c0bd44918
2021-04-06 17:57:03 +00:00
Samuel Fufa 50c6a37ea9 Merge "[Search][Layout] Fix blank space when predictions are disabled" into sc-dev 2021-04-06 17:56:51 +00:00
Zak Cohen fd9af2f017 Merge "Overview - update Clear All and Empty message drawing" into sc-dev 2021-04-06 17:42:05 +00:00
TreeHugger Robot 46099a47e0 Merge "Update device padding to allocate more space to workspaceBottomPAdding." into sc-dev am: d69407c02e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14095430

Change-Id: Iec72085cd15f466fcd7e2ffe7e1f0a40e7f5c816
2021-04-06 17:36:26 +00:00
TreeHugger Robot cc31edfcda Merge "Update device padding to allocate more space to workspaceBottomPAdding." into sc-dev am: d69407c02e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14095430

Change-Id: I1225c0bade3637c5f5ba01e89f7fe12bcf3e21e3
2021-04-06 17:36:03 +00:00
Tony Wickham fbdb50aa48 Fix HINT_STATE not tracking the entire height of the screen
Explicitly use DeviceProfile#heightPx instead of getShiftRange(),
which might be less depending on AllAppsTransitionController

Test: swipe up from bottom on home, ensure workspace scales down
as the gesture goes all the way to the top of the screen

Change-Id: I9c2988d361c22d437c7eb9bea8ed715d06054c59
2021-04-06 10:09:44 -07:00
TreeHugger Robot d69407c02e Merge "Update device padding to allocate more space to workspaceBottomPAdding." into sc-dev 2021-04-06 16:55:33 +00:00
Samuel Fufa 5461089baa [Search][Layout] Fix blank space when predictions are disabled
This regression is caused due to getExpectedHeight relying on view visibility state while AlphaUpdateListener.updateVisibility was reseting the views visibility.

Bug: 184211402
Test: local
Change-Id: Ib756f5eb8f6356a18a025626008b97fd7c77fec9
2021-04-06 04:05:20 -05:00
Samuel Fufa ac120c9a47 [Search] make AbstractSlideinView#createColorScrim overridable
+ Introduce feature flag for people tile results

Bug: 183972880
Bug: 184003600
Test: Manual
Change-Id: Ia8b3af4e99a66f640f6f42fc5886d9cbfb5e913c
2021-04-06 03:18:07 -05:00
TreeHugger Robot 9ed01f19a5 Merge "[Hotseat] Don't show hotseat edu in tests" into sc-dev am: ce271c1067
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14094674

Change-Id: I716189fe0eca98af596666c115b25a04777c5747
2021-04-06 06:50:34 +00:00
TreeHugger Robot 18210721e7 Merge "[Hotseat] Don't show hotseat edu in tests" into sc-dev am: ce271c1067
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14094674

Change-Id: Ib625be5cb0a041e476bc84cc9097d0e7367daa7c
2021-04-06 06:49:45 +00:00
TreeHugger Robot ce271c1067 Merge "[Hotseat] Don't show hotseat edu in tests" into sc-dev 2021-04-06 06:18:56 +00:00
Winson Chung 7700bffc47 Fix noisy log from sysui flag changes
Bug: 144854916
Test: Logcat after sysui flag changes, ensure no tracing change logs
Change-Id: I36b6b71bae08303787508ab6eb63ca989866370c
2021-04-06 04:38:03 +00:00
Winson Chung 27d9a92a44 Reset force-minimized split state when in live tile mode
Bug: 184233556
Test: Enter split, go home, launch same task by tapping or swiping
Change-Id: Ied2d56f087e5c05f5f7c4b19428f8088edf4e599
2021-04-05 21:19:25 -07:00
TreeHugger Robot 6aff071086 Merge "Add split placeholder view above OverviewScrim" into sc-dev am: e77fc9cc25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14094826

Change-Id: I28b24bba5a2073941a95ac33a40a53c2e5a9f0f2
2021-04-06 03:16:05 +00:00
TreeHugger Robot e508dd17a8 Merge "Add split placeholder view above OverviewScrim" into sc-dev am: e77fc9cc25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14094826

Change-Id: I38e33d134b4a7727431d87932ec1716e02c8cedb
2021-04-06 03:15:42 +00:00
TreeHugger Robot e77fc9cc25 Merge "Add split placeholder view above OverviewScrim" into sc-dev 2021-04-06 02:34:19 +00:00
android-build-team Robot 8f5bd82323 Snap for 7259849 from dd2b8b6f2e to sc-v2-release
Change-Id: I51881fbe2c5e9ae1addfc3e2cdc7e6bcae57029d
2021-04-06 01:09:02 +00:00
android-build-team Robot cb727db92a Snap for 7259849 from dd2b8b6f2e to sc-release
Change-Id: Id021d950e37a447f57b282e0fddcd15c32f509b0
2021-04-06 01:08:19 +00:00
Tony Wickham 9f436dfe8e Ensure taskbar animation ends when running window animation does
- Store the possible parallel animation to cancel/end in
  AbsSwipeUpHandler#endRunningWindowAnim()

Test: 1. remove taskbar during transition, ensure cleaned up properly
2. open a second app during transition to home, ensure taskbar
maintains correct visibility
Bug: 182512211

Change-Id: I71a6b6ce624113d43ad5a599cb5cfec28a555310
2021-04-05 17:52:38 -07:00
Tony Wickham e13a4a4475 Cleanup taskbar touchableInsets
- Remove obsolete visibleInsets hack and isDraggingItem() check
- Have TaskbarController determine whether taskbar is touchable,
  rather than TaskbarContainerView.
- Disallow touches during transition to home (can potentially
  improve this later)

Test: Swupe home, tap taskbar folder during transition, ensure
don't end up in broken state with the uninteractable folder open
Bug: 182512211

Change-Id: Id625ce8b9b876a8a1b450b7d6fb771540e23bc08
2021-04-05 17:33:44 -07:00
Tony Wickham 49c2a3548d Merge "Send a notification when there's an uncaught exception" into sc-dev am: 2e0eee4d63
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14020270

Change-Id: I34d62ee46811d705b06c73f984316ff8cccb870d
2021-04-06 00:22:10 +00:00
Tony Wickham d4c35c2d31 Merge "Send a notification when there's an uncaught exception" into sc-dev am: 2e0eee4d63
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14020270

Change-Id: Ia93aa44346ec2b052b6af04d2d0a042e241fc1c2
2021-04-06 00:17:36 +00:00
Tony Wickham 2e0eee4d63 Merge "Send a notification when there's an uncaught exception" into sc-dev 2021-04-05 23:58:22 +00:00
Zak Cohen 23b7fea6eb Overview - update Clear All and Empty message drawing
Update Clear All and Empty message to use primary color, not workspace
color, as they are drawn on floating background now, not wallpaper.

Bug: 184260454
Fixes: 184260454
Test: local build, flash and run
Change-Id: Ie8ef4b7ace3053c2068a27b7cbedbbb039fc36d8
2021-04-05 23:45:02 +00:00
Tony Wickham 6a74e65953 Explicitly set which taskbar view is visible at each caller
This makes it more clear which taskbar view is expected for particular
code flows. Also makes it easier to set it to null in cleanup().

Test: call cleanup() while taskbarOnHome is invisible, ensure hotseat
icons go back to being visible
Bug: 182512211
Fixes: 183633496

Change-Id: I680a15582c8034a049b20e035b4d54f5ea5aee04
2021-04-05 16:42:17 -07:00
Becky Qiu 98378c8815 Merge "Shared element transition between image and sharesheet." into sc-dev am: 9b85dc836d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13926966

Change-Id: I089974782c4bf26ea302bff1d354598a10b50b59
2021-04-05 22:58:43 +00:00
Becky Qiu 41e66d7deb Merge "Shared element transition between image and sharesheet." into sc-dev am: 9b85dc836d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13926966

Change-Id: Ia460de836ff797d724d1996e9f138e86f01d6649
2021-04-05 22:57:36 +00:00
Becky Qiu 9b85dc836d Merge "Shared element transition between image and sharesheet." into sc-dev 2021-04-05 22:18:34 +00:00