TreeHugger Robot
85b38729a8
Merge "Removing UI dependency from LauncherModel in case of 2-panel layout" into sc-v2-dev am: d327290762 am: 3694d653c4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302087
Change-Id: I438361fe609dcfe38d5455ceb3139d5e5784ae06
2021-07-22 19:40:16 +00:00
TreeHugger Robot
2b144aa6a3
Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev am: 6a01fe49a5 am: c48e4fa64d am: 1331588b51
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15359118
Change-Id: I52340b2fa74478e94508a607d9d094a4fab9facf
2021-07-22 19:40:04 +00:00
Adam Cohen
ed82e0daef
Fix widget drop preview outline on 4x5 grids
...
=> We were not account for mBorderSpacing in the outline calculation
=> This was fine in most cases as this value is 0, but 4x5 appears to be the exception
Bug: 194227752
Test: manual, see video in bug.
Change-Id: Ib590bc142a0f65e75f92ee057f8b4f4b0f81521b
2021-07-22 12:31:21 -07:00
TreeHugger Robot
3694d653c4
Merge "Removing UI dependency from LauncherModel in case of 2-panel layout" into sc-v2-dev am: d327290762
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302087
Change-Id: Iee3afcdc1861954dbbabab7445ddb627fb0b72d9
2021-07-22 19:23:31 +00:00
TreeHugger Robot
1331588b51
Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev am: 6a01fe49a5 am: c48e4fa64d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15359118
Change-Id: Ieb6490062af299ee7f72f655e5029f16807fdce2
2021-07-22 19:23:27 +00:00
TreeHugger Robot
a914d2d70a
Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev am: 6a01fe49a5 am: 268dd89cb0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15359118
Change-Id: Ia8971a215762c5f9b9e1a0a4b97da5ed3359a400
2021-07-22 19:22:41 +00:00
TreeHugger Robot
d327290762
Merge "Removing UI dependency from LauncherModel in case of 2-panel layout" into sc-v2-dev
2021-07-22 19:16:52 +00:00
TreeHugger Robot
c48e4fa64d
Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev am: 6a01fe49a5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15359118
Change-Id: I0004e2f55347e018fa553f8b56c26a754a93e0f1
2021-07-22 19:11:55 +00:00
TreeHugger Robot
268dd89cb0
Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev am: 6a01fe49a5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15359118
Change-Id: I727434e2844939039a53325dbc3ff52060bfa00f
2021-07-22 19:10:45 +00:00
TreeHugger Robot
6ba5972f84
Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev am: 6a01fe49a5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15359118
Change-Id: Idaeaadb2e1ba47eb2f0d7c3cbcaf3b4529daecf1
2021-07-22 19:09:11 +00:00
TreeHugger Robot
6a01fe49a5
Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev
2021-07-22 18:53:32 +00:00
Jonathan Miranda
21de322a69
resolve merge conflicts of b6347c9d48 to sc-v2-dev-plus-aosp
...
Folder icon polish.
- Increase the overlap between the preview items and the background
so that it appears more intentional (lots of reports of users
thinking that its a bug)
- Fix bug where clip path was still clipping icons when
dragging and swiping to home.
Bug: 194341143
Bug: 193701705
Bug: 191225536
Test: test 2 icon, 3 icon, and 4 icon folders
close folder on 2nd page, ensure clipping
ensure no preview items are clipped in drag view
ensure no preview items are clipped in swipe up to home
test 2x2, 3x3, 4x4, 4x5, and 5x5 grids to ensure no clipping
of folder icons
drag and drop folder in and out of hotseat
create folders (2 icon, 3 icon, 4 icon)
Change-Id: I308ed533a0746025d965ec429f23270566b137ba
Merged-In: Id49bae33438e10248bef05450d7e2c92c2140748
2021-07-22 18:12:20 +00:00
Jason Chang
ec17aa564f
Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev am: 1b3f5d3883 am: 12a0357c31 am: 9008a57ae6
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15311532
Change-Id: I99f77b25e2a4b7f6b4d0e24116b69f713078244d
2021-07-22 17:56:40 +00:00
TreeHugger Robot
a86d7e8756
[automerger skipped] Merge "resolve merge conflicts of 46378eb881 to sc-v2-dev" into sc-v2-dev am: f3a387d731 am: 2482a19429 -s ours
...
am skip reason: Merged-In Id49bae33438e10248bef05450d7e2c92c2140748 with SHA-1 2cc564c647 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15351394
Change-Id: I30f71ea6775d44742c5e0ac1f286129a30f4bf38
2021-07-22 17:55:58 +00:00
Sunny Goyal
12e3f1f2f7
Removing UI dependency from LauncherModel in case of 2-panel layout
...
Bug: 175939730
Bug: 192431856
Bug: 185515153
Test: Manual
Change-Id: I8baa1cf9e5a8a04d5b8bc38c1f4b0755265cd8a9
2021-07-22 10:34:25 -07:00
Jason Chang
9008a57ae6
Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev am: 1b3f5d3883 am: 12a0357c31
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15311532
Change-Id: I9abbe0fc14aee95f9195fada302c380f3a84d861
2021-07-22 17:28:02 +00:00
TreeHugger Robot
2482a19429
Merge "resolve merge conflicts of 46378eb881 to sc-v2-dev" into sc-v2-dev am: f3a387d731
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15351394
Change-Id: If1169f6a7d1db4bed676d9d4a4039f830ab00077
2021-07-22 17:25:46 +00:00
Jason Chang
12a0357c31
Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev am: 1b3f5d3883
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15311532
Change-Id: I6459733abb399137224fe9c24ac7cdc63282dd9e
2021-07-22 16:54:17 +00:00
TreeHugger Robot
f3a387d731
Merge "resolve merge conflicts of 46378eb881 to sc-v2-dev" into sc-v2-dev
2021-07-22 16:49:35 +00:00
Alex Chau
41e77de54e
Avoid seeing ClearAllButton for overview grid's snap position
...
- This is a follow-up of http://ag/15220572
- When determining if task's snap position is too close to ClearAllButton, avoid positions that will see part of ClearAllButton
Bug: 192254835
Test: manual
Change-Id: I09425075ff0c24835ac3c4e79856aef7985476b2
2021-07-22 16:14:15 +01:00
Steven Ng
a606d344a6
Measure WidgetsFullSheet before estimating the recommended table
...
size
Issue: The header view height was obtained before any measurement.
Test: On Pixel 5 4x5 gird with Photo widget shown in recommended
table, make the device in landscape. Then open the full widgets
picker. The widgets picker can be scrolled. Before this fix,
scrolling is not possible.
Fix: 194172597
Change-Id: Ib30cf4b95d2ed23ff28f3d24e103f0e919b3a551
2021-07-22 16:08:15 +01:00
TreeHugger Robot
58d6237dae
Merge "Fix scaling on widget previews that have width / height set to wrap_content" into sc-v2-dev am: b971baefe1 am: 841fc730ef
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15346899
Change-Id: I02a14ea7f818f35f64f4d663ec897543458d1802
2021-07-22 12:38:55 +00:00
TreeHugger Robot
841fc730ef
Merge "Fix scaling on widget previews that have width / height set to wrap_content" into sc-v2-dev am: b971baefe1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15346899
Change-Id: I44db843f7c9248c078342ac927a2663427f4b3ee
2021-07-22 12:18:33 +00:00
TreeHugger Robot
b971baefe1
Merge "Fix scaling on widget previews that have width / height set to wrap_content" into sc-v2-dev
2021-07-22 12:05:03 +00:00
TreeHugger Robot
908a1ef10d
Merge "Add null check for recents scaling during quick switch." into sc-v2-dev am: d32a472e5c am: 125ea48ce5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15358270
Change-Id: Ifd729f96f9f291a91901dfca33f51e54cf0bb72b
2021-07-22 11:04:10 +00:00
TreeHugger Robot
125ea48ce5
Merge "Add null check for recents scaling during quick switch." into sc-v2-dev am: d32a472e5c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15358270
Change-Id: I7651d1192328c675bc4b31b97ded7869f7442ad1
2021-07-22 10:43:33 +00:00
TreeHugger Robot
d32a472e5c
Merge "Add null check for recents scaling during quick switch." into sc-v2-dev
2021-07-22 10:28:50 +00:00
Thales Lima
a66ee1ddda
Merge "launcher: correct page spacing for multiple panels" into sc-v2-dev am: 496ca0081e am: 016ba91625
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15337415
Change-Id: Ibc5d0f65082b8130cbadb362d54272a21b714989
2021-07-22 10:24:45 +00:00
Jason Chang
f4a1256c06
Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev am: 1b3f5d3883 am: 0476be4a35
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15311532
Change-Id: Ideff92e3380a41b21aa307b3ab8ce4d28a3221c8
2021-07-22 10:24:20 +00:00
Steven Ng
2b90d043f6
Fix scaling on widget previews that have width / height set to
...
wrap_content
If the widget preview has width / height set to wrap_content, we should
set the layout param width / height to the exact dimension after
measurement. Otherwise, we will end up clipping the previews.
Test: manual
Fix: 193144010
Change-Id: I101f7c6d3dbd264fee448b85c54029d5650d6630
2021-07-22 11:19:25 +01:00
Jason Chang
0476be4a35
Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev am: 1b3f5d3883
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15311532
Change-Id: I073ad3902e3e47832d97a181428c980ea1c7b96f
2021-07-22 10:06:24 +00:00
Thales Lima
016ba91625
Merge "launcher: correct page spacing for multiple panels" into sc-v2-dev am: 496ca0081e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15337415
Change-Id: I3967a4b40aa8c14baedc192c05733865c4f68f01
2021-07-22 10:06:06 +00:00
Jason Chang
668fd1db2f
Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev am: 1b3f5d3883
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15311532
Change-Id: I45544393dec62e60baebdda57602f931e0919b3a
2021-07-22 10:01:58 +00:00
Jason Chang
1b3f5d3883
Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev
2021-07-22 09:43:13 +00:00
Thales Lima
496ca0081e
Merge "launcher: correct page spacing for multiple panels" into sc-v2-dev
2021-07-22 09:41:56 +00:00
Thales Lima
e445774ab5
launcher: correct page spacing for multiple panels
...
This fixes 2 things:
- adding the correct space between pages as insets (eg camera) were
being discarded
- adding the space between pages instead of between panels as was before
This solution should work with more panels and don't create problems for
phones, where panels = 1.
Fixes 193194192
Test: manual testing in unfolded state in portrait and landscape, both
rotations
Change-Id: Ia3b148ceb773c6d5b6f8848ced07d7f9c1459e92
2021-07-22 09:41:43 +00:00
Pat Manning
b442aee4c4
Add null check for recents scaling during quick switch.
...
Test: manual - FallbackRecentsTest.goToOverviewFromHome and
StartLauncherViaGestureTests.testStressPressHome were previously failing
due to null mActivity in AbsSwipeUpHandler#getScaleProgressDueToScroll.
Bug: 192470757
Change-Id: I562171c22ad3c89e64b4dc853a266c8b8b78402c
2021-07-22 08:52:28 +00:00
vadimt
6c1331ca42
Improving diags when Launcher is invisible when the test fails
...
Test: presubmit
Bug: 187761685
Change-Id: I69a930ef076dbf6cca5af516228ebe689fac91eb
2021-07-21 18:50:32 -07:00
Android Build Coastguard Worker
4f13ba2029
Snap for 7571196 from eb894b577a to sc-v2-release
...
Change-Id: I8d321b6f05153d53f925ed6422653f52bede4f5a
2021-07-22 01:12:47 +00:00
Android Build Coastguard Worker
bf75ee78b4
Snap for 7571067 from ec4a56a311 to sc-release
...
Change-Id: Idde3c6c7bb739cc5bc6ca2b4bd827c1e674d71aa
2021-07-22 01:09:13 +00:00
Jonathan Miranda
c2a49ee2bc
resolve merge conflicts of 46378eb881 to sc-v2-dev
...
Folder icon polish.
- Increase the overlap between the preview items and the background
so that it appears more intentional (lots of reports of users
thinking that its a bug)
- Fix bug where clip path was still clipping icons when
dragging and swiping to home.
Bug: 194339057
Bug: 193701705
Bug: 191225536
Test: test 2 icon, 3 icon, and 4 icon folders
close folder on 2nd page, ensure clipping
ensure no preview items are clipped in drag view
ensure no preview items are clipped in swipe up to home
test 2x2, 3x3, 4x4, 4x5, and 5x5 grids to ensure no clipping
of folder icons
drag and drop folder in and out of hotseat
create folders (2 icon, 3 icon, 4 icon)
Change-Id: I09ce9ef59e340b1009de3d26eed430a0a8dc4b33
Merged-In: Id49bae33438e10248bef05450d7e2c92c2140748
2021-07-22 00:43:27 +00:00
Jonathan Miranda
b90b473c04
[automerger skipped] Merge "Folder icon polish." into sc-dev am: 46378eb881 am: 076ee3dcfc -s ours
...
am skip reason: Merged-In Id49bae33438e10248bef05450d7e2c92c2140748 with SHA-1 2cc564c647 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15339889
Change-Id: Icc03ef62f6b0b078312b34d9fa97e4d2b5b27ac3
2021-07-22 00:39:36 +00:00
Jonathan Miranda
b6347c9d48
Merge "Folder icon polish." into sc-dev am: 46378eb881
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15339889
Change-Id: If24654967e2ddc5e8672ae00776ef65f322a4c70
2021-07-22 00:35:55 +00:00
Jonathan Miranda
076ee3dcfc
Merge "Folder icon polish." into sc-dev am: 46378eb881
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15339889
Change-Id: Iaa81d36eef4ff3ac2a05583dfd3b39bbd753b6a3
2021-07-22 00:23:01 +00:00
Jonathan Miranda
46378eb881
Merge "Folder icon polish." into sc-dev
2021-07-22 00:15:29 +00:00
TreeHugger Robot
dae4d9f324
Merge "Scale recents during quick switch for large screens." into sc-v2-dev am: eb894b577a am: 07b974c8ad
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15337882
Change-Id: If6103f7dffc06002498dfbccf94b52746d824566
2021-07-21 21:47:02 +00:00
TreeHugger Robot
07b974c8ad
Merge "Scale recents during quick switch for large screens." into sc-v2-dev am: eb894b577a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15337882
Change-Id: Ibbbae9f3bba290209a12e58e864b705e8502266e
2021-07-21 21:41:54 +00:00
TreeHugger Robot
eb894b577a
Merge "Scale recents during quick switch for large screens." into sc-v2-dev
2021-07-21 21:35:12 +00:00
Brian Isganitis
5848ac11de
Support overriding All Apps EDU animation on drag am: ec4a56a311 am: 647f62657c am: 7699d1bd1e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15349065
Change-Id: I4333a46a2653a87c2811803ae38a789633c051d2
2021-07-21 20:35:54 +00:00
Brian Isganitis
c9a62028d2
Support overriding All Apps EDU animation on drag am: ec4a56a311 am: a9b1814d42 am: cfeb463f33
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15349065
Change-Id: I68d6740c0dfe6884f284f1869446c12987b2f65c
2021-07-21 20:35:50 +00:00