Commit Graph

49925 Commits

Author SHA1 Message Date
Pat Manning 1b5975c205 Fix scroll task off screen to support different screen dimensions.
This will fix the breaks on cuttlefish as seen in b/203781041.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: I3b582a9df1790543c4e1521b45494fb462bb5c1c
2021-10-26 18:08:45 +01:00
Sebastian Franco 97503ab4fb Fixing the possibility of opening multiple WidgetsFullSheet
The error is that you can open multiple times the view for
selecting widgets for the Home Screen (i.e. WidgetsFullSheet.java)
but only when using a keyboard by using the command ctrl+w
creating a new instance every time you use it. To fix this
I added a singleton pattern so that only one instance of
WidgetsFullSheet.java can be open at any given point.

Test: Manually Tested
Fix: 196704061
Change-Id: I7a364ee5e746e77455da326a21aff6830ac18e8c
2021-10-26 11:26:21 -05:00
Pablo Gamito 77d3cab287 Set custom task transition spec when taskbar is visible
This is to ensure that the task to task animations look good when the
taskbar is visible (the transition background is the same as the taskbar
color, the taskbar overlay rounded corners are hidden, and the task
animates above the taskbar so it's rounded corners are visible during
the animation and not hidden behind the taskbar).

Test: Open tasks from other tasks to trigger task to task animations and
see if they look good
Bug: 200675009
Bug: 196387647

Change-Id: I8e46718829c0e6541a5c1b1a3a156285aeecd30a
2021-10-26 14:56:27 +02:00
Alina Zaidi 987221a1cc Send widget added and removed events to AiAi.
-Pass the widgets on workspace as an extra List<AppTargetEvents> while
 creating prediction session.
-Notify the session about widget added/removed events after creation.

Bug: 186648032
Test: Manually checked events are received
Change-Id: I4de6c011a1e24c129a3e995ddba16bfc55074939
2021-10-26 12:29:48 +01:00
Tony Wickham 5a2f61da23 Merge "Hide taskbar background when notification shade is expanded" into sc-v2-dev am: add188f339 am: d6123537c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16102657

Change-Id: I68306fb21825ab94cd8aa46b35ffb0e49bc5a6ac
2021-10-26 03:21:00 +00:00
Tony Wickham a222a0d6d9 Merge "Hide taskbar background when notification shade is expanded" into sc-v2-dev am: add188f339
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16102657

Change-Id: I447aca295140455bdba48508baef922bda287721
2021-10-26 03:10:09 +00:00
Tony Wickham d6123537c5 Merge "Hide taskbar background when notification shade is expanded" into sc-v2-dev am: add188f339
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16102657

Change-Id: I6b49aa2008b6cebe4e66ef9a0036863ae47cbbfa
2021-10-26 03:09:37 +00:00
Tony Wickham add188f339 Merge "Hide taskbar background when notification shade is expanded" into sc-v2-dev 2021-10-26 02:56:47 +00:00
sfufa@google.com 467d95cef3 [Test] Introduce tracing to identify why pm create-user is failing
Bug: 203817455
Test: presubmit
Change-Id: Iccfa152bea7a914292d566d6dd3e58eb73c38aa4
2021-10-25 18:56:49 -07:00
TreeHugger Robot 74f7d5e0b8 Merge "Fix the remove button icon not centered when the home screen is in landscape." into sc-v2-dev am: 8935b22cd7 am: 763405dfca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16087348

Change-Id: I29b9912fdf63a922b5cf8904be768c1e481b5e6c
2021-10-26 00:35:36 +00:00
TreeHugger Robot 8b5fe18795 Merge "Fix the remove button icon not centered when the home screen is in landscape." into sc-v2-dev am: 8935b22cd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16087348

Change-Id: I6c7f31d1b5e38d39551dc82410c869a3fd773802
2021-10-26 00:21:24 +00:00
TreeHugger Robot 763405dfca Merge "Fix the remove button icon not centered when the home screen is in landscape." into sc-v2-dev am: 8935b22cd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16087348

Change-Id: I5d4e7cac925a706b45860c6241427c63b2e076bf
2021-10-26 00:20:51 +00:00
TreeHugger Robot 8935b22cd7 Merge "Fix the remove button icon not centered when the home screen is in landscape." into sc-v2-dev 2021-10-26 00:06:37 +00:00
Alex Chau 46306e31b7 Merge "Avoid calling getIconResult if recycle is called after request is queued" into sc-v2-dev am: 4941b84717 am: 2a6e9abf6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16118639

Change-Id: I3fc485432c60f815e7cdbdab428b6bb3ff7543dc
2021-10-25 23:54:49 +00:00
TreeHugger Robot 17f5239620 Merge "Fix launching window bounds for immersive apps" into sc-v2-dev am: c6649763a7 am: d9a4c9b03f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16049085

Change-Id: Ia29cf8a50e9152dbef024b307cb0c2ee5fe0579b
2021-10-25 23:54:42 +00:00
Schneider Victor-tulias 1bda3e7424 Fix overview clear all tasks button text color.
Test: checked button on dark/light mode on a wallpaper similar to bug
Fixes: 203198804
Change-Id: I03e663422d2cdba63f3c5953741b5c0bd722fccf
2021-10-25 16:49:36 -07:00
Alex Chau 8c7ff40062 Merge "Avoid calling getIconResult if recycle is called after request is queued" into sc-v2-dev am: 4941b84717
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16118639

Change-Id: I246fce26863074168012589e6b60c64eb863440e
2021-10-25 23:39:38 +00:00
TreeHugger Robot 2aa0bc0f5d Merge "Fix launching window bounds for immersive apps" into sc-v2-dev am: c6649763a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16049085

Change-Id: I4fbff919b24a13ad948e2d03feff0562c2572db7
2021-10-25 23:39:34 +00:00
Alex Chau 2a6e9abf6a Merge "Avoid calling getIconResult if recycle is called after request is queued" into sc-v2-dev am: 4941b84717
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16118639

Change-Id: Ib777b424001d84513d4ebb4151cc10e815fdf4fc
2021-10-25 23:38:32 +00:00
TreeHugger Robot d9a4c9b03f Merge "Fix launching window bounds for immersive apps" into sc-v2-dev am: c6649763a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16049085

Change-Id: If1a2ff2d40d937ca1813522b544bd3572742b341
2021-10-25 23:38:21 +00:00
Alex Chau 4941b84717 Merge "Avoid calling getIconResult if recycle is called after request is queued" into sc-v2-dev 2021-10-25 23:30:32 +00:00
TreeHugger Robot c6649763a7 Merge "Fix launching window bounds for immersive apps" into sc-v2-dev 2021-10-25 23:20:47 +00:00
Android Build Coastguard Worker 0c2982f5f6 Snap for 7852542 from 39da1f78da to sc-v2-release
Change-Id: I9a419eb0253c433feb4fdd2728f14dda5b433abe
2021-10-25 23:08:06 +00:00
Sebastian Franco 63d1a181e5 Fix the remove button icon not centered when the home screen is in landscape.
To fix it I put the bounds of the Icon/drawable when the text is not visible.

Fix: 202811811
Test: Manually Tested.
Change-Id: Ieff54a73e819c4b3a61e28fd76faf93a84b67666
2021-10-25 17:34:11 -05:00
Tony Wickham 232e9a4631 Hide taskbar background when notification shade is expanded
- In 3 button mode, don't hide the background but do ensure nav buttons are translated down when swiping to notificaitons from the home screen

Test: swipe down notifications, background hides in 0 button mode but not in 3 button mode
Fixes: 199163951
Change-Id: Ic70adc7d67b2ab7c92a2d5d846b9b259d1bd7bfc
2021-10-25 13:44:09 -07:00
Alex Chau 53c7ed5084 Avoid calling getIconResult if recycle is called after request is queued
Fix: 203582251
Test: atest -c NexusLauncherTests:com.android.launcher3.memory.MemoryTests
Change-Id: Ice1e981e1813df516008be578aa89ee17fb79fab
2021-10-25 21:06:27 +01:00
Alex Chau 948d9fb223 Fix TaskView jumping caused by split select am: 39da1f78da am: 6b465023e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16095449

Change-Id: I2c0075c9228de998f8bd97492924663a5c662649
2021-10-25 18:03:00 +00:00
Alex Chau 062e5650fb Fix TaskView jumping caused by split select am: 39da1f78da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16095449

Change-Id: Iae8916945942185f8669520e4634c351c8d9405d
2021-10-25 17:50:00 +00:00
Alex Chau 6b465023e0 Fix TaskView jumping caused by split select am: 39da1f78da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16095449

Change-Id: I26f0067df68088d9aba94ce8f83aa28d0882a468
2021-10-25 17:48:45 +00:00
Alina Zaidi fa37c6742e Make sure distinct widgets items are used when mapping widget component
names to widget items.

This is to prevent a crash on duplicate key when creating map.

Bug: 204065759
Test: Enabled flag and got no crash
Change-Id: Ice9f93af76c02eeba53c934687358ed806c60b60
2021-10-25 16:10:45 +01:00
Alex Chau 39da1f78da Fix TaskView jumping caused by split select
- Never apply split select translation to grid overview, instead use dismiss translation to make space to split placeholder to minimize motion and avoid janky double movement
- Ensures snapping to last task for end of grid split cases
- Adjust mCurrentPageScrollDiff due to coordinate shift
- Use longGridRowWidthDiff to shift all task to make space for split placeholder
- Also fixed a bug that split translation isn't reset if entering overview immediately after exit

Bug: 200537815
Test: manual
Change-Id: Ie1b57c34ce4bb079f898ba5b7c3464a714021847
2021-10-25 15:38:34 +01:00
Alex Chau 920be89b26 Clean up IllegalStateException for page pairing
Fix: 198820019
Test: manual
Change-Id: Ic691f781b20d664c57a26370aae479ab68508303
2021-10-25 15:20:16 +01:00
Benno Lin 5261776d3a Update TAPL to operate on folder icons.
The change updates features listed as follow:

1. Create a new class for folder icon.
2. Implement function to drag a icon to the other.
   (create a folder)
3. Find folders in a workspace.

Bug: 199120092
Test: Launcher3Tests:com.android.launcher3.ui.TaplTestsLauncher3#testDragToFolder
Change-Id: I3044025f8297f6e442446d70238f4b56f38a798a
2021-10-25 11:08:44 +00:00
Bill Lin 2745327c5e Allow One-handed gesture when densityDpi > 600
This logic was aim to prevent tablet device enable One-handed gesture
so added displayInfo.densityDpi < DisplayMetrics.DENSITY_600 before.

However, it seems this densityDpi=600 does not able to represent to
tablet device, instead we already have system property
"ro.support_one_handed_mode" which provides feasibility to config false
on tablet project, as the reason we can safe to remove this condition.

Bug: 203936659
Test: adb shell wm density 600 , and observe OHM gesture is available
Test: atest WMShellUnitTests
Change-Id: Ic7ae10e8a47d26b9bb39ab80e22d591d74f89ae5
2021-10-25 06:47:13 +00:00
Android Build Coastguard Worker 0e5eb5cb7e Snap for 7848193 from 85da1db1aa to sc-v2-release
Change-Id: I3665284533cbbad35026e11fecba5bb78d951bcc
2021-10-23 01:08:10 +00:00
Alex Chau 309e21844b Add back @Ignore for testOverviewForTablet
The @Igonore is latest lost due to auto-merger.

Test: TaplTestQuickstep.java
Bug: 203781041
Change-Id: Ifb9fa9ef74f9da4ac0630338c1fe374280102c94
2021-10-22 09:44:52 +00:00
TreeHugger Robot a1fc0d9699 Merge "Import translations. DO NOT MERGE ANYWHERE" 2021-10-22 05:17:58 +00:00
TreeHugger Robot 7b137b101c Merge "Import translations. DO NOT MERGE ANYWHERE" 2021-10-22 02:27:00 +00:00
Bill Yi ac3b8de879 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: f2e186c6df -s ours am: 91c07c1875 -s ours am: e4a0f112a9 -s ours am: 810cd5ef2b -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097527

Change-Id: I2bebc91c6bab3ff0d12383ac3cfb4269df14afb3
2021-10-22 02:20:46 +00:00
Bill Yi 810cd5ef2b [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: f2e186c6df -s ours am: 91c07c1875 -s ours am: e4a0f112a9 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097527

Change-Id: I49dfa31211682ae9f43c64686bfe27b1cd63e944
2021-10-22 02:01:37 +00:00
TreeHugger Robot 4a3ddf78cc Merge changes from topic "presubmit-am-cb4679fd6eb1414cb720168b20bbb591" into sc-qpr1-dev am: f409849bc4 am: 85da1db1aa am: 8ac8f535bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097527

Change-Id: Ib82837d41b0d80ca317888d2a8bba2efc5e366a9
2021-10-22 01:59:12 +00:00
Bill Yi 0aaff8a907 [automerger skipped] [automerged blank] Import translations. DO NOT MERGE ANYWHERE 2p: f2e186c6df am: a72c102031 -s ours am: 7bb30c848f -s ours am: 36cbb2657b -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097527

Change-Id: Id745f661d36c30cdccce99a60b4ca6ef576911bf
2021-10-22 01:59:12 +00:00
TreeHugger Robot bce400cd88 Merge changes from topic "presubmit-am-cb4679fd6eb1414cb720168b20bbb591" into sc-qpr1-dev am: f409849bc4 am: 45066a9fca am: 2088ca567d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097527

Change-Id: If0c28cae892cd73be6a9d2e8996f0fb294b193cf
2021-10-22 01:58:41 +00:00
Bill Yi 1d759f1fc6 [automerger skipped] [automerged blank] Import translations. DO NOT MERGE ANYWHERE 2p: f2e186c6df am: a72c102031 -s ours am: 0bcb9d1ebc -s ours am: f7d1ff7ff2 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097527

Change-Id: I1a6b45aa92d42e34acfd46fdf14dc7a9089cd67a
2021-10-22 01:58:41 +00:00
Bill Yi a3c25df5ec [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: dda2a04183 -s ours am: a69d7317fc -s ours am: a770674274 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097528

Change-Id: Iaa61c1f0cf0fb56574006cefc209575f41b84406
2021-10-22 01:58:16 +00:00
Bill Yi e09b3dd843 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: dda2a04183 -s ours am: cabc741d2a -s ours am: b7459a7f5f -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097528

Change-Id: I35779f7734f5c2bb3934e1675044456d7af4820d
2021-10-22 01:57:59 +00:00
Bill Yi d0dcd6d194 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: f2e186c6df -s ours am: 63021191d6 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097527

Change-Id: I3b253dc5bd0289badfa1dc3193d66064978c29d9
2021-10-22 01:50:34 +00:00
Bill Yi e4a0f112a9 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: f2e186c6df -s ours am: 91c07c1875 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097527

Change-Id: Ie254c7af34b7db84f1858680f4fe5297b46b67e6
2021-10-22 01:50:31 +00:00
TreeHugger Robot 5647d9f39b Merge changes from topic "presubmit-am-cb4679fd6eb1414cb720168b20bbb591" into sc-qpr1-dev am: f409849bc4 am: 85da1db1aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097527

Change-Id: I98e18faab5c397dd208e83dd1df9135c36418dc3
2021-10-22 01:46:07 +00:00
Bill Yi cc2a629ee0 [automerger skipped] [automerged blank] Import translations. DO NOT MERGE ANYWHERE 2p: f2e186c6df am: a72c102031 -s ours am: 7bb30c848f -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16097527

Change-Id: I74e675d1d0611dcbcf6babed48a7af80ea0997a4
2021-10-22 01:46:06 +00:00