Commit Graph

4959 Commits

Author SHA1 Message Date
TreeHugger Robot 67d79af886 Merge "Unifying scroll calculation logic for both widgets and apps recycler view Also using itemType instead of item object for widget size cache" into tm-qpr-dev am: 5069964ea2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18763224

Change-Id: Ief18fa0a43fd0c01685109ef26f37d32af1c200b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-22 03:35:36 +00:00
TreeHugger Robot 5069964ea2 Merge "Unifying scroll calculation logic for both widgets and apps recycler view Also using itemType instead of item object for widget size cache" into tm-qpr-dev 2022-06-22 03:23:07 +00:00
Sunny Goyal bbad97e273 Unifying scroll calculation logic for both widgets and apps recycler view
Also using itemType instead of item object for widget size cache

Bug: 234008165
Test: Verified on device
Change-Id: Ia4b4a00a11627c0c454e4a699570e8ab1667a390
2022-06-16 16:03:37 -07:00
Bill Yi b5b0870455 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7f6161ae95861d6249bf51f515c783513df7fb0f
2022-06-11 15:06:05 -07:00
Andy Wickham bbd4414e0a Merge "Fixes Search bar padding when work profile not present." into tm-dev am: 34e8c3364a am: ef4136ad4e am: aade3dc637
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18789522

Change-Id: I798dfe4c9257f81a9f0bca392fa44db01ed670f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-10 20:05:51 +00:00
Andy Wickham aade3dc637 Merge "Fixes Search bar padding when work profile not present." into tm-dev am: 34e8c3364a am: ef4136ad4e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18789522

Change-Id: I2db55aaab2e0ad4ad8b2f3388f0cc7fe404a2aec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-10 19:41:29 +00:00
Andy Wickham 34e8c3364a Merge "Fixes Search bar padding when work profile not present." into tm-dev 2022-06-10 17:07:43 +00:00
Brian Isganitis e69783e586 Merge "Update download app icon treatment to latest mocks." into tm-qpr-dev am: 4aab0fdafc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18590244

Change-Id: Iede7db9a14b7f06f54609960bc44ccf68cca662f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 23:03:07 +00:00
Brian Isganitis 4aab0fdafc Merge "Update download app icon treatment to latest mocks." into tm-qpr-dev 2022-06-09 22:44:10 +00:00
Bill Yi 13d38f34e3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I4010e9fb1b609b0bfb001f333b3e0c15f2f9de81
2022-06-09 13:47:10 -07:00
Andy Wickham 5a476da75c Fixes Search bar padding when work profile not present.
The full padding was accounted for between the search bar and the
work/personal tabs, but only part of it was there when the tabs
were not shown.

Screenshot: https://screenshot.googleplex.com/8axV9QQ5Qy8MaUn.png

Test: Manually with and without work profile added. In the latter
case, nothing changed. The screenshot reflects the former case.
Fix: 233010483

Change-Id: I11b3c8cc814be48c25cbd9f454c3e122fff96fa0
2022-06-08 13:32:41 -07:00
Bill Yi b01161606f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ibc4e348adb39b393690be0b1a1ecd341a58a5542
2022-06-07 13:56:51 -07:00
Brandon Dayauon 3232df8ec3 Merge "Fix issue where allAppsCellWidth is 0" into tm-qpr-dev am: e9b40bec24
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18763968

Change-Id: Id6526eb9dea28aa2d764511c26d0edde3dbd5233
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-07 19:10:21 +00:00
Brandon Dayauon e9b40bec24 Merge "Fix issue where allAppsCellWidth is 0" into tm-qpr-dev 2022-06-07 18:49:46 +00:00
Brandon Dayauon 7a8a9ed170 Fix issue where allAppsCellWidth is 0
when using secondary display on non-scalable grids causing allApps to be squished.
Bug: 234748862
Test: Manual

Change-Id: I2e92bce69438a17eccb0e4b2b2e3f2bdbfa7600e
2022-06-06 14:32:22 -07:00
Brian Isganitis cd7cc294b8 Update download app icon treatment to latest mocks.
Demo: https://screenshot.googleplex.com/BfTvY2EaByJXwdw.png
Test: Manually using "start install session helper" in SupportApp.
Fix: 205714358
Change-Id: I3ec2fb776cbad974ae36f34b29f3081b3d073c83
2022-06-02 11:53:47 -07:00
TreeHugger Robot 5437b2f038 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-06-02 04:23:47 +00:00
James O'Leary 76066e8cc8 Merge "Revert "Update app icon shadows"" into tm-dev am: 202ac414bf am: b2919ce557 am: 0ac64cba0f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18675016

Change-Id: I0be9ca0b4e85b084f1f24696d3efbc6759ce0e7f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 02:24:05 +00:00
James O'Leary 0ac64cba0f Merge "Revert "Update app icon shadows"" into tm-dev am: 202ac414bf am: b2919ce557
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18675016

Change-Id: I9f92216f1db5331b450b750855213cc9fd642335
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 01:52:33 +00:00
James O'Leary b2919ce557 Merge "Revert "Update app icon shadows"" into tm-dev am: 202ac414bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18675016

Change-Id: I98e3165ccc5e02228020e4c45386045c4cf1df12
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 01:34:00 +00:00
James O'Leary 202ac414bf Merge "Revert "Update app icon shadows"" into tm-dev 2022-06-01 01:29:34 +00:00
James O'Leary dac75aef3b Revert "Update app icon shadows"
Revert submission 17935777-lightDarkDetection

Reason for revert: Talked with Adam Cohen, white shadows are controverstial and we'd need to escalate to senior UX if we want to ship. James would rather do it in U timeframe, will flag to UXers we work with that the opportunity to escalate is available if needed.
Reverted Changes:
Ia91221427:Update light/dark detection.
Ie12d3d054:Update app icon shadows
Icc88c3496:Update smartspace shadow

Change-Id: I8bc90e79073b8e088f2912fef2af4c6c99a33553
2022-05-31 21:12:38 +00:00
Bill Yi 3b8026fd1d Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ide677bcf0bab99f44d6e06c7f7bed2f3404e5c58
2022-05-31 08:46:54 -07:00
James O'Leary 5f4db0ffe8 Merge "Update app icon shadows" into tm-dev am: 2b6700a94c am: 5131a1a203 am: ef64789d0a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17937870

Change-Id: I9329e4b84ddc480029285485f48f98cc2182dd0e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 20:35:28 +00:00
James O'Leary ef64789d0a Merge "Update app icon shadows" into tm-dev am: 2b6700a94c am: 5131a1a203
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17937870

Change-Id: I16cb7b30a5219d196427bedbbe0c3adbb66c1360
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 20:29:31 +00:00
James O'Leary 5131a1a203 Merge "Update app icon shadows" into tm-dev am: 2b6700a94c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17937870

Change-Id: Ie4eaa9e8cd699849487bfe99bb37eeab10dcce40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 20:05:31 +00:00
James O'Leary 2b6700a94c Merge "Update app icon shadows" into tm-dev 2022-05-27 19:44:39 +00:00
TreeHugger Robot 731978a0a5 Merge "[conflict] Merge "Moves Search results into a separate RV (take 2)." into tm-dev am: 4ca247a6bb am: 15dc59f8b1" into tm-qpr-dev am: a7b4152e90
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18624669

Change-Id: Ib4926dde7f34e27029b868663cb441641ef53b64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 02:36:47 +00:00
Andy Wickham a1ec03bdfe [conflict] Merge "Moves Search results into a separate RV (take 2)." into tm-dev am: 4ca247a6bb am: 15dc59f8b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18420827

Change-Id: Ic7e380e21342011afcbd1ada0eb453dc83eff4be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 23:31:31 +00:00
Andy Wickham 15dc59f8b1 Merge "Moves Search results into a separate RV (take 2)." into tm-dev am: 4ca247a6bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18420827

Change-Id: Ibcc128ec5f74a96978e0c65af79283997ac1db50
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 22:00:44 +00:00
Andy Wickham 4ca247a6bb Merge "Moves Search results into a separate RV (take 2)." into tm-dev 2022-05-26 21:41:55 +00:00
TreeHugger Robot 7e31517a2d Merge "Allows work apps to be dragged down while work edu is showing." into tm-dev am: c907fd0a17 am: 1bdcde8920 am: e3bbcaa7de
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18605850

Change-Id: I260bdee92c7c8a38427efce79ade969151f1f0c6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 03:03:41 +00:00
TreeHugger Robot 51d3cd635a Merge "Allows work apps to be dragged down while work edu is showing." into tm-dev am: c907fd0a17 am: bf3e735e9e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18605850

Change-Id: I501f98722998c9372b12aa7cf618a6ca14f659b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 02:53:45 +00:00
TreeHugger Robot e3bbcaa7de Merge "Allows work apps to be dragged down while work edu is showing." into tm-dev am: c907fd0a17 am: 1bdcde8920
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18605850

Change-Id: I8b7274d6a7cedfbf617a1f2d40236c497c4f614c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 02:40:30 +00:00
TreeHugger Robot bf3e735e9e Merge "Allows work apps to be dragged down while work edu is showing." into tm-dev am: c907fd0a17
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18605850

Change-Id: I8f5648da9e85f10219e93803d7d6f5f5e8124a51
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 02:21:49 +00:00
TreeHugger Robot 1bdcde8920 Merge "Allows work apps to be dragged down while work edu is showing." into tm-dev am: c907fd0a17
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18605850

Change-Id: Ic20dc9a52263e4892c2731f364eedbe90d10b3ab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 02:11:40 +00:00
TreeHugger Robot c907fd0a17 Merge "Allows work apps to be dragged down while work edu is showing." into tm-dev 2022-05-26 00:06:08 +00:00
Andy Wickham ff3721fe96 Allows work apps to be dragged down while work edu is showing.
Also fixes jumpiness of the personal/work tabs while scrolling
with this card showing.

Cause: AllAppsRecyclerView#getCurrentScrollY() calculates the
current scroll based on the top of the first item in the view.
This is used to determine if pulling down should move the
container (if you are scrolled to the top), and it is also used
to align the personal/work tabs as you scroll down (they stop
moving when the top item reaches their bottom).

Fix: The top of the Work Edu card was lower than the top of the
recycler view because it was offset by a top margin. Switching
this to padding in the card's container fixes the associated
calculations while keeping the visual positioning from before.

Fix: 233836148
Test: Manually tried dragging down and scrolling. Tried it with
and without my refactor.

Change-Id: Idaf4b3801174c1dfeceda5c0f112e405908e856d
2022-05-25 14:55:39 -07:00
Bill Yi 06d2238892 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev 2022-05-25 18:43:37 +00:00
Alex Chau ea9554cd21 Merge "Center drop target button alignment across devices" into tm-dev am: 179c289a6c am: 7ca1b38d7e am: 6329b20f43
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580267

Change-Id: Id121a4eb31fda98107b3c622c907c105c288d0ef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 13:39:28 +00:00
Alex Chau b21fcdd423 Merge "Center drop target button alignment across devices" into tm-dev am: 179c289a6c am: 7ca1b38d7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580267

Change-Id: Ia3de7157c7230c0a892a2052fda7af614ddd4db1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 13:24:04 +00:00
Alex Chau 6329b20f43 Merge "Center drop target button alignment across devices" into tm-dev am: 179c289a6c am: 7ca1b38d7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580267

Change-Id: I57dd855387257a8704f8529f14ea176562e63549
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 13:24:02 +00:00
Alex Chau d740490fe4 Merge "Center drop target button alignment across devices" into tm-dev am: 179c289a6c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580267

Change-Id: I38e2fe0b317980661df1e7ee67b3a08cf440eb42
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 13:03:30 +00:00
Alex Chau 179c289a6c Merge "Center drop target button alignment across devices" into tm-dev 2022-05-25 12:38:11 +00:00
Andy Wickham 2ba7797edb Moves Search results into a separate RV (take 2).
Bug: 206905515
Test: Manually verified b/230648542 did not resurface. Tested
on phone and tablet with and without work profile.

Change-Id: If724f635286b9dff2c64255f9ece3568a5cb4ea9
2022-05-24 17:10:24 -07:00
Bill Yi 16026ae9f9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1d33db6f290ae068d29aea6a405cd0436c3d5341
2022-05-24 14:51:03 -07:00
Stefan Andonian 8fbdf9ba18 Merge "Fix folder app icon truncation after rotating to landscape." into tm-dev am: af8b7d3313 am: 2e8f2e192b am: 058c88bfce
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18090271

Change-Id: I1903181928efcf03cf27d70009957aa16e3a67b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 19:00:13 +00:00
Stefan Andonian 506456cc7a Merge "Fix folder app icon truncation after rotating to landscape." into tm-dev am: af8b7d3313 am: 2e8f2e192b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18090271

Change-Id: I880515e684db4389c5ed0848c12d8c10e0229e8e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:35:14 +00:00
Stefan Andonian 058c88bfce Merge "Fix folder app icon truncation after rotating to landscape." into tm-dev am: af8b7d3313 am: 2e8f2e192b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18090271

Change-Id: I30e4c6c0884721519ecf5167f0b8c6aa68c18911
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:34:30 +00:00
Stefan Andonian e0770eb4fd Merge "Fix folder app icon truncation after rotating to landscape." into tm-dev am: af8b7d3313
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18090271

Change-Id: I22de25f8e8d439eb5e18c96b0036f66caa5bd8aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:23:45 +00:00