Vinit Nayak
837359b1ea
Set correct divider dimension for task menu options
...
Previously divider drawable dimension was set on height,
which only works when things are divided vertically.
For horizontal layouts, we need to set divider width.
Bug: 192398954
Test: Tested portrait + fake/real landscape
+ tablet
Change-Id: I5a63df9749bf37c3a563e923a1b4724aa17d9409
2021-07-01 02:05:42 +00:00
Tracy Zhou
89f8d0763d
Merge "[Live Tile] App surface is above launcher even after reaching Overview" into sc-v2-dev am: d25ee3294c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15158868
Change-Id: Ic6dfce00e0b80adaa26da23b05363578ada8689a
2021-07-01 01:22:10 +00:00
Tracy Zhou
d25ee3294c
Merge "[Live Tile] App surface is above launcher even after reaching Overview" into sc-v2-dev
2021-07-01 01:11:11 +00:00
Jon Miranda
17cc821c28
Fix bug where app icon is gone for first frame on cold start.
...
We need the icon to be full alpha during the init pass, then when
the actual animation starts, we can swap the icon with the window
(splash screen that draws the icon).
Bug: 192366079
Test: slow down window animations
check no empty frame on cold start app launch
check no empty frame on warm start app launch
Change-Id: I16a1779e5252d8e88bc3c408e1dc40b264fe4cf4
2021-07-01 00:11:41 +00:00
Hongwei Wang
4b38eb6f95
Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev am: 005e269220 am: c3a9f0e75b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15132509
Change-Id: Id3d94c0000cd8738475213b21435dfe306b13feb
2021-06-30 20:52:44 +00:00
Hongwei Wang
52df9c8580
Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev am: 005e269220
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15132509
Change-Id: I0fa466ab04f93a9d6f1f6ab15658a1d10f968fa4
2021-06-30 20:41:42 +00:00
Hongwei Wang
c3a9f0e75b
Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev am: 005e269220
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15132509
Change-Id: Id256786bd820ea5f01174c136fc992fc2cd82999
2021-06-30 20:35:28 +00:00
Hongwei Wang
005e269220
Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev
2021-06-30 20:23:23 +00:00
Sunny Goyal
25f386edc8
Fixing some dimentions in AllSet activity
...
Bug: 192412172
Test: Manual
Change-Id: I599c858fc21d45dd41eaa01ff3d91863d52f6ae8
2021-06-30 12:19:30 -07:00
Winson Chung
a7d7f78c08
Defer cleaning up screenshot until after we actually switch to screenshot
...
- In the case where we get a screenshot on cancel, we should wait to
finish the recents animation until the view gets a chance to update
Bug: 185643608
Test: Swipe up to overview in 2 button, hit home
Change-Id: I2ac3567006f6fa7e6f473499f6862e5e408dfc3d
2021-06-30 12:03:33 -07:00
Yogisha Dixit
8235d49e74
Merge "Log widgets source." into sc-dev am: f9acf1d5d4 am: 669bac8bd6
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879
Change-Id: I5b2fe5baebd5f38e897412523f3920ff22054247
2021-06-30 18:47:29 +00:00
Yogisha Dixit
ba28286260
Merge "Log widgets source." into sc-dev am: f9acf1d5d4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879
Change-Id: I2fa39b66ca31549f7754657b7d3bde6bdf8a5f59
2021-06-30 18:33:44 +00:00
Yogisha Dixit
669bac8bd6
Merge "Log widgets source." into sc-dev am: f9acf1d5d4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879
Change-Id: Ib47b6d3aaacaa30c723dafeeb65492510a150eb2
2021-06-30 18:32:53 +00:00
Yogisha Dixit
f9acf1d5d4
Merge "Log widgets source." into sc-dev
2021-06-30 18:18:12 +00:00
Yogisha Dixit
658c5dafd4
Log widgets source.
...
Test: manual
(1) Upgrading to new DB version is successful (no errors thrown in logcat)
(2) Widgets that were added with the old DB version have CONTAINER_UNKNOWN as their source container
(3) Widgets that are added with the new DB version still log source container after reboot
Bug: 185778648
Change-Id: Iaa38f0be6bc4cb0d29842f9a2ea0d08de000c930
2021-06-30 17:48:14 +00:00
Vinit Nayak
0a708332b8
Merge "Take margin insets into account when setting position" into sc-dev am: 0f3053ceae am: 0a740a074a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15152173
Change-Id: If8a9fc5ddb10538c008181e71e78cd990c1cb644
2021-06-30 17:34:42 +00:00
Yogisha Dixit
9d096bb34c
Merge "Log widget features to new features field." into sc-dev am: f91abaa6f9 am: 1e143f2c6b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15133002
Change-Id: Ib396bb1b4afc661f0df417107c3da6344cc5268c
2021-06-30 17:34:34 +00:00
Tracy Zhou
e9e5e51d73
[Live Tile] App surface is above launcher even after reaching Overview
...
Currently we place app surface below launcher and punch a hole through task view to display live tile in overview. In this change the order will be flipped, with a few benefits not limited to the following. For example, we have a surface view lifecycle bug where the surface view in a live tile app can go blank during app launch transition. This change will significantly mitigate the issue visually as the background wallpaper will not be revealed.
In order to make sure visually everything still looks the same, we will need to finish the recents animation when the user taps on the task view icon, since the menu overlaps with the task snapshort view.
This change also addresses fading out the task view when it's getting dismissed.
Test: manual
Fixes: 186531762
Fixes: 189265196
Change-Id: Ieae67fb89b60136fd81ceb8abde1a0cab8718b27
2021-06-30 17:34:13 +00:00
Vinit Nayak
0a740a074a
Merge "Take margin insets into account when setting position" into sc-dev am: 0f3053ceae
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15152173
Change-Id: Ib3639aeb91dabbb4283d21e3e6cb6da69af08d23
2021-06-30 17:34:03 +00:00
Cyrus Boadway
8cf91e4bcc
Merge "Defer onColorsChanged updates during widget-to-home animation" into sc-dev am: 1edaed8790 am: f5f23ba119
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147896
Change-Id: Ibea99f93bd4047de977566282d3fe567e62cfdc3
2021-06-30 17:33:22 +00:00
Vinit Nayak
7f5fa6d1e6
Merge "Take margin insets into account when setting position" into sc-dev am: 0f3053ceae
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15152173
Change-Id: Ic1ce3fbd0e68848a7095f3408d877117b0678adb
2021-06-30 17:32:59 +00:00
Vinit Nayak
0f3053ceae
Merge "Take margin insets into account when setting position" into sc-dev
2021-06-30 17:29:44 +00:00
Yogisha Dixit
1e143f2c6b
Merge "Log widget features to new features field." into sc-dev am: f91abaa6f9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15133002
Change-Id: Ib0e8d40b2b09d1b090f7968cce73fbafde5534c2
2021-06-30 17:28:34 +00:00
Yogisha Dixit
aacc518984
Merge "Log widget features to new features field." into sc-dev am: f91abaa6f9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15133002
Change-Id: Ia2f5626249f63f7d6aa28b7646e0cbb230bb7ce8
2021-06-30 17:26:59 +00:00
Yogisha Dixit
f91abaa6f9
Merge "Log widget features to new features field." into sc-dev
2021-06-30 17:25:46 +00:00
Cyrus Boadway
f5f23ba119
Merge "Defer onColorsChanged updates during widget-to-home animation" into sc-dev am: 1edaed8790
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147896
Change-Id: I93c3c42dc173182c7625dea719bbc540a544234a
2021-06-30 17:24:57 +00:00
Cyrus Boadway
239e0b5408
Merge "Defer onColorsChanged updates during widget-to-home animation" into sc-dev am: 1edaed8790
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147896
Change-Id: I99610b251d570b96e29dec44a3b918e413ec0918
2021-06-30 17:24:03 +00:00
Cyrus Boadway
9d609707c1
Merge "Defer onColorsChanged updates during widget-to-home animation" into sc-dev am: 1edaed8790
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147896
Change-Id: I9849c410aa7058ff3dc7f922c0b630c8230d3fd2
2021-06-30 17:23:56 +00:00
Cyrus Boadway
1edaed8790
Merge "Defer onColorsChanged updates during widget-to-home animation" into sc-dev
2021-06-30 17:14:57 +00:00
Bill Yi
9b578cbd52
Merge "Import translations. DO NOT MERGE ANYWHERE"
2021-06-30 16:26:34 +00:00
Tony Wickham
69e6340c91
Merge "Fully null check mRecentsAnimationController" into sc-dev am: d61f224570 am: 4eacef2e1b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147296
Change-Id: Ia7c8b6feadc756c24b7f877111e60da565097920
2021-06-30 15:09:01 +00:00
TreeHugger Robot
814d644d81
Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev
2021-06-30 15:08:32 +00:00
Tony Wickham
c6192426a0
Merge "Fully null check mRecentsAnimationController" into sc-dev am: d61f224570 am: 597943985f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147296
Change-Id: Ic9a36bc25a01d9ef5832918c9898a362fa1bf6c5
2021-06-30 15:07:00 +00:00
Tony Wickham
2067c978a2
Merge "Fully null check mRecentsAnimationController" into sc-dev am: d61f224570
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147296
Change-Id: I70839338c0e4d9e5b20a4ed41b0341fddc0979a3
2021-06-30 15:00:48 +00:00
Tony Wickham
597943985f
Merge "Fully null check mRecentsAnimationController" into sc-dev am: d61f224570
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147296
Change-Id: I88d51d664b00ec21145281782612045fc6297663
2021-06-30 14:54:49 +00:00
Tony Wickham
4eacef2e1b
Merge "Fully null check mRecentsAnimationController" into sc-dev am: d61f224570
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147296
Change-Id: Ie6cdb362ed480068fc1793ee454c3a3648a64061
2021-06-30 14:53:54 +00:00
TreeHugger Robot
bc4a01ee59
Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev
2021-06-30 14:46:04 +00:00
Tony Wickham
d61f224570
Merge "Fully null check mRecentsAnimationController" into sc-dev
2021-06-30 14:35:03 +00:00
Yogisha Dixit
4c3259a0eb
Log widget features to new features field.
...
Bug: 185778648, 187734511
Test: manual
Change-Id: Ifa5d88602e4fccce153b207b2d57d10d13f33dc9
2021-06-30 14:14:55 +00:00
Cyrus Boadway
0d96baec13
Defer onColorsChanged updates during widget-to-home animation
...
Color change updates recreate the view, which can interfere with the
widget-to-home return animation, specifically the GhostView's use of the
AppWidgetHostView's render node.
Deferring the application of color changes until the end of the
animation allows the widget to settle and remove the GhostView before a
color change might recreate the widget's view.
Bug: 190818220
Test: manual
Change-Id: I6552e583ebb0e4810077d4e70fe9ecb07fd5d01a
2021-06-30 13:10:02 +00:00
Alex Chau
930d85fe0f
Merge "Snap to relative position to snappd task when dismissing" into sc-v2-dev am: f35a887446 am: fa8f4be314
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15142494
Change-Id: I1c1a07020d48c77d309fe947e3717e912a447ac4
2021-06-30 10:51:37 +00:00
Alex Chau
fa8f4be314
Merge "Snap to relative position to snappd task when dismissing" into sc-v2-dev am: f35a887446
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15142494
Change-Id: Icc1f598eb8a39f788c87b61dc99d4c7a12e07ef3
2021-06-30 10:36:33 +00:00
Alex Chau
f35a887446
Merge "Snap to relative position to snappd task when dismissing" into sc-v2-dev
2021-06-30 10:24:11 +00:00
Bill Yi
d76d479169
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: I56634b7bcddaa88b9bbb874a54bc003d821f4090
2021-06-30 08:20:43 +00:00
Bill Yi
f0353b5a9a
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: I1fae17d8a50cccf65bb432eef39ac7cbc77f5fd8
2021-06-30 08:17:46 +00:00
Bill Yi
a77f3a3096
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: Ie7f978c5858b3280e706d0e65d31505f5be4bb2f
2021-06-30 08:17:13 +00:00
Vinit Nayak
4ce773962e
Take margin insets into account when setting position
...
Previously we computed insets for task menu position
whenever a Task was told that orientation had changed.
This missed a path for the TaskMenuView's onScrollChanged()
listener, which also calls set position and wasn't taking
the insets into account.
Moved the inset into setPosition() directly so it's caught
on all code paths.
Also noticed 2 bugs where
* We were calling updateChildTaskOrientation() twice, it
already happens in the call to updateOrientationHandler()
* We were directly modifying insets from the activity's
drag layer instead of copying those insets to another rect
and then modifying (this is no longer an issue since we
are not touching those insets at all anymore)
Bug: 192400086
Test: Rotated w/ task menu open for fake and real
landscape. Nothing seems broken.
Note real landscape hides the menu whereas fake one
shows it (which was behavior before this change)
Change-Id: I613dac9519220f49285655ef11a1f72e4a6d31bd
2021-06-30 06:23:38 +00:00
Sunny Goyal
c78573cd00
Merge "AllSet page fixes" into sc-dev am: 50f43df36e am: ae7ef2d5c1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147340
Change-Id: I3892a50bfedebf111876056b3720729086434941
2021-06-30 04:57:16 +00:00
Sunny Goyal
ec0dc1daf4
Merge "AllSet page fixes" into sc-dev am: 50f43df36e am: 9227721d72
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147340
Change-Id: I8a0d3ed75797454b244df9b6b6650d1a27c06afd
2021-06-30 04:56:44 +00:00
Sunny Goyal
ae7ef2d5c1
Merge "AllSet page fixes" into sc-dev am: 50f43df36e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147340
Change-Id: I7a000e357abf704bceea0bedca3407439ca50206
2021-06-30 04:42:29 +00:00