Commit Graph

10816 Commits

Author SHA1 Message Date
Jonathan Miranda 1a1cc95c8f Merge "Significantly reduce gesture feedback when swiping up to home screen." into sc-v2-dev am: e2455aa1cf am: 5940915502
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15898541

Change-Id: I3d13ae1415abf495cafba6697ca4c04ed3e5f59f
2021-09-23 23:34:05 +00:00
Andy Wickham 824e343604 Merge "Makes All Set layout more responsive." into sc-v2-dev am: 768e686466 am: 022c60fe05
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15890763

Change-Id: I9f900c7e607cb51bd942b517e60ff12502cf97c7
2021-09-23 23:33:52 +00:00
Tony Wickham 2424f1f3b5 Fix right split screen app going to wrong target
- applyWindowToHomeRotation() to both Matrix's individually
- Move matrix.postTranslate(mSplitOffset) into applyWindowToHomeRotation so it applies both during swipe up and animation to home

Test: Swipe up from vertical and horizontal split screen, ensure both app windows go towards the same target
Fixes: 200817624
Change-Id: I5769da2adb1abb967fa465fc8371b5c9484a32d0
2021-09-23 16:24:21 -07:00
Jonathan Miranda 5940915502 Merge "Significantly reduce gesture feedback when swiping up to home screen." into sc-v2-dev am: e2455aa1cf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15898541

Change-Id: I99e6980287c57e2e308463037c4900e56577fe03
2021-09-23 23:23:50 +00:00
Andy Wickham 022c60fe05 Merge "Makes All Set layout more responsive." into sc-v2-dev am: 768e686466
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15890763

Change-Id: I80dd8dce0d591b971c963f14cbdba128033048be
2021-09-23 23:23:44 +00:00
Jonathan Miranda e2455aa1cf Merge "Significantly reduce gesture feedback when swiping up to home screen." into sc-v2-dev 2021-09-23 23:14:50 +00:00
Andy Wickham 768e686466 Merge "Makes All Set layout more responsive." into sc-v2-dev 2021-09-23 23:12:44 +00:00
Andy Wickham 13c3f31a0d Makes All Set layout more responsive.
- No longer forced portrait mode
 - Bottom texts are aligned proportionally to the screen height
   to avoid overlapping in landscape folded
 - Subtitle text width is limited to force wrapping to avoid an
   awkward line of text on wider screens

Fix: 189896987
Bug: 187701213
Test: Manually went between portrait/landscape/folded/unfolded.
Change-Id: Ibb2bbe545cf7f154ad77e10d574e72f8d9110a72
2021-09-23 23:11:59 +00:00
Jerry Chang d3ceb3dc88 Reset floating split task view after remote animation finished
Move reseting floating task view for entering split after remote
animation finished to prevent the floating task view disappear before
opening split task view being visible and causing flicker.

Bug: 199377815
Test: Manual check the flicker disappear
Change-Id: I4a864335972842570c61291a7a0c423edeb74578
2021-09-23 16:01:18 -07:00
Vinit Nayak ea7e9a48fd Don't show taskbar when keyguard occluded
* Show only back button in taskbar for 3
button nav.

Fixes: 199406716
Test: From lock screen view home controls
or double-tap camera, no taskbar shown.

Change-Id: Ia603c7dbe584e3fab62365de4fc5a790c48d1340
2021-09-23 15:55:22 -07:00
Vinit Nayak 9299a743af Allow tapping on app icon for second split app.
Fixes: 200851336
Test: Split with one app from overview,
tap on app icon for second app. Gets
selected as second app.

Change-Id: I312169fe7bc42007c2f1a0146a5fef5f8d5f46d6
2021-09-23 14:46:59 -07:00
Jon Miranda 13519e4402 Significantly reduce gesture feedback when swiping up to home screen.
- Uses overscroll damping logic to reduce the velocity
- The start to target rect interpolation can be from the
  start, center, or bottom of the rect depending on where the item
  is on the workspace. This reduces the  amount of distance needed to
  travel between, which helps further reduce gesture feedback.

Bug: 173107751
Test: test closing app that is on:
      -  top row of home screen
      -  middle of home screen
      - in hotseat

Change-Id: I055dd61ca3491807109ff2f6c501bf710c8d340f
2021-09-23 20:13:40 +00:00
Vinit Nayak ab02520ca6 Merge "Shorten and center TaskMenuView for landscape" into sc-v2-dev am: 5dded93a72 am: 870a105b79
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15857414

Change-Id: I144ed5776c8c64e9827309ef732b82ac0db43433
2021-09-23 06:17:04 +00:00
Vinit Nayak 870a105b79 Merge "Shorten and center TaskMenuView for landscape" into sc-v2-dev am: 5dded93a72
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15857414

Change-Id: Iab80cdbf68e75a16b64f4b8e9bae9a8602866cc6
2021-09-23 06:07:37 +00:00
Vinit Nayak 5dded93a72 Merge "Shorten and center TaskMenuView for landscape" into sc-v2-dev 2021-09-23 05:55:17 +00:00
Tony Wickham 4af64f0913 Merge "Allow visual stashing when going to overview in tests" into sc-v2-dev am: d523841ab4 am: 06743b6818
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15889760

Change-Id: If51a0502c0c5c2677c923f5deb596d6d04e3ddbf
2021-09-23 01:03:56 +00:00
Tony Wickham 06743b6818 Merge "Allow visual stashing when going to overview in tests" into sc-v2-dev am: d523841ab4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15889760

Change-Id: Iee408c6091ec44875387ba390d6f9478a0fb4ccd
2021-09-23 00:50:38 +00:00
Tony Wickham d523841ab4 Merge "Allow visual stashing when going to overview in tests" into sc-v2-dev 2021-09-23 00:39:01 +00:00
Vinit Nayak 9e6a642d8b Shorten and center TaskMenuView for landscape
* The width of the task menu view for landscape
(both fake and real) is the same as the width
it would be in portrait.
* With the shorter width, we also center the
positioning of the TaskMenuView
* Note this is only for phone, large screen
changes TODO

Bug: 193432925
Test: Tested real/fake landscape + seascape,
view is centered. Portrait same as before.

Change-Id: Ide41e252a3c177c4a911aab544f78930fed2e76f
2021-09-22 14:55:29 -07:00
Tony Wickham 25b6d9783f Allow visual stashing when going to overview in tests
- Seprate out supportsStashing() into supportsVisualStashing() and supportsManualStashing().
- Manual stashing is when user explicitly long presses to stash, which we disable for tests.

Test: testStressSwipeToOverview
Fixes: 200273854
Change-Id: Ib07efa31a1b073de45fdcfac26215129b1b1985b
2021-09-22 13:58:10 -07:00
Schneider Victor-tulias b2339e37d7 Fix stalled gesture navigation tutorial.
Touching the screen after completing the gesture removed all callbacks, preventing the tutorial to progess. Added logic to only remove logic if the gesture is incomplete.

Fixes: 198285152
Test: manual, touched screen and attempted all gestures after completing a step
Change-Id: I320b13cd9b7632a9fb722bc10d3d0a96dc111144
2021-09-22 12:04:24 -07:00
Jonathan Miranda 47bd7aeb3a Merge "Play window close animation to home for most app to launcher scenarios" into sc-v2-dev am: e37b51b30f am: 739afa1bec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15741392

Change-Id: I156b5694002f5c5c299b84d019f70c53536c00b0
2021-09-22 18:58:39 +00:00
Jonathan Miranda 739afa1bec Merge "Play window close animation to home for most app to launcher scenarios" into sc-v2-dev am: e37b51b30f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15741392

Change-Id: I95b22ad6b05fb86707aff017eb11fca3af9f9c7d
2021-09-22 18:38:32 +00:00
Jonathan Miranda e37b51b30f Merge "Play window close animation to home for most app to launcher scenarios" into sc-v2-dev 2021-09-22 18:26:44 +00:00
Vinit Nayak 307614c70a Merge "Show distinct TaskMenus for each task in GroupedTaskView" into sc-v2-dev am: 9693766477 am: 38935d3441
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15872704

Change-Id: Iff0b89a2307d833ed52c77835e87818c0ddb3ec2
2021-09-22 17:51:25 +00:00
Vinit Nayak 38935d3441 Merge "Show distinct TaskMenus for each task in GroupedTaskView" into sc-v2-dev am: 9693766477
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15872704

Change-Id: Ie56e8d555cb0f803c30939633dc1533b6e11f17e
2021-09-22 17:38:54 +00:00
Vinit Nayak 9693766477 Merge "Show distinct TaskMenus for each task in GroupedTaskView" into sc-v2-dev 2021-09-22 17:25:08 +00:00
Alex Chau 998a85e913 Merge "Keep insets stable when taskbar is destroyed/recreated" into sc-v2-dev am: 8f990b94a2 am: f6e67fb067
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15857676

Change-Id: Iac12c4380cde4270539f93a9fca552e8fd715ac8
2021-09-22 13:56:59 +00:00
Alex Chau f6e67fb067 Merge "Keep insets stable when taskbar is destroyed/recreated" into sc-v2-dev am: 8f990b94a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15857676

Change-Id: Ied04deccc9e9ed6813831b7a25ad36380d38a783
2021-09-22 13:45:12 +00:00
Alex Chau 8f990b94a2 Merge "Keep insets stable when taskbar is destroyed/recreated" into sc-v2-dev 2021-09-22 13:34:12 +00:00
Jon Miranda 8d3d2757e2 Play window close animation to home for most app to launcher scenarios
- Animates into icon/widget location on workspace (when applicable)
- Excludes unlock animation
- Excludes when user goes back to to All Apps state

Bug: 197656197
Bug: 197450256
Bug: 197656915
Test: go in app, swipe back to land on home
Change-Id: Icdf680bd88599f1b6288822a177087283668431c
2021-09-21 20:19:23 -07:00
Vinit Nayak 7caf5f0ea4 Show distinct TaskMenus for each task in GroupedTaskView
* For now we only show the App Info option
for each task icon clicked for GroupedTaskView
* Have TaskMenuView operate on a specific task instead
of only a TaskView
* NOTE: getItemInfo() in TaskIdAttributeContainer needs to
dynamically call getItemInfo(Task) because at the time of
creation of the container in TaskView#bind(), the task
object provided initially is a palceholder task which only
has a taskId and no other attributes set.
getItemInfo() needs a non-null baseIntent, which the
placeholder task doesn't have.
Right fix for this is to have GestureState hold onto
multiple running tasks when in split screen that are
provided by ActivityManagerWrapper when the gesture starts
(but that change is extensive and out of scope w/ this
workaround available)

Bug: 181704764
Test: Open TaskMenuView's w/ either task icon for
GroupedTaskView, opens up corresponding tasks menu.

Change-Id: I70b7c13394ad4980cabbd611cb928bb03d8a2924
2021-09-21 17:47:54 -07:00
TreeHugger Robot 8005d92d22 Merge "Adding screen record for a flake" into sc-v2-dev am: c48f770a3d am: 21f2b4cc91
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15875064

Change-Id: Ic4f372da594e6f726f01211693fdf71f6ab72708
2021-09-21 22:15:55 +00:00
TreeHugger Robot 21f2b4cc91 Merge "Adding screen record for a flake" into sc-v2-dev am: c48f770a3d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15875064

Change-Id: I16bc98a32e7b12a871617b4fd622e180c0bb6bca
2021-09-21 22:02:15 +00:00
TreeHugger Robot c48f770a3d Merge "Adding screen record for a flake" into sc-v2-dev 2021-09-21 21:49:58 +00:00
Tony Wickham 7eb5b53865 Keep insets stable when taskbar is destroyed/recreated
- Calculate nav bar insets ourselves. Currently when taskbar is going to be present, we use taskbarSize as the nav bar insets. This is consistent with other existing calculations, but going forward we should instead always use the nav bar size instead of taskbar size, given we don't want taskbar to inset launcher (since taskbar is hidden).
- Also update tappable insets to be 0 in gesture mode. Test: Swipe to all apps, ensure there's no background protection at the bottom.

Test: Rotate device, no visual jumps
Test: Stash taskbar, quick switch a couple times without settling, and swipe up to overview; no jank due to reapplyState()

Bug: 198798034
Fixes: 197232424
Fixes: 197212581
Change-Id: I4c2bb5816dbb214846bd9f2a46c6f759c0545911
2021-09-21 13:52:36 -07:00
Vinit Nayak b0ca4b3070 Merge "Prevent focusing next task if focused task part of split select" into sc-v2-dev am: 5f412199ad am: 0ada7824c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15854777

Change-Id: I5fd527ce8f4d20a4c915fc6a15e6f1ee00d5d8e6
2021-09-21 17:56:14 +00:00
Vinit Nayak 0ada7824c1 Merge "Prevent focusing next task if focused task part of split select" into sc-v2-dev am: 5f412199ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15854777

Change-Id: I474126fe11984793006c8c07529c89d409621a58
2021-09-21 17:41:54 +00:00
Vinit Nayak 5f412199ad Merge "Prevent focusing next task if focused task part of split select" into sc-v2-dev 2021-09-21 17:28:01 +00:00
TreeHugger Robot 346af60111 Merge changes I675dbe99,Ia6daa741 into sc-v2-dev am: 139dee45dd am: 8bc27a7ee2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862033

Change-Id: I412985630ce32cd2f544db3b5b50885405983afb
2021-09-21 17:07:01 +00:00
TreeHugger Robot 8bc27a7ee2 Merge changes I675dbe99,Ia6daa741 into sc-v2-dev am: 139dee45dd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862033

Change-Id: I3ef3b561f2c76e5e4c069af751477ae83e11fcb7
2021-09-21 16:52:31 +00:00
TreeHugger Robot 139dee45dd Merge changes I675dbe99,Ia6daa741 into sc-v2-dev
* changes:
  [Hotseat] Fix hotseat edu flicker
  [Hotseat] Show edu tip within screen bounds
2021-09-21 16:33:10 +00:00
sfufa@google.com 5b38ff6d16 [Hotseat] Fix hotseat edu flicker
When edu view animation is not started in closed state, it results in a single frame showing right before the animation begins.

Bug: 184610272
Test: visual
Change-Id: I675dbe9927771f4b64d1d81c637f19621037b415
2021-09-21 01:50:41 -07:00
Samuel Fufa 6ebbe4206e Merge "[Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app" into sc-v2-dev am: e4057e628c am: 8998a393b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15864327

Change-Id: Ib5945c7fb5c3c3780a244435526bdb62ddab6752
2021-09-21 07:01:56 +00:00
Samuel Fufa a4c1891723 Merge "[Hotseat] Fix hotseat migration in landscape mode" into sc-v2-dev am: cf175820c4 am: fb0bd63b32
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862162

Change-Id: I5f465b7078b4ae35521678b88fff0613c80b3ba7
2021-09-21 07:01:37 +00:00
Samuel Fufa 8998a393b0 Merge "[Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app" into sc-v2-dev am: e4057e628c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15864327

Change-Id: Ic5165aeabf619e649f3a9291bf64c689644c6c0b
2021-09-21 06:48:59 +00:00
Samuel Fufa fb0bd63b32 Merge "[Hotseat] Fix hotseat migration in landscape mode" into sc-v2-dev am: cf175820c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862162

Change-Id: I8649602454a097b553e94048027d772c68a14941
2021-09-21 06:48:53 +00:00
Samuel Fufa e4057e628c Merge "[Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app" into sc-v2-dev 2021-09-21 06:33:06 +00:00
Samuel Fufa cf175820c4 Merge "[Hotseat] Fix hotseat migration in landscape mode" into sc-v2-dev 2021-09-21 06:24:37 +00:00
vadimt 99479a9925 Adding screen record for a flake
Test: presubmit
Bug: 195673272
Change-Id: I3ea99f68872554d688b30bf87f595fef1538a7cb
2021-09-20 20:09:07 -07:00