Commit Graph

10816 Commits

Author SHA1 Message Date
vadimt 542b7df7fd Waiting for Launcher model load in out-of-proc tests.
Not doing this seems to have caused flakes.

Bug: 141770616
Change-Id: Ia9caf20e4a2d93298adf4249ca815ad79bced802
2019-10-01 17:46:35 +00:00
Tony Wickham c9654eb091 Don't allow scrolling RecentsView outside navbar during quickswitch
Once the inputProxy (OverviewInputConsumer) was enabled, it was never
disabled. And while it was enabled, touches above the nav bar would go
through to launcher, allowing you to scroll RecentsView (for example)
during quick switch transitions. This breaks some assumptions, since
it doesn't go through our normal shared swipe state logic that cancels
the animation, updates the new end target (e.g. NEW_TASK vs LAST_TASK),
etc. Thus, if you tried returning to LAST_TASK via this route, we would
end up starting it as a new activity instead of resuming the existing
one, causing a flicker (I guess because that TaskView is hidden).

Test:
- Swipe up from task A to home (to enable input proxy)
- Open A
- Swipe to B, and during transition scroll back to A from the center of
the screen

Before, this caused a flicker, now the last scroll is ignored.

TODO: we should increase the nav region during quick switch to make it
easier to continue scrolling

Bug: 136829198
Bug: 138620399
Change-Id: I5ffb53743b728e1909066c5dd18cc9308aff2c7e
2019-10-01 10:16:26 -07:00
Vinit Nayak a62de7aa88 Merge "Set exclusion rect for launcher before it gains focus" into ub-launcher3-master 2019-10-01 15:54:05 +00:00
Vinit Nayak 9a8462117d Set exclusion rect for launcher before it gains focus
Back gesture still shows if user attempts to swipe
back while we're animating to launcher state normal.
Focus is only granted after the animation has
completed, but the user can interact w/ the back
edge panels while it's ongoing.

fixes: 138622418
Test: Open app, swipe home and quickly swipe from
the edge of the screen. Should go to -1 screen and
not see back arrow.

Change-Id: I32228370c7ec1bdb75474fdff2d1c99cb677fa6a
2019-09-30 16:04:57 -07:00
Vadim Tryshev 6254e5e246 Merge "Deprecating LauncherInstrumentation constructor with parameter" into ub-launcher3-qt-qpr1-dev am: dd079691c1
am: 1430f132f3

Change-Id: If494e30957893c4e3414ebdbd274601d16a66a98
2019-09-27 13:28:18 -07:00
Vadim Tryshev 1430f132f3 Merge "Deprecating LauncherInstrumentation constructor with parameter" into ub-launcher3-qt-qpr1-dev
am: dd079691c1

Change-Id: I7419be6416f26274bf03abfd84eedef20fd6f084
2019-09-27 13:21:46 -07:00
vadimt 2611d79f69 Deprecating LauncherInstrumentation constructor with parameter
Change-Id: I779b4a8fde2db73cced8133f12d1356ad0b8729e
2019-09-27 12:00:09 -07:00
Sunny Goyal b32b6938fd Routing new API calls through a compat layer
Change-Id: I0bdbe99d6bc2291b370d143c6b5cb4408fe144eb
2019-09-27 08:52:08 -07:00
Hongwei Wang 655074680d Updates shelf visibility from Launcher to SysUI
We used to set shelf visibility (and its height) from Launcher to WM and
with the PiP-SysUI migration, this function will be called from Launcher
to SysUI directly since SysUI will be the new source of truth for PiP
bounds.

Bug: 139016518
Test: atest PinnedStackTests
Test: Manual
Change-Id: Id0931333da76b52ccc6fa23877c72fbe2747203b
(cherry picked from commit 95a6dba078)
2019-09-27 08:51:52 -07:00
Samuel Fufa db202abe4e Merge "Fix ScrimView caret alignment and ignore touches" into ub-launcher3-qt-future-dev
am: d69327e9c0

Change-Id: Ia19d766bdeb5d2a4023b1c408bddfe30e4de4dac
2019-09-26 17:38:25 -07:00
TreeHugger Robot d69327e9c0 Merge "Fix ScrimView caret alignment and ignore touches" into ub-launcher3-qt-future-dev 2019-09-27 00:15:36 +00:00
Samuel Fufa 0316d6cd7a Fix ScrimView caret alignment and ignore touches
Test:Manual
Bug:79868152
Change-Id: Idd5a2b965173b8071697b50aac8760b0d84e469f
2019-09-26 16:30:46 -07:00
Becky Qiu 5ba1fc93c4 Merge "Add OverviewScreenshotActions plugin interface and use it in TaskView." into ub-launcher3-qt-future-dev 2019-09-26 18:17:30 +00:00
Becky Qiu d3f6d72ebf Add OverviewScreenshotActions plugin interface and use it in TaskView.
Bug: 139828243
Change-Id: Idbefc11ef32619dd5eaaa5552088859eb2304e1e
Merged-In: Idbefc11ef32619dd5eaaa5552088859eb2304e1e
2019-09-26 18:05:47 +00:00
Becky Qiu 90c303b6a7 Add OverviewScreenshotActions plugin interface and use it in TaskView.
Bug: 139828243
Change-Id: Idbefc11ef32619dd5eaaa5552088859eb2304e1e
2019-09-25 16:24:54 -07:00
Hongwei Wang a2da38380c Merge "Updates shelf visibility from Launcher to SysUI" 2019-09-25 21:22:59 +00:00
vadimt fe2d10e90a Merge "Removing debug tracing for a fixed bug" into ub-launcher3-qt-qpr1-dev am: b72cd2629c
am: eda5c215b7

Change-Id: Ie37cd755184c954ada7c14faf99241b954f8ce22
2019-09-25 12:28:05 -07:00
vadimt eda5c215b7 Merge "Removing debug tracing for a fixed bug" into ub-launcher3-qt-qpr1-dev
am: b72cd2629c

Change-Id: Id28e20b5fe23c6f6501f3c7a38305f0a306b287a
2019-09-25 12:21:06 -07:00
vadimt 49b64a98ca Removing debug tracing for a fixed bug
Bug: 141275518
Change-Id: I171361d4f797f587b404eed07108224d8ab844f8
2019-09-25 11:26:56 -07:00
Vadim Tryshev c86abf0ed0 Merge "Removing temporary checks that tests are running on AVD" into ub-launcher3-qt-qpr1-dev am: 6929199c8a
am: ec1ae481d4

Change-Id: I3cf67561ae50575486db5360d0139ff916c5dfaf
2019-09-24 18:24:50 -07:00
Vadim Tryshev ec1ae481d4 Merge "Removing temporary checks that tests are running on AVD" into ub-launcher3-qt-qpr1-dev
am: 6929199c8a

Change-Id: Iaa6200f0371a4deca630194ac8ecfcfc04313750
2019-09-24 18:18:19 -07:00
Vadim Tryshev 6929199c8a Merge "Removing temporary checks that tests are running on AVD" into ub-launcher3-qt-qpr1-dev 2019-09-25 00:56:05 +00:00
vadimt 926e29f8b6 Removing temporary checks that tests are running on AVD
Bug: 136278866
Change-Id: I2b7b63b7745936ea84b7cba599e21d954b682ba5
2019-09-24 17:19:51 -07:00
Tony Wickham d82b32f30f Merge "Move offscreenTranslation calculation to LauncherRecentsView" into ub-launcher3-qt-future-dev
am: ffa00614b4

Change-Id: I6cdc1d86cca45372b1ec678c431ffcfa675cc9d9
2019-09-24 16:34:02 -07:00
TreeHugger Robot ffa00614b4 Merge "Move offscreenTranslation calculation to LauncherRecentsView" into ub-launcher3-qt-future-dev 2019-09-24 23:25:46 +00:00
Sunny Goyal 599e95bdde Fixing some tests
> Adding retry to fallback recents tests
> Fixing provider test after provider name change
> Fixing AllApps icon detection when there is no more scroll available

Bug: 141390432
Bug: 141523101
Bug: 141517004
Bug: 141524555
Bug: 141522764
Change-Id: I425638d20c053206134835dabde819f16160f035
2019-09-24 15:10:06 -07:00
Tony Wickham 8a1ba838f4 Move offscreenTranslation calculation to LauncherRecentsView
Couple of benefits here:
- Doesn't rely on having a measured TaskView, since it already knows how
  to calculate the task size
- Code can be shared (planning to use this for quick switch from home)

Bug:
Change-Id: I517a78506ac95fcc37d9225a074427941d691903
2019-09-24 14:23:26 -07:00
vadimt bba8c98de3 Removing "Failed to get system health diags" message from fallback tests
am: 9b1c168273

Change-Id: I4528370073f0258e5f0276dfb1d71dae9816ddea
2019-09-24 13:13:12 -07:00
vadimt 9b1c168273 Removing "Failed to get system health diags" message from fallback tests
Now getting diags though the test process that has right permissions.

This doesn't fix other failures in fallback tests.

Bug: 141517004
Change-Id: Ibba5f0471a83525a64544c62dbe82ab3e11712cd
Merged-in: Ibba5f0471a83525a64544c62dbe82ab3e11712cd
2019-09-24 19:31:35 +00:00
vadimt 6096451dbf Removing "Failed to get system health diags" message from fallback tests
Now getting diags though the test process that has right permissions.

This doesn't fix other failures in fallback tests.

Bug: 141517004
Change-Id: Ibba5f0471a83525a64544c62dbe82ab3e11712cd
2019-09-24 19:30:02 +00:00
Hongwei Wang 95a6dba078 Updates shelf visibility from Launcher to SysUI
We used to set shelf visibility (and its height) from Launcher to WM and
with the PiP-SysUI migration, this function will be called from Launcher
to SysUI directly since SysUI will be the new source of truth for PiP
bounds.

Bug: 139016518
Test: atest PinnedStackTests
Test: Manual
Change-Id: Id0931333da76b52ccc6fa23877c72fbe2747203b
2019-09-24 10:00:08 -07:00
Winson Chung 280242e5dd Merge "Updating launcher interface for recents animation change" into ub-launcher3-master 2019-09-24 05:26:59 +00:00
vadimt e139dee1c3 Merge "Removing debug tracing for flakes that stopped reproing" into ub-launcher3-qt-qpr1-dev am: 76aadac4e4
am: 6d5511a42f

Change-Id: I7df8a8322bae3fa6aed5978679f477c90fe14dc0
2019-09-23 15:04:06 -07:00
vadimt 6d5511a42f Merge "Removing debug tracing for flakes that stopped reproing" into ub-launcher3-qt-qpr1-dev
am: 76aadac4e4

Change-Id: I5099741d3502584f7d501d74897944edc3339977
2019-09-23 14:56:04 -07:00
vadimt 5466699f0b Removing debug tracing for flakes that stopped reproing
Bug: 139941530
Bug: 140311911
Change-Id: Idf4c013373e627db92aa96f9207e25336ee039f8
2019-09-23 13:57:32 -07:00
Winson Chung eff177a7f2 Fix wrong check for debug mode
Bug: 140246642
Change-Id: I4ce7cf623fe31d53fd9f6506f339d51a64ed8f8d
2019-09-23 20:11:43 +00:00
Tony Wickham 84250aa576 Don't crash when swiping up if there are no TaskViews
This can happen in LockTask mode, after enabling Overview. In that case,
you are locked to the current task, but are allowed to go to overview
but no tasks are shown there.

Bug: 139917483
Change-Id: I2180cc5e72c343977ea53cc02907ed8dac0f8bc6
(cherry picked from commit 60bf8c117b)
2019-09-21 04:09:41 +00:00
Tony Wickham 521224131e resolve merge conflicts of 5c229885fc to ub-launcher3-qt-future-dev
Bug: None
Test: I solemnly swear I tested this conflict resolution.

Change-Id: I41247ff46308b72158731e4a47466533d42e67c6
2019-09-20 16:22:59 -07:00
Tony Wickham 5c229885fc Merge "Don't crash when swiping up if there are no TaskViews" into ub-launcher3-qt-qpr1-dev 2019-09-20 22:44:28 +00:00
TreeHugger Robot 25986ffd64 Merge "Adding test to check view inflation during swipe up" into ub-launcher3-master 2019-09-20 22:44:01 +00:00
Sunny Goyal 8f90d5da8a Adding test to check view inflation during swipe up
Bug: 137851409
Change-Id: Ic8e6f0b3c667051b921d1d4fad03c94122ee92e9
2019-09-20 15:36:02 -07:00
Winson Chung 1b231ecc56 Updating launcher interface for recents animation change
Bug: 140626334
Change-Id: Ib8e837c157bb99db429b7936fdf111e05170ac25
2019-09-20 15:15:43 -07:00
Tony Wickham 60bf8c117b Don't crash when swiping up if there are no TaskViews
This can happen in LockTask mode, after enabling Overview. In that case,
you are locked to the current task, but are allowed to go to overview
but no tasks are shown there.

Bug: 139917483
Change-Id: I2180cc5e72c343977ea53cc02907ed8dac0f8bc6
Merged-In: I2180cc5e72c343977ea53cc02907ed8dac0f8bc6
2019-09-20 22:01:18 +00:00
Tony Wickham 9e88a6d8be Don't crash when swiping up if there are no TaskViews
This can happen in LockTask mode, after enabling Overview. In that case,
you are locked to the current task, but are allowed to go to overview
but no tasks are shown there.

Bug: 139917483
Change-Id: I2180cc5e72c343977ea53cc02907ed8dac0f8bc6
2019-09-20 21:58:30 +00:00
TreeHugger Robot 3a5d7cca9e Merge "Updating animation start callback" into ub-launcher3-master 2019-09-20 21:31:20 +00:00
Becky Qiu 4df06903bc Fill in LauncherTarget fields with values extracted from LauncherLogProto.Target.
Test: manual
Bug: 137777105

Log result:
1. Swipe to -1:
  data {
    elapsed_timestamp_nanos: 1372265229686264
    atom {
      launcher_event {
        action: SWIPE_LEFT
        src_state: HOME
        dst_state: HOME
        extension {
          src_target {
          }
        }
        is_swipe_up_enabled: true
      }
    }
  }
2. Swipe out of -1:
  data {
    elapsed_timestamp_nanos: 1372368006970305
    atom {
      launcher_event {
        action: SWIPE_RIGHT
        src_state: HOME
        dst_state: HOME
        extension {
          src_target {
            page_id: -1
          }
        }
        is_swipe_up_enabled: true
      }
    }
  }
3. Launch app from homescreen:
  data {
    elapsed_timestamp_nanos: 1372397640628726
    atom {
      launcher_event {
        action: LAUNCH_APP
        src_state: HOME
        dst_state: BACKGROUND
        extension {
          src_target {
            item: APP_ICON
            grid_x: 2
            grid_y: 1
          }
          src_target {
          }
        }
        is_swipe_up_enabled: true
      }
    }
  }
4. Launch app from hotseat:
  data {
    elapsed_timestamp_nanos: 1372399813031963
    atom {
      launcher_event {
        action: LAUNCH_APP
        src_state: HOME
        dst_state: BACKGROUND
        extension {
          src_target {
            item: APP_ICON
            grid_x: 2
          }
          src_target {
            container: HOTSEAT
          }
        }
        is_swipe_up_enabled: true
      }
    }
  }
5. Launch app from allapps prediction:
  data {
    elapsed_timestamp_nanos: 1372403080724736
    atom {
      launcher_event {
        action: LAUNCH_APP
        src_state: ALLAPPS
        dst_state: BACKGROUND
        extension {
          src_target {
            item: APP_ICON
          }
          src_target {
            container: PREDICTION
          }
        }
        is_swipe_up_enabled: true
      }
    }
  }

Change-Id: I981401d06577c15948cfee0062b8a6f8a5594345
2019-09-20 21:26:59 +00:00
TreeHugger Robot 8fbbbe0687 Merge "Fixing some tests for 2-button mode" into ub-launcher3-master 2019-09-20 17:54:25 +00:00
Winson Chung f779e78789 Updating animation start callback
Bug: 140626334
Test: Builds
Change-Id: I86e8d448188d21f0318ac2ea053a8394a1d0cf1a
2019-09-20 17:40:17 +00:00
Sunny Goyal 3d56046ff8 Fixing some tests for 2-button mode
Bug: 141315387
Change-Id: I66db3e790f5fbe6bc30999ed599cce03874509be
2019-09-20 10:40:14 -07:00
Winson Chung c1f89d921a Updating animation start callback
Bug: 140626334
Test: Builds
Change-Id: I86e8d448188d21f0318ac2ea053a8394a1d0cf1a
2019-09-20 10:39:08 -07:00