Commit Graph

10816 Commits

Author SHA1 Message Date
Tracy Zhou b5f7e4fc19 Fix npe in FrameHandler
Previously we check if the view root is null, but after ag/16308550 we no longer do so

Fixes: 208657242
Test: N/A
Change-Id: I0bb4a1b26ca8b201393587e7d0d922b7d4e08419
2022-03-31 21:46:47 -07:00
Tracy Zhou bb75f59792 Merge "Do not append additional delimiters" into tm-dev 2022-04-01 04:26:20 +00:00
Tracy Zhou 0439fcdd5c Do not append additional delimiters
Fixes: 227665358
Test: N/A
Change-Id: I6ec0bca286c0824e474f04a61b7d855858490120
2022-03-31 17:15:46 -07:00
Vinit Nayak c8b2fdbc6a Merge "Add metrics for taskbar 3 button nav" into tm-dev 2022-03-31 23:22:33 +00:00
Tony Wickham 6e9c06998d Merge "Log when calling disposeEventHandlers" into tm-dev 2022-03-31 23:20:46 +00:00
Vinit Nayak 188ae14220 Listen for density changes through DisplayController callbacks
* Make display controller callbacks member variable for
clarity.
* Created follow-up refactor (b/227669780)

Fix: 227329641
Test: Repro steps in bug no longer make taskbar appear
when it shouldn't

Change-Id: I83702c0b817749943d2a9c4c5f0e44342a475e75
2022-03-31 16:20:23 -07:00
Vinit Nayak 26b6b577b9 Add metrics for taskbar 3 button nav
Fixes: 221075063
Test: wwlogcat shows right events,
new events show up on aster dashboard

Change-Id: I3864ac02ea00f281d33ccb26b95a4916bd8b6be9
Merged-In: I3864ac02ea00f281d33ccb26b95a4916bd8b6be9
2022-03-31 19:36:47 +00:00
Schneider Victor-tulias 3a6b7360a2 Merge "Add public constructors to gesture tutorial fragments." into tm-dev 2022-03-31 17:30:14 +00:00
Tony Wickham e0c464a0e0 Merge "Decouple taskbar background color from overview" into tm-dev 2022-03-31 17:28:40 +00:00
Tony Wickham ae82fc4ba0 Decouple taskbar background color from overview
- Taskbar background is 15L but Overview dark should be 35L

Test: Swipe up from taskbar (which is 15L), background matches until
going to overview, then animates to appropriate overview color based on
theme (light or dark).
Bug: 227344452
Change-Id: I52d892a569c8db565b4cfe271e532009f34ec669
2022-03-31 17:28:16 +00:00
Alex Chau 5f8386cf26 Merge "Using the WindowMetrics API instead of display.getRealSize" into tm-dev 2022-03-31 10:58:40 +00:00
wilsonshih 64cfa05d59 Update orientation state while gesture animation start.
While quickswitch in landscape mode, the orientation handler would be
update to LandscapePagedViewHandler when receive onLauncherStart,
however, it might be too late because the VelocityTracker can already
tracking with PortraitPagedViewHandler at
AbsSwipeUpHandler#setupRecentsViewUi, which leads the wrong
judgement while PagedView#onTouchEvent handling the ACTION_UP that
the velocity can nearly 0 from mOrientationHandler.getPrimaryVelocity.

By update the orientation handler earlier at onGestureAnimationStart,
the velocity tracking result should stay consistent from ACTION_DOWN
till ACTION_UP.

Bug: 213867585
Bug: 209936664
Bug: 221805258
Test: run below tests w/o shell transition.
atest FlickerTests:QuickSwitchBetweenTwoAppsForwardTest
atest FlickerTests:QuickSwitchBetweenTwoAppsBackTest

Change-Id: If73fa8d88cc372b6f783fb6cdda4148d11a2ee19
2022-03-31 13:03:39 +08:00
Vinit Nayak 254c77e279 Merge "Fix translation for secondary split thumbnail in RTL" into tm-dev 2022-03-31 04:19:42 +00:00
Schneider Victor-tulias 054faba0a1 Add public constructors to gesture tutorial fragments.
The lack of public, no-arg constructors was causing the tutorial to crash on re-creation (eg. rotating the screen.) Added public constructors and refactored event logging.

Also added an update to the All Set page to allow the subtitle to display in one line.

Fixes: 226321558
Fixes: 226550217
Test: manual
Change-Id: I00a6135e658a66313df5e07833e6c6a20a618672
2022-03-30 23:51:18 +00:00
Hongwei Wang fe43ca95da Merge "Handle shadow radius for auto-pip in Launcher" into tm-dev 2022-03-30 22:23:51 +00:00
Sunny Goyal 36c0f76e21 Using the WindowMetrics API instead of display.getRealSize
Bug: 221961069
Bug: 195408476
Bug: 198965093
Test: Verified locally and presubmit
Change-Id: I4dac9c19df4c43e6a38ba5c05f27d25f4cfcb071
2022-03-30 21:07:23 +00:00
Vinit Nayak 1322fc3710 Fix translation for secondary split thumbnail in RTL
Fix: 225157531
Test: Swipe up in RTL shows both thumbnails
were expected.

Change-Id: I87d286b6ce6542c7cffadf86e3d4d99a3618f984
2022-03-30 10:32:51 -07:00
Benno Lin 264d9a67de Enable pressback tests
Bug: 205027405
Test: Manual
Change-Id: I5bb41fc27db17e95d7a7c91cec2bbf85f33d6dad
(cherry picked from commit b5b70930e9)
2022-03-30 10:36:38 +00:00
shawnlin 34aad9e022 Fixed cts failure of WindowInsetsControllerTests
If stashing taskbar is caused IME visiblity, we could just skip updating
rounded corner insets since the rounded corners will be covered by IME
during IME is showing and task bar will be restored back to unstashed
when IME is hidden.

Bug: 225765490
Test: atest WindowInsetsControllerTests
Change-Id: If8f40add0d4d9f746169d26f46f27545b4023e90
2022-03-30 18:20:32 +08:00
Sunny Goyal 6d5a1c1307 Fixing crash when unfolding with an app already open
Bug: 227388787
Test: Manual
Change-Id: Ib1726b99a978bd613c337c2eff4873322d894485
2022-03-29 16:29:05 -07:00
Vinit Nayak db2c726560 Merge "Always look for MODE_OPENING during task launch from overview" into tm-dev 2022-03-29 21:11:26 +00:00
TreeHugger Robot 4cb55616e2 Merge "Close system windows when toggling overview" into tm-dev 2022-03-29 16:56:16 +00:00
Tony Wickham b2aa48cad6 Merge "Fix problems with taskbar floating views on rotation" into tm-dev 2022-03-29 16:36:16 +00:00
Tony Wickham c30e733d5f Merge "Update gesture region when display size changes" into tm-dev 2022-03-29 16:33:58 +00:00
Jason Chang ae4d2193d9 Fix One-handed mode tutorial broken on large screen device
Change the orientation judgement by checking display info's
width & height

Bug: 223486060

Test: manual
Change-Id: I94947ad635146dcb656e5074577b297617326c8d
2022-03-29 13:46:27 +00:00
Alex Chau f10b877fbd Merge "Add screen record to FallbackRecentsTest#goToOverviewFromHome" into tm-dev 2022-03-29 11:39:44 +00:00
TreeHugger Robot 38aeb36043 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev 2022-03-29 07:37:55 +00:00
Vinit Nayak 526f4ce7ae Always look for MODE_OPENING during task launch from overview
* Previously the target mode was dependent on whether liveTile
was running or not, opposite targets seem to be coming in from
WM now.
* Remove a bunch of un-used code from LauncherSplitScreenListener
that was used when we only allowed one split pair in overview
previously. Now that is handled by RecentTasksController in shell
so we don't need any additional bookkeeping.

Fix: 212220301
Test: Able to launch side tasks in overview
Change-Id: I002340d98ba379cb4ab9ae37eadfa235d6b5e56d
2022-03-28 21:32:09 -07:00
Sebastián Franco 9d5eef80cd Merge "Brighten theme-icons when in Dark mode and add dark color for taskbar" into tm-dev 2022-03-29 00:00:33 +00:00
Tony Wickham 30be4bfdb3 Update gesture region when display size changes
Test: change resolution on device, ensure bottom gestures work
Fixes: 225169659
Change-Id: Iafc4a797741092c82bc89b46dd2babe6d1c13512
2022-03-28 16:50:01 -07:00
Hongwei Wang b46d6ebc01 Handle shadow radius for auto-pip in Launcher
Bug: 206508708
Test: Verify the auto-enter-pip transition
Change-Id: I1e99c3e1ce890885d95006293a1469491c5c6672
2022-03-28 16:44:28 -07:00
Vinit Nayak 6be66c96ef Close system windows when toggling overview
Fix: 203835798
Test: Tap on overview with notification shade,
it closes

Change-Id: I01a5cab4fabf7950f48290418df3ae6cb270305c
2022-03-28 14:54:07 -07:00
Tony Wickham 538c9a0b52 Fix problems with taskbar floating views on rotation
- Close all views except TYPE_REBIND_SAFE
- Make All Apps TYPE_REBIND_SAFE again
- Reapply fullscreen to ensure any remaining floating views such as taskbr edu are laid out correctly upon rotation

Test: Rotating with folder and/or popup closes them; rotating with all apps stays open; rotating with all apps + popup closes popup but not all apps; rotating taskbar edu lays out correctly; opening shortcut or notification from all apps popup still closes all apps
Fixes: 220074790
Fixes: 219981733
Change-Id: I1dfea4ed0a636ab84bcc4e33304c80a689da01cd
2022-03-28 14:48:20 -07:00
Alex Chau 2871958fb4 Add screen record to FallbackRecentsTest#goToOverviewFromHome
Bug: 223278795
Test: none
Change-Id: I3ddcf5db0980968636a6b67ef2dbfe8d44446cc7
2022-03-28 16:16:56 +01:00
Jeremy Sim db92b5d73f Merge "Fix issue with camera overlapping split staging UI" into tm-dev 2022-03-26 19:41:48 +00:00
Bill Yi 534966f98e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I13ff147ba826b962e0ec46dca17c2e0f80275bf3
2022-03-26 05:19:32 +00:00
Jeremy Sim b8eeb41ee0 Fix issue with camera overlapping split staging UI
Fixes an issue on some devices where initiating a split in Overview would cause an icon to be placed partly under the camera cutout.

Fixed by adding some padding to FloatingTaskView#mSplitPlaceHolderView, so that it always respects the device's insets.

Fixes: 220997064
Test: Manual
Change-Id: I7270bde3320f562519ea8e36a38e49609e0d6cd7
2022-03-25 16:31:46 -07:00
Chavi Weingarten ba653b3b92 Merge "Replace consumeNextDraw with SurfaceSyncer" into tm-dev 2022-03-25 22:08:17 +00:00
Evan Rosky 5a7d6e93af Merge "Implement switchtoScreenshot recents callback" into tm-dev 2022-03-25 21:26:12 +00:00
Stefan Andonian 234889c81c Update text in "get app suggestions" bottom sheet to use Google Sans
font family.

Bug: b/211375020
Test: Verified that the font was different after setting it in the xml.
Screenshot: screenshot.googleplex.com/AEvdCXTufBnbQC5.png
Change-Id: Ie5447344b9e917648b50945414cf58562a1d0ca8
(cherry picked from commit 4f15b6cafb)
2022-03-25 19:37:22 +00:00
Tony Wickham 59d4896635 Merge "Don't recreate taskbar on rotation" into tm-dev 2022-03-25 16:14:04 +00:00
Nicolò Mazzucato 286dd249e0 Merge "Tune fold animation on top of apps" into tm-dev 2022-03-25 09:31:10 +00:00
Vinit Nayak 7ac2116fcc Merge "Hide taskbar when launcher receives nav and keyguard showing" into tm-dev 2022-03-24 22:01:15 +00:00
Evan Rosky e81d9679c1 Implement switchtoScreenshot recents callback
This lets the recents animation trigger a switchToScreenshot
to avoid premature live-tile disappearance.

Bug: 223321653
Test: put app in pip, open another app, go to recents, expand pip
Change-Id: I7ddcd891978fca7e91d7d90c1c8d9b824f5652a6
2022-03-24 14:13:59 -07:00
Sebastián Franco 1c11c5319c Merge "Task thumbnail background is spilling to the front, making the BK 1px smaller to fix it" into tm-dev 2022-03-24 18:17:39 +00:00
Tony Wickham 3b7a391c2b Don't recreate taskbar on rotation
This was a regression due to ag/17241303, since technically the size changes when rotating (width and height swap). Now we detect that case and don't recreate, but instead propagate the new DeviceProfile via TaskbarActivityContext#updateDeviceProfile()

Test: Open an app, rotate device, ensure taskbar isn't recreated. Changing properties such as dark theme does still recreate taskbar.
Bug: 219981733
Change-Id: Ic827c8e697a284a085609ea8653d77900686306a
2022-03-24 10:35:10 -07:00
TreeHugger Robot 181f803258 Merge "Prevent removing the feedback view and callbacks when the user completes a gesture." into tm-dev 2022-03-24 12:17:42 +00:00
Nicolo' Mazzucato ff84d2bc66 Tune fold animation on top of apps
On top of apps, the fold animation is triggered only after a threshold. On Launcher, there is not threshold.

In this way, we don't show fold animation while apps might be handling table top/half_folded state.

+ timeout to finish the animation made shorter

Test: atest DeviceFoldStateProviderTest
Bug: 225185239
Change-Id: I5adf82e853af9a5dee5af41a853abb84c9926ccd
2022-03-24 11:31:51 +00:00
Hongwei Wang ca9f9ebec5 Merge "Hide the Taskbar when user leaves PiP mode" into tm-dev 2022-03-23 22:38:48 +00:00
Vinit Nayak c750e3d3aa Hide taskbar when launcher receives nav and keyguard showing
* On large screen we receive notification shade expanded
signals even on keyguard.
* Add a check to not show taskbar if keyguard is showing

Fixes: 223465924
Test: Taskbar doesn't show on 3 button nav except
on bouncer, as expected.

Change-Id: I4a7ea14422eda13ae8571793ed7ba1a1964072d6
2022-03-23 14:09:25 -07:00