Commit Graph

10816 Commits

Author SHA1 Message Date
Tracy Zhou 023537038d Originate split select animation from the original icon view instead of the split menu icon
Bug: 226395821
Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/ed355c4f-b9d3-4b85-870f-2decb0b786db
Change-Id: I7277a9de212328d6f580bff5d28338ea0c058d99
2022-04-26 18:00:25 -07:00
Mateusz Cicheński 76fb120994 Make Hotseat report shelf height on large screen devices.
Test: http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/ckTLvEEiaCugieedwOU6tj
Bug: 198311114
Change-Id: I9d5bc6ab031fb6d07d5205581c33aa5ab9b45a8c
2022-04-26 23:34:22 +00:00
Tracy Zhou b2151475b6 Merge "Add originalView of the menu to SystemShortcut" into tm-dev am: 7183e4b460 am: 7148e74f1e am: 9660c41b4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17677218

Change-Id: I3b09f7af5b4be06dfa305d0585b9a5d73d377f85
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 19:33:02 +00:00
Tracy Zhou 9660c41b4c Merge "Add originalView of the menu to SystemShortcut" into tm-dev am: 7183e4b460 am: 7148e74f1e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17677218

Change-Id: I3db055b4066d721eccc9ca6cdc70d25aec0b3574
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 18:25:22 +00:00
Tracy Zhou 7148e74f1e Merge "Add originalView of the menu to SystemShortcut" into tm-dev am: 7183e4b460
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17677218

Change-Id: Ic6378b71451cafcf02ece812c93a240123cd2c03
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 17:53:25 +00:00
Tracy Zhou 7183e4b460 Merge "Add originalView of the menu to SystemShortcut" into tm-dev 2022-04-26 17:28:40 +00:00
Shan Huang 3e952539a1 Fix screen rounded corner flicker.
We've previously always played transitions with a fixed start corner
radius. This should however be an interpolated value based on gesture
progress.

Bug: 230115505
Test: Turn on predictive animations. Try completing a back swipe as well
as canceling a back swipe. Observe corner radius to make sure there's no
flicker.

Change-Id: Iae2517d969ed1b779bced866407b939b3a011b68
2022-04-26 17:16:22 +00:00
TreeHugger Robot e58c73ffea Merge "Refactors Search results into separate RV for Toast." into tm-dev am: 0a6e9b4751 am: 14615df286 am: 16a13ec3e6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17699868

Change-Id: I78b6b7d97fab1810140b2bc09f585566feb47c2a
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 16:32:31 +00:00
TreeHugger Robot 16a13ec3e6 Merge "Refactors Search results into separate RV for Toast." into tm-dev am: 0a6e9b4751 am: 14615df286
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17699868

Change-Id: I10c86da47d157bb99d3422719f2f9c8acf8fc568
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 16:11:39 +00:00
TreeHugger Robot 14615df286 Merge "Refactors Search results into separate RV for Toast." into tm-dev am: 0a6e9b4751
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17699868

Change-Id: I86545cb56dac22db803cacfdc893f82efcecefd5
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 15:36:46 +00:00
Vinit Nayak 2d1a69e58b Revert "Revert "Use new onStartSplitLegacy when starting split f..."
Revert submission 17918609-revert-17779173-startSplitLegacy-OOWPZEFFGI

Reason for revert: Running through TH
Reverted Changes:
I6d81e0584:Revert "Use new onStartSplitLegacy when starting s...
I754bc308f:Revert "Remove check for preventing re-parenting n...

Change-Id: I6eea82f34b3680020b49ec7fe19eb61cc68286a5
2022-04-25 19:55:31 +00:00
Alex Chau a2fc764405 Update overview actions alignment
- Align overview actions to the top with a defined margin below task thumbnail, except for vertical bar layout
- In modal state, use task view's bottom as pivot, and expand using all the space about pivot
- Simplified overview actions margin calculation and moved some logic to DeviceProfile

Bug: 209981696
Test: manual on various devices
Change-Id: I4c96cb02c6f3d6adf30633ddeb883bc4eec16f36
2022-04-25 19:20:21 +01:00
Jerry Chang c3865b86e4 Fix divider bar won't fade-in as the other splitting tasks
Bug: 226271407
Test: manual check the divider bar fade-in animation after launchTasks
Change-Id: I5ea7c6ea5ac3f3550b28e9c0f854e70edcfc97b0
2022-04-25 15:41:28 +00:00
Andy Wickham 6729f0b950 Refactors Search results into separate RV for Toast.
This will help enable transitions between A-Z apps lists and
search results because both can be seen simultaneously and
manipulated independently.

Some high level items of the refactor:
 - SearchRecyclerView is added; logic that populated the main
   (personal) tab with search results was simply redirected to
   this RV instead.
 - BaseAllAppsContainerView added isSearching() method. Returns
   false, and ActivityAllAppsContainerView overrides (as search
   is handled there).
 - Renamed BaseRecyclerView to FastScrollRecyclerView to better
   describe what it does. SearchRecyclerView extends this, but
   returns false for supportsFastScrolling().
 - AlphabeticalAppsList#mAllAppsStore is now optional, so the
   Search RV doesn't need to store/listen to apps. Note this
   doesn't affect the predicted app row which is still updated
   if one of the predicted apps is uninstalled (I tested this).

Future work:
 - Determine why dispatchRestoreInstanceState is not called for
   BaseAllAppsContainerView. Save is called, e.g. on rotation.
   Effect of restore not called: rotating while searching goes
   back to A-Z list.
 - Keep suggested apps in Header while searching. Currently they
   are rendered in the SearchRV above search results, as before.
 - Potentially extract Personal/Work tabs to move independently of
   header.
 - AlphabeticalAppsList is a misleading name because it can also
   contains search results. However, things are pretty intertwined
   between that and BaseAllAppsAdapter (effectively a circular
   dependency), so I figured cleaning all that up was out of the
   immediate scope of this refactor, which is mainly meant to
   unblock transition work.

Bug: 206905515
Test: Manually checked for regressions, ran tests.
Change-Id: I4d3757c8a8f9b774956ca6be541dd4fcdad1de13
2022-04-24 17:36:48 -07:00
TreeHugger Robot f07608957b Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev am: 1582aafbc0 am: 9c3bd94b48 am: 4ebc61e76a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921423

Change-Id: Ied4008303bbd0e5f726cb6dd49cfe58159af933c
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 04:17:49 +00:00
TreeHugger Robot 4ebc61e76a Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev am: 1582aafbc0 am: 9c3bd94b48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921423

Change-Id: I5a02a4c0d0d22655559100c95998ceec0f7a752b
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 03:56:23 +00:00
TreeHugger Robot 9c3bd94b48 Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev am: 1582aafbc0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921423

Change-Id: I3083e1b4d5e9556b0152b8229658575e403ca76a
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 03:24:58 +00:00
TreeHugger Robot 1582aafbc0 Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev 2022-04-23 02:51:20 +00:00
Tony Wickham bb6926f8c6 Defer onIsStashedChanged() until all controllers are initialized am: aed0c4d73e am: cc10db044f am: 96c5c67dca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921731

Change-Id: Ia3625ff9b17b348790926c217d48f48782ab2a6a
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 02:00:52 +00:00
Tony Wickham 96c5c67dca Defer onIsStashedChanged() until all controllers are initialized am: aed0c4d73e am: cc10db044f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921731

Change-Id: I0471cb6feb14e517dea2ca0a07445335ecee45a5
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 01:47:33 +00:00
Tony Wickham cc10db044f Defer onIsStashedChanged() until all controllers are initialized am: aed0c4d73e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921731

Change-Id: Id798f042e7cc39d76fb3e4ce8c7ffbf2a54184fd
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 01:18:24 +00:00
Tony Wickham aed0c4d73e Defer onIsStashedChanged() until all controllers are initialized
Test: N/A
Fixes: 230133882
Change-Id: I27df993a08327d28669963e3cecfaa133daf11c9
2022-04-22 17:28:35 -07:00
Tony Wickham b64eecba3a Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev am: 357c622572 am: 9de10ff889 am: b0b89c7f00
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17873349

Change-Id: I7c922df6ae38c31ec507591420c2115884d3745c
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 00:14:54 +00:00
Tony Wickham b0b89c7f00 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev am: 357c622572 am: 9de10ff889
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17873349

Change-Id: I56e8a873e333b1470eddddb73157ace4eb531bb7
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 23:43:01 +00:00
Schneider Victor-tulias 04169cd3fc Provide more accurate feedback on nav bar region gestures during the back gesture tutorial.
Test: manual
Fixes: 221192860
Change-Id: Id9f912e7db2d89fc948566f5cd16f4b641cdfa31
2022-04-22 16:37:49 -07:00
Tony Wickham 9de10ff889 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev am: 357c622572
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17873349

Change-Id: I6c01f58f282234ce2e85a582a25a442ba7c7d9d2
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 23:19:24 +00:00
Tony Wickham 357c622572 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev 2022-04-22 22:55:10 +00:00
Santiago Etchebehere d17d701859 Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev am: 8340cb6d7d am: 78194ca6ad am: eef266fe39
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17918609

Change-Id: Ie4fefefa49c0ff23c0e09933c0db403eedba06de
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:43:48 +00:00
Sunny Goyal 01d3f8ef47 Merge "Removing fade in logic during load." into tm-dev am: 84151d2bca am: d99aee90ef am: 8fbfd8ecf8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17768817

Change-Id: I165aa0431d79c61668f2fd4f194e57ba862095b7
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:43:37 +00:00
Santiago Etchebehere eef266fe39 Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev am: 8340cb6d7d am: 78194ca6ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17918609

Change-Id: I2d68fd2a3348c2ca7bede5a189e93c14b34b8826
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:20:47 +00:00
Sunny Goyal 8fbfd8ecf8 Merge "Removing fade in logic during load." into tm-dev am: 84151d2bca am: d99aee90ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17768817

Change-Id: I7ca9e432376e4533a1643187c51ab3545f25c465
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:20:32 +00:00
Santiago Etchebehere 78194ca6ad Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev am: 8340cb6d7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17918609

Change-Id: I7e56d7a2f10052f9cb0a3ef6e83e33aa4024f493
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:11:04 +00:00
Santiago Etchebehere 8340cb6d7d Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev 2022-04-22 21:07:18 +00:00
Sunny Goyal d99aee90ef Merge "Removing fade in logic during load." into tm-dev am: 84151d2bca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17768817

Change-Id: Id8a4e2f0a5b45267b8386f22b15639f232e93460
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:03:22 +00:00
Santiago Etchebehere b8ad6e08cf Revert "Use new onStartSplitLegacy when starting split from overview"
Revert submission 17779173-startSplitLegacy

Reason for revert: Broken build: b/230129218
Reverted Changes:
I01590e53c:Remove check for preventing re-parenting non-split...
I696749f76:Use new onStartSplitLegacy when starting split fro...

Change-Id: I6d81e0584bbfda3694772dcf293a4d064b2e8517
2022-04-22 21:02:22 +00:00
Jeremy Sim ef914fe5b1 Merge "Fix crash bug when splitting with animations disabled" into tm-dev am: 602b46c399 am: cca5e510fd am: fb8907517c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17807433

Change-Id: Ib3686882f4d2e43bdf7100d162506410d154b67b
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:44:54 +00:00
TreeHugger Robot a36b69f84c Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev am: 8aead5503f am: e17589f4b8 am: f06f6e7f1d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17779173

Change-Id: I63d97dc762d22f52868d4aefd88d095f2e94925d
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:44:22 +00:00
Tony Wickham da6d914e7c Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev am: 741e4aeb95 am: 44e65099c2 am: cf6b7e2dd9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778392

Change-Id: I7470fbc1ad42ae90aa6e426914c3640834d33cc2
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:43:56 +00:00
Sunny Goyal 84151d2bca Merge "Removing fade in logic during load." into tm-dev 2022-04-22 20:29:34 +00:00
Jeremy Sim fb8907517c Merge "Fix crash bug when splitting with animations disabled" into tm-dev am: 602b46c399 am: cca5e510fd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17807433

Change-Id: Ie12e347f3d58730d4a0ae5ed9c4c92fbfcace800
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:21:14 +00:00
TreeHugger Robot f06f6e7f1d Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev am: 8aead5503f am: e17589f4b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17779173

Change-Id: Ib73e94fdb7f113ba0838b857817648520d91bb02
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:20:50 +00:00
Tony Wickham cf6b7e2dd9 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev am: 741e4aeb95 am: 44e65099c2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778392

Change-Id: If17f49f0227f14bdbbd72a8c7480b7a27eacc73a
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:20:01 +00:00
Jeremy Sim cca5e510fd Merge "Fix crash bug when splitting with animations disabled" into tm-dev am: 602b46c399
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17807433

Change-Id: I18ac8925b7cf520d4d123c6648dc0e7cbaf2a862
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:10:47 +00:00
TreeHugger Robot e17589f4b8 Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev am: 8aead5503f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17779173

Change-Id: If978a1789f76f0edbc8259031c42f9fe94438dc9
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:10:37 +00:00
Jeremy Sim 602b46c399 Merge "Fix crash bug when splitting with animations disabled" into tm-dev 2022-04-22 20:05:09 +00:00
TreeHugger Robot 8aead5503f Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev 2022-04-22 20:03:36 +00:00
Tony Wickham 44e65099c2 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev am: 741e4aeb95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778392

Change-Id: I437518bf5b439cf7918ffe42d4bfdf9971207e3c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:02:21 +00:00
Jeremy Sim 42276318b9 Fix crash bug when splitting with animations disabled
Fixes a bug where disabling animations (through Settings) would cause split staging to crash.

The crash occurs because when animations are disabled, StateManager advances to OVERVIEW_SPLIT_SELECT too quickly, and does not trigger the appropriate code block in RecentsViewStateController#handleSplitSelectionState(). This causes a crash.

Fixed by changing the conditional so that it always runs when OVERVIEW_SPLIT_SELECT is the target state, no matter the starting state.

Note: If more animations are added for this state in the future, the conditional may need to be tweaked further.

Fixes: 223598955
Test: Confirmed not crashing on 2 devices when splitting in a variety of ways.
Change-Id: I7f3def88f124fa1babe9a943adf72c10f58b7131
2022-04-22 19:58:40 +00:00
Tony Wickham 741e4aeb95 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev 2022-04-22 19:55:31 +00:00
TreeHugger Robot 5d315a06e3 Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev am: 37fa1392ec am: 0e46bac72f am: 3c2956abcc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17586926

Change-Id: Icd0fd5878abd5563e850bed798c3da6d31ad0d18
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 18:53:04 +00:00