Commit Graph

6524 Commits

Author SHA1 Message Date
Jon Miranda ccbc78735f Merge "Check for isAttachedToWindow before dispatching touch event" into main 2025-03-11 13:38:38 -07:00
Sukesh Ram feda773d48 Merge "[CD Taskbar] Make External Taskbar 3-Button & Persistent" into main 2025-03-11 09:32:47 -07:00
Treehugger Robot 2595899b6e Merge "Reset All Apps button alpha at the end of all set page -> home animation" into main 2025-03-11 09:12:54 -07:00
Schneider Victor-Tulias f7b75b2f8c Reset All Apps button alpha at the end of all set page -> home animation
Flag: EXEMPT bug fix
Fixes: 360338079
Test: swiped up from the all set page
Change-Id: Ide5eb3b8e81bfc67975932d0806e4ab17d60c078
2025-03-11 07:03:19 -07:00
Johannes Gallmann b44c55a6a1 Fix back button touch region too small
The back button in 3-button-nav touch region was unintentionally
decreased with the predictive_back_three_button_nav flag. The reason is
that NearestTouchFrame did not consider the back button for its touch
forwarding logic, because the back button did not have isClickable set
to true. Manually setting the clickable attribute fixes that.

Bug: 393498908
Test: Manual, i.e. verified that touches close to back button are not routed to the home button
Flag: EXEMPT bugfix
Change-Id: I7ad1ee13f92aa947f1a86f8d65de79a9d9e13899
2025-03-11 08:11:05 +00:00
Treehugger Robot 3868333a60 Merge "Fix layout transition crash for phone with QSB inline." into main 2025-03-10 17:04:12 -07:00
Randy Pfohl 0678d08e87 Merge "Move flags to desktopmodeflag" into main 2025-03-10 14:50:38 -07:00
Ahmed Fakhry 30d39caacb Merge "Propagate desks changes" into main 2025-03-10 14:06:52 -07:00
Sukesh Ram c166a373a9 [CD Taskbar] Make External Taskbar 3-Button & Persistent
The gesture handle still persists in conjunction with the three buttons. In addition to being forced into three button mode, the taskbar on external displays needs to never enter transient mode. More info and before/after images on bug.

Flag: com.android.window.flags.enable_taskbar_connected_displays
Bug: 399718805
Test: Manual
Change-Id: Iff5c297c8ac4823fa24e7a8e4becd0447224cac0
2025-03-10 13:58:21 -07:00
Mykola Podolian 595433f1eb Merge "Fixing NPE caused by postponed action relaying on controllers." into main 2025-03-10 13:38:08 -07:00
Jon Miranda d6b9eff743 Check for isAttachedToWindow before dispatching touch event
Otherwise we get an IllegalStateException

Fixes: 380318615
Test: repos in production
Flag: EXEMPT bugfix
Change-Id: Id72b76ab288f40ee50ba8485d4b0636c525e22e3
2025-03-10 13:10:53 -07:00
Treehugger Robot a6533ae04b Merge "Improve KQS accessibility" into main 2025-03-10 12:49:00 -07:00
Treehugger Robot a4fc3ad45d Merge "Introducing a wrapper over binder to simplify lifecycle management for IPC" into main 2025-03-10 12:46:34 -07:00
Brian Isganitis dfdab91337 Fix layout transition crash for phone with QSB inline.
Phone can now have QSB inline when in landscape. Need to adjust layout
transition initialization to reflect that.

Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I9f0b61108170188da1a37b99c9e1411da6b71946
2025-03-10 15:21:13 -04:00
Randy Pfohl d94ca57547 Move flags to desktopmodeflag
Flag: com.android.launcher3.enable_fallback_overview_in_window
Flag: com.android.launcher3.enable_launcher_overview_in_window
Flag: com.android.launcher3.enable_state_manager_proto_log
Flag: com.android.launcher3.enable_recents_window_proto_log

Test: built and ran locally with flags on and off

Bug: b/401073215
Bug: b/401073401
Bug: b/401075030
Bug: b/401076625

Change-Id: I1bd2822d20f677445610b912dd82ff160bff4143
2025-03-10 19:08:55 +00:00
Simon (Qiong) Sun ebdcf7ba8a Merge "Update Task Bar and Split-Screen with new font type." into main 2025-03-10 11:09:58 -07:00
Ahmed Fakhry 6a19fc0765 Propagate desks changes
This CL propagates desk changes events to `RecentTasksList` and
`RecentsView`.

Bug: 395908683
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I77457d5e2e66166dd8c7d6505317d9add5b886a2
2025-03-10 18:06:03 +00:00
Shamali Patwa af883adedc Merge changes from topic "flags-cleanup" into main
* changes:
  [Part 3] Clean up references for flags from past release.
  [Part 2] Clean up references for flags from past release.
  [Part 1] Clean up references to flags from past release.
2025-03-10 10:54:42 -07:00
Toni Barzic 394d5e0010 Improve KQS accessibility
Adds accessible pane name, and content description for keyboard quick
switch view. Improves content description for task views, by having it
provide the task position in the task list. Also, sets a task content
description immediately when it gets associated with a task, even if the
task description is not available at the time. Accessibility focus for a
task may be requested as the KQS view is shown, so the task view should
have a meaningful content description from the start.

While here, update KQS to focus first task  by default when opened from
taskbar.

Bug: 399032757
Test: Manual, with Talkback enabled - open KQS via taskbar overflow view,
      and Alt+Tab, and verify Talkback announcements are informative
      (e.g. no "Pixel launcher" utterance).
      Also atest NexusLauncherTests:TaplTestsKeyboardQuickSwitch
Flag: EXEMPT bug fix

Change-Id: I3688954ab383035c1db35c5eb7a0ddf9a39a123f
2025-03-10 17:35:04 +00:00
Sunny Goyal 018356d3c3 Introducing a wrapper over binder to simplify lifecycle management for IPC
Fix: 400733213
Flag: NONE - release code
Test: manual
Change-Id: I5e143fce6a4cbc1dbb246bc6e0141ebbbc8bd274
2025-03-10 10:27:58 -07:00
mpodolian c7390ce4e3 Fixing NPE caused by postponed action relaying on controllers.
This change addresses a NullPointerException (NPE) caused by a postponed
action that relied on controllers. Logic has been added to verify the
availability of controllers prior to checking bubble bar visibility.
Additionally, the destruction sequence of LauncherTaskbarUIController
has been modified: the DeviceProfileListener is now unregistered before
the controller reference is cleared.

Fixes: 396336136
Test: N/A
Flag: EXEMPT bugfix
Change-Id: I1a7f716b3ad0dd4f8431773ea447b95ade4d87ef
2025-03-10 09:29:33 -07:00
Liran Binyamin a5c9d86e1d Merge "Address flakes in BubbleBarViewAnimatorTest" into main 2025-03-07 18:17:59 -08:00
Treehugger Robot 9a993d2b9d Merge "pin-shortcut: Implements the actual pinning functionality" into main 2025-03-07 18:09:10 -08:00
Artsiom Mitrokhin b673fbf897 Merge "Update taskbar overflow view to match the spec" into main 2025-03-07 18:06:50 -08:00
Brian Isganitis 0dc5fac084 Merge "Animate changes in Taskbar recents indicators." into main 2025-03-07 14:47:08 -08:00
Liran Binyamin c2edd1c79a Address flakes in BubbleBarViewAnimatorTest
- Fix some mockito issue by using a fake implementation rather
   than a mock.
 - Return early in the bubble bar animation if there's no animating
   bubble. The issue here is that the scaleY property of the bubble
   bar is set to 1 when the animation is interrupted. However, in
   the test environment, the cancellation of the animator is posted
   to a different thread, and another animation frame is running
   after the scaleY was already reset to 1.

Flag: EXEMPT test only
Test: atest BubbleBarViewAnimatorTest
Bug: 399934422
Bug: 399720438
Change-Id: I271f670c50168237aeaf867c8171ae3023ee09ff
2025-03-07 14:13:31 -08:00
Brian Isganitis 26f9468db1 Animate changes in Taskbar recents indicators.
Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Fix: 356394053
Test: go/testedequals
Change-Id: Ic018695254bbfea11469c3579e242089b00b90f5
2025-03-07 15:47:48 -05:00
Treehugger Robot b6001773da Merge "desktop-exploded-view: Launch desktop task view should reverse its exploded animation" into main 2025-03-07 11:45:18 -08:00
Treehugger Robot 9cc284aa17 Merge "Don't show more apps button in KQS opened from taskbar" into main 2025-03-07 10:39:05 -08:00
Xiaoqian Dai 3dfd8bb2b5 desktop-exploded-view: Launch desktop task view should reverse its
exploded animation

Following CLs will support launching individual task window in the
desktop task view.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 353948437
Change-Id: I5d084a7d8b231522bf5db1704cee1d6124affc22
2025-03-07 17:40:14 +00:00
Liran Binyamin fd1cb45975 Merge "Handle bubble bar drag and bubble drag to fullscreen" into main 2025-03-07 08:11:24 -08:00
Artsiom Mitrokhin dcf37ce078 Update taskbar overflow view to match the spec
This includes:
1) updating the color token used in dark mode,
2) adjusting sizes of individual app icons and their strokes.

See screenshots in http://b/383556682#comment7.

Bug: 383556682, 380386440
Flag: com.android.launcher3.taskbar_overflow
Test: manual
Change-Id: Ia05d803c5602552ce4f3e4675411b281107ac843
2025-03-07 10:38:37 -05:00
Treehugger Robot 80ffe676d1 Merge "[CD Taskbar] Remove External Taskbar's Rounded Corners" into main 2025-03-06 17:58:42 -08:00
Li Lin 6be6102a44 Merge "Add Growth Framework nudge payload model." into main 2025-03-06 17:03:21 -08:00
Shamali P 992facdff3 Unregister widget prediction callback on clear
Noticed that predictor holds the registered callback and caused leak.
Using named listener classes for better stacks and also unregisters them

Bug: N/A
Flag: EXEMPT BUGFIX
Test: WidgetPredictionsRequesterTest
Change-Id: I94211ddbc77077c98b804827bb1cecdefe57703b
2025-03-06 14:25:13 -08:00
Jagrut Desai d5e5fca0dc Merge "Fix Taskbar not present in Desktop Mode after unlocking" into main 2025-03-06 13:18:33 -08:00
Simon (Qiong) Sun 391a00630e Update Task Bar and Split-Screen with new font type.
The change applies new font type to Task Bar and Split-Screen if gsf is enbled.

Bug: b/393610004
Test: Check that the fonts change when gsf is enabled.
Flag: com.android.wm.shell.enable_gsf
Change-Id: I704763dc9aec26aa0a6fe6b95c054c8e563cdc16
2025-03-06 10:59:26 -08:00
Toni Barzic 200c5ee980 Don't show more apps button in KQS opened from taskbar
The button is shown when "hidden" non-desktop mode apps are open, and
KQS gets shown in desktop mode. Per UX, the button should be removed
when KQS is shown from taskbar, as taskbar overflow bubble.

Bug: 399860396
Test: Open apps in fullscreen, switch to desktop mode, open enough apps
     for taskbar to enter overflow, tap taskbar overflow icon, verify
     that the overflow bubble does not show "X more apps" button.
     Separately, press Alt+Tab, and verify the button gets shown.
Flag: com.android.launcher3.taskbar_overflow
Change-Id: Ic4050b1b29fe22a1e0d2be661acfca18561b4ed1
2025-03-06 17:16:10 +00:00
Sergey Pinkevich f3ea2ed42c Merge "Change launch change requirement within DesktopAppLaunchAnimatorHelper" into main 2025-03-05 23:55:30 -08:00
Jagrut Desai bf0727b60d Fix Taskbar not present in Desktop Mode after unlocking
The problem: with taskbar animation for Desktop mode we were checking, if we are already in DW then don't recreate taskbar. This was put in as condition so where DisplayController Info change we don't recreate twice. first being from transilition listerners and second being form info change in display controller.

The solution: Ignore the info change listener when there is already ongoing recreation is in progress.

Test: Presubmit
Bug: 399826787
Flag: EXEMPT bugfix

Change-Id: Ib86e79b3b4c86e515e44d1d1dd7ca98ed694c365
2025-03-05 18:58:38 -08:00
Sukesh Ram 850179005f [CD Taskbar] Remove External Taskbar's Rounded Corners
Remove Taskbar's Rounded Corners for External Display.

Flag: com.android.window.flags.enable_taskbar_connected_displays
Bug: 400799093
Test: Manual
Change-Id: I6808850647cd4136aae23de13fa54ecaba3c1025
2025-03-05 15:14:56 -08:00
Li Lin ebb8fe35bb Add Growth Framework nudge payload model.
This model will be used to drive Growth Framework nudge rendering and
behavior in follow up CL.

More details at: go/al-growth-framework-nudge

Test: Manual
Bug: 398026145
Flag: EXEMPT add separately
Change-Id: Icfd53f2587fe7b184f21f7e180c795bd6f586040
2025-03-05 15:14:54 -08:00
Treehugger Robot 7a7a92999c Merge "Making ActivityContext extend SavedStateRegistryOwner" into main 2025-03-05 11:44:19 -08:00
Liran Binyamin 6b18e3811d Handle bubble bar drag and bubble drag to fullscreen
This change wires bubble bar dragging as well as bubble dragging to
full screen behind a flag. Note that when the bubble is dragged to
full screen we remove the bubble from the bubble bar and notify
sysui but on the sysui side the bubble doesn't yet get converted.

Flag: com.android.wm.shell.enable_bubble_to_fullscreen
Bug: 388858013
Test: manual
       - with flag off
         - verify existing dragging works
       - with flag on
         - verify bubble bar can be dragged across
         - verify bubble is removed when bubble dragged to full screen zone
Change-Id: I9e4d8ee3d2ba9dffff3dd4ba91dfce1a5c723d68
2025-03-05 10:04:58 -08:00
Mykola Podolian e5c9aadf2c Merge "Added logic to show the shell drop target and update the bubble location" into main 2025-03-05 09:24:38 -08:00
Sunny Goyal 84e0e6a188 Making ActivityContext extend SavedStateRegistryOwner
Bug: 390572144
Test: Presubmit
Flag: EXEMPT refactor

Change-Id: I8272e95a8d2da95b3c93ec616fdf877b89db5b26
2025-03-05 09:22:47 -08:00
Sergey Pinkevich fe17dd475b Change launch change requirement within DesktopAppLaunchAnimatorHelper
Add freeform check and update logs

Return early instead of crashing if a launch change is not available

Bug: 395495925
Flag: NONE only adding logs, not change of actual code
Test: DesktopAppLaunchAnimatorHelperTest

Change-Id: I0d51c563a26e7d6020222cb84757e0ea8d561d69
2025-03-05 16:23:18 +00:00
Liran Binyamin d3a0c94067 Merge "Wire up bubble dragging to DropTargetManager" into main 2025-03-05 04:18:18 -08:00
Treehugger Robot 325545ac2f Merge "Allow recent task to have long-press menu" into main 2025-03-04 20:11:42 -08:00
Treehugger Robot 57cab7794a Merge "Simplifying some view iteration methods" into main 2025-03-04 18:42:06 -08:00