The reason for non-scrolling was excluding the pages view from the
accessibility hierarchy by marking it as non-important. So, I just
removed the code manipulating [non]importance of the PagedView.
However, this would make the PagesView accessibility-focusable, which is
undesirable. It becomes focusable because it supports long clicks in "normal"
mode. Since it doesn't support accessibility long clicks (i.e. Overview mode is
fetched NOT via accessibility long-click), I just disabled accessibility
long-clickability, which made PageView non-focusable, and it started to behave
correctly.
Bug: 21281859
Change-Id: I7ab01e5f39cb37c456c961199c27458c9bda1c3d
AccessibilityEvent.TYPE_VIEW_SCROLLED sent by PagedView.
This causes an additional reduntant voice message on scroll (see the
bug).
Also, setting these attributes violate rules set here:
http://developer.android.com/reference/android/view/accessibility/AccessibilityEvent.html
i.e. that these fields should be set only for descendants of
AdapterView.
Note that we can't just stop sending TYPE_VIEW_SCROLLED, because in this
case, accessibility focus won't be set after scrolling.
Bug: 21304383
Change-Id: I84f8e064d8209c0e09d6827551e00c9913829b57
> Fixing some RTL errors by specifying both marginStart and marginLeft
> Moving all layout direction checks to Utilities
> Explicitely adding @TargetApi before every method
Change-Id: Ibe9c52b93b5a6adeadb27ace2b312770fd732ea0
1. Not generating scroll events from snapToPage(). It already gets
generated from computeScrollHelper().
2. Not setting action because doing so is not mentioned here:
http://developer.android.com/reference/android/view/accessibility/AccessibilityEvent.html.
3. Not generating scroll event when the page stays same (before it was
generated, say, when we simply returned from the AllApps view to
Workspace).
4. From/To index is not the old and new page numbers; they are indices
of the first and last item; in our case, the item is the page, and
both FromIndex and ToIndex should be set to this page number.
Bug: 18761184
Change-Id: I3dadf816c3d45b8bd42a13930344874584467499
> Removing fling to delete pages
> Removing delete drop target for pages
> Removing syncpages support (was used by paged all apps)
Change-Id: I0a35ae30da8c48a27aac341bbee9fb5623665902
- Also fix a bug where the focus is not navigating to the next page when there
isn't an icon within +45 and -45 range of the origin.
b/20294717
Change-Id: I16dac5c6a0463fbc9f56a447abedad18abadde98
Elimates 304 methods based on dex analysis
The java compiler generates sythetic accessor methods for all private
fields, methods and contructors accessed from inner classes. By marking them
package-private and @Thunk instead, sythentic accessor methods are no
longer needeed. These annotated elements should be treated as private.
Change-Id: Id0dc2c92733474250d8ff12fa793d3a8adeb1f26
-> This caused funky layout issues with views not appearing
on devices prior to K in addition to log spam.
issue 17282728
Change-Id: Id05856ba2ef3de3a8a636ba9b4b46ddef3eff75e
-> adding dark panel / associated visual updates
-> cleaning up the sizing / padding / to match all apps
-> fixing a couple things from previous CL
-> (removed Context#getDrawable() calls, L-only)
Change-Id: Ia65a6eb704b35f74e7305be9334c27971b22235a
-> separating HW layers during animation to be siblings
instead of parent-child (was destroying parent layer
on each frame)
-> Unifying material transition with pre-L, everything
is the same, just missing the reveal.
Change-Id: I8f7d5e658c2d9298bea83ce8199cb35e6fc0d44e
-> Fixes issue 11701996
-> Fixes issue where if you tried to longpress a widget before the page
settled, it would instead enter overview
Change-Id: Ic6321805687dd5e8c69506c6cd6941a11d557ed6
-> Never allow the custom content overhang onto the viewport when
it is not the current page
-> Never fade the custom content screen as a consequence of scrolling
Change-Id: I91a4cfb3f740ee8b429084fce1c96258bac8dd9e
Vadim Tryshev
Sunny Goyal
Winson Chung
Hyunyoung Song
Adam Cohen
Michael Jurka