Commit Graph

21934 Commits

Author SHA1 Message Date
Pat Manning cc973dfdce Prevent multiple competing dismissals.
This brings into line with existing UX prior to the feature.

Fix: 400727071
Test: Manual. Dismiss as quickly as possible.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Ie3f6f82c3ed4626829f3a61307e73cbdb8a31ceb
2025-03-14 16:11:19 +00:00
Treehugger Robot 02be70164c Merge "Add keyboard navigation for App Chip and Chip Menu" into main 2025-03-12 10:09:13 -07:00
Brian Isganitis 2d8be58d59 Merge "Wait until updateItems is called to perform addStaticViews." into main 2025-03-12 09:10:08 -07:00
Jordan Silva 99eefc9055 Add keyboard navigation for App Chip and Chip Menu
Bug: 400410772
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual using Keyboard. Access the app chip via TAB.
Change-Id: I75f80b5c6f366ecfc27596519a721cc6ace18d45
2025-03-12 07:55:04 -07:00
Uwais Ashraf d4b187b997 Add perf tracing for several key operations in TaskView lifecycle.
Fix: 402622741
Test: Manually looking at perf traces
Flag: EXEMPT - tracing only
Change-Id: If42a30d83dd72ebfe4074fedd7bdefcd102881d6
2025-03-12 11:02:00 +00:00
Treehugger Robot b615b9bdaf Merge "Add Arrows to Folder PageIndicatorDots for Accessibility Purposes." into main 2025-03-11 23:50:53 -07:00
Mykola Podolian 4050670549 Merge "Updated animation to account bubble bar stash state." into main 2025-03-11 19:03:01 -07:00
Treehugger Robot 8561c5690f Merge "Drag and drop from the search view on the overview screen." into main 2025-03-11 18:26:48 -07:00
mpodolian 61de3b43cb Drag and drop from the search view on the overview screen.
Bubble bar drop targets have been added to the TaskbarDragController
used in the TaskbarOverlayContext. This enables dragging taskbar icons
to the bubble bar drop zone from the search view on the overview screen.

Bug: 399678274
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Go to the overview screen. Click the search icon. Drag any
application icon from the grid to the bubble bar drop zone. Drop the
application icon.

Change-Id: I33eb13785d8837fefc717a95a6566d3091ec855b
2025-03-11 16:07:21 -07:00
Mykola Podolian 00017267df Updated animation to account bubble bar stash state.
Added logic to check the bubble bar stash state and perform appropriate
animations based on that state.

Bug: 399678274
Test: Manual: Have bubbles in the bubble bar. Go to an application.
Swipe up the taskbar handle so the taskbar is shown. Click the search
icon in the taskbar. Start a drag on any icon in the grid. The bubble
bar stashes immediately on drag start. When the icon is dragged over the
bubble bar drop zone, the bubble bar unstashes and is shown at the
dragged location.
Flag: com.android.wm.shell.enable_create_any_bubble

Change-Id: I9663a03a7daacdfaba071d5e35d5b7404cefed4e
2025-03-11 15:57:34 -07:00
Brian Isganitis 2053f6fdfc Wait until updateItems is called to perform addStaticViews.
This is more consistent with pre-LayoutTransition approach, and should
behave more reliably on phones.

Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: Ib758b1e44c3b87d6d2ff71425ed40ff621261104
2025-03-11 18:53:38 -04:00
Jagrut Desai c05107357b Merge "Don't recreate Desktop Mode Taskbar if already in Desktop Mode." into main 2025-03-11 15:04:53 -07:00
Treehugger Robot ace69f7644 Merge "Making various model objects injectable" into main 2025-03-11 14:48:30 -07:00
Stefan Andonian aa29761825 Add Arrows to Folder PageIndicatorDots for Accessibility Purposes.
Bug: 383974843
Test: Verified via go/web-hv that the hitbox sizes were correct. Measured the width and height within the folder for 1 through 7 pages, and everything looked great.Change title worked, and pressing on arrows to change page worked great.
Flag: com.android.launcher3.enable_launcher_visual_refresh

Change-Id: Ic095b2abe330544882467fb4803724e8d50a1798
2025-03-11 14:27:35 -07:00
Jon Miranda ccbc78735f Merge "Check for isAttachedToWindow before dispatching touch event" into main 2025-03-11 13:38:38 -07:00
Treehugger Robot 89816b8e46 Merge "Track the empty desk correctly inside applyLoadPlan" into main 2025-03-11 12:49:52 -07:00
Treehugger Robot db6fa77ec3 Merge "Keep the desks order inside overview by its deskId" into main 2025-03-11 12:35:15 -07:00
Jagrut Desai d8ed1c6ee3 Don't recreate Desktop Mode Taskbar if already in Desktop Mode.
The problem: Due to complexitiy of recent animation, taskbar is currently getting recreated upon recent animation being canceled for Desktop Mode.
Upon canceling of recent animation showDesktopApps is called again, but user is already in desktop mode.

The solution: simply check if user is in desktop mode upon getting onEnterDesktopMode transition callback before recreating taskbar.

Test: Manual
Bug: 399857150
Flag: EXEMPT bugfix
Change-Id: I8f36a8c8c834bca7be1ce7164cd712a7578c1ab4
2025-03-11 10:41:25 -07:00
minch 3049247a2e Track the empty desk correctly inside applyLoadPlan
Track the DesktopTaskView through its `deskId` if it is the current
TaskView or the running TaskView. This is done to support emtpy
desk which has no tasks inside.

Bug: 400532675
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: Id1e7e7efc2a6ac3126d0320d85a3d327eec0f3c1
2025-03-11 17:41:25 +00:00
Jordan Silva afff31deb3 Merge "Add hover and pressed states for app chip and menu items" into main 2025-03-11 10:27:51 -07:00
minch c972e58da3 Keep the desks order inside overview by its deskId
Bug: 400723456
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: Ib86e1260620587293ababfaa94aacef5846a8479
2025-03-11 17:22:50 +00:00
Sukesh Ram feda773d48 Merge "[CD Taskbar] Make External Taskbar 3-Button & Persistent" into main 2025-03-11 09:32:47 -07:00
Treehugger Robot 2595899b6e Merge "Reset All Apps button alpha at the end of all set page -> home animation" into main 2025-03-11 09:12:54 -07:00
Johannes Gallmann 986985f5c0 Merge "Fix back button touch region too small" into main 2025-03-11 08:45:34 -07:00
Schneider Victor-Tulias f7b75b2f8c Reset All Apps button alpha at the end of all set page -> home animation
Flag: EXEMPT bug fix
Fixes: 360338079
Test: swiped up from the all set page
Change-Id: Ide5eb3b8e81bfc67975932d0806e4ab17d60c078
2025-03-11 07:03:19 -07:00
Jordan Silva 38af4f71c7 Add hover and pressed states for app chip and menu items
Fix: 356830855
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewActionsMenuHoverImageTest
Change-Id: I3a244a4eea07192a622c57d28618dabbb107a088
2025-03-11 05:37:43 -07:00
Massimo Carli 284fdfb2e3 Merge "Consider userId in transparent policy heuristic" into main 2025-03-11 03:55:06 -07:00
Jordan Silva b6bae63a6e Merge "Fix TaskMenuView to calculate bottom menu's max height" into main 2025-03-11 03:45:25 -07:00
Johannes Gallmann b44c55a6a1 Fix back button touch region too small
The back button in 3-button-nav touch region was unintentionally
decreased with the predictive_back_three_button_nav flag. The reason is
that NearestTouchFrame did not consider the back button for its touch
forwarding logic, because the back button did not have isClickable set
to true. Manually setting the clickable attribute fixes that.

Bug: 393498908
Test: Manual, i.e. verified that touches close to back button are not routed to the home button
Flag: EXEMPT bugfix
Change-Id: I7ad1ee13f92aa947f1a86f8d65de79a9d9e13899
2025-03-11 08:11:05 +00:00
Wei Sheng Shih 7d05e50e88 Merge "Remove DepartingAnimationTarget from BackMotionEvent(2/2)" into main 2025-03-10 23:25:25 -07:00
Treehugger Robot 3868333a60 Merge "Fix layout transition crash for phone with QSB inline." into main 2025-03-10 17:04:12 -07:00
Randy Pfohl 0678d08e87 Merge "Move flags to desktopmodeflag" into main 2025-03-10 14:50:38 -07:00
Sunny Goyal 42975c39db Making various model objects injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ibb45b72c186e6aeeed7a37b0ae3f8083472019d7
2025-03-10 14:37:43 -07:00
Ahmed Fakhry 30d39caacb Merge "Propagate desks changes" into main 2025-03-10 14:06:52 -07:00
Sukesh Ram c166a373a9 [CD Taskbar] Make External Taskbar 3-Button & Persistent
The gesture handle still persists in conjunction with the three buttons. In addition to being forced into three button mode, the taskbar on external displays needs to never enter transient mode. More info and before/after images on bug.

Flag: com.android.window.flags.enable_taskbar_connected_displays
Bug: 399718805
Test: Manual
Change-Id: Iff5c297c8ac4823fa24e7a8e4becd0447224cac0
2025-03-10 13:58:21 -07:00
Mykola Podolian 595433f1eb Merge "Fixing NPE caused by postponed action relaying on controllers." into main 2025-03-10 13:38:08 -07:00
Jon Miranda d6b9eff743 Check for isAttachedToWindow before dispatching touch event
Otherwise we get an IllegalStateException

Fixes: 380318615
Test: repos in production
Flag: EXEMPT bugfix
Change-Id: Id72b76ab288f40ee50ba8485d4b0636c525e22e3
2025-03-10 13:10:53 -07:00
Treehugger Robot a6533ae04b Merge "Improve KQS accessibility" into main 2025-03-10 12:49:00 -07:00
Treehugger Robot a4fc3ad45d Merge "Introducing a wrapper over binder to simplify lifecycle management for IPC" into main 2025-03-10 12:46:34 -07:00
Brian Isganitis dfdab91337 Fix layout transition crash for phone with QSB inline.
Phone can now have QSB inline when in landscape. Need to adjust layout
transition initialization to reflect that.

Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I9f0b61108170188da1a37b99c9e1411da6b71946
2025-03-10 15:21:13 -04:00
Randy Pfohl d94ca57547 Move flags to desktopmodeflag
Flag: com.android.launcher3.enable_fallback_overview_in_window
Flag: com.android.launcher3.enable_launcher_overview_in_window
Flag: com.android.launcher3.enable_state_manager_proto_log
Flag: com.android.launcher3.enable_recents_window_proto_log

Test: built and ran locally with flags on and off

Bug: b/401073215
Bug: b/401073401
Bug: b/401075030
Bug: b/401076625

Change-Id: I1bd2822d20f677445610b912dd82ff160bff4143
2025-03-10 19:08:55 +00:00
Jordan Silva 298ed152f3 Fix TaskMenuView to calculate bottom menu's max height
Fix: 402145575
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewMenuImageTest
Change-Id: I9cc02ea501bb599e8ec614912389b04130552089
2025-03-10 11:25:10 -07:00
Simon (Qiong) Sun ebdcf7ba8a Merge "Update Task Bar and Split-Screen with new font type." into main 2025-03-10 11:09:58 -07:00
Ahmed Fakhry 6a19fc0765 Propagate desks changes
This CL propagates desk changes events to `RecentTasksList` and
`RecentsView`.

Bug: 395908683
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I77457d5e2e66166dd8c7d6505317d9add5b886a2
2025-03-10 18:06:03 +00:00
Shamali Patwa af883adedc Merge changes from topic "flags-cleanup" into main
* changes:
  [Part 3] Clean up references for flags from past release.
  [Part 2] Clean up references for flags from past release.
  [Part 1] Clean up references to flags from past release.
2025-03-10 10:54:42 -07:00
Toni Barzic 394d5e0010 Improve KQS accessibility
Adds accessible pane name, and content description for keyboard quick
switch view. Improves content description for task views, by having it
provide the task position in the task list. Also, sets a task content
description immediately when it gets associated with a task, even if the
task description is not available at the time. Accessibility focus for a
task may be requested as the KQS view is shown, so the task view should
have a meaningful content description from the start.

While here, update KQS to focus first task  by default when opened from
taskbar.

Bug: 399032757
Test: Manual, with Talkback enabled - open KQS via taskbar overflow view,
      and Alt+Tab, and verify Talkback announcements are informative
      (e.g. no "Pixel launcher" utterance).
      Also atest NexusLauncherTests:TaplTestsKeyboardQuickSwitch
Flag: EXEMPT bug fix

Change-Id: I3688954ab383035c1db35c5eb7a0ddf9a39a123f
2025-03-10 17:35:04 +00:00
Sunny Goyal 018356d3c3 Introducing a wrapper over binder to simplify lifecycle management for IPC
Fix: 400733213
Flag: NONE - release code
Test: manual
Change-Id: I5e143fce6a4cbc1dbb246bc6e0141ebbbc8bd274
2025-03-10 10:27:58 -07:00
Sebastián Franco 0d8df93275 Merge "Sync landscape rotation with Overview rotation" into main 2025-03-10 09:30:11 -07:00
mpodolian c7390ce4e3 Fixing NPE caused by postponed action relaying on controllers.
This change addresses a NullPointerException (NPE) caused by a postponed
action that relied on controllers. Logic has been added to verify the
availability of controllers prior to checking bubble bar visibility.
Additionally, the destruction sequence of LauncherTaskbarUIController
has been modified: the DeviceProfileListener is now unregistered before
the controller reference is cleared.

Fixes: 396336136
Test: N/A
Flag: EXEMPT bugfix
Change-Id: I1a7f716b3ad0dd4f8431773ea447b95ade4d87ef
2025-03-10 09:29:33 -07:00
Massimo Carli 156b9b3184 Consider userId in transparent policy heuristic
Flag: com.android.window.flags.enable_modals_fullscreen_with_permission
Bug: 401583497
Test: atest NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest
Test: atest NexusLauncherTests:com.android.quickstep.ExternalDisplaySystemShortcutTest

Change-Id: Ife36b3a7e2ba0376cf72ca545fa05c5a90d52f07
2025-03-10 14:30:43 +00:00