Commit Graph

19116 Commits

Author SHA1 Message Date
Treehugger Robot cc0e19d298 Merge "Add more logs to investigate empty launcher restore" into main 2024-12-07 05:13:33 +00:00
Shamali Patwa 5fb8180b00 Merge "Remove the elevation on the DragView to avoid shadows underneath" into main 2024-12-06 23:40:38 +00:00
Treehugger Robot ddaf0bbd7a Merge "Modify the accessibility tree to move the searchbox to the top." into main 2024-12-06 23:37:45 +00:00
Charlie Anderson bad2be4944 Add more logs to investigate empty launcher restore
Flag: EXEMPT logs
Test: presubmit
Bug: 377510898
Change-Id: I1c05b90c9e1337663c4c06703ad14b6c0d00aa07
2024-12-06 22:14:19 +00:00
Anushree Ganjam 8335b9790a Modify the accessibility tree to move the searchbox to the top.
This change fixes both quickstep and pixel launcher variants.

Before
A11y traversal order : https://paste.googleplex.com/4735370693181440
Video: http://recall/-/cYrER3oshUB9gisWlEhySV/fGSVr7vsAToApiYzywptQ6

After
A11y traversal order : https://paste.googleplex.com/6464092613902336
Video: http://recall/-/cYrER3oshUB9gisWlEhySV/cEEPIPidHGP4tg9Hng7Ra6

Bug: 378610191
Test: Manual
Flag: EXEMPT a11y Bugfix
Change-Id: I95fbdc2db02f2957db461769e0d9a0556adbb760
2024-12-06 13:13:15 -08:00
Shamali P cc21323af2 Remove the elevation on the DragView to avoid shadows underneath
In b/297952359 we are seeing that widgets with clipped outline
 elements end up showing shadows below their drag view. Which
 due to not maintaining clipping looks further bad.

It seems like, we don't really need the elevation for drag
view anymore - and presumably it was added for older android
 versions for shadow for folders. But, they don't have them
  anymore, so, removing elevation now.

 Note: The issue that during drag and drop, the dragged preview
 not showing clip to outline or shadows within widget's views is
 a separate issue related to the Picture API usage during drag
  and drop.

Bug: 297952359
Test: Screen record in comments
Flag: EXEMPT Bugfix

Change-Id: If31a0275938afe374d269a46cc950970033323f9
2024-12-06 21:10:51 +00:00
Treehugger Robot 07bf3c3085 Merge "Restore fallback Overview state when restarted by theme changes" into main 2024-12-06 19:35:07 +00:00
Treehugger Robot 3e159f5654 Merge "Generalizing monochrome icon into Theme icons" into main 2024-12-06 18:29:07 +00:00
Alex Chau c76d4a8971 Restore fallback Overview state when restarted by theme changes
- Moved RUNTIME_STATE_RECREATE_TO_UPDATE_THEME to StatefulActivity
- Handle uiMode in RecentsActivity
- When RecentsActivity is recreated due to theme changes, restore previous state

Fix: 382072029
Test: Manual: Change light/dark them from QuickSettings while in fallback Overview, Overview stay open
Flag: EXEMPT bugfix
Change-Id: Ia596150afa1436c4a25e94fd2b6930a8ded0b0d4
2024-12-06 17:10:03 +00:00
Sunny Goyal 97eb832cd3 Generalizing monochrome icon into Theme icons
Bug: 381897614
Flag: EXEMPT refactor
Test: atest MonoIconThemeControllerTest
      atest MonoThemedBitmapTest

Change-Id: Iaa0cbe3523ee26a6d4f77e002d0cca90657f89b2
2024-12-05 14:57:06 -08:00
Uwais Ashraf 4b05341d6e Merge "Use custom background dispatcher to stop excess thread creation." into main 2024-12-05 21:37:38 +00:00
Pinyao Ting 0cb19af97c Merge "Hide "Shortcut Menu" from a11y actions when shortcut menu is already opened" into main 2024-12-05 21:05:31 +00:00
Mykola Podolian 362e060c4e Merge "Update Hotseat icons adjustment X calculation based on cell X Index" into main 2024-12-05 19:59:51 +00:00
Sebastián Franco 8f3a671ff6 Merge "Fix findMinWidthAndHeightDpForDevice so it finds the smallest dp height of the cached displays" into main 2024-12-05 12:54:52 +00:00
Sebastián Franco 5c4cebc4ac Merge "Using the right context when in FixedLandscape" into main 2024-12-05 12:54:52 +00:00
Uwais Ashraf 1348514466 Use custom background dispatcher to stop excess thread creation.
Bug: 381317629
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Performance tests
Change-Id: I0e205cf7f55c90375a5a1e95fbd0f1adf0fc6658
2024-12-05 11:05:27 +00:00
Sebastián Franco 2377bd1c3a Merge "Make sure GRID_NAME is updated every time it changes." into main 2024-12-05 03:46:37 +00:00
Charlie Anderson a2464c6609 Merge "Add logging to verify when LoaderTask is stopped or cancelled" into main 2024-12-05 02:34:09 +00:00
Sebastian Franco 2b0cdbbc87 Make sure GRID_NAME is updated every time it changes.
Bore it was only updated when the device was innitialized,
but other changes to the IDP would not udpate the GRID_NAME pref.

Fix: 380954618
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: I4fa73a4b838c0d0c7c1c88ea91c62ac8ae6676b7
2024-12-05 01:25:25 +00:00
mpodolian 2fd98270a7 Update Hotseat icons adjustment X calculation based on cell X Index
Resolved an issue where the X translation for hotseat icons was computed
using the view index in the parent, leading to misaligned adjustments.
The logic has been updated to calculate translation based on the cell X
index, ensuring more accurate positioning and alignment.

Fixes: 380794616
Test: Manual. Have a bubble in landscape orientation. Drag any item from
the hotseat to the workspace, then rotate the device.
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: Ibd0709e6c58ad9c1470de469cfced8bbe66fd30b
2024-12-04 16:23:00 -08:00
fbaron 9ce45bac05 Fix findMinWidthAndHeightDpForDevice so it finds the smallest dp height of the cached displays
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: I04bc264a3f3579eff18412c02546460aaaeff955
2024-12-04 23:51:43 +00:00
Sebastian Franco 789546f528 Using the right context when in FixedLandscape
Fix: 378956881
Test: HomeScreenImageTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I57c0fb2b57828e0cb80d20417f0a45e49c78b80e
2024-12-04 23:51:34 +00:00
Pinyao Ting caac0a978d Hide "Shortcut Menu" from a11y actions when shortcut menu is already opened
Bug: 378062790
Change-Id: Iab742e7f24625b1f626c30bbbefdcad68d61904e
Test: manual
Flag: EXEMPT bugfix
2024-12-04 23:14:12 +00:00
Charlie Anderson 8d76114fe3 Add logging to verify when LoaderTask is stopped or cancelled
Flag: EXEMPT just logging
Test: Presubmit
Bug: 377510898
Change-Id: Ie97adc07ed995af8b09eab232fcce9431bea42d5
2024-12-04 15:56:43 -05:00
Shamali Patwa 2909e72d36 Merge "Update accessibility hint for widget cell that shows add button." into main 2024-12-04 20:22:26 +00:00
Treehugger Robot 14a4684992 Merge "Fix issue in scrolling in remote compose widgets" into main 2024-12-04 18:38:57 +00:00
Shamali P 0e668e1b1d Update accessibility hint for widget cell that shows add button.
With tap to add feature, tapping widget cell reveals add button.

So, clarify the intent with ACTION_CLICK

Bug: 374033389
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I03e47241fbc16f1354394e3a6fd412998642e6cf
2024-12-04 18:12:36 +00:00
Alex Chau d7ad4d5dee Merge "Reapply insets normalization on configuration changes" into main 2024-12-04 11:25:37 +00:00
Alex Chau ba8b4d7851 Merge "Reland "Handle uiMode changes in QuickstepLauncher"" into main 2024-12-04 10:45:02 +00:00
Pinyao Ting 1f72f9b3de Fix issue in scrolling in remote compose widgets
There was special check in LauncherAppWidgetHostView to disallow intercept touch events in launcher when the widget is scrollable, the same check needs to be implemented for remote compose widget for scrolling to work properly.

Bug: 339721781
Change-Id: I8b824f293ab287a7844f93610b8b952c4aefa3dd
Test: manual
Flag: EXEMPT bugfix
2024-12-04 00:45:48 +00:00
Treehugger Robot d0b6a849ad Merge "Make DynamicResource as dagger singleton (15/n)" into main 2024-12-03 22:14:56 +00:00
Treehugger Robot 5ef606c417 Merge "Do not let talkback read "Item added to home screen" after an app is added to home screen." into main 2024-12-03 21:43:08 +00:00
Anushree Ganjam b60be0896d Make DynamicResource as dagger singleton (15/n)
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I8a3de783de34f79c8f8f64c5c964cc1636ace1a8
2024-12-03 12:01:45 -08:00
Alex Chau 579a785144 Reapply insets normalization on configuration changes
- When going from an app to Overview after deivce is rotated, sometimes the Configuration associated with Launcher activity have old information (dimension from preious rotation), causing LauncherRootView.onApplyWindowInsets to store wrong insets from WindowManagerProxy.normalizeWindowInsets
- The fix is when LaucnehrRootView.dispatchInsets is called, reapply insets by calling onApplyWindowInsets again to get updated normalized insets.

Fix: 323105140
Test: Launch an app, rotate to landscape, tap Recents button to go to Overview
Flag: EXEMPT BUG_FIX
Change-Id: I8e641a2702670d1364ee5a0f10a1b3c8d1a2b324
2024-12-03 19:03:28 +00:00
Brandon Dayauon f274d3ca95 Merge "Fix "disabled" at the end of talkback for workPausedCard." into main 2024-12-03 18:31:46 +00:00
Alex Chau 007abe80e4 Reland "Handle uiMode changes in QuickstepLauncher"
- Added uiMode in handled configChanges for QuickstepLauncher, NexusLauncherActivity
- RecentsActivity will be handled separately in b/382072029
- This avoids Launcher from being recreated when swithching from an app in driving mode (e.g. Maps), which causes massive jank
- Launcher layout is unaffected when driving mode changes, so a recreation is unnecessary
- When Light/dark mode changes, BaseActivity.updateTheme will still causes activity to be recreated. Launcher will mark a boolean in saved staete so next recreate will restore previous state even if state has FLAG_DISABLE_RESTORE (e.g. Overview), similar to the existing check that force restore when UI_MODE changes

Relanded changes: /q/submissionid:27627108-b/339747262

Fix: 339747262
Test: Swtich from driving mode app to another or home in 1p and 3p laucnher
Test: Switch light/dark mode and Launcher is updated correctly and stay in previous state
Flag: EXEMPT bugfix
Change-Id: I5a62b1bcd19eed9d232f30db94aa0e032f4541bd
2024-12-03 18:20:56 +00:00
Treehugger Robot 1733dedf85 Merge "Add GridDimensionSpecs to fixed landscape and make grid dimension generalized so we can use it to determine row count or col count" into main 2024-12-03 18:05:10 +00:00
Brandon Dayauon a7340e8575 Merge "Add unit testing to workkUtilityView" into main 2024-12-03 15:43:48 +00:00
fbaron d1cd8c2ea6 Add GridDimensionSpecs to fixed landscape and make grid dimension generalized so we can use it to determine row count or col count
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: If1dafedc710ebc483fc7b6b5cd6cae6f70dc3cfc
2024-12-03 02:43:13 +00:00
Kevin Lim 79fb6dfbdb Merge "[a11y] Fix talkback column and item count for AllAppsGrid" into main 2024-12-02 20:52:54 +00:00
Treehugger Robot 27c2f4ddc1 Merge "Decouple Backup / Restore Error Codes" into main 2024-12-02 18:57:17 +00:00
Brandon Dayauon fcb892328b Add unit testing to workkUtilityView
Testing inflate and visibility states (with both flag states)

bug: 361589193
Test: manually screenshot: https://screenshot.googleplex.com/45HDsyfQfNbgjiE
Flag: com.android.launcher3.work_scheduler_in_work_profile
Change-Id: I57cff03fe3b362e304f52984a2699f8d5b6e653e
2024-12-02 10:32:56 -08:00
Treehugger Robot b5bf7820e6 Merge "Adding MSDL haptics for dragging app icons in Workspace and Hotseat." into main 2024-11-29 08:14:34 +00:00
Stefan Andonian 6df13d3b8e Decouple Backup / Restore Error Codes
Bug: 381315244
Test: Simply looked at emitted error codes and changed names if they were used in multiple locations.
Flag: EXEMPT bug fix
Change-Id: Iab4a8d6ff410682f448b2ac32e44b766d79a7616
2024-11-27 16:48:28 -08:00
Brandon Dayauon 067ed8fa6e Fix "disabled" at the end of talkback for workPausedCard.
Talk back announces "disabled" at the end because onClick() seems to unncessarily call setEnabled(false). It's not needed
and can be removed.

bug: 379804516
Test: manually with talkback
Flag: EXEMPT bug fix
Change-Id: Iebd0c0689f7a36320ec59b6898daf10988b75cf6
2024-11-27 15:53:25 -08:00
Treehugger Robot c4a90de0e9 Merge "Convert px to dp for determining minWidth and minHeight for each row count, and add breakpoints" into main 2024-11-27 21:17:43 +00:00
Ana Salazar Maldonado ffef53ecb6 Merge "Fix condition for showing contraste tile" into main 2024-11-27 21:16:38 +00:00
Mykola Podolian 400fc4ad98 Merge changes I239f9357,I57a32ac5 into main
* changes:
  Update setting taskbar window height
  Set bubble bar aligned to QSB
2024-11-27 20:44:53 +00:00
mpodolian 28907bcbd6 Set bubble bar aligned to QSB
Change logic to updated bubble bar alignment with the QSB vertical
center for 3 buttons navigation mode.

Fixes: 378400160
Flag: com.android.wm.shell.enable_bubble_bar
Test: PersistentBubbleStashControllerTest
Test: TransientBubbleStashControllerTest
Test: Manual. Set the buttons navigation mode and observe that the
bubble bar is centered with the QSB when the QSB is not aligned with the
hotseat. Then, switch to gestures navigation mode and observe that the
bubble bar is centered with the hotseat when the QSB is not aligned with
the hotseat.

Change-Id: I57a32ac5bde7a7055b54a89727429424e5c0ca4f
2024-11-27 10:15:08 -08:00
Ana Salazar Maldonado 1e392d6679 Fix condition for showing contraste tile
Merge error caused the condition to only draw contrast tiles for empty
labels.

Bug: 381062398
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: Id2d55d3bc16e76613faca07b0fd28ef01921f016
2024-11-27 10:00:58 -08:00