Commit Graph

17984 Commits

Author SHA1 Message Date
Anushree Ganjam cbfa8043c8 Merge "Add "Don't suggest app" shortcut to suggested apps." into main 2024-01-17 22:25:17 +00:00
Andy Wickham 32f2cae290 Merge "Allow stashed taskbar to be long pressed." into main 2024-01-17 21:09:15 +00:00
Shamali Patwa 56fd022d10 Merge "Filter shortcuts in the widget picker activity." into main 2024-01-17 14:15:51 +00:00
Pat Manning 5b7f564395 Merge "Add flag guard to hover actions in TouchInteractionService." into main 2024-01-17 13:05:20 +00:00
Pat Manning 8bcf485ac4 Add flag guard to hover actions in TouchInteractionService.
Flag: ACONFIG com.android.launcher3.enable_cursor_hover_states NEXTFOOD
Test: Manual.
Bug: 306745595
Change-Id: I74818f517b84c4aba8a7dd4a77397495595bbef5
2024-01-17 11:44:31 +00:00
Andy Wickham caf0c35661 Allow stashed taskbar to be long pressed.
Bug: 319175012
Test: Manual and unit test
Flag: NA
(see other change)

Change-Id: Ic8ac68d21c64a909a1035339d36f9c3b50a8963c
2024-01-16 21:43:46 -08:00
Vinit Nayak 701d267b05 Add log when user attempts to split with widget
Bug: 295467097
Flag: none

Change-Id: Ice6cdc7a2db85c8efca7d4e1bc74a0cdc367a9ab
2024-01-16 23:54:19 +00:00
Vinit Nayak fc02f88d1b Merge "Sync split dismiss anim scrim fadee timing with taskbar to home anim duration" into main 2024-01-16 23:21:03 +00:00
Shamali P ddde81f4c0 Filter shortcuts in the widget picker activity.
In its current state the WidgetPickerActivity only allows adding widget
items, so to match the state, updated it to show only widgets.

manual test - https://screen/cast/NDUxMjg1NjI0MTM0MDQxNnwxMzE4MzNhOS1mZg

Bug: 320495335
Test: atest Launcher3Tests
Flag: N/A
Change-Id: Ifa75f457219efef49e104efc428d369187db2710
2024-01-16 21:19:16 +00:00
Vadim Tryshev f93d6ed80e Demoting new flaky test testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme to postsubmit
Bug: 320490387
Test: presubmit
Flag: N/A
Change-Id: I1e94ebc71089f68354069fd932be98dd53926ec4
2024-01-16 10:50:52 -08:00
Schneider Victor-tulias 0c8439e17d Merge "Update the KQS app launch animation to match the spec exactly" into main 2024-01-15 18:42:37 +00:00
Johannes Gallmann 898b9af9a2 Merge "Fix stuck wallpaper with predictive back" into main 2024-01-15 09:51:42 +00:00
Anushree Ganjam 64614a1ec6 Merge "Add null check since LauncherUserInfo can be null." into main 2024-01-13 05:04:14 +00:00
Anushree Ganjam 32b5ac61e0 Add null check since LauncherUserInfo can be null.
Bug: 319142187
Test: Manual
Flag: N/A. Crash in tests.
Change-Id: Iaa9fc1b8e7c2c09621d984bfdeb9012bcc479ef8
2024-01-12 18:05:29 -08:00
Tony Wickham dc566559d0 Merge "Improve Taskbar touchableRegion debuggability" into main 2024-01-13 01:38:18 +00:00
Jagrut Desai a15b88f484 Merge "Adding Taskbar Pinning Analytics again." into main 2024-01-13 00:54:14 +00:00
Sunny Goyal 39f235154e Merge "Fixing some launcher model tests" into main 2024-01-12 23:04:39 +00:00
Jagrut Desai fff93577e8 Merge "Update enableTaskbarNoRecreate logic" into main 2024-01-12 22:31:15 +00:00
Charlie Anderson 9fc2fa34b3 Merge "Replace ENABLE_LAUNCHER_BR_METRICS flags with fixed aconfig flag." into main 2024-01-12 21:37:17 +00:00
Jagrut Desai 777f3a4b9d Merge "Fix TaskbarDividerPopupView vertrical Arrow offset" into main 2024-01-12 21:18:27 +00:00
Sunny Goyal 6449a21062 Fixing some launcher model tests
> Removing static mocks and using Sandbox context instead
> Removing inheritence in LauncherModel and converting LauncherApps.Callbacks
  to a separate class. decMaker sometimes fails because of API changes in
  LauncherApps.Callbacks

Bug: 319877828
Test: atest LoaderTaskTest
Flag: N/A
Change-Id: If78b5d83595627a355b284f52d887d75fef53014
2024-01-12 12:30:52 -08:00
Bill Yi 9f46172927 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-01-12 20:09:43 +00:00
Charlie Anderson da3138cd91 Replace ENABLE_LAUNCHER_BR_METRICS flags with fixed aconfig flag.
This is necessary because the value of the read-write flag will not be updated in time for backup/restore.

Bug: 307527314
Test: compiles
Flag: ACONFIG ENABLE_LAUNCHER_BR_METRICS_FIXED TEAMFOOD
Change-Id: I67a1a820734d8881b3ed5be4a1f2f1556e6e4704
2024-01-12 14:33:29 -05:00
Jagrut Desai 057144e0f6 Update enableTaskbarNoRecreate logic
Test: Presubmit
Bug: 318567569
Flag: NONE
Change-Id: I6927f0bab0317219a00a7c09c08640825d54e91b
2024-01-12 10:59:10 -08:00
Vadim Tryshev 8ed18ab5bc Merge "Using a standard way to go to Overview in DWB Toast test" into main 2024-01-12 18:41:20 +00:00
Anushree Ganjam 5e9b71e055 Add "Don't suggest app" shortcut to suggested apps.
This works for suggested apps in both Home and AA+. When enable_shortcut_dont_suggest_app is true, the secondary drop target "Don't Suggest app" is removed instead "Don't suggest app" is added to shortcuts.

Video: https://b.corp.google.com/issues/319250810#comment5

Home: https://screenshot.googleplex.com/d7Wts48X6EmFAYg.png
Private space app suggested: https://screenshot.googleplex.com/BukzCRTvkzbpwQ3.png

AA+: https://screenshot.googleplex.com/ADMCHnQ378jvJEE.png
Private space app suggested : https://screenshot.googleplex.com/AYga8Km3646AqMt.png

Bug: 319250810
Flag: aconfig com.android.launcher.enable_shortcut_dont_suggest_app DEVELOPMENT
Test: Manual.

Change-Id: Ia7df749a1c7d806bd9d74124be138384c3050119
2024-01-12 10:33:24 -08:00
Anna Zhuravleva eb1966c278 Merge "Add shortcut to install an app to Private space" into main 2024-01-12 15:51:05 +00:00
Johannes Gallmann 9532717757 Merge changes I05d517a7,Ided0a095 into main
* changes:
  Minor clenaup in LauncherBackAnimationController
  Fix window corner radius for predictive back to home on Felix
2024-01-12 10:33:56 +00:00
Johannes Gallmann 09f29f7492 Merge "Align window clipping logic of back-to-home to cross-task-back" into main 2024-01-12 09:15:41 +00:00
Tracy Zhou 7a30de2fc3 Merge "Remove taskbar window from WindowManager in TaskbarManager.destroy()" into main 2024-01-12 06:05:44 +00:00
Bill Yi 2f863664af Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Iecc8364731c1fd3bd540875601599642a36a1e96
2024-01-11 17:25:02 -08:00
Tracy Zhou 78c548a829 Remove taskbar window from WindowManager in TaskbarManager.destroy()
When task bar crashes (from anything), task bar window is not cleaned up properly. This is because destroyExistingTaskbar() only removes the root layout from the window when we are no longer rendering task bar (one use case of that is folding the device). We need to clean it up in onDestroy() also.

Fixes: 319105323
Test: adb shell am crash com.android.systemui and make sure there is only one task bar window
Change-Id: Ia9c808e903422707bf4c270b2631fc913dde65d9
2024-01-11 16:13:06 -08:00
Tony Wickham 480448b059 Merge "Temporary workaround for taskbar hiding in Desktop" into main 2024-01-11 23:21:42 +00:00
Jagrut Desai 3fc1e3a45d Fix TaskbarDividerPopupView vertrical Arrow offset
Test: Manual
Bug: 310673489
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TEAMFOOD
Change-Id: I6c6af315cb058c8da599af8120a6a903ab247006
2024-01-11 14:00:37 -08:00
Vadim Tryshev 5674552a5d Using a standard way to go to Overview in DWB Toast test
Standardizing reduces maintenance.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I0f59262a9f34c29a97c496f0f61c44ab1af56d04
2024-01-11 12:46:47 -08:00
Jagrut Desai 80cc62173e Adding Taskbar Pinning Analytics again.
Test: Presubmit
Bug: 265436916
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TEAMFOOD
Change-Id: I742dccccc7648bb7ec8bf94d5f5f55430a5543ab
2024-01-11 11:33:02 -08:00
Anna Zhuravleva 29a3139815 Add shortcut to install an app to Private space
Introduce long-press shortcut to install a copy
of the main user app to private space.

Test: manual, installed apps in different stores
and tried shortcut
https://screenshot.googleplex.com/6oAVamTytiYmvPC.png
Bug: 316118005
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space_install_shortcut DEVELOPMENT

Change-Id: I702cd2a27388e3cc6e9e126308d5479836ba6655
2024-01-11 12:40:28 +00:00
Riddle Hsu 1438af66f8 Merge "Fix leakage of GestureExclusionListener" into main 2024-01-11 05:54:05 +00:00
Tony Wickham 4e7411c54c Temporary workaround for taskbar hiding in Desktop
Taskbar still hides during the transition, but then reappears
after settling.

Flag: LEGACY ENABLE_HOME_TRANSITION_LISTENER enabled
Bug: 314207404
Test: manual
Change-Id: Ie3d29b3d40e513f39cb34176baa781c9f2853e57
2024-01-10 19:59:25 +00:00
Tracy Zhou e19c572ac2 Merge "Hook up luma sampling state change from CommandQueue" into main 2024-01-10 19:33:24 +00:00
Vinit Nayak 9efb2fb0a0 Sync split dismiss anim scrim fadee timing with taskbar to home anim duration
* We sync the scrim fade with the taskbar animation duration
to avoid any flickers fortaskbar icons disappearing before hotseat
icons show up.
* Layer wise taskbarIcons > scrim > hotseat
as taskbarIcons are translating into place, the frame where they fade out
the scrim should also fade out so they get seamlessly replaced by hotseat icons
* In our case the scrim was staying on too long so the scrim would show before
the hotseat, making it look like a flicker.
* Now we fade away the scrim sooner

Bug: 318747712
Test: Flicker no longer occurs
Flag: None
Change-Id: I779af1826ee55bfcbced3e972f14f5f299e9aaeb
2024-01-10 11:18:26 -08:00
Schneider Victor-tulias 7b019ef700 Update the KQS app launch animation to match the spec exactly
Updated the KQS to look exactly like the default app launch animation, in the opposite direction:
- animation interpolator
- task corner radius
- task margin
- animation duration

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313606549
Fixes: 313607264
Test: launched tasks from KQS from home and launched app
Change-Id: I3f49f9430b2148680816d904aced93d14f366123
2024-01-10 15:34:00 +00:00
Johannes Gallmann 376cde95d0 Align window clipping logic of back-to-home to cross-task-back
Bug: 315461656
Flag: ACONFIG com.android.systemui.predictive_back_system_animations STAGING
Test: Manual, i.e. visually verifying back to home behaviour on Felix
Change-Id: I075c38fc58c56108128fdf895c62b2f626da36ad
2024-01-10 14:18:39 +00:00
Helen Cheuk 78745df2b4 Merge "Fix wrong translation for swiping up split task" into main 2024-01-10 13:11:05 +00:00
helencheuk 06ddebb34f Fix wrong translation for swiping up split task
The wrong calculation is caused by using half size mTaskRect in Split task to calculate the translation X to middle
It should use the fullTaskSize instead of half size. This change refactors the code to store the full size so it does not need to re-calculate many times

Bug: 312371505
Test: Manual, swiping up split task diagonally from right side many times, test the case when mSplitBounds is not null in addAppToOverviewAnim
Test: Tested swipe up to overview for split task/single task in Phone, Tablet and Unfolded phone, with the flag on and off
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: Id2b008a7d9597271e077a125f3195b27196797d7
2024-01-10 11:40:58 +00:00
Riddle Hsu 96d7f9c2d7 Fix leakage of GestureExclusionListener
So the unregister/register are paired when launcher activity
is relaunched:

Launcher#onDestroy
 > mSplitWithKeyboardShortcutController.onDestroy()
+ > RecentsAnimationDeviceState#destroy
+  > unregisterExclusionListener

Launcher#onCreate
 > setupViews
  > new SplitWithKeyboardShortcutController
   > new RecentsAnimationDeviceState
    > onDisplayInfoChanged
     > registerExclusionListener

Bug: 319133753
Test: Toggle screen resolution many times and check the amount
      of DisplayContent#mSystemGestureExclusionListeners.
Change-Id: I2fb84415db71aaa14e653fea2592d6b9b5adad59
2024-01-10 17:59:28 +08:00
Tracy Zhou cf5407dfc6 Hook up luma sampling state change from CommandQueue
Currently when swiping up from some apps (maps), the stashed task bar color changes. Instead, sampling should be disabled during the transition (with a signal from the frameworks).

Bug: 230395757
Test: Swipe up from maps. Make sure the bar color doesn't change during transition
 to overview
Change-Id: Ifc30f4067a0e4d134b422d152f5b5caee0a77a33
2024-01-09 21:56:58 -08:00
Fengjiang Li ad3915e7dd Merge "Adding support for skipping animation cancel on reapply" into main 2024-01-10 02:28:19 +00:00
Sunny Goyal 40e7937af8 Merge "Simplifying pending widget inflation path" into main 2024-01-09 23:11:08 +00:00
Sunny Goyal 98b5e1f077 Adding support for skipping animation cancel on reapply
Bug: 314279319
Test: Verified on device
Flag: None
Change-Id: I0a6e9eef77a1d917c0fce7d4bddd079ceeb10c99
2024-01-09 10:35:43 -08:00