Commit Graph

12453 Commits

Author SHA1 Message Date
TreeHugger Robot cb776ca518 Merge "Preventing workspace scroll over QSB area" into sc-v2-dev 2021-08-31 23:17:52 +00:00
TreeHugger Robot ff705eabe6 Merge "Fix some taskbar stashing issues" into sc-v2-dev 2021-08-31 22:38:01 +00:00
Tony Wickham 42b0395fee Fix some taskbar stashing issues
- Don't allow long press to stash between taskbar icons
- Ensure taskbar_icon_touch_size is respected; previously it wasn't, because BubbleTextView@shouldIgnoreTouchDown() was returning true in the padding region. For taskbar, we want the whole icon size to be touchable.
- Cancel long press when passing touch slop to avoid swipe down being detected as long press

Test: long press on taskbar background, both between icons and not; swipe down on taskbar
Fixes: 198305464
Change-Id: I36f1d792e91da9a3bf57a2bef1e974b299c4e25c
2021-08-31 14:06:09 -07:00
Samuel Fufa e34c2f8272 Merge "[Search] Update AllApps header protection" into sc-v2-dev 2021-08-31 18:08:34 +00:00
TreeHugger Robot 667bda8448 Merge "Revert "Revert "Migrating all model tests to Instrumentation tests""" into sc-v2-dev 2021-08-31 10:52:02 +00:00
Sunny Goyal 777d49062f Revert "Revert "Migrating all model tests to Instrumentation tests""
This reverts commit 7a4a30d86d.

Test: Presubmit
Reason for revert: Fixing original bug

Bug: 196825541
Change-Id: Id4b1eb24a89564d264266d305aebea52917dfcd9
2021-08-31 10:51:52 +00:00
TreeHugger Robot a0426f9743 Merge "Enables Taskbar Edu by default." into sc-v2-dev 2021-08-31 04:14:28 +00:00
Thiru Ramasamy 4df46b1da2 Add RESERVE_NEW_UI_EVENT_ID field to EventEnum interface.
Bug: 193797130
Test: NA
Change-Id: I786ff0222f2fd4c5cbc2598fe4b3e22733233f8b
2021-08-30 11:52:24 -07:00
Samuel Fufa 966e0507d6 Merge "[Work] Fix duplicate work button issue" into sc-v2-dev 2021-08-30 16:25:40 +00:00
y cb5bb989e3 [Work] Fix duplicate work button issue
Bug: 195623679
Test: manual
Change-Id: I882c5f7a196e07fa0dab3a2f27437abd233ec782
2021-08-30 00:27:21 -07:00
y 8dcd7e0ce7 [Search] Update AllApps header protection
- Disables header protection on AOSP
- Fades in/out search box pill instead of sudden movements
- Work tabs protection shows and hides based on scroll position

Bug: 194106968 [APK attached]
Test: Manual
Change-Id: I5532847ddba3d4555003b0934b8fc846dc5a5cc7
2021-08-29 22:56:54 -07:00
Vinit Nayak cdcaf7a2ed Code cleanup from rebase
Bug: 195423591
Change-Id: I623d6ef46458a282e3c63cde0bdc457cb38e4d50
2021-08-27 16:28:12 -07:00
Brian Isganitis ca74b4d5be Merge "Support dark theme in wallpaper launcher preview." into sc-v2-dev 2021-08-27 19:49:15 +00:00
Brian Isganitis 1094b503f5 Support dark theme in wallpaper launcher preview.
Test: Search bar in wallpaper preview follows dark theme without themed
icons enabled.
Fix: 197475508

Change-Id: Ib71356fad3510348c1408c886c4796bc16a59642
2021-08-27 14:23:17 -04:00
Sunny Goyal bb0305614c Preventing workspace scroll over QSB area
Bug: 189792966
Test: Manual
Change-Id: Ie2fe8e7fb6c80b9cc19d517fe828cf26f54f6f09
2021-08-27 10:38:30 -07:00
TreeHugger Robot 64a826fa16 Merge "Do not reload launcher when changing active display" into sc-v2-dev 2021-08-27 15:50:56 +00:00
Andy Wickham fe6fabaefe Enables Taskbar Edu by default.
Bug: 180605356
Test: Manual
Change-Id: I42fbdabf1e78e92e46a0d8e60a24dd94f499abbe
2021-08-26 14:55:04 -10:00
Hyunyoung Song eaa208bb11 All apps memory leak fix / unregister data observer am: 6e72c8bbba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15687067

Change-Id: I16c9cfc4aec2fa36e1fe465e0093eba1b7b475bf
2021-08-27 00:27:28 +00:00
Sunny Goyal 6e6f79933e Do not reload launcher when changing active display
> Updating IDP to use fixed bitmap sizes, so that the cache
  stays valid
> Caching last known windowMetrices for non-active displays and
  using estimation only when the cache is not available
> Only reloading model if IDP change could have affected the model
> Remove unnecessary listeners from IDP which are already controlled by
  model lifecycle

Bug: 191657065
Test: Manual
Change-Id: Ia8e6dfafd0977e62aa3fcf367ad79f7a49b2df51
2021-08-26 15:55:21 -07:00
Hyunyoung Song 6e72c8bbba All apps memory leak fix / unregister data observer
Bug: 197702957

Test: adb shell dumpsys meminfo com.google.android.apps.nexuslauncher, ahat

Change-Id: Ia5732cced959e4a199d9c2b59f1f3941a2e23552
2021-08-26 15:18:47 -07:00
Android Build Prod User 2d5a8dc847 Merge changes Ib2bc8419,Ia41cb0e3,I43bfbc41 into sc-v2-dev
* changes:
  Animate PredictedAppIcon when its icon changes
  Add "wave" animation when entering taskbar edu
  Add slot machine animation for PredictedAppIcon
2021-08-26 21:48:07 +00:00
Tony Wickham 175d152f76 Animate PredictedAppIcon when its icon changes
Reuses the slot machine animation to slide in the new icon. Additionally, staggers based on other icons changing before it.

Test: open apps, watch predictions change
Bug: 197780290
Change-Id: Ib2bc84193a9e350c915dd3486b6c98c6c88d3f83
2021-08-26 13:00:51 -07:00
Vinit Nayak 6174106f68 Add Split button in OverviewActions
Shows up only for large screen devices, not phones.
Tested for NexusLauncher, general 3P launcher support
needed for staged split (TODO b/195607777)

Bug: 195423591
Change-Id: I4d455769b17637174b590c640516b9fbb6352c3d
2021-08-26 11:49:38 -07:00
András Klöczl 701c76013c Merge "Two panel home empty page removing logic change" into sc-v2-dev 2021-08-26 11:09:05 +00:00
Andras Kloczl 8c574de97f Two panel home empty page removing logic change
- Don't remove a single page if it's empty, only if both pages are empty.
- Add back empty pages after they were removed while the phone
  was on single panel home.
- On two panel home don't add new workspace items onto the second screen

Test: manual
Bug: 196376162
Change-Id: I4c54ffa3b359a236deb3ab67adb54111e77ec896
2021-08-26 12:06:50 +01:00
Vinit Nayak f1aa726e9f Merge "Fix public variables to not have 'm' prefix" into sc-v2-dev 2021-08-26 00:07:45 +00:00
Android Build Prod User 14a7d63c23 Merge changes I54e39cc5,Iec62abae into sc-v2-dev
* changes:
  Set thumbnails for GroupedTaskView based on split layout bounds
  Implement swipe gesture for staged split in landscape
2021-08-25 20:30:43 +00:00
Android Build Prod User 543bf45c9b Merge "Add feature flag to control two panel home in portrait" into sc-v2-dev 2021-08-25 20:04:40 +00:00
Vinit Nayak aa11976cc5 Fix public variables to not have 'm' prefix
Bug: 181704764
Change-Id: I89e43ce6cc74119514c8124e7cc61b11dc475f58
2021-08-25 11:59:43 -07:00
Vinit Nayak c35507dc29 Set thumbnails for GroupedTaskView based on split layout bounds
Bug: 181704764
Test: Go to stage split in landscape w/
home rotation on/off, swipe up.
Thumbnails aren't perfectly overlaid, polish needed

Change-Id: I54e39cc5a18f527e80a664d60aca72dfd706ebdc
2021-08-25 11:59:00 -07:00
Thales Lima 653ae0a524 Merge "workspace: get the correct page when setting paddings" into sc-v2-dev 2021-08-25 11:54:13 +00:00
Alex Chau b1c36ce938 Add feature flag to control two panel home in portrait
Bug: 197723099
Test: manual
Change-Id: I20d7751e09053dc90c495f398334431f390f64bf
2021-08-25 11:54:08 +01:00
Thales Lima 41f33c3cfd workspace: get the correct page when setting paddings
When adding a new page to the workspace, mWorkspaceScreens doesn't
necessarily keeps the order. We should use the mScreenOrder field to get
 the correct index of pages.

Fixes: 197198491
Test: drag an app from first page and paddings should be correct
Change-Id: I4f79c164391348b53b71a87d5d49cfc4d3d35e5a
2021-08-25 11:16:13 +01:00
Vinit Nayak 8b78c138d4 Implement swipe gesture for staged split in landscape
* Maintain task split percentages when swiping up.
* Split percentages not maintained in GroupedTaskView, however.
That is a TODO.

Bug: 181704764, 181705607
Test: Swiped up in landscape with home rotation on/off.
Portrait still works.

Change-Id: Iec62abae34f6ccadf98e2afdc9409cf3160f8223
2021-08-24 17:32:47 -07:00
Alex Chau 204e749f06 Merge "Revert "Migrating all model tests to Instrumentation tests"" into sc-v2-dev 2021-08-24 17:29:06 +00:00
Alex Chau 7a4a30d86d Revert "Migrating all model tests to Instrumentation tests"
This reverts commit 455ba62b5d.

Reason for revert: Breaks tests on all targets

Bug: 196825541
Bug: 197570389
Change-Id: Ida6792a09c54dee46105b6b914a0dd1545bdf48d
2021-08-24 17:27:52 +00:00
Lucas Dupin f52fb6f632 Act on scrim visibility am: a8382dc052
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15655786

Change-Id: I40626071bdaadd997cc1479118224847b78229d3
2021-08-23 21:34:23 +00:00
TreeHugger Robot c817d2a633 Merge "Migrating all model tests to Instrumentation tests" into sc-v2-dev 2021-08-23 21:08:51 +00:00
Sunny Goyal 455ba62b5d Migrating all model tests to Instrumentation tests
Bug: 196825541
Test: Presubmit
Change-Id: Iebd46eb41eb46c187d569197f4b97b4fddc0f6f7
2021-08-23 12:34:44 -07:00
Lucas Dupin a8382dc052 Act on scrim visibility
The scrim visibility drives whether the launcher window is opaque or
not. We should track it and apply the flag instead of trying to catch it
through other Launcher life cycles.

Fixes: 195365607
Bug: 196403152
Test: tap on home button while launching app from overview
Change-Id: I2a00b86b602b5dd12c901433b92adcf0170be15e
(cherry picked from commit e4a9469156)
2021-08-23 19:22:02 +00:00
TreeHugger Robot a71426811e Merge "Fixing crash when the adapter is no longer available" into sc-v2-dev 2021-08-19 19:00:39 +00:00
Sunny Goyal 8e3a60648a Fixing crash when the adapter is no longer available
Bug: 197176748
Test: trivial change
Change-Id: Ie55a248c1998168c45bfa346186d61d7456ff7fb
2021-08-19 10:26:35 -07:00
TreeHugger Robot 46db057249 Merge "Fix NPE when converting final screen to empty screen." into sc-qpr1-dev am: 70dd01be85
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15583988

Change-Id: Ie6d11b74141ff777b10f05919b9a61f7af809900
2021-08-19 15:43:06 +00:00
TreeHugger Robot 70dd01be85 Merge "Fix NPE when converting final screen to empty screen." into sc-qpr1-dev 2021-08-19 15:30:20 +00:00
Sunny Goyal 177785eccf Moving all widget picker tests to instrumentation tests
Bug: 196825541
Test: Presubmit
Change-Id: I946f29baedb2e6b29044f8df1bc73b74e9999efe
2021-08-18 15:06:53 -07:00
Sunny Goyal 7dcf197821 Merge "Removing widget preview caching" into sc-v2-dev 2021-08-18 16:13:22 +00:00
Lucas Dupin 482f983a7b Add depth to -1 screen
Wallpaper will zoom out as you drag the overlay

Test: manually pull overlay
Fixes: 192502999
Change-Id: I9067b70d10497d4e16a5ef601161fbedfa9307e1
Merged-In: I9067b70d10497d4e16a5ef601161fbedfa9307e1
(cherry picked from commit 87d752062e)
2021-08-18 15:34:45 +00:00
TreeHugger Robot a7f7c4b432 Merge "Logging for Nexus home activity appearing after to-home gesture in L3." into sc-v2-dev 2021-08-18 11:19:26 +00:00
Alex Chau 2683bd7728 Merge "Support different task icon margin for grid tasks" into sc-v2-dev 2021-08-18 08:41:42 +00:00
TreeHugger Robot 04c4f94223 Merge "Fixing ModelPreload cancelling existing load" into sc-qpr1-dev am: 8782ad4f99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15524186

Change-Id: Ib89cd2bbe854242c87f52d2edc384ae864af01c2
2021-08-18 05:21:30 +00:00