This requires a decent sized refactor. Namely, rather than relying on
mCurrentPosition we need to rely more upon mLastPosition and
mFinalPosition for increasing and decreasing dot size. We also need to
delay the animation start if we are mega-moving to have the desired
delayed dot change effect.
Bug: 407711750
Test: Verified this works locally. Please see the bug for a screenrecording that shows this correct behavior working.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I83ef113c17f2197e3c02e85f44cf3f05947d2adb
I was being cautios on my previous fix for this same
isse, cautios because I'm modifying an object by reference
That's why I was only updating the container when the icon being
dropped was PendingAddShortcutInfo but we can change the container
on every icon (we don't need to in the Widget case which is the
other if statement), we can be sure it is a safe operation because
we later update the info anyway rendering the previous info invalid.
Fix: 413784315
Test: WIP
Flag: EXEMPT bug fix
Change-Id: I60ecdb52be1c7bf0584cb1c74ee15b85961e5012
- Also clean up some of the draw code
Bug: 377938340
Test: installing apps to finish
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: If5e825a4bc54c62e183be980e12a0c6ee14e4dff
animateToPosition now only occurs if the user performs a fling.
Bug: 394355070
Test: Verified this works locally. Please see the bug for a screen recording of the working behavior.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: Ic57495e3aec00d903ed948b887723b1389337c8d
Bug: 394355070
Test: Verified locally that indicator dots are not cut off with 6 pages. See screen recording on https://buganizer.corp.google.com/issues/394355070#comment28
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I5b0ac0441201e8dafcba10ff52ac24e1821815b9
Test: Use dumpsys to check if SurfaceControlViewHost still exists
Bug: 410052692
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: Ibbb29445422dd37e764be2f518c9d528340cdfaa
1) Moving any DB file deletion before opening the DB to avoid deleting already opened file
2) Using a sandbox directory for BackupAndRestoreDBSelectionTest which can delete actively opened files causing other tests to fail
Bug: 403551539
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: Ib1088a0e486edf755e5f7dcd738eb835af78b4c4
This brings the BgCallbacks closer to a repository pattern making is easier to switch eventually
Bug: 390572144
Flag: EXEMPT refactor
Test: Updated AsyncBindingTest to use real ModelCalbacks
Change-Id: I9c932b00ea8ac7330473b9c0f5d778453fe7a390
Instead of the dispatcher specifying the type, the UI checks th diff. This
ensures that the UI is updated correctly in all paths
Bug: 390572144
Flag: EXEMPT refactor
Test: Manually verified folder edit path where these callbacks were getting dispatched
Change-Id: Ib73eed5da87a847753a78453a48ab4fc495c1199
The LauncherModel#addCallbacks() and #removeCallbacks() apis are thread safe due to synchronized(mCallbacksList). So there is no need to enforce main thread.
This CL will unblock taskbar per-window ui thread work.
Bug: 404636836
Test: presubmit
Flag: NONE - released code
Change-Id: Iccc3f6da12625305f8db7111226df6e923c1891e
Sorry for the whack-a-mole here. The intention is to only blur
going to All Apps or returning from All Apps to Normal. Added some
tests to help prevent regressions.
Test: DepthControllerTest#test_blurWorkspaceDepthTargets
Flag: com.android.launcher3.all_apps_blur
Bug: NA (noticed locally from a recent cl)
Change-Id: Ib0285dae42c41ba9eb2e747b272d40c228e0b035
- Removed enableDesktopWindowingCarouselDetach flag
- detachDesktopCarousel is now always false, except in home quick switch (QuickSwitchState)
- Updated home quick switch controller NoButtonQuickSwitchTouchController to apply DESKTOP_CAROUSEL_DETACH_PROGRESS
Fix: 411127271
Test: manual
Flag: EXEMPT flag cleanup and refactor
Change-Id: I1cbf0987b111d0111cb8b9b6c7994f4494780e1a
Previously: blur if previous and next state want it blurred.
New: blur if previous OR next state want it blurred.
As part of this, change the default from true to false. Only All
Apps currently sets it to true, meaning we blur workspace only
going to or from All Apps.
Fix: 405836159
Test: Launch app, quickly go home and to All Apps
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ic52c5aa2dce7e1e107418952031574bc2e47e585
It reuses the predictive back animation now. In addition, if All
Apps entered directly into the Search state (i.e. via QSB), the
back gesture now scales the whole panel to indicate it will close
and return to the home screen (as opposed to closing Search within
All Apps).
Demo: https://drive.google.com/file/d/1wpaZg3JaSxDMMc62uU-1miP9RaIO10EB/view?usp=drive_link&resourcekey=0-h8qKzuDguwIE2vUDr0H6lQ
Fix: 406523972
Flag: EXEMPT bugfix
Test: Manual
Change-Id: I470d67e03b2d8bbbaa39aea76c7dde639cff62f5
Stefan Andonian
Sebastián Franco
Treehugger Robot
Sunny Goyal
Pat Manning
Andy Wickham
Charlie Anderson
George Lin
Anushree Ganjam
Fengjiang Li
Alex Chau