Commit Graph

2271 Commits

Author SHA1 Message Date
Treehugger Robot ca739ac8ae Merge "Add tooltip for taskbar overflow button" into main 2025-06-05 09:02:43 -07:00
Treehugger Robot bd029b8887 Merge "Fix IllegalStateException in AbsSwipeUpHandler.onRecentsAnimationStart" into main 2025-06-05 07:12:28 -07:00
Toni Barzic f9d6341458 Add tooltip for taskbar overflow button
Bug: 402787161
Test: Manual
Flag: com.android.window.flags.enable_taskbar_overflow

Change-Id: I04704612260f17561b4d18804d792a3fe0d47313
2025-06-05 05:05:44 +00:00
Treehugger Robot 3eed388766 Merge "Add missing nullability checks for AbsSwipeUpHandler.mRecentsView" into main 2025-06-04 14:21:53 -07:00
Schneider Victor-Tulias dc870049c1 Fix IllegalStateException in AbsSwipeUpHandler.onRecentsAnimationStart
Flag: EXEMPT bug fix
Fixes: 420854746
Test: AbsSwipeUpHandlerTestCase
Change-Id: I534d6cb7c6d05395663cd45b0c889095b8aead4a
2025-06-04 14:45:34 -04:00
Schneider Victor-Tulias 053d45170d Add missing nullability checks for AbsSwipeUpHandler.mRecentsView
Flag: EXEMPT bug fix
Fixes: 422239562
Test: AbsSwipeUpHandlerTestCase.testRecentsViewNullability
Change-Id: I0e2ac2d14bf8ee6130e1349d3c776df0c46fe256
2025-06-04 14:05:53 -04:00
Andy Wickham 46af1d5939 Merge "Fix workspace blur for non-user controlled animations." into main 2025-06-03 14:03:40 -07:00
Brian Isganitis 1352955035 Merge "Use displayId from sandbox context." into main 2025-06-03 13:26:13 -07:00
Jagrut Desai 12cdeb2fe2 Merge "Fix Hotseat flashing during DW to home transition" into main 2025-06-03 13:06:23 -07:00
Xiaoqian Dai 817f5c3589 desktop-exploded-view: Add hover and press support for the close button
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 421051864
Change-Id: I75601c738e6f82275240a7e4265f9b7940d3dc7f
2025-06-03 16:45:54 +00:00
Brian Isganitis a2c2cf6c26 Use displayId from sandbox context.
This matches the default display.

Flag: TEST_ONLY
Test: TaskbarOverflowTest
Bug: 415326979
Change-Id: If8edf46c16cd10105587ced5dfff316d08bbf2fd
2025-06-02 17:06:28 -04:00
Treehugger Robot cb6b287f16 Merge "Fix TaskbarAutohideSuspendControllerTest with grant_manage_key_gestures_to_recents enabled" into main 2025-06-02 12:13:45 -07:00
Jagrut Desai b5d2f3ee7f Fix Hotseat flashing during DW to home transition
Problem: upon exiting the deesktop mode we were getting change in recents tasks which we were commiting to ui and that resulted in hotseat flashing.

Solution: since layout transition is only in use while we are in desktop windowing mode, we will only need to change icon layout bound while we are in desktop mode and not when we are exiting.

Test: Manual, Presubmit
Bug: 417696108
Bug: 415700104
Flag: EXEMPT bugfix
Change-Id: Ibcf65df49e7b48312a27d2750d3d0c6c5d392006
2025-06-02 10:30:58 -07:00
Steven Ng 38ff87fca6 Fix TaskbarAutohideSuspendControllerTest with grant_manage_key_gestures_to_recents enabled
Problem:
The framework prevents a key gesture handler from being re-registered by the same process ID. In `TaskbarAutohideSuspendControllerTest`, we observed two calls to `QuickstepKeyGestureEventsManager#registerAllAppsKeyGestureEvent`. The first call originated from TouchInteractionService (as expected). The second, however, came from a new TaskbarManager instance created within `TaskbarbarUnitTestRule`. This occurs because `TaskManager#recreateTaskbarForDisplay` triggers `AllAppsActionManager#isTaskbarPresent`, which ultimately leads to the duplicate call to `QuickstepKeyGestureEventsManager#registerAllAppsKeyGestureEvent`.

Solution:
Since this problem only occurs in tests and not in practice, we can mock out `QuickstepKeyGestureEventsManager`'s [un]registration calls to do nothing within `TaskbarbarUnitTestRule` to prevent duplicated re-registration.

Flag: com.android.window.flags.grant_manage_key_gestures_to_recents
Test: atest NexusLauncherTests:TaskbarAutohideSuspendControllerTest
Test: atest NexusLauncherTests:TaskbarEduTooltipControllerTest
Fix: 421853013
Change-Id: Ic87bd8d36ce018935002b8698b1d53e30b2fca6d
2025-06-02 17:33:20 +01:00
Treehugger Robot 31ae5a7c6d Merge "Don't cap number of items in taskbar overflow" into main 2025-06-02 08:55:22 -07:00
Steven Ng d3c7533a55 Unregister all apps key gesture handler at AllAppsActionManager#onDestory
Bug: 406452076
Flag: com.android.window.flags.grant_manage_key_gestures_to_recents
Test: atest NexusLauncherTests:AllAppsActionManagerTest
Change-Id: Idec5ad32b190eff58c263d6c7696a9f218084f5a
2025-05-31 09:35:09 -07:00
Andy Wickham b8a471c0eb Fix workspace blur for non-user controlled animations.
In these cases, stateManager.getTargetState() reflects the state the
animation is going to, while getState() reflects user controlled state
transitions.

An example of this is the All Apps edu animation, which occurs when
you swipe up a few times on the navbar. In this case, the workspace
was not getting blurred because the depth controller didn't think it
was animating towards ALL_APPS.

Demo: https://drive.google.com/file/d/1fR_4dawE6je7Vkcs8InWZG4LcJShUJQA/view?usp=sharing&resourcekey=0-PYDMWlS9-sSbrYO0ATMNEg

Test: Manual (swipe up 3 times on navbar; spot check other state transitions)
Test: atest DepthControllerTest
Flag: com.android.launcher3.all_apps_blur
Fix: 421371766

I'm not sure if the following are fixed, but the symptom is similar.
Bug: 419036313
Bug: 420677002

Change-Id: I55d6d15afbb26169ff531dc1b8869d15ee84b100
2025-05-30 20:30:22 -07:00
Treehugger Robot 5e67f9d7cd Merge "Update DisplayControllerSpy for overview on CD" into main 2025-05-30 16:19:33 -07:00
Treehugger Robot bb41fe629a Merge "Make RecentTasksRepository dispayId aware" into main 2025-05-30 14:22:46 -07:00
Will Osborn 4589acb53d Make RecentTasksRepository dispayId aware
Bug: 402365283
Flag: com.android.launcher3.enable_overview_on_connected_displays
Test: unit tests + local test on tablet + foldable
Change-Id: I379547e41029baedb95c67b4440f23adfb29b1ba
2025-05-30 15:40:06 +00:00
Shamali Patwa cddba00520 Merge changes from topic "widget-picker-launcher" into main
* changes:
  Add dagger2-compiler to some of picker module targets.
  Add no-op widget picker module to some test modules / graphs.
  Wire the compose based widget picker in widget picker activity
  Repository and datasource implementations backing the widget picker.
  Add widget picker module dependency to launcher when compose is enabled
  Open widget picker activity instead of full sheet when refactor flag is on
2025-05-30 04:18:55 -07:00
Treehugger Robot ca758f80a7 Merge "Do not reflow dismissed grid task is already in split select." into main 2025-05-30 04:00:20 -07:00
Ajinkya Chalke d2ea106305 Update DisplayControllerSpy for overview on CD
- Use both infoModifier and infoModifierForDisplay to support overview
  on CD changes in DisplayController.

Test: TaskbarModeRuleTest TaskbarInsetsControllerTes
Bug: 363251602
Flag: EXEMPT test only change
Change-Id: I18f2dd7f6c486a269769d93f5ad7623bcba5fe3c
2025-05-30 08:30:39 +00:00
Mykola Podolian bd997ba791 Merge "Notify taskbar and nav bar of bubble bar location updates." into main 2025-05-29 21:12:09 -07:00
mpodolian 6f82248053 Notify taskbar and nav bar of bubble bar location updates.
Added logic to notify the BubbleBarLocationListener implementors on
bubble bar location updated.

Bug: 411506181
Test: DragToBubbleControllerTest
Flag: com.android.wm.shell.enable_create_any_bubble
Change-Id: I51290bb6c2b35ff913a43c04db35be65b377ea03
2025-05-29 15:54:05 -07:00
Toni Barzic 229bbf059c Don't cap number of items in taskbar overflow
Updates KQS view not to show fullscreen tasks, and not to cap off number
of items in the view if shown for taskbar overflow.

Bug:419279335
Test: TaskbarOverflowTest
Flag: com.android.window.flags.enable_taskbar_overflow

Change-Id: I771cabc51ffa527b7db83cf12747cf8c4793670d
2025-05-29 22:14:44 +00:00
Shamali Patwa 9d946aa755 Add no-op widget picker module to some test modules / graphs.
Bug: 408283627
Flag: EXEMPT not applicable
Test: dagger build
Change-Id: I77b2f9f32037303ddfd7f2950c7b235f9aff8f2c
2025-05-29 13:26:10 -07:00
Sebastian Franco 8244449a9f Moving taskbar variables in DeviceProfile to their own class
Bug: 419264653
Flag: EXEMPT refactor
Test: DeviceProfileDumpTest
Test: All Image tests
Change-Id: I05ec9e15ef02096326596af4835adb706473a736
2025-05-29 11:04:06 -07:00
Jagrut Desai 2cb88061e4 Merge "Fix Settting Cache NPE" into main 2025-05-29 09:44:39 -07:00
Treehugger Robot 3893804a59 Merge "Moving hotseat variables in DeviceProfile to their own class" into main 2025-05-29 09:01:51 -07:00
Pat Manning 14b76f7867 Do not reflow dismissed grid task is already in split select.
When the task is not found in top or bottom set, return current page. This fixes rotation in overview while split select is already active.

Fix: 420546041
Test: TaskGridNavHelperTest
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I4f654b017a0c051bd373e78ebd3d3f02f7bdf3cf
2025-05-29 14:49:55 +01:00
Uwais Ashraf 478f07798e Moving hotseat variables in DeviceProfile to their own class
Bug: 419264653
Flag: EXEMPT refactor
Test: DeviceProfileDumpTest
Test: All Image tests
Change-Id: I377b33668c3ed330d362527f62226dd84a5773db
2025-05-29 13:16:05 +00:00
Treehugger Robot baacf9f4df Merge "Converting StatsLogManager to kotlin" into main 2025-05-28 18:29:53 -07:00
Vadim Tryshev a5c22505bb Merge "Removing ViewCaptureRule" into main 2025-05-28 15:01:22 -07:00
Sunny Goyal bb0f554148 Converting StatsLogManager to kotlin
This is make it easier to create factory classes for individual when adding more injected parameters

Bug: 361850561
Test: Presumit
Flag: EXEMPT refactor
Change-Id: Ie68e9e24aae801b7fed14d1b03df760e5b67c183
2025-05-28 14:12:13 -07:00
Liran Binyamin 63850c4a1d Merge "Deflake BubbleBarViewScreenshotTest" into main 2025-05-28 13:17:10 -07:00
Liran Binyamin f53c72b4ed Deflake BubbleBarViewScreenshotTest
Suppress animation to avoid flakes

Fix: 416207075
Flag: EXEMPT test only
Test: atest BubbleBarViewScreenshotTest
Change-Id: I6e3c6105cef4a5d74567de91de75e8bec7609b3c
2025-05-28 13:16:50 -07:00
Vadim Tryshev f3112aea02 Removing ViewCaptureRule
Bug: 315482167
Flag: EXEMPT test fix
Test: presubmit
Change-Id: If60412dcec9614fefe897e766395660acb8fa4f8
2025-05-28 11:53:07 -07:00
Xiaoqian (Daisy) Dai f767b504bf Merge "desktop-exploded-view: truncate the task header app title if it overflows" into main 2025-05-28 10:47:36 -07:00
Jagrut Desai bcd634a31f Fix Settting Cache NPE
Test: Presubmit
Bug: 406906811
Flag: EXEMPT bugfix
Change-Id: If2dacf2686339a0c8b9e87fdd9a8e555a813aab1
2025-05-28 09:55:39 -07:00
Treehugger Robot ccf83ca310 Merge "Remove screen record" into main 2025-05-28 09:34:23 -07:00
Pat Manning a96d9ce82c Merge "Removing screen record annotations." into main 2025-05-28 07:21:28 -07:00
Alex Chau b1eef72619 Remove screen record
Bug: 407406547
Test: N\A
Flag: EXEMPT test only

Change-Id: Ic413e82d506286ad0799025d4ea1904124bf534f
2025-05-28 15:02:51 +01:00
Pat Manning f8a374e02d Removing screen record annotations.
Fix: 415773066
Fix: 412766455
Test: Manual.
Flag: EXEMPT cleanup.
Change-Id: I83b77d1d105f9c467fbb256d8d42cdd9e16b2332
2025-05-28 12:18:22 +01:00
Simon (Qiong) Sun be9eea8f23 Merge "Support multiple tasks per split screen via SplitRemoteTargetHandles" into main 2025-05-27 18:11:37 -07:00
Treehugger Robot 97594d1e94 Merge "Unregister AbsSwipeUpHandler's ContextInitListener on launcher destroy" into main 2025-05-27 11:45:32 -07:00
Schneider Victor-Tulias 8f88cb272d Unregister AbsSwipeUpHandler's ContextInitListener on launcher destroy
- Unregister the init listener on launcher destroy to unblock the home button
- This also exposes a crash in AbsSwipeUpHandler.onRecentsAnimation start since the home bounds aren't available. So, also adding handling to reload the launcher on night mode change

Flag: EXEMPT bug fix
Fixes: 384423890
Fixes: 416536400
Test: changed dark theme then swiped/pressed home and overview buttons.
Change-Id: Ic26192e8d0e4e6b226fb9af6dba596aa78a09e96
2025-05-27 11:39:53 -07:00
Xiaoqian (Daisy) Dai d108ef020b Merge "desktop-exploded-view: Fix various values for Task windows in desktop tile." into main 2025-05-27 09:25:51 -07:00
Saumya Prakash a272ff81ad Merge "Report lower insets for SUW if expressive theme enabled" into main 2025-05-27 08:57:52 -07:00
Treehugger Robot d5b20e3940 Merge "Add recents animation start timeout handling to TaskAnimationManager" into main 2025-05-23 19:10:36 -07:00