Commit Graph

18303 Commits

Author SHA1 Message Date
Treehugger Robot 03cd176277 Merge "Add support for animating non-running tasks" into main 2024-05-02 18:24:56 +00:00
Sunny Goyal 93221e00a5 Merge "Converting ModelTask to an interface instead of an abstract class" into main 2024-05-02 17:41:09 +00:00
Sunny Goyal f4b51c603f Merge "Fixing StatsLogger not getting activityContext" into main 2024-05-02 17:36:21 +00:00
Jagrut Desai 0fd34b783c Merge "Taskbar in Desktop Windowing Mode" into main 2024-05-01 22:49:48 +00:00
Sunny Goyal 993893895c Converting ModelTask to an interface instead of an abstract class
This allows extensibility and better use of lambdas

Bug: 338282246
Test: Presubmit
Flag: None

Change-Id: Ia41067f0068b3b631eeb4faf877dc77f8587e1f6
2024-05-01 15:43:26 -07:00
Schneider Victor-tulias 65ae550a92 Add support for animating non-running tasks
It is possible to animate a non-running task to home mid-quick switch, which was not properly supported, causing a janky animation. Added custom animations to handle this more smoothly.

Flag:  ACONFIG com.android.launcher3.enable_additional_home_animations DISABLED
Fixes: 237638627
Test: swipe to home mid-quick switch on handheld/large screen in portrait/landscape from an app present/missing on the workscape in RTL/LTR
Change-Id: I89c9cf1ed1c0b88ff6c3ce71a663cb16e69d5843
2024-05-01 20:06:34 +00:00
Sunny Goyal a5438a3cfc Fixing StatsLogger not getting activityContext
Bug: 338254085
Test: Verified on device
Flag: None
Change-Id: I5a821a89df80ce43b73092db43af3dd8d53d81f4
2024-05-01 12:59:58 -07:00
Alex Chau 6a44889c99 Merge "Add additional StateManager log to track cancelAnimation" into main 2024-05-01 18:26:20 +00:00
Jagrut Desai 2e8ca87c21 Taskbar in Desktop Windowing Mode
Test: presubmit
Bug: 330146462
Flag: NONE
Change-Id: Ib33f90704c3010df6a52e2a1c420960b11dbd0d4
2024-05-01 09:29:24 -07:00
Alex Chau d840e6270b Add additional StateManager log to track cancelAnimation
Bug: 325463989
Test: Manual
Flag: NONE
Change-Id: I4f9eb13eb460e0bae0582992d18b8b81250f8eaa
2024-05-01 15:08:42 +01:00
Holly Jiuyu Sun 2737373f6e Merge "[reset] Remove redundant calls in resetAndScrollToPrivateSpaceHeader." into main 2024-04-30 21:20:39 +00:00
Holly Jiuyu Sun 477d70f92e Merge "[reset] Call SearchUiManager#resetSearch instead of reset." into main 2024-04-30 21:20:22 +00:00
Sunny Goyal 15949163a6 Merge "Removing disabled color extractor from Widgets" into main 2024-04-30 03:51:37 +00:00
Federico Baron c113ce9f9f Merge "Migrate smartspace as a widget and smartspace removal toggle flags to aconfig" into main 2024-04-29 21:46:03 +00:00
Fengjiang Li dd2b47350e Merge "[Launcher Jank] Avoid lock contention on AssetManager in all apps preinflate thread" into main 2024-04-29 17:05:36 +00:00
Gustav Sennton 56f9df0620 Merge "[Desktop Mode] Show indicators under Taskbar app icons for running apps" into main 2024-04-29 08:28:28 +00:00
Fengjiang Li b2d0845a29 [Launcher Jank] Avoid lock contention on AssetManager in all apps preinflate thread
Create a separate context with a separate AssetManager obj.

Bug: 337056120
Flag: NONE
Test: presubmit
Change-Id: Ic6765f7f19b649605aec6a889f8382ee10f929b0
2024-04-29 04:43:25 +00:00
Sunny Goyal 277ef4868c Removing disabled color extractor from Widgets
Bug: 266941872
Flag: None
Test: Presubmit (removed dead code)
Change-Id: Ie45cf08c694652266af6c95dab0eac5b9dd138f6
2024-04-26 15:46:04 -07:00
Holly Sun 7bb9247bf6 [reset] Call SearchUiManager#resetSearch instead of reset.
This is a follow-up of ag/26362927.
When it's in searching state, we only need to reset search instead of resetting everything.

Test: search something and scroll in AA+. Trigger AA+ by filing an intent (adb shell am start -n com.google.android.apps.nexuslauncher/.NexusLauncherActivity -a android.intent.action.ALL_APPS). Notice the search RV is reset and scroll to top.
Bug: 328505782
Flag: aconfig com.android.launcher3.enable_private_space nextfood
Change-Id: I9d1d4386077433a676c1f3b8e3614fb848284a88
2024-04-26 14:25:16 -07:00
Willie Koomson 21379bfbbc Merge "Remove widget education tip dialog" into main 2024-04-26 20:23:21 +00:00
Holly Sun 4e203b2826 [reset] Remove redundant calls in resetAndScrollToPrivateSpaceHeader.
1. When a user clicks a PS tile, fast scrolling is already end.
2. When a user clicks a PS tile, it should be in the search RV, so no need to handle header.
3. We need the `animateToSearchState` with 0 time because the one inside `resetSearch` with 300ms delay will conflict with the following scrolling to bottom. When `resetSearch` is called after `animateToSearchState(0)` finishes, the inside `animateToSearchState(300)` is just a no-op and return early, so we won't have redundant call.

Bug: 328505782
Test: manual
Flag: aconfig com.google.android.apps.nexuslauncher.enable_inject_private_space_tile nextfood
Change-Id: Ied9f96c276c8f7707c672425bebe81e72e0d3bae
2024-04-26 11:41:50 -07:00
Holly Jiuyu Sun 782d506330 Merge "[a11y] Change all apps screen name to All Apps instead of reusing Home." into main 2024-04-26 18:28:29 +00:00
Willie Koomson 5fb9b1595e Merge "Fix Add button animations" into main 2024-04-26 18:24:13 +00:00
Treehugger Robot d62a3aefc0 Merge "Converting IconShape to mainThreadInitializedObject instead of keeping it a process static" into main 2024-04-26 16:17:52 +00:00
Gustav Sennton 52a8b7e24b [Desktop Mode] Show indicators under Taskbar app icons for running apps
In Desktop Mode we show running Desktop apps in the Taskbar. With this
change we also show an indicator under the app icon for each such
running app.

Bug: 332504528
Test: manual
Test: DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT
Change-Id: If0906dab8ad0bd8a78d93a4e99db47550e763bed
2024-04-26 15:29:00 +00:00
Willie Koomson d731ba2ff1 Remove widget education tip dialog
This change removes the widget education tip dialog, and the arrow
tip view. These are no longer needed now that taps are handled by
showing an add button.

Bug: 335318980
Test: `pm clear com.google.android.apps.nexuslauncher` and open widget
 picker
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: I9b24a41604880f5f94939c02b94f1a9f6a6c83d5
2024-04-25 22:56:36 +00:00
Sunny Goyal 638a687fc8 Converting IconShape to mainThreadInitializedObject instead of
keeping it a process static

Bug: 297950111
Flag: None
Test: Presubmit
Change-Id: Id66100e0cb300659c6017c287eb38ab04290477b
2024-04-25 15:56:30 -07:00
Holly Sun 47b9cb8436 [a11y] Change all apps screen name to All Apps instead of reusing Home.
Now even when we enter the All Apps page, talkback still reads the page name as Home (https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=586;drc=120838b04dcaf072704c6fb382ea9115672cfcaa).

Bug: 330470894
Bug: 333833220
Test: manual
Flag: NA
Change-Id: I32a1ce8844cd111c7d1c492ee0a39fec47858a47
2024-04-25 15:13:41 -07:00
fbaron 9d08e0fe70 Migrate smartspace as a widget and smartspace removal toggle flags to aconfig
Bug: 336823684, 336823681
Test: none
Flag: ACONFIG enable_smartspace_as_a_widget DISABLED
Flag: ACONFIG enable_smartspace_removal_toggle DISABLED
Change-Id: I4cba42e09f58365f761ab866b15a494817e6bb0f
2024-04-25 14:26:30 -07:00
Willie Koomson ff1a1a9e46 Fix Add button animations
Use AnimatorSet to make the fade animations sequential instead of
simultaneous. Also reduce the total duration to 200ms (100ms fade out,
100ms fade).

Before: http://screencast/cast/NjQ4NTcwMjcyNzQzNDI0MHxjNDY5NDJiNy03Mg
After: http://screencast/cast/NTg5NDA0NDI5ODI0ODE5MnxmMjczMTlmYi05Mw

Bug: 333734220
Test: manual, see screencast
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD

Change-Id: I2ee87f33c46e5dd07974152fa32393c39a18ecf1
2024-04-25 20:51:15 +00:00
Shamali P 01a297942a Fix issue that expanded widgets appear before next item moved down
Issue - http://screen/AYyCKCWZH4uYeBp

* Before - http:/screencast/cast/NTc1NzE0MTg1NDk3ODA0OHwyNjA4ZmU5OC02ZQ
* After - http://screencast/cast/NDcyNTkzNzcyMjYyMTk1MnwxNmU1MTRmNy1jMw

Additionally, also fixes problem that fade in for some expanded sections
didn't always happen.

Bug: 332457155
Flag: N/A
Test: Manual (see video)
Change-Id: Iad3a341d9b992c72b61492d57db4faa96a06ecfa
2024-04-25 20:31:54 +00:00
Helen Cheuk b9ed7c152a Merge "Disable launcher focus outline animation" into main 2024-04-25 18:43:05 +00:00
Himanshu Gupta 578f1a474e Merge "Fix Accessbility bugs for PS." into main 2024-04-25 17:03:54 +00:00
Himanshu Gupta 42e3196011 Fix Accessbility bugs for PS.
This Cl contains:
1. Alt text for Lock/Unlock button as per state.
2. Alt text for Header when Locked.
3. Removing Header from accessibility target when unlocked.

Bug: 328024119
Test: Manual
Flag: NA
Change-Id: I791176afdae4fc6eb9387080aa036c1aed2a03a9
2024-04-25 11:57:53 +01:00
Treehugger Robot b1037fb3ca Merge "Put Receiver unregistration on Background thread." into main 2024-04-25 00:24:59 +00:00
Shamali Patwa 587c3ce049 Merge changes from topic "bottomsheet-with-insets" into main
* changes:
  Align the margins between handle, text, and container with main picker.
  Update the app-specific picker to have a container like the main picker
2024-04-24 21:16:28 +00:00
Stefan Andonian 1f9bb1372c Put Receiver unregistration on Background thread.
Bug: 336722585
Test: Verified manually this doesn't break the build.
Flag: NA
Change-Id: If083d5c4ca7749946b50f5d4b64a5ea87f5651ce
2024-04-24 20:25:17 +00:00
Shamali P 9478a40898 Update the app-specific picker to have a container like the main picker
This is to ensure widgets are displayed with same container across the
two pickers.

* http://screencast/cast/NDYxNjMzNDExNjY1MTAwOHwwMTBlYzkwZC0wNg
* http://screencast/cast/NjY1NzAyNzY5NzgwMzI2NHwyYTg3ZWIzNS0wNw
* http://screencast/cast/NTYyMzcwMTc4NDQ5NDA4MHw3Y2JlZDEwZS04Mw

Bug: 328812171
Flag: N/A
Test: Manual - need to build a SS test for this opened - 336284716
Change-Id: I42b743b99cf6f47b7bade57de01b130df78ac1e9
2024-04-24 19:14:50 +00:00
Shamali P 3132947812 Limit number of items grouped on a row to 3.
With shortcuts this allows for more space to display two word title
below without ellipsizing it. (screen/4pJvcFFKJhooqZU)

Also let widget description show upto 3 lines to more of it to show
when stacked (screen/7xv8ng4H7iRLU79)

Bug: N/A
Flag: N/A
Test: Screenshot
Change-Id: Ia4e30f943f602b811e607d9cb52152f78cdc20e5
2024-04-24 19:14:23 +00:00
Saumya Prakash 8245ac04e3 Merge "Only run search edu when enabled, also make code more generic." into main 2024-04-24 16:13:43 +00:00
helencheuk ce0f8595b7 Disable launcher focus outline animation
Bug: 335424188
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Teamfood
Change-Id: I31c63607c914da956d7c6139cc5089fe419f40e1
2024-04-24 11:37:30 +01:00
Sunny Goyal ee6f471f3f Merge "Using settings cache for listening to haptic feedback setting" into main 2024-04-24 01:25:50 +00:00
Saumya Prakash 17cd6ca62a Only run search edu when enabled, also make code more generic.
We only need to run the Search edu if it is enabled on devices. The code
itself is also made more generic in terms of method and variable names.

Fix: 330401405
Test: Enable and disable the search function and check whether the edu tooltip shows
up for each specific use case.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD

Change-Id: I1cea3ee56922c0b47ae7e8379aad4b36570daa17
2024-04-23 22:02:15 +00:00
Willie Koomson f88bf7e23f Merge "Fix issue with tap-to-add on recycled WidgetCells" into main 2024-04-23 18:53:33 +00:00
Sunny Goyal 99d9c7efbd Using settings cache for listening to haptic feedback setting
Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: I5732875c1e3ce6468078b4bfdc2fa0eb7a29f0de
2024-04-23 11:30:00 -07:00
Treehugger Robot 62a1a8a336 Merge "Move PreInstalled App List to UserCache." into main 2024-04-23 18:24:01 +00:00
Winson Chung a9ccb34d1c Merge "Migrate PackageManagerHelper to MainThreadInitializedObject" into main 2024-04-23 18:10:56 +00:00
Sunny Goyal edbe8e5ffc Merge "Fixing MainThreadInitializedObject" into main 2024-04-23 18:06:38 +00:00
Himanshu Gupta ae4631e6a3 Move PreInstalled App List to UserCache.
Bug: 333543006
Test: atest PrivateSpaceHeaderViewTest, AlphabeticalAppsListTest
Flag: NA
Change-Id: I84233c5a6406325d9e641b72ea8455911b46f65f
2024-04-23 15:28:01 +01:00
Fengjiang Li fa0a4c1c11 Merge "[Predictive Back] Swipe back within workspace all apps should only scale down content view, rather than whole all apps sheet" into main 2024-04-23 03:45:32 +00:00