Commit Graph

2438 Commits

Author SHA1 Message Date
Treehugger Robot f42f516621 Merge "Remove unused spec in device_profiles.xml" into main 2025-03-03 17:24:20 -08:00
Federico Baron d8f0bed596 Remove unused spec in device_profiles.xml
Bug: 395912263
Flag: com.android.launcher3.one_grid_specs
Test: n/a, code cleanup
Change-Id: Ifd1ecf905427902f895a1b4e16711874fd52ddf3
2025-03-03 18:35:10 +00:00
Federico Baron 66999f0a19 Add screenrecord for uninstallWorkspaceIcon
Bug: 399756302
Flag: EXEMPT TEST_ONLY
Test: TaplUninstallRemoveTest
Change-Id: I4bdf8087276a93f8f736c23ba95f35acb7f05c3a
2025-02-28 21:27:07 +00:00
Treehugger Robot 087e54c81c Merge "Removing temporary debug tracing" into main 2025-02-24 14:55:05 -08:00
Sunny Goyal b1fab90e26 Enforcing grid customization permission in manifest instead of code
Bug: 389173244
Test: Updated tests
Flag: EXEMPT manifest change
Change-Id: I0fee57f935156da6b2b5a612259db2c4b3605846
2025-02-24 10:40:43 -08:00
Sunny Goyal c9f697aeb5 Converting LauncherAppState to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: I336a233d2703c23a7e9065474bde471786886144
2025-02-20 19:13:49 -08:00
Sunny Goyal db724a010c Removing temporary debug tracing
Bug: 378167329
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: I06ed0d96a83c13b1bce9aff8e2e21fa1510bc4c2
2025-02-20 12:26:35 -08:00
Owner Cleanup Bot a5d9e8a600 Merge "[owners] Remove zakcohen@google.com from tests/src/com/android/launcher3/widget/picker/OWNERS" into main am: c3a2e87058 am: aa4f86641c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3490672

Change-Id: Ic91f4281f7e12f23046a7e739830c5d76dbeccb5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-18 14:33:03 -08:00
Charlie Anderson 3487ef52f2 Merge "Temporarily disable shapes flag in image and device dump tests." into main 2025-02-18 10:14:11 -08:00
Charlie Anderson 24e65da8b3 Temporarily disable shapes flag in image and device dump tests.
Will re-enable after more shapes changes, as part of b/396211437

Bug: 396211437
Bug: 395952745
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: Presubmit
Change-Id: Ib0c85167df2723632adce9dadae718a2a1b7b757
2025-02-14 15:14:19 -05:00
Anushree Ganjam 5a8fcc3d40 Merge "Refactor TestEmitter and it doesn't need to be MainThreadInitializedObject" into main 2025-02-14 10:35:40 -08:00
Anushree Ganjam 7128c6fcfb Refactor TestEmitter and it doesn't need to be MainThreadInitializedObject
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: I30e7c3c165db698785e9e4d7e2256ab061ff71a2
2025-02-13 15:20:17 -08:00
Charlie Anderson 527be0c133 Temporarily disable shapes flag for tests that it breaks.
- when done with breaking changes will update tests as part of b/396211437

Bug: 395952745
Bug: 396211437
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: Presubmit

Change-Id: I461f6834932a710efa439a112bce23359aee13de
2025-02-13 09:32:52 -08:00
Owner Cleanup Bot 40e6a538ab [owners] Remove zakcohen@google.com from tests/src/com/android/launcher3/widget/picker/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.
If this change is unnecessary or in error, vote the lowest CR value
(i.e. reject the CL) and the bot will abandon it. Vote the highest CR to
approve this change. You may also abandon this change.

See the owner's recent activity for context:
https://android-review.googlesource.com/q/zakcohen@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: I012d61af6b55dd1ae2f00be846af393bc7bc2f38
2025-02-11 16:03:09 -08:00
Sunny Goyal 5bca45a739 Moving InvariantDeviceProfile to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: Ia99ee031e96c5e6069a56fe90a262a533dd8665a
2025-02-11 15:22:18 -08:00
Treehugger Robot d3b31eb20d Merge "Removing BaseDraggingActivity > Merging come methods to BaseActivtiy > Separating wallpaper theme implementation to an independent class" into main 2025-02-04 09:29:46 -08:00
Treehugger Robot f86a05eee2 Merge "Fix attempt for testAddAndDeletePageAndFling" into main 2025-02-03 20:46:21 -08:00
Sunny Goyal edc1453cf1 Removing BaseDraggingActivity
> Merging come methods to BaseActivtiy
> Separating wallpaper theme implementation to an independent class

Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I8cdb6d1520beff3f8226b62c5b7eafd48b2c674f
2025-02-03 17:23:10 -08:00
Federico Baron 1c1b130a4b Fix attempt for testAddAndDeletePageAndFling
it looks like the issue is that the layout has a widget on the second
page leading the page count to be different than expected

Bug: 381918059
Test: TaplWorkspaceTest#testAddAndDeletePageAndFling
Flag: TEST_ONLY
Change-Id: I19e475450494a5580e8fd04d02692624c086807c
2025-02-03 23:05:51 +00:00
Charlie Anderson 0905744966 Use launcher db icon column to load pre-archived app icons on restore, similar to Promise Icons.
- includes loading icons for AllApps as archived apps show there as well

Bug: 391913214
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Test: LoaderTaskTest, LoaderCursorTest and manually doing backup + restore
Change-Id: Icc9dc292551d4a3c6ac23de89aea4cb14856744c
2025-02-01 01:11:04 +00:00
Sebastián Franco cf060a9871 Merge "Remove screen record annotation from passing test" into main 2025-01-29 09:42:33 -08:00
Sebastian Franco 057f613d5b Remove screen record annotation from passing test
Fix: 322823478
Fix: 331261431
Test: TaplTestsLauncher3Test
Flag: TEST_ONLY
Change-Id: I5d744b20701ae9a97c4422616f13a5faa55c6c76
2025-01-28 18:54:39 -08:00
Charlie Anderson db9bb3c869 Merge "Convert UserCache to use Dagger" into main 2025-01-28 16:15:03 -08:00
Charlie Anderson e90282b317 Convert UserCache to use Dagger
Bug: 372012340
Test: Presubmit
Flag: EXEMPT Dagger Change
Change-Id: I36a0a3f56540c0515d99badc127c2ab8534e684e
2025-01-28 15:30:07 -05:00
Jagrut Desai b3bb1f1c4a Merge "Removing ScreenRecord from test" into main 2025-01-27 13:56:58 -08:00
Jagrut Desai 7b9af1296e Removing ScreenRecord from test
Test: Presubmit
Bug: 319501259
Flag: EXEMPT bugfix
Change-Id: If417b0f748bd4cbc1270d8e393bb787c812074de
2025-01-27 10:45:56 -08:00
Treehugger Robot 196ba82377 Merge "Removing redudntant objects from BgDataModel" into main 2025-01-24 12:00:33 -08:00
Sunny Goyal 777324ed15 Removing redudntant objects from BgDataModel
Bug: 390572144
Flag: EXEMPT refactor
Test: Updated model tests
Change-Id: Ied8a0bfdbfd324b9fb05724f1fcf67238aa37d16
2025-01-23 12:55:37 -08:00
Treehugger Robot 11e4b589f6 Merge "Remove heuristic that determines whether to shift cells down or not" into main 2025-01-22 23:55:00 -08:00
Federico Baron 8d3883def3 Remove heuristic that determines whether to shift cells down or not
We decided to always shift the cells down, so that the new row always
shows up at the top

Bug: 391697719
Test: GridMigrationTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: Id093e0d64e437bf218f942bfdf6d2f14ee875776
2025-01-22 23:19:43 +00:00
Federico Baron 0a9a5dc466 Fix failing tests that are blocking OOM investigation
Flag: TEST_ONLY
Bug: 388258969
Test: InstallSessionTrackerTest InstallSessionHelperTest
Change-Id: I539c51c6a253ff0b64113e73764979c5e188bbbb
2025-01-21 19:44:50 -08:00
Treehugger Robot 2e2c11e49d Merge "Ignore the tests temporarily." into main 2025-01-16 21:10:23 -08:00
Anushree Ganjam de0d4498c8 Ignore the tests temporarily.
This is to measure the impact of OOM issue
https://googleplex-android-review.git.corp.google.com/q/topic:%22launcher-clearMock-RunListener%22

The tests will be  re-enabled on Jan 22. Currently NexusLauncherTests are
100% failing due to b/385147987 and b/388258969 which blocks us from
measuring the OOM issue fix impact.

Bug: 385147987
Bug: 388258969
Bug: 378520480
Test: Manual
Flag: TEST_ONLY
Change-Id: I1d804c7fcba3b48943025408a530981ff808d511
2025-01-16 16:26:51 -08:00
Sihua Ma 8fc266d063 Move tests to multivalent
Test: SysUI studio
Test: atest NexusLauncherRoboTests
Flag: EXEMPT test migration
Change-Id: Idd9e52f281d955e87f6db638ebfd8218a4dcb77f
2025-01-17 00:04:27 +00:00
Treehugger Robot 5850008ade Merge "Remove ScreenRecord for a closed bug" into main 2025-01-14 10:51:03 -08:00
Adnan Begovic 8d3eaf1a36 Merge "launcher3: Introduce onGridMigrationComplete callback." into main 2025-01-13 15:22:18 -08:00
Treehugger Robot 3ddd380c14 Merge "Remove ScreenRecord for a closed bug" into main 2025-01-13 10:19:05 -08:00
Adnan Begovic 4b9b9d7e40 launcher3: Introduce onGridMigrationComplete callback.
onGridMigrationComplete is invoked when grid migration
  successfully completes.

  ModelDelegate's can choose to observe this by overriding
  the callback.

Test: manual, existing
Flag: com.android.launcher3.one_grid_specs
Bug: 386802204

Change-Id: Iaca2e61a95c3d3decc12b2cc54461dba441202a0
2025-01-13 09:52:16 -08:00
Treehugger Robot 441a7ecfd1 Merge "Remove unused test debug tracing" into main 2025-01-13 09:35:05 -08:00
Treehugger Robot 7741fccfee Merge "Remove TaplIsTabletTest" into main 2025-01-13 08:16:27 -08:00
Schneider Victor-Tulias 2734f9854d Remove unused test debug tracing
Flag: EXEMPT debug tracing cleanup
Fixes: 289161193
Test: TaplAddWidgetTest
Change-Id: I3929379cbe77d6c1d74b80b705d63f073f3d21eb
2025-01-13 10:39:18 -05:00
fbaron 826f8f28e6 Remove TaplIsTabletTest
This test was there to verify if this check was causing other tests to fail, but it turns out that other tests were the problem. Remvoing this tests as now that we verified that it's a bit redundant

Bug: 366237798
Test: TaplIsTabletTest
Flag: TEST_ONLY
Change-Id: I925108b9ba39b96233f558c89d61791630aefe5a
2025-01-10 16:04:18 -08:00
Vadim Tryshev aa836cff82 Remove ScreenRecord for a closed bug
Bug: 330232490
Test: presubmit
Flag: NONE Test change
Change-Id: I20d843b470bc83d0ad0f137ba4810b9872389897
2025-01-10 14:46:51 -08:00
Vadim Tryshev 3dafa1edff Remove ScreenRecord for a closed bug
Bug: 349439239
Test: presubmit
Flag: NONE Test change
Change-Id: If80c6681e6a3cb6c0bc81763c28ed7837c14c719
2025-01-10 14:46:42 -08:00
Sebastián Franco a237a71a1c Merge "Making sure we don't use Launcher when null" into main 2025-01-09 15:35:02 -08:00
Riddle Hsu 6eda95c70c Merge "Wait for launcher state before proceeding next test step" into main 2025-01-09 13:54:54 -08:00
Treehugger Robot 49337285b7 Merge "Attempt to fix TaplUninstallRemoveTest.testUninstallFromAllApps" into main 2025-01-09 13:27:59 -08:00
Sebastian Franco cc5911a57b Making sure we don't use Launcher when null
Fix: 386230683
Test: all test that use @PortraitLandscape
Flag: TEST_ONLY
Change-Id: I40dfd0e8f42a68649e1cbb2f8e69ce617a415f68
2025-01-09 13:04:37 -08:00
Stefan Andonian 56f17cfddf Attempt to fix TaplUninstallRemoveTest.testUninstallFromAllApps
Based on the video, it seems that existing app icons cause the long press menu
to be opened when the test bot is trying to scroll to open the AllApps page.
The fix is to clear the data so there are no icons that will interrupt said scrolling.

There might be 2 issues that are affecting this test based on my research. So if it still fails, that doesn't mean this change wasn't necessary. I think there might also be an issue with the test infrastructure.

Bug: 386231522
Test: Ran a go/abdt run to verify test isn't flaky. This does have 100% reproduction though.
Flag: EXEMPT test fix
Change-Id: Id2b1cf89eda39d1d921af0da544f92604c3f8591
2025-01-09 10:30:22 -08:00
Riddle Hsu a584c24493 Wait for launcher state before proceeding next test step
Otherwise if scrollToAppIcon is called immediately, it could
interrupt the state that causes the test to be unable to drag
the icon into workspace.

Fix: 388510107
Flag: TEST_ONLY
Test: atest Launcher3Tests:ThemeIconsTest#testIconWithoutTheme
Change-Id: Ied77b3f8d2f19de18d054a80643f3d13c5641ac4
2025-01-09 12:58:39 +08:00