Commit Graph

18400 Commits

Author SHA1 Message Date
Anushree Ganjam 991a40ca92 Merge "Update the Online search Engine key to "selected_search_engine"." into main 2024-05-30 19:50:05 +00:00
Jordan Silva 503985c663 Merge "Fix Talkback wrong label announced going from App to Overview" into main 2024-05-30 16:02:55 +00:00
Shamali Patwa c4c554139f Merge "Scale down the widget previews on similar scale as the spring load scale" into main 2024-05-30 14:58:41 +00:00
Jordan Silva 8181dfdf92 Fix Talkback wrong label announced going from App to Overview
To fix the incorrect title information being spoken after a transition state ends, a new function named getTitle is introduced in the LauncherState. This function provides the correct title for the transition state. The default accessibility label is set to R.string.home_screen. All Apps and Overview states override the getTitle function to ensure the correct accessibility label for their respective states.

Fix: 265892510
Flag: EXEMPT bugfix
Test: Manual with Talkback. With Talkback enabled, navigate from App to Overview.
Change-Id: I96b820f310f8b778a149709bca687a5912386246
2024-05-30 14:01:32 +00:00
Brandon Dayauon e2d42c617f Merge "Fix private space icons disappearing from search state." into main 2024-05-30 07:19:45 +00:00
Brandon Dayauon 987efd6ea4 Fix private space icons disappearing from search state.
This is because during onBind() that the icon alpha should be set to 0 ONLY in the case
when animation + scroll is happening.

The repro cuj is this:
user has private space unlocked -> goes to toast and clicks qs tile -> onBind() happens
and animationScrolling = true -> icon alpha is now 0. Instead we should check getAnimate() && scrolling()
&& isStateTransitioning()

bug: 340836439
Test: manually -
before: https://drive.google.com/file/d/1WLZRPsz-hm1d3fVRNGXs_Ps_AcdJhkPs/view?usp=sharing
after: https://drive.google.com/file/d/1LidDKhx2ijOXmX_tcPAmng5P56WNPyyx/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation NEXTFOOD
Change-Id: I10b8ee5d8449acdb3d2c64e0e311f7dde89a464a
2024-05-29 22:41:57 -07:00
Shamali P 3dabf391f2 Scale down the widget previews on similar scale as the spring load scale
Currently entire workspace scales down, but the original view sticks
to user's finger at same size as before. This makes the view look larger
obstructing the view of workspace behind it - specifically, when the
widgets are of larger size.

Additionally, with this scaling change, the preview images that aren't
of same aspect ratio don't break the transition to final widget as
before.

Bug: 338290585
Test: Unit test
Flag: None bugfix
Change-Id: I1d1818e60506898c7b28074f01cee91282032a94
2024-05-29 22:38:22 +00:00
Brandon Dayauon c1a7d51870 Merge "Remove animatorSet's duration" into main 2024-05-29 21:16:22 +00:00
Anushree Ganjam 34c4605cf1 Update the Online search Engine key to "selected_search_engine".
Test steps:
1. Execute adb shell settings put secure selected_search_engine <search_engine_package_name> (Ex: com.duckduckgo.mobile.android)
2. Install the app and verify the search widget on launcher is updated.
3. Uninstall the app and verify the search widget is replaced by
   placeholder

When we change the search engine setting after the app is installed , we need to force-stop launcher app for the new settings to take effect.

Bug: 333029477
Flag: EXEMPT bugfix
Test: Manual
Change-Id: If127dcc87c5278a98177b83514cddb09a4124223
2024-05-29 13:40:41 -07:00
Brandon Dayauon 3f5437e14e Remove animatorSet's duration
Setting this animationDuration slows down the individual animations.
This is fine as the individual animations already has the timings that will add up to spec.

bug: 343493101
Test: before: https://drive.google.com/file/d/1nuS1c143HUosaVdhde3GW8Ryz04gUW7x/view?usp=sharing
after: https://drive.google.com/file/d/1yNcYLqBFD0di-YISNMUpryzBhqNZdncm/view?usp=sharing
Flag: None Animation tweak.
Change-Id: I5f10388fdecd934801ca208a46cc6ba93094c56f
2024-05-29 11:51:19 -07:00
Sunny Goyal b03d274375 Merge "Fixing some missing swipecancelled events" into main 2024-05-25 08:11:56 +00:00
Sunny Goyal 97ceed42e6 Fixing some missing swipecancelled events
Updating NavBarPosition to expose more constructor and getters

Flag: com.android.launcher3.use_activity_overlay
Test: atest SwipeTransitionTest
Bug: 340432854
Change-Id: I86193fa26c0337d50e366cecb2d7debf37940fe1
2024-05-24 17:34:36 -07:00
Brian Isganitis 7317e42b47 Merge changes I340485ed,Iba07382d into main
* changes:
  Disable taskbar EDU for tiny taskbar.
  Initial prototype of tiny taskbar.
2024-05-24 19:11:55 +00:00
Pierre Barbier de Reuille 2de842b558 Merge "Update desktop mode to identify minimized tasks" into main 2024-05-24 08:26:48 +00:00
Liam Lee Pong Lam 1f5e8c6e77 Merge "[Launcher3] Hide keyboard when fastscroller scrolling down and keyboard shown" into main 2024-05-23 23:35:36 +00:00
Brian Isganitis e1eaefd537 Initial prototype of tiny taskbar.
Introducing isTinyTaskbar and using in a few places to show Taskbar on
phones.

Disabling for three button mode since the buttons will take up most of
the space. Could also prototype adding meta key as a 4th button in
this case if we feel like it.

Flag: com.android.wm.shell.enable_tiny_taskbar
Test: Manual
Bug: 341784466
Change-Id: Iba07382d9bd5d14fc29ef080a390db561f6fd454
2024-05-23 16:40:58 -04:00
Pierre Barbier de Reuille f60dd5471c Update desktop mode to identify minimized tasks
When a task is minimised, it becomes invisible but is still running.
WMShell now signals to the launcher when a task's visibility changes.
The task bar takes the visibility into account to know if a running task
is, in fact, minimised.

Test: atest NexusLauncherTests:DesktopTaskbarRunningAppsControllerTest
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 333872717
Change-Id: Iaff6b1240d354bb3c4de8e4884948acf9bf40112
2024-05-23 20:59:16 +01:00
Liam, Lee Pong Lam 883a79db71 [Launcher3] Hide keyboard when fastscroller scrolling down and keyboard
shown

Implement keyboard hiding logic: Hide keyboard when scrolling down (y > mLastY) unless already requested (mRequestedHideKeyboard). Track hide request state to prevent redundant calls.

result video: https://photos.app.goo.gl/e4dYUUiUN3BujNUz9

Bug: 333967597
Flag: EXEMPT bugfix
Test: Manual
Change-Id: I42b9d05dd5368b021577f12541248d434ee22495
2024-05-22 23:17:28 +00:00
Treehugger Robot 014a17ee58 Merge "Animate scrim within open/close PendingAnimation." into main 2024-05-22 23:13:47 +00:00
Sihua Ma 26d9b9c696 Merge "Reapply "Move widget picker tests to Robolectric"" into main 2024-05-22 21:56:02 +00:00
Zak Cohen 73fe0b439e Merge "WidgetPicker - Fix sliding scrim on add widget dialog." into main 2024-05-22 21:03:46 +00:00
Zak Cohen 10cf086910 WidgetPicker - Fix sliding scrim on add widget dialog.
Use the system dimming for standalone widget picker activity, as the system
is applying a default transition.


Bug: 342230362
Flag: NONE animation tweak
Test: visual

Change-Id: I278f8bf97acbfbfca652e1e6b616e2d2885ca92a
2024-05-22 13:32:59 -07:00
Andrew Cole 4897f7bcd6 Merge "Removing AdaptiveIconDrawable Checks" into main 2024-05-22 20:25:56 +00:00
Sihua Ma 1159c2546f Reapply "Move widget picker tests to Robolectric"
This reverts commit 97ee134acc.

Reason for revert: Fixed an issue with UI_HELPER_EXECUTOR that caused the flakiness

Test: atest NexusLauncherRoboTests
Test: SysUI studio
Flag: None Test migration
Fix: 325088642
Fix: 325088805
Fix: 325089116
Fix: 325088960

Change-Id: I2f50c30d2c861e3bba8a8fa3ec547ca2ade6153a
2024-05-22 19:41:11 +00:00
Anushree Ganjam ef9427c709 Merge "Add "Uninstall app" string for private space shortcut." into main 2024-05-22 16:08:31 +00:00
Anushree Ganjam 87e875e702 Add "Uninstall app" string for private space shortcut.
Before: https://screenshot.googleplex.com/8RvbiWnJmgAvSYf.png
After: https://screenshot.googleplex.com/4e7N3rr8EAH7k6B.png

Bug: 335451332
Flag: com.android.launcher3.enable_private_space
Flag: EXEMPT resource only update
Test: Manual
Change-Id: I759005f51562683cb6c095abcca27d448acd10f8
2024-05-21 16:36:02 -07:00
Brian Isganitis 08a7ef9d6d Animate scrim within open/close PendingAnimation.
AbstractSlideInView implementations can override how the scrim is
interpolated.

Test: Manual
Flag: NONE Trivial
Bug: 341784466
Change-Id: Id184a5753b369f8f6b4c3d905d26c1a27209dad6
2024-05-21 15:06:54 -04:00
Alex Chau 4127e460b0 Move common code from DesktopTaskView and GroupedTaskView to TaskView
- Most TaskView method will now loop through taskContainer instead of accessing the first/second
- Moved TaskThumbnailView, showWindowsView, and TaskOverlay to be part of TaskContainer. There are still some TaskOverlay access from TaskThumbnailViewDeprecated that should be remove as we start using TaskThumbnailView

Fix: 339787250
Test: Manual
Flag: EXEMPT refactor
Change-Id: Icfaa4f5eb50582faed01113465335b6d2899f781
2024-05-21 12:43:37 +01:00
Andrew Cole cdfa5e6b33 Removing AdaptiveIconDrawable Checks
As part of the internal cleanup for adaptive icons, we are removing if checks for AdaptiveIconDrawable that are no longer necessary. Also refactoring to follow a more functional programming pattern for easier future refactors.

Bug: 318867282
Flag: EXEMPT BUGFIX
Test: AllAppsSearchImageTest
Change-Id: Id13040bc4fd2ca7e85583d727b228ee390eadc91
2024-05-20 11:01:51 -07:00
Oli Thompson 9305badf5a Merge "Show edu card when managed profile removed" into main 2024-05-20 10:38:19 +00:00
Fengjiang Li 01d4ca8aca Merge "Use global PackageManagerHelper for LoaderTask" into main 2024-05-17 21:02:01 +00:00
Sunny Goyal b7cd672363 Merge "Adding support for importing/exporting launcher layout" into main 2024-05-17 18:08:25 +00:00
Fengjiang Li a3e89b0cd2 Merge "Log warning when UserHandle in UserManagerState#allUsers get overridden" into main 2024-05-17 05:56:12 +00:00
Sunny Goyal 25f5e29418 Adding support for importing/exporting launcher layout
Bug: 338282246
Flag: None
Test: Manual, developer feature
      atest AutoInstallsLayoutTest
Change-Id: I8a5674080f3c156d97bc6118c51532c2fe8177d5
2024-05-16 15:24:41 -07:00
Fengjiang Li 172e454e2c Log warning when UserHandle in UserManagerState#allUsers get overridden
Bug: 340362067
Test: manual
Flag: NONE
Change-Id: I123f02f52408db0f7c711ee420743ac01df04156
2024-05-16 13:59:47 -07:00
Treehugger Robot 7ca8954796 Merge "Clean up some old (pre-aconfig) flags." into main 2024-05-16 18:37:43 +00:00
Fengjiang Li 62f1eca9e7 Use global PackageManagerHelper for LoaderTask
This reverts ag/27303480 as we have found the root cause of workspace icons deleted by setting up private space (ag/27354841)

Fix: 340362067
Test: manual
Flag: NONE
Change-Id: I81d95e95282f09b872268ddb232ba9f092e952bc
2024-05-16 11:04:32 -07:00
Luca Zuccarini 2d3dae75be Clean up some old (pre-aconfig) flags.
These have been enabled for a long time and are safe to remove.

Fix: 270394392
Fix: 270394041
Flag: NONE removing an old flag
Test: everything still works as expected (no-op change)
Change-Id: Id5fc356a29a7e85324a8c3f922709251f371b2c5
2024-05-16 16:43:27 +00:00
Alex Chau ed9e3a8701 Merge "Convert TaksView to Kotlin" into main 2024-05-16 14:00:02 +00:00
Charlie Anderson a8058669d5 Merge "Adding additional logging around updated shortcuts" into main 2024-05-16 13:52:02 +00:00
Alex Chau 9565667813 Convert TaksView to Kotlin
- PS1: Android Studio conversion (unformatted, cannot compile)
- PS2: Fix compilation issues and formatting
- PS3: First pass ready for review
- PS4: Minor changes (Remove Consumer, remove unnecessary null-checks)
- PS5: Removed check() around taskContainers, which is now lateinit and should always be initiailzed. Also ensure TaskView is bound before adding to parent.
- PS6: Move a bunch of getters to use .property style
- PS8: Refacoted RecentsView.applyLoadPlan bind logic, to avoid inflating TaksView, bind, add then immediatley remove
- PS10: Turned more functions to express functions; added an extension function
- PS11: Re-order functions, no code changes
- PS12: Reverted unit express function back to {} style

Bug: 339787593
Test: Manual
Flag: NONE
Change-Id: I75c06cf29718d8f258a4124997bcb054f5eb056f
2024-05-16 12:33:28 +01:00
Sam Cackett 1ee568bf13 Merge "Add metric logging for fake landscape usage" into main 2024-05-16 10:28:26 +00:00
Charlie Anderson 1e96d751d2 Adding additional logging around updated shortcuts
Bug: 338218961
Test: locally
Flag: N/A
Change-Id: Ic72ec2686de20036928c1e98b52677bd82368282
2024-05-15 14:18:21 -04:00
Oli Thompson 3ea1acb8ca Show edu card when managed profile removed
Reset the work edu card bit so the edu card shows if the managed profile is removed

Also remove padding from the close button so it doesn't clip. screenshot https://screenshot.googleplex.com/96Yc6yExZ57btxG

Bug: 315449027
Bug: 293642345
Test: manual
Flag: NONE
Change-Id: I60cfc0c258d28a6674aec41862c1770550a14955
2024-05-15 14:19:03 +00:00
samcackett 76331b6c17 Add metric logging for fake landscape usage
- Reuse existing TaskSwitcherContainer for Overview metric logging
- Log current orientation state for Overview when interacting with
gestures or via three button nav
- Log current orientation state on each phone rotation

Bug: 332870519
Test: Manual
Flag: NA
Change-Id: Ia10cf1acb809432175daab55151998f0d77362f9
2024-05-15 09:42:08 +01:00
Brandon Dayauon e369bd6502 Merge changes I7c303e66,Idc03b9d3 into main
* changes:
  Add floatingMaskView when animating to mimic bottom container.
  Add private_space_floating_mask_view flag.
2024-05-14 23:15:40 +00:00
Anushree Ganjam a77c28cd78 Merge "Add 0-state web data loader logs" into main 2024-05-14 23:13:03 +00:00
Charlie Anderson 8aa2898a58 Merge "Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon." into main 2024-05-14 18:57:09 +00:00
Shamali Patwa 8a5eddb923 Merge changes from topic "update-strings" into main
* changes:
  Add comments on suggestion category related strings
  Clean-up unused categories (follow up cleans up strings)
2024-05-14 18:38:54 +00:00
Chris Göllner fa09b12443 Merge "Convert SysUiState flags from int to long" into main 2024-05-14 10:44:40 +00:00