Commit Graph

2723 Commits

Author SHA1 Message Date
Sunny Goyal c82916fecb Some cleanup in RecentsView
> Merging overview and all-apps scrims into a single View
> Decoupling TaskMenuView from taskView

Bug: 184676497
Test: Manual

Change-Id: I49f7249eaa2a800054385ab8e73a441d6a1b5e16
2021-04-06 15:47:33 -07:00
Tony Wickham fc3bc6098f Merge "Explicitly set which taskbar view is visible at each caller" into sc-dev 2021-04-06 19:37:18 +00:00
Tony Wickham 0b0c173ec0 Merge "Ensure taskbar animation ends when running window animation does" into sc-dev 2021-04-06 19:35:38 +00:00
Tony Wickham c9846dc6e7 Merge "Cleanup taskbar touchableInsets" into sc-dev 2021-04-06 18:36:05 +00:00
Samuel Fufa 50c6a37ea9 Merge "[Search][Layout] Fix blank space when predictions are disabled" into sc-dev 2021-04-06 17:56:51 +00:00
Zak Cohen fd9af2f017 Merge "Overview - update Clear All and Empty message drawing" into sc-dev 2021-04-06 17:42:05 +00:00
Samuel Fufa 5461089baa [Search][Layout] Fix blank space when predictions are disabled
This regression is caused due to getExpectedHeight relying on view visibility state while AlphaUpdateListener.updateVisibility was reseting the views visibility.

Bug: 184211402
Test: local
Change-Id: Ib756f5eb8f6356a18a025626008b97fd7c77fec9
2021-04-06 04:05:20 -05:00
TreeHugger Robot ce271c1067 Merge "[Hotseat] Don't show hotseat edu in tests" into sc-dev 2021-04-06 06:18:56 +00:00
TreeHugger Robot e77fc9cc25 Merge "Add split placeholder view above OverviewScrim" into sc-dev 2021-04-06 02:34:19 +00:00
Tony Wickham 9f436dfe8e Ensure taskbar animation ends when running window animation does
- Store the possible parallel animation to cancel/end in
  AbsSwipeUpHandler#endRunningWindowAnim()

Test: 1. remove taskbar during transition, ensure cleaned up properly
2. open a second app during transition to home, ensure taskbar
maintains correct visibility
Bug: 182512211

Change-Id: I71a6b6ce624113d43ad5a599cb5cfec28a555310
2021-04-05 17:52:38 -07:00
Tony Wickham e13a4a4475 Cleanup taskbar touchableInsets
- Remove obsolete visibleInsets hack and isDraggingItem() check
- Have TaskbarController determine whether taskbar is touchable,
  rather than TaskbarContainerView.
- Disallow touches during transition to home (can potentially
  improve this later)

Test: Swupe home, tap taskbar folder during transition, ensure
don't end up in broken state with the uninteractable folder open
Bug: 182512211

Change-Id: Id625ce8b9b876a8a1b450b7d6fb771540e23bc08
2021-04-05 17:33:44 -07:00
Zak Cohen 23b7fea6eb Overview - update Clear All and Empty message drawing
Update Clear All and Empty message to use primary color, not workspace
color, as they are drawn on floating background now, not wallpaper.

Bug: 184260454
Fixes: 184260454
Test: local build, flash and run
Change-Id: Ie8ef4b7ace3053c2068a27b7cbedbbb039fc36d8
2021-04-05 23:45:02 +00:00
Tony Wickham 6a74e65953 Explicitly set which taskbar view is visible at each caller
This makes it more clear which taskbar view is expected for particular
code flows. Also makes it easier to set it to null in cleanup().

Test: call cleanup() while taskbarOnHome is invisible, ensure hotseat
icons go back to being visible
Bug: 182512211
Fixes: 183633496

Change-Id: I680a15582c8034a049b20e035b4d54f5ea5aee04
2021-04-05 16:42:17 -07:00
Becky Qiu 9b85dc836d Merge "Shared element transition between image and sharesheet." into sc-dev 2021-04-05 22:18:34 +00:00
Samuel Fufa 2043f2009f [Hotseat] Don't show hotseat edu in tests
Bug: 180972179
Test: presubmit
Change-Id: I2e82c0c90804d0149717ebdcd83fdac9c822ce7d
2021-04-05 16:49:47 -05:00
Zak Cohen 7ec7c22b07 Merge "Overview - add the ability to color scrim task views." into sc-dev 2021-04-05 21:05:25 +00:00
Vinit Nayak e3f7d0d1b4 Add split placeholder view above OverviewScrim
Only show single split option for landscape and
seascape overview menu options.

Bug: 181705607
Change-Id: I577fbaed41b5debd007c953851ec2056988057d9
2021-04-05 12:41:06 -07:00
Sreyas 8a9cc9689a Shared element transition between image and sharesheet.
Bug: 182373655
Test: Manual
Change-Id: I6f5abffa0c4911d939ba45476fe1301d65b840cf
2021-04-05 19:15:55 +00:00
Samuel Fufa ee9aff9b5b [Search][Motion] Normal<->AllApps transition revamp
Preview video attached to BR

Key changes:

- SearchUiManager#getScrollRangeDelta is removed. AllApps initial vertical offset is now controlled by deviceProfile.allAppsOpenVerticalTranslate.
- ShelfScrimView is renamed to AllAppsScrimView. Scrim no longer does vertical translate with AllApps open.  Shelf/overview related code removed.
- Scrim and AllApps content transition are animated with different interpolators. Scrim color is a blend of accentColor and allAppsScrim with proportion determined by progress*TINT_DECAY_MULTIPLIER

Bug: 183001675
Test: Manual
Change-Id: Id6bde7ee65c55c83c2973fe41f458b9364d39ecd
2021-04-05 13:32:51 -05:00
Zak Cohen ec4407b4ef Overview - add the ability to color scrim task views.
Bug: 184202238
Test: local build and flash
Change-Id: If700cb6dffc3966fe860c40d98d40a5899c236e4
2021-04-05 11:17:02 -07:00
Alex Chau 5bd9ba2a80 Merge "Focus running task in overview grid" into sc-dev 2021-04-02 03:57:58 +00:00
TreeHugger Robot 20efbbbb1c Merge "Fixing notification dots settings not updated properly" into sc-dev 2021-04-01 20:14:34 +00:00
Sunny Goyal 7a5b6f868a Merge "Removing some unused classes" into sc-dev 2021-04-01 20:11:14 +00:00
Alex Chau dfde4d96ea Focus running task in overview grid
- calculateTaskSize now returns the Rect for focused task
- Introduced calculateGridTaskSize for non-focused task, and translate non-focused tasks to fit the grid
- As Task Rect is now vertically centered, removed ClearAllButton's grid vertical translation
- When ClearAllButton is not shown (e.g. quickswitch), make sure ClearAllButton's scroll won't be used when page snapping. This happens when page scrolls are translated so they're negative.
- Added back ActionsView when task is focused below the TaskView, which become invisible as you scroll
- In Modal state, move the ActionsView down so it won't cover the TaskView

Bug: 175939487
Test: manual
Change-Id: Idfa94a51f856418adc0503cf04211dcb4b1814fe
2021-04-01 14:52:25 +01:00
Winson Chung 80988abae3 Merge "Expose the full task info with the remote animation target" into sc-dev 2021-04-01 03:56:56 +00:00
Sunny Goyal 58530bd64b Fixing notification dots settings not updated properly
Also avoiding settings cache reset whenever someone registers
a new listener

Bug: 184200027
Test: Manual
Change-Id: I0c8b7084b6b4656102e9041b779b80a98624ddd8
2021-03-31 15:57:49 -07:00
Marvin Bernal a090cfc836 Merge "Add System Back function to SystemUiProxy" into sc-dev 2021-03-31 20:59:03 +00:00
Zak Cohen 00611188e5 Merge "Overview - update UI to use solid color scrim." into sc-dev 2021-03-31 20:34:00 +00:00
Sunny Goyal 157a9ee7dd Removing some unused classes
Bug: 184183801
Test: Manual
Change-Id: I946b4b4d486d52e467bb3df7dcac65e534803b7d
2021-03-31 12:59:57 -07:00
Zak Cohen a547b781ee Overview - update UI to use solid color scrim.
Also required updates to colors and status bar icons to match with new
color.

Bug: 179922117
Test: local build and flash on two devices

Change-Id: Ibec54107f52c01f125e6d100abe32434f2067b71
2021-03-31 11:25:41 -07:00
Alex Chau 21dfadab76 Merge "Changes page alignment in PagedView calcualtion" into sc-dev 2021-03-31 10:36:12 +00:00
TreeHugger Robot 70c3d5f98b Merge "Using an independent drawable for rounded corners" into sc-dev 2021-03-31 09:02:00 +00:00
Marvin Bernal 3804f91a46 Add System Back function to SystemUiProxy
Bug: 183988752
Test: mp launcher
Change-Id: Iaddd1f8a9440c80840209d653c0b3e59b8138a26
2021-03-31 01:37:18 +00:00
Tony Wickham 7e7116278b Merge changes I2af1792e,Ice314d46,Ib17d4a5e into sc-dev
* changes:
  Invert StateAnimationConfig.PLAY_ANIMATION as SKIP_ALL_ANIMATIONS
  Remove Overview atomic animation support
  In 2 button mode, animate to HINT_STATE instead of OVERVIEW directly
2021-03-30 22:27:07 +00:00
Sunny Goyal 940c27ef1a Using an independent drawable for rounded corners
Bug: 183641907
Test: Manual
Change-Id: I3114d43d07c03884348e1c33805545f19bb8d540
2021-03-30 14:47:44 -07:00
Sunny Goyal 07fb2fea34 Merge "Simplifying all-apps seach pipeline" into sc-dev 2021-03-30 19:50:23 +00:00
Hongwei Wang d21362a5a7 Merge "Pass the whole auto pip transaction to recents animation" into sc-dev 2021-03-30 19:26:24 +00:00
Tony Wickham 99af1b2954 Merge "Fix Home->Overview not being logged in 0 button mode" into sc-dev 2021-03-30 19:22:15 +00:00
Sunny Goyal 04e9f39f19 Simplifying all-apps seach pipeline
Bug: 183607616
Test: Verified on device
Change-Id: Id7ded3c244b747a577cdfcf298db6dddf19fa4eb
2021-03-30 10:07:32 -07:00
Alex Chau b5c4d1108f Changes page alignment in PagedView calcualtion
- Align pages to right (instead of left) in RTL, to make scroll calculation for grid overview easier for out of orientation tasks
- Changed TaskView pivot direction to be consistent with page alignment
- Add scroll offset for ClearAllButton to align to left in RTL
- Fixed Workspace scroll issues in RTL, and removed needs to use panelCount when calculating page scroll

Bug: 175939487
Test: Test carousel/grid overveiw, Workspace, Folder scroll view for normal/RTL
Change-Id: Ic0ba88e5d58638e1149d97a68a978d80fbf26774
2021-03-30 12:05:16 +01:00
Zak Cohen d9efc0b273 Merge "Overview - extract AssistContentRequester logic for reuse." into sc-dev 2021-03-30 02:39:51 +00:00
Vadim Tryshev 419c1092e3 Merge "Fixing a leak in WallpaperColorInfo" into sc-dev 2021-03-30 01:13:40 +00:00
vadimt 1b54846254 Fixing a leak in WallpaperColorInfo
Nulling temp listeners after use

Test: presubmit
Bug: 181356264
Change-Id: I6cace47f1424e2fe59a283bb0e16de523875b6cf
2021-03-29 14:47:06 -07:00
Pat Manning adcc940d4b Merge "Shift only tasks within current grid row upon task dismissal." into sc-dev 2021-03-29 20:38:00 +00:00
Tony Wickham 52bbcc3976 Invert StateAnimationConfig.PLAY_ANIMATION as SKIP_ALL_ANIMATIONS
This allows the default flag to be 0 instead of PLAY_ANIMATION, and is
aligned with the existing SKIP_OVERVIEW and SKIP_DEPTH_CONTROLLER
flags.

Test: Navigate to various states, works as before
Bug: 175137718
Change-Id: I2af1792e7fbd5bca82afb225290fd6b545368dcf
2021-03-29 11:59:14 -07:00
Tony Wickham 6cd95cd2d8 Remove Overview atomic animation support
- Remove PLAY_ATOMIC_OVERVIEW_SCALE and PLAY_ATOMIC_OVERVIEW_PEEK
- Remove complicated parallel atomic animation support from
  AbstractStateChangeTouchController and subclasses
- Remove some code related to going between Overview <-> AllApps

Test: Swipe between states in all 3 navigation modes
Bug: 175137718
Change-Id: Ice314d46946c3a983cdc6ccf1a67effb5da9156e
2021-03-29 11:59:06 -07:00
Tony Wickham c5d168da82 In 2 button mode, animate to HINT_STATE instead of OVERVIEW directly
When reaching HINT_STATE_TWO_BUTTON, we goToState(OVERVIEW) with a
haptic, to keep the same feeling as before.

Test: Swipe up from home on nav bar, ensure it goes to overview
Bug: 175137718
Change-Id: Ib17d4a5e9e33b8bf9b074f926faa6d0e2fb487fa
2021-03-29 11:58:50 -07:00
Zak Cohen 733efa1bcd Overview - extract AssistContentRequester logic for reuse.
Extract the logic for fetching AssistContent into a common reusable place.

Bug: 179705864
Test: Local build of main launcher
Change-Id: Ife37a393d93f899fa1ae460bdcf0cadff6468b04
2021-03-27 14:53:34 -07:00
Tracy Zhou 78f5a8c6ab Merge "Fix failed test in order to enable Live Tile (in the next change)" into sc-dev 2021-03-26 18:54:31 +00:00
Sunny Goyal 7cb9327c28 Merge "Moving some common functionality to IconLoaderLib" into sc-dev 2021-03-26 16:42:04 +00:00