Commit Graph

2373 Commits

Author SHA1 Message Date
ELIYAZ MOMIN (xWF) 931a86396f Merge "Revert "Making sure that test go to FixedLandscape on landscape"" into main 2024-12-11 04:05:30 -08:00
ELIYAZ MOMIN (xWF) d98bb0b979 Revert "Making sure that test go to FixedLandscape on landscape"
This reverts commit 279b77a882.

Reason for revert: <Potential culprit for b/383424365 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.>

Change-Id: I4b1c81a8e458432c880ad68fa5bd0e2062f2680f
2024-12-11 02:38:04 -08:00
Sebastián Franco 485c57044d Merge "Making sure that test go to FixedLandscape on landscape" into main 2024-12-11 00:40:31 +00:00
Treehugger Robot 11537828ad Merge "Fising some tests bugs, assuming primary user is user 0" into main 2024-12-10 23:50:28 +00:00
Sunny Goyal 89551b71be Fising some tests bugs, assuming primary user is user 0
Bug: 383091872
Bug: 383183795
Bug: 383088668
Test: Presubmit
Flag: EXEMPT test fix
Change-Id: I551f13fc3d51bf1c2718f0582f8ee76d51067896
2024-12-10 12:09:33 -08:00
Sebastian Franco 279b77a882 Making sure that test go to FixedLandscape on landscape
Fix: 379871292
Test: TaplDragTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I56027c22e4c3b1b0532ba0ac00eb0f4caea24abb
2024-12-10 17:08:54 +00:00
Sunny Goyal 3dfaba2d8c Fixing missing userId in various shell commands
Bug: 380276168
Test: atest TaplMemoryTests
Flag: EXEMPT testfix
Change-Id: I87026eaf6340a2a43cbc899d262879259e339fc5
2024-12-09 10:36:06 -08:00
Treehugger Robot 45e274977d Merge "Some test fixes where default user is assumed to be user 0" into main 2024-12-07 08:11:56 +00:00
Brandon Dayauon 5d69c5c505 Merge "Fix workUtilityView receiving touch for pause work apps button." into main 2024-12-07 07:28:02 +00:00
Sunny Goyal 9c58954488 Some test fixes where default user is assumed to be user 0
CheckLongPressHelper: Cancelling view longpress which inturn also cancels self
This ensures that long press is properly cancelled if the default timeout for system longpress is same as ours

Bug: 379777736
Bug: 379807782
Bug: 379805363
Bug: 379805788
Bug: 379777734
Bug: 379774350
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: Ic4d9d6c4f79325a5d7ab98eafa1c86db4c2e67a5
2024-12-06 22:23:51 -08:00
Brandon Dayauon 8143b69cec Fix workUtilityView receiving touch for pause work apps button.
bug: 382501851
Test manually video:
before: https://drive.google.com/file/d/1I6av4cFoYex6QhzYAdlzJWCBwd2ilgzT/view?usp=sharing
after: https://drive.google.com/file/d/1hMDELNTqUvoI7oI-lw0sLifcGyIalbS_/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile

Change-Id: I9dfead6deac7f3dbcb66c961bea4a1828f20478d
2024-12-06 14:05:03 -08:00
Sunny Goyal 97eb832cd3 Generalizing monochrome icon into Theme icons
Bug: 381897614
Flag: EXEMPT refactor
Test: atest MonoIconThemeControllerTest
      atest MonoThemedBitmapTest

Change-Id: Iaa0cbe3523ee26a6d4f77e002d0cca90657f89b2
2024-12-05 14:57:06 -08:00
Shamali P 0e668e1b1d Update accessibility hint for widget cell that shows add button.
With tap to add feature, tapping widget cell reveals add button.

So, clarify the intent with ACTION_CLICK

Bug: 374033389
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I03e47241fbc16f1354394e3a6fd412998642e6cf
2024-12-04 18:12:36 +00:00
Brandon Dayauon fcb892328b Add unit testing to workkUtilityView
Testing inflate and visibility states (with both flag states)

bug: 361589193
Test: manually screenshot: https://screenshot.googleplex.com/45HDsyfQfNbgjiE
Flag: com.android.launcher3.work_scheduler_in_work_profile
Change-Id: I57cff03fe3b362e304f52984a2699f8d5b6e653e
2024-12-02 10:32:56 -08:00
fbaron ddc338c39b Fixing grid migration test and adding extra tests to cover one grid updates
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: GridMigrationTest
Change-Id: Ib162b2f802da610a4d2802af4c890425cd657add
2024-11-26 21:05:04 +00:00
Sunny Goyal 82efdccc6e Wait for animations before injecting input event
While animaiton is running, some views might not be visible causing
them to miss input events

Bug: 378167329
Bug: 378167718
Test: Presubmit
Flag: EXEMPT test fix
Change-Id: I8608c415e524fc5186833eac840ec18c6f244eb0
2024-11-18 13:44:20 -08:00
Sunny Goyal 5f8e2d7c13 Migrating widgets tests off TAPL
Bug: 377772352
Test: Presubmit
Flag: EXEMPT test refactor
Change-Id: I6e9ffb3dee913617ca9ad897504e8457cfbdccd6
2024-11-15 12:45:27 -08:00
Sunny Goyal cac373ce91 Separating TAPL functionality from AbstractLauncherUiTest into a separate base class
This will make it easier to get rid of AbstractLauncherUiTest by directly depending on the base class

Bug: 377772352
Test: Presubmit
Flag: EXEMPT test infra
Change-Id: I46ceb188ed4b64d4fb86236969ed0d3f23809000
2024-11-13 16:27:22 -08:00
Schneider Victor-tulias 7e34644021 Merge "Revert "Revert "Reset the frozen recents list state prior to tes..."" into main 2024-11-13 14:54:31 +00:00
Treehugger Robot bda5d70e03 Merge "Revert "Adding screen record for the bug where we can't find a folder after dragging"" into main 2024-11-13 00:53:04 +00:00
Vadim Tryshev e238685c0d Revert "Adding screen record for the bug where we can't find a folder after dragging"
This reverts commit 243650e2cb.

Reason for revert: Bug stopped to repro

Change-Id: Idebb704546146018c6a365143ff84efb04be9c27
2024-11-12 23:09:38 +00:00
Federico Baron bad6326145 Merge "Add device profile dump flag guarding for OneGrid" into main 2024-11-12 07:39:56 +00:00
fbaron 9b2f38fa26 Add device profile dump flag guarding for OneGrid
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: n/a
Change-Id: I8bee69a051e81e7a1f7ed0d4e20196e2379a8ed0
2024-11-12 04:30:41 +00:00
Treehugger Robot 287b90278f Merge "Moving some tests off TAPL" into main 2024-11-12 00:35:53 +00:00
Schneider Victor-tulias a576a818e9 Revert "Revert "Reset the frozen recents list state prior to tes..."
Revert submission 24905816-revert-24866277-recents_freeze_tests-WMHXUBYPSF

Reason for revert: fixes b/374269947. revert reason may be obsolete

Reverted changes: /q/submissionid:24905816-revert-24866277-recents_freeze_tests-WMHXUBYPSF

Change-Id: I514973959407b48e9616d27a44bd93cdc8dd100e
2024-11-11 13:41:40 -05:00
Sunny Goyal 50eeb4c161 Investigating test failure in all-apps
Bug: 378167329
Test: atest KeyboardFocusTest
Flag: EXEMPT test fix
Change-Id: I2f9b9dad3dabf0dc25bb3751ba82a9dc03ccdae2
2024-11-11 10:15:46 -08:00
Sunny Goyal 4631b2eb2c Moving some tests off TAPL
Bug: 377772352
Test: Presubmit
Flag: EXEMPT test refactor
Change-Id: I390fcfd1ad698ba8858891b72e61e3b6792cf718
2024-11-08 14:55:56 -08:00
Sunny Goyal 5ad2d9f53c Moving some tests off TAPL
Bug: 377772352
Test: Presubmit
Flag: EXEMPT test refactor
Change-Id: I679ae043d617b74a61a682d802c38cc904d2d0c5
2024-11-08 11:09:59 -08:00
Federico Baron b986ac5398 Merge "Resolve issue where incorrect grid migration logic was used when migrating to strictly taller new grid" into main 2024-11-08 16:42:03 +00:00
fbaron 3c8a6c6914 Resolve issue where incorrect grid migration logic was used when migrating to strictly taller new grid
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: n/a
Change-Id: I615c2ada4a2275899c08f8b40589c53c9e1dff84
2024-11-07 22:22:35 -08:00
Sunny Goyal 8bbe47c31b Moving Wait to kotlin
Making LauncherInstrumentation optional and removing some reduntant constants.
This allows less dependency on AbstractLauncherUITest

Bug: 377772352
Test: Presubmit
Flag: EXEMPT test refactor
Change-Id: I7cf78d6acc5fef0359dee141a06fd51ff9d4f5a8
2024-11-07 13:51:27 -08:00
Brandon Dayauon 270e1c3dc4 Merge changes from topic "implementWorkSchedulerViewAndUpdateColorsOfFab" into main
* changes:
  Make sure work button is collapsed when keyboard is up upon going to app drawer
  Implement the work scheduler view and update colors of FAB
2024-11-06 19:57:26 +00:00
Brandon Dayauon bfd02bb36a Implement the work scheduler view and update colors of FAB
Update colors of the FAB to spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=3784-112229&node-type=instance&m=dev
Exported the brief case icon from figma since it is not available on go/icons.
Color of the brief case icon is onPrimary.
Have place holder string in launcher but implement the actual string in NL.

bug:361589193
Test - manual: video: https://drive.google.com/file/d/1CIs8qdtV1jUvbq57CcgAXDBPPHHX5CKJ/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile

Change-Id: Ia98e9c4394f6ddfa7009653034929f9afbfeac8c
2024-11-06 09:48:26 -08:00
Shamali P ea078cb647 Add a resource override for providing default widgets filter.
The implementation in this CL is no-op i.e. all widgets will be shown

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Verified with other child cls
Change-Id: I0a6f8973dc8ec58fd87d29b3f291b5e290ea988d
2024-11-04 22:17:23 +00:00
Federico Baron 43cc25b64b Merge "Fix grid migration tests with grid migration refactor flag on" into main 2024-10-29 07:01:16 +00:00
Charlie Anderson b021c32c89 Merge "Fix flagging for LoaderTask broadcast tests and add more coverage" into main 2024-10-28 18:55:43 +00:00
fbaron 22029f6517 Fix grid migration tests with grid migration refactor flag on
Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationDBControllerTest, ValidGridMigrationUnitTest
Change-Id: I2dceb5f9756da7ee7e7ef2d5ec29b3550a51e965
2024-10-28 10:46:17 -07:00
Charlie Anderson 7df6af5831 Fix flagging for LoaderTask broadcast tests and add more coverage
Flag: EXEMPT just tests
Bug: 375674876
Bug: 375704692
Test: LoaderTaskTest and presubmit
Change-Id: Ied00f9282f48ee88949697e5d684c489013e8aeb
2024-10-28 13:15:27 -04:00
Anushree Ganjam ba8c0a8fbd Merge "Make ApiWrapper to be injected by dagger (12/n)" into main 2024-10-25 19:27:50 +00:00
Anushree Ganjam ef2c5c0e49 Make ApiWrapper to be injected by dagger (12/n)
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I53ec78999085b3e0ad6df69e177806e0cb1b52d1
2024-10-24 12:14:40 -07:00
fbaron a796d74e36 Refactor grid migration
In this CL:
-Make GridsizeMigrationLogic functions pure (no side effects)
-Make it so GridSizeMigrationLogic contains the migration logic and does NOT interact with the database
-Let GridSizeMigrationUtil receive the results from the logic layer and use those results to interact with the database appropriately

In future CLs:
-Refactor GridSizeMigrationLogic to Kotlin

Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationTest
Change-Id: Ifcc5ca356558a7463352580f2e89eef8c86ed16b
2024-10-23 22:26:38 +00:00
Schneider Victor-Tulias 8463dc47eb Generalize ActivityTracker to support RecentsWindowManager
Continued quick switch couldn't work using existing infrastructure until RecentsWindowManager could be properly tracked by ActivityTracker. Refactored ActivityTracker into ContextTracker to support this.

Also refactored ActivityInitListener into ContextInitListener to fit the updated pattern.

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 366023051
Test: RecentsWindowSwipeHandlerTestCase; Attempted continued quick switch from home and launched app
Change-Id: Ic38ebf3611ef22fbfd1ddeb79d72d8a3621940a0
2024-10-22 15:29:59 -04:00
Schneider Victor-tulias 892ad69191 Merge "Improve test isolation in AbstractLauncherUiTests" into main 2024-10-17 19:22:37 +00:00
Sukesh Ram fc6cc4e409 Cleanup for TAPL Debugging
Cleaning up leftover log statements.

Flag: EXEMPT bugfix
Bug: 324419890
Test: Manual
Change-Id: I54145d07f0699f68c44aaa34e1692c8fe2f7b780
2024-10-16 16:55:45 -07:00
Schneider Victor-Tulias 07669e9575 Improve test isolation in AbstractLauncherUiTests
- Removing suspicious duplicate uses of AbstractLauncherUiTest.initialize to prevent unnecesary launcher restarts
- Adding UiDevice#pressHome to AbstractLauncherUiTests.verifyLauncherState to ensure the next test starts with a known clean state

Flag: EXEMPT test fix
Fixes: 372956489
Test: AbstractLauncherUiTest
Change-Id: Id68ece4ab195a4f6c47aa401eb50a91b8ff70e10
2024-10-16 13:18:36 -04:00
Sunny Goyal 0bf39fdf26 Merge "Removing unnecessary SafeClosable requirement from DaggerSingletonObject" into main 2024-10-14 17:06:13 +00:00
Sunny Goyal bf9d047b53 Removing unnecessary SafeClosable requirement from DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: EXEMPT dagger
Change-Id: I453159be83e92eee92f5a18cfe0d3ea9a3123f47
2024-10-12 01:26:50 -07:00
Treehugger Robot 99f6d447ea Merge "Cleaning up temporary interfaces which were created for refactoring" into main 2024-10-11 23:02:52 +00:00
Sunny Goyal 43b01b9900 Cleaning up temporary interfaces which were created for refactoring
Bug: 366237794
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: Ic2c69bcdde1429c787903c24f0e19ea26b91d314
2024-10-11 11:03:47 -07:00
Federico Baron f20255fd09 Revert "Demote TaplThemeIconsTest#testShortcutIconWithTheme"
This reverts commit 7672f320e8.

Reason for revert: issue no longer happening

Change-Id: I6dd0b00deb626e0248abc9007c0ae58743931f0c
2024-10-10 18:45:56 +00:00