Commit Graph

20982 Commits

Author SHA1 Message Date
minch c7a66bd4af Migrating the remaining getTaskViewAt(0)
Migrating the remaining `getTaskViewAt(0)` to `getFirstTaskView()`.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Manual
Change-Id: I083626b0ca62b88d06f508dfc15d9f64112f1a6a
2024-12-11 23:50:53 +00:00
Treehugger Robot 4d4eb7d685 Merge "Introduce mTaskViewCount inside the RecentsView" into main 2024-12-11 12:36:00 -08:00
minch 58abc8b0a6 Introduce mTaskViewCount inside the RecentsView
Add a member property `mTaskViewCount` inside the RecentsView to track
the number of TaskView inside it. Its value will be increased
`onViewAdded` and decreased `onViewRemoved`.
- Then `getTaskViewCount()` can just return this variable directly.
- Invalidate the `PagedView.mPageScrolls` on a view addition and
  removal util they have been updated on next `onLayout`. This is done
  to guarantee that `mOnPageScrollsInitializedCallbacks` is run with
  up to date `mPageScrolls`.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Tested on Tangor, ensure `mTaskViewCount` is correct in the
      following scenarios:
      1. Adding more tasks and enter overview
      2. Dismissing one and more tasks
      3. Dismissing all tasks
Change-Id: I32407e77dd2a9b3d8200efc334c1eadea1336b31
2024-12-11 10:43:31 -08:00
Mykola Podolian 29ccf8703b Merge "Remove usage of the enableBubbleBarInPersistentTaskBar flag." into main 2024-12-11 09:24:25 -08:00
Treehugger Robot 9632253a4a Merge "Revert "Play workspace reveal animation for predictive back-to-home"" into main 2024-12-11 08:07:22 -08:00
Schneider Victor-tulias 72fe47d329 Merge "Update OWNERS files to include the sysnav team" into main 2024-12-11 07:01:50 -08:00
Schneider Victor-Tulias 55500094e8 Update OWNERS files to include the sysnav team
Flag: EXEMPT updating OWNERS
Fixes: 383379046
Test: not needed
Change-Id: Ia1c95d6953bfddc9a4cbc7238cf1f9a2e4ee18cf
2024-12-11 09:59:16 -05:00
Johannes Gallmann 6b1272ad9f Revert "Play workspace reveal animation for predictive back-to-home"
This reverts commit 09603bfb39.

Reason for revert: Launcher icons are sometimes not visible during the back-to-home animation when immediately swiping back after opening the app.

Change-Id: I13869cf755160986e323365a460f6ebe128008a9
2024-12-11 06:05:39 -08:00
Johannes Gallmann b2683aa902 Merge "Play workspace reveal animation for predictive back-to-home" into main 2024-12-11 01:33:53 -08:00
Treehugger Robot 8bba339d80 Merge changes Ifd8f10f5,I14f66628 into main
* changes:
  Update LauncherSwipeUpHandlerV2Test setup to account for RecentsWindowFactory
  Update TaplTestsQuickstep to expect recents window states when enabled
2024-12-11 02:40:01 +00:00
Treehugger Robot 3c3c96f66c Merge "Adding MSDL Feedback when swiping up to reveal overview." into main 2024-12-11 01:50:01 +00:00
Treehugger Robot 60b53b3f00 Merge "Adding MSDL long-click feedback to IconView." into main 2024-12-11 01:48:02 +00:00
Juan Sebastian Martinez a159e667e3 Adding MSDL long-click feedback to IconView.
Test: manual. Verified haptics play when MSDL flag is on.
Test: manual. Verified haptics played from the history of the
  MSDLWrapper via adb dumpsys
Flag: com.android.launcher3.msdl_feedback
Bug: 376283547
Change-Id: I66c9c712141a7b618cc8b4ca995e1475e21b377b
2024-12-10 15:59:24 -08:00
Juan Sebastian Martinez ce427bfe16 Adding MSDL Feedback when swiping up to reveal overview.
Test: AbsSwipeUpHandlerTestCase
Flag: com.android.launcher3.msdl_feedback
Bug: 376282841

Change-Id: I90a76ea72f87066b9f9d33dda055f99d25249e77
2024-12-10 15:57:07 -08:00
Treehugger Robot 11537828ad Merge "Fising some tests bugs, assuming primary user is user 0" into main 2024-12-10 23:50:28 +00:00
Treehugger Robot 4d8f0d5a8f Merge "Add Aster logging for entering and exiting desktop mode via quick switch" into main 2024-12-10 23:31:50 +00:00
mpodolian 3e419ebbf1 Remove usage of the enableBubbleBarInPersistentTaskBar flag.
Remove and merge the usage of the enableBubbleBarInPersistentTaskBar
flag to the enableBubbleBar flag.

Bug: 383181643
Flag: com.android.wm.shell.enable_bubble_bar
Test: NONE - removed and merged flag usage.
Change-Id: I4f131e1ddf8367425b91c8fb597857ee222b75d8
2024-12-10 15:10:49 -08:00
Treehugger Robot cedfde549e Merge "Update QuickstepTestInformationHandler.getWindowInsets to support recents window" into main 2024-12-10 23:02:27 +00:00
Jeremy Sim 41cdb7ffee Merge "App Groups: Allow app pairs to take more than 2 members" into main 2024-12-10 22:37:31 +00:00
Schneider Victor-Tulias 35c7dae0ef Update LauncherSwipeUpHandlerV2Test setup to account for RecentsWindowFactory
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 383375436
Test: LauncherSwipeHandlerV2Test
Change-Id: Ifd8f10f55a6c1e43ce7e5e410f77d47d845b216d
2024-12-10 16:18:07 -05:00
Schneider Victor-Tulias 76e1676c7f Update TaplTestsQuickstep to expect recents window states when enabled
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 382527932
Test: TaplTestsQuickstep
Change-Id: I14f66628105fab5d8c39ae7f9fd9ebfa61a268b7
2024-12-10 16:17:57 -05:00
Schneider Victor-Tulias 37deb21bd4 Update QuickstepTestInformationHandler.getWindowInsets to support recents window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 382252723
Fixes: 378158368
Test: TaplDragTest
Change-Id: I272a9e50f2209d3b7959bb9abc834546c9b845e8
2024-12-10 16:17:48 -05:00
Sunny Goyal 89551b71be Fising some tests bugs, assuming primary user is user 0
Bug: 383091872
Bug: 383183795
Bug: 383088668
Test: Presubmit
Flag: EXEMPT test fix
Change-Id: I551f13fc3d51bf1c2718f0582f8ee76d51067896
2024-12-10 12:09:33 -08:00
Uwais Ashraf 1f09cd720d Don't use flow for one-off get of ThumbnailData
Bug: 381317629
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TasksRepositoryTest
Test: Performance tests
Change-Id: I1990ad1972beea8c81b44cdd50c7f674f225c69d
2024-12-10 17:28:55 +00:00
Vania Desmonda 7fd479c454 Add Aster logging for entering and exiting desktop mode via quick switch
Fixes: 360874817
Fixes: 381214742
Flag: com.android.window.flags.enable_desktop_windowing_quick_switch
Test: manual test
Change-Id: I7bae2aaff614a5590fa107d0c102c520b14b85d9
2024-12-10 13:35:15 +00:00
Johannes Gallmann 9899283045 Merge "Don't cancel or commit predictive back on multi touch in 3-button-nav" into main 2024-12-10 13:33:00 +00:00
Johannes Gallmann 200ee94279 Don't cancel or commit predictive back on multi touch in 3-button-nav
Bug: 381054861
Test: Manual, i.e. verify that tapping the taskbar while predictive back is in progress does not cancel or commit it
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: I4117aca74216849519a0cabcbd3cb14f7fc5b38f
2024-12-10 13:28:36 +00:00
Johannes Gallmann 09603bfb39 Play workspace reveal animation for predictive back-to-home
Bug: 382453424
Test: Manual, i.e. tested back-to-home and back-to-allapps animation on phones, tablets and foldables, including interruptions.
Flag: EXEMPT bugfix
Change-Id: Iece001b6b9edd9ca7a909e3ccbe8ebdff2e71d9f
2024-12-10 12:42:12 +00:00
Alex Chau 20ed6de98b Merge "Revert "Don't recreate taskbar in Overview"" into main 2024-12-10 10:33:30 +00:00
Treehugger Robot ea27c11334 Merge "Use ViewStub for TTV creation to prevent double inflation (TTVDeprecated then TTV)." into main 2024-12-10 10:20:46 +00:00
Uwais Ashraf ca8a53911a Use ViewStub for TTV creation to prevent double inflation (TTVDeprecated then TTV).
Bug: 381317629
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Performance tests
Test: Open single, split and desktop tasks with flag combinations for TTV refactor and app chip.
Change-Id: Ie43955ddf6c9fac162974077a37e8448c5ef1781
2024-12-10 08:19:22 +00:00
Brian Isganitis 9c0552e09d Merge changes from topic "taskbar-view-recents-changes" into main
* changes:
  Move recents divider if hotseat is set after recents.
  Animate out/in the correct task view when recents change.
  Implement initial LayoutTransition for Taskbar recents.
2024-12-10 02:18:53 +00:00
Treehugger Robot 74cc80d239 Merge "Introduce a function getFristTaskView()" into main 2024-12-10 01:51:26 +00:00
Treehugger Robot 278ab17033 Merge "Fixing missing userId in various shell commands" into main 2024-12-10 00:50:10 +00:00
Jeremy Sim 0c3b2e9540 App Groups: Allow app pairs to take more than 2 members
Changes saveAppPair to take a general number of apps, rather than just 2. At the moment, this will not change anything, since GroupedTaskViews are still hard coded to contain 2 apps.

Bug: 349828130
Flag: com.android.wm.shell.enable_flexible_split
Test: No effect on behavior, just a small refactor.
Change-Id: I6f86210ab4662f0d3a8fba1f6bb6fd78391e7fa2
2024-12-09 16:41:24 -08:00
Treehugger Robot 9bb546953c Merge "Adapt TaskbarOverflow tests to check items added overflow view" into main 2024-12-10 00:21:18 +00:00
minch 0933ba83d8 Introduce a function getFristTaskView()
- Introduce a function `getFirstTaskView()` in RecentsView to get the
  first TaskView inside RecentsView.
- Replace `getTaskViewAt(0)` with this newly introduced function.
- Let `RecentsView.isTaskInExpectedScrollPosition()` accept a TaskView
  instead of index of the TaskView. This can avoid using the index at
  the callsites of this function.
- Change `getTaskViews()` to be a public function, thus it can be
  used outside of the RecentsView.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Ensure the TaskViews required are correct in the following
      scrnarios:
      1. Swiping up from home screen to enter overview with empty or
         multiple tasks
      2. Swiping up from a fullscreen app to enter overview with
         one or multiple tasks
      3. Dimissing one or multiple tasks, exit and re-enter overview
         w/o newly opened tasks
      4. Remvoing all the tasks, re-enter overview w/o newly opened
         tasks
Change-Id: If63ad6dc9f5106be08d867090fdaf616117dcd82
2024-12-09 22:43:14 +00:00
Randy Pfohl 6cbf910d9a Merge "initial commit for multicontext management for recent windows" into main 2024-12-09 22:27:52 +00:00
Brian Isganitis c7f6cd6062 Move recents divider if hotseat is set after recents.
Fixes a bug where updateItems is first called with recents and then with hotseat. This causes the Taskbar to first be All Apps, Divider, and then Recents. The layout transition path assumes though that the Divider after All Apps is not for recents in this case, which is wrong. Due to this assumption, it skips over the divider and then adds the hotseat items after it (should be added before). Added a test for this case.

Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: Ia690c71fe482709e35ab302a7b497bf547eb4478
2024-12-09 15:35:43 -05:00
Brian Isganitis 3c24c421f6 Animate out/in the correct task view when recents change.
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I6c7708ed9f03eff8469b5f2e75ce00e545b03f54
2024-12-09 15:35:43 -05:00
Brian Isganitis 8e2b850df7 Implement initial LayoutTransition for Taskbar recents.
The animations mostly match the spec, though the recents indicators scale/fade with icon currently.

The change transitions need to incorporate translateX since that changes based on the number of icons in Taskbar. We need the translateX for pinning update to happen before TaskbarView lays out its children so that the animator computes the correct start and end values.

Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I13aa49abf80ddc09fab890f78bde924a8f7f1d6e
2024-12-09 15:35:43 -05:00
Alex Chau e8aa9a383c Revert "Don't recreate taskbar in Overview"
This reverts commit 7a14d1b7b9.

Reason for revert: b/383084557
Bug: 343882478

Change-Id: Ia9b13964df7d85cfee441f4163f41e198c283021
2024-12-09 19:05:39 +00:00
Sunny Goyal 3dfaba2d8c Fixing missing userId in various shell commands
Bug: 380276168
Test: atest TaplMemoryTests
Flag: EXEMPT testfix
Change-Id: I87026eaf6340a2a43cbc899d262879259e339fc5
2024-12-09 10:36:06 -08:00
Treehugger Robot cea1888874 Merge "Update SystemUiProxy to support RemoteTransition when moving a task to desktop" into main 2024-12-09 12:50:20 +00:00
Treehugger Robot c531c9fb90 Merge "Minor kotlin cleanup" into main 2024-12-06 23:49:12 +00:00
Treehugger Robot bd203f948d Merge "Fix icon flicker from home-> overview when 3 button navigation is enabled in 3P launcher." into main 2024-12-06 19:52:26 +00:00
Toni Barzic 7bea1821d4 Adapt TaskbarOverflow tests to check items added overflow view
Adds a step to verify that TaskbarOverflowView items get set to the list
of the least recent tasks. Adds test cases for an edge case where
taskbar hits max number of items event without recent tasks
(b/379774843).
Has a fix for a further edge case where taskbar overflow view could be
created with a single item (in which case we can just show that item
directly).

Bug: 379774843
Flag: com.android.launcher3.taskbar_overflow
Test: atest TaskbarOverflowTest

Change-Id: I004676da3e17f26b8110d14d39589c84a9f384d8
2024-12-06 19:39:47 +00:00
Treehugger Robot 07bf3c3085 Merge "Restore fallback Overview state when restarted by theme changes" into main 2024-12-06 19:35:07 +00:00
randypfohl 81962e6fac initial commit for multicontext management for recent windows
Test: Built and ran locally

Flag: com.android.launcher3.enable_fallback_overview_in_window

Bug: 379746094

Change-Id: Ic48b4ef2471a3d6d5eb2e9bacdf00e7d71a87778
2024-12-06 11:17:01 -08:00
Jordan Silva 8ec11ab65f Update SystemUiProxy to support RemoteTransition when moving a task to desktop
This CL updates the methods and APIs to match the updated API from DesktopTasksController in WM Shell.
We've introduced RemoteTransition to be used for animating a task when it's moved into a desktop task.

Bug: 333524374
Fix: 379620787
Flag: com.android.window.flags.enable_desktop_windowing_mode
Test: TaplTestsOverviewDesktop
Test: OverviewDesktopTaskImageTest
Change-Id: I63cd094b3956ebe8fe7acda7da30ca73e1098ea0
2024-12-06 19:08:46 +00:00