- On display change, we don't seem to re-arrange workspace widgets
whose current span size may no longer be a valid
- In some cases, the existing span showing on workspace is less than
the widget's min size and user is unable to resize to the correct size.
- Ideally irrespective of problem they should be able to resize to
correct size.
This cl lets user resize to valid size. In another bug we might want to
evaluate refreshing / updating widgets on display change.
Bug: 408974387
Test: See demo
Flag: EXEMPT BUGFIX
Change-Id: I9712a20739ec8ee1de9d85f22814c7f1b3474e47
This will allow the use of Flows in BgDataModel
Flag: EXEMPT refactor
Bug: 390572144
Test: Presubmit
Change-Id: I8fdd1635a19ae4d75260fb1ddb9cd7ab00cd0496
Currently there is a bit of inconsistency in the way grid change
happens.
1. Grid migration decides different size, inflate item uses
different, and scale is applied using yet another size.
2. also when
going from small -> medium we reload data, but if while wallpaper picker
is open, if we revert to small, it leads to a wrong state due to
inconsistencies in #1 and shows cropped widget content. Instead in this
cl, we always reload on grid update, so widgets are shown for correct
size. There is still possibility of issue if the widget didn't respond
with data - but even in public build today there are tons of issues with
widgets on changing grid.
Bug: 408934352
Flag: EXEMPT BUGFIX
Test: See demo.
Change-Id: I91741d762cbf34ab7f9e0269ea307d2aad9e0eda
I was being cautios on my previous fix for this same
isse, cautios because I'm modifying an object by reference
That's why I was only updating the container when the icon being
dropped was PendingAddShortcutInfo but we can change the container
on every icon (we don't need to in the Widget case which is the
other if statement), we can be sure it is a safe operation because
we later update the info anyway rendering the previous info invalid.
Fix: 413784315
Test: WIP
Flag: EXEMPT bug fix
Change-Id: I60ecdb52be1c7bf0584cb1c74ee15b85961e5012
- Also clean up some of the draw code
Bug: 377938340
Test: installing apps to finish
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: If5e825a4bc54c62e183be980e12a0c6ee14e4dff
animateToPosition now only occurs if the user performs a fling.
Bug: 394355070
Test: Verified this works locally. Please see the bug for a screen recording of the working behavior.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: Ic57495e3aec00d903ed948b887723b1389337c8d
Bug: 394355070
Test: Verified locally that indicator dots are not cut off with 6 pages. See screen recording on https://buganizer.corp.google.com/issues/394355070#comment28
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I5b0ac0441201e8dafcba10ff52ac24e1821815b9
Test: Use dumpsys to check if SurfaceControlViewHost still exists
Bug: 410052692
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: Ibbb29445422dd37e764be2f518c9d528340cdfaa
1) Moving any DB file deletion before opening the DB to avoid deleting already opened file
2) Using a sandbox directory for BackupAndRestoreDBSelectionTest which can delete actively opened files causing other tests to fail
Bug: 403551539
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: Ib1088a0e486edf755e5f7dcd738eb835af78b4c4
This brings the BgCallbacks closer to a repository pattern making is easier to switch eventually
Bug: 390572144
Flag: EXEMPT refactor
Test: Updated AsyncBindingTest to use real ModelCalbacks
Change-Id: I9c932b00ea8ac7330473b9c0f5d778453fe7a390
Instead of the dispatcher specifying the type, the UI checks th diff. This
ensures that the UI is updated correctly in all paths
Bug: 390572144
Flag: EXEMPT refactor
Test: Manually verified folder edit path where these callbacks were getting dispatched
Change-Id: Ib73eed5da87a847753a78453a48ab4fc495c1199
The LauncherModel#addCallbacks() and #removeCallbacks() apis are thread safe due to synchronized(mCallbacksList). So there is no need to enforce main thread.
This CL will unblock taskbar per-window ui thread work.
Bug: 404636836
Test: presubmit
Flag: NONE - released code
Change-Id: Iccc3f6da12625305f8db7111226df6e923c1891e
Sorry for the whack-a-mole here. The intention is to only blur
going to All Apps or returning from All Apps to Normal. Added some
tests to help prevent regressions.
Test: DepthControllerTest#test_blurWorkspaceDepthTargets
Flag: com.android.launcher3.all_apps_blur
Bug: NA (noticed locally from a recent cl)
Change-Id: Ib0285dae42c41ba9eb2e747b272d40c228e0b035
- Removed enableDesktopWindowingCarouselDetach flag
- detachDesktopCarousel is now always false, except in home quick switch (QuickSwitchState)
- Updated home quick switch controller NoButtonQuickSwitchTouchController to apply DESKTOP_CAROUSEL_DETACH_PROGRESS
Fix: 411127271
Test: manual
Flag: EXEMPT flag cleanup and refactor
Change-Id: I1cbf0987b111d0111cb8b9b6c7994f4494780e1a
Shamali Patwa
Sunny Goyal
Sebastián Franco
Treehugger Robot
Pat Manning
Andy Wickham
Charlie Anderson
George Lin
Anushree Ganjam
Stefan Andonian
Fengjiang Li
Alex Chau