This commit is part of a large scale change to fix errorprone
errors that have been downgraded to warnings in the android
source tree, so that they can be promoted to errors again.
The full list of changes include the following, but not all
will be present in any one individual commit:
BadAnnotationImplementation
BadShiftAmount
BanJNDI
BoxedPrimitiveEquality
ComparableType
ComplexBooleanConstant
CollectionToArraySafeParameter
ConditionalExpressionNumericPromotion
DangerousLiteralNull
DoubleBraceInitialization
DurationFrom
DurationTemporalUnit
EmptyTopLevelDeclaration
EqualsNull
EqualsReference
FormatString
FromTemporalAccessor
GetClassOnAnnotation
GetClassOnClass
HashtableContains
IdentityBinaryExpression
IdentityHashMapBoxing
InstantTemporalUnit
InvalidTimeZoneID
InvalidZoneId
IsInstanceIncompatibleType
JUnitParameterMethodNotFound
LockOnBoxedPrimitive
MathRoundIntLong
MislabeledAndroidString
MisusedDayOfYear
MissingSuperCall
MisusedWeekYear
ModifyingCollectionWithItself
NoCanIgnoreReturnValueOnClasses
NonRuntimeAnnotation
NullableOnContainingClass
NullTernary
OverridesJavaxInjectableMethod
ParcelableCreator
PeriodFrom
PreconditionsInvalidPlaceholder
ProtoBuilderReturnValueIgnored
ProtoFieldNullComparison
RandomModInteger
RectIntersectReturnValueIgnored
ReturnValueIgnored
SelfAssignment
SelfComparison
SelfEquals
SizeGreaterThanOrEqualsZero
StringBuilderInitWithChar
TreeToString
TryFailThrowable
UnnecessaryCheckNotNull
UnusedCollectionModifiedInPlace
XorPower
See https://errorprone.info/bugpatterns for more
information on the checks.
Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: If17d2944bfd3e7ab10592a4c74c956203c356f81
Since we enable generate_traces by default for the system and
signature apps, we can remove this special case
Test: Manual
Bug: 161393989
Change-Id: Iff92c0a729a9b9b038fb6310c7509925c59547b6
Merged-In: Iff92c0a729a9b9b038fb6310c7509925c59547b6
This removes some dependency on FloatingHeaderView, making it
easier to replace
Bug: 234008165
Test: Verified that the UI does not change
Change-Id: I363c98c23f84fe570ea9cb1a40128359f5b67c9f
Merged-In: I363c98c23f84fe570ea9cb1a40128359f5b67c9f
(cherry picked from commit 42b640404a)
Merged-In: I363c98c23f84fe570ea9cb1a40128359f5b67c9f
WM was changed to use NAV_BAR_KIDS_MODE instead of NAV_BAR_FORCE_VISIBLE, this needs to update to match.
Fix: 229580780
Test: manual.
Change-Id: I38fb23dcc85676593a3f8f0851676bc526802d2e
(cherry picked from commit c773d7cdc8)
The launcher was not properly preloading upon launching the All Set Activity. The Launcher would only start loading once the user started swiping up. This would stop the all set activity from drawing.
Test: Factory reset with a restore and tested the all set page.
Fixes: 234536107
Change-Id: I6bcb805ea6c43fb993f2b57499444ea62bcc37e1
Fixes: 234022857
Test: Open ImCapture and swipe up to home; repeat 20 times and ensure never see empty overview tasks over launcher
Change-Id: Icef6d7a54000e1e21453feeae7e207679077b772
- If the user has scrolled the running task offscreen, then
snap back to the task if back is invoked.
Bug: 233952141
Test: Swipe to overview, scroll away from the current task
and then go back
Change-Id: Icc5040d4b38c97e0329f937e24bd517a71a32f13
Bug: 235273016
Test: Start up several apps and take a heap dump and verify the buffers
have been preemptively closed prior to the next GC
Change-Id: If7e46e668efa101d4257dd174f31e5e366a02c9d
When launching a pair of apps from overview panel, it will perform
cross-fade animations to transit from overview to the split pair. But
wallpaper might be visible for a while when both overveiw and split pair
is transparent during the transition. This updates to not fade-out
overview until the split pair is finishing showing in foregorund to
prevent the flicker of wallpaper.
Bug: 235137249
Test: swipe to home and enter overview panel, select and swipe down to
enter a split pair, verified there's no flicker.
Change-Id: Iec1dc49e260f6e46640d47295d7f65dad5c24ab5
- This was added for Go when they had their own recents implementation
and isn't necessary for the default implementation
Bug: 229668039
Test: Follow steps using test apk from the bug
Change-Id: I0c36f98683e1bf9a3dc11cde2d1113ed1c4d6448
Context: there was a bug where you could get stuck in HintState if you
did the following (timing is critical):
1. Short swipe from nav region towards HintState, but not far enough or
fast enough to commit before letting go; this cancels the state
animation, returning towards Normal (but, crucially, StateManager
still has state set as Hint)
2. While previous animation is animating back to Normal, swipe up again,
but this time faster/farther to actually reach Hint; this time, the
animation does go towards Hint, but gets stuck there. The reason it
gets stuck is because StateManager thinks we're already in Hint from
step 1, so doesn't call onStateTransitionEnd(Hint) in step 2. Thus,
we never get QuickstepLauncher#onStateSetEnd(Hint), which is what we
rely on to return to Normal.
The simple fix is to prevent the second swipe in the first place.
Test: short swipe followed immediately by fast fling from nav region on home successfully stays in Normal state intead of getting stuck in HintState
Test:
NexusLauncherOutOfProcTests: com.google.android.apps.nexuslauncher.TaplTestsNexus
Fixes: 228276181
Change-Id: I54c371c8518a9a220e75c98003331b552d8bf8af
Treehugger Robot
Cole Faust
Zim
Xin Li
Bill Yi
Sunny Goyal
Pat Manning
Alex Chau
Schneider Victor-tulias
Tony Wickham
Winson Chung
Jerry Chang
Becky Qiu
Jon Miranda
Anushree Ganjam
Luca Zuccarini