Commit Graph

3817 Commits

Author SHA1 Message Date
Samuel Fufa a529cd0f5f Merge "Allow Users to migrate their hotseat when returning from AiAi" into ub-launcher3-rvc-dev 2020-06-19 00:51:18 +00:00
Samuel Fufa d25a112b0e Allow Users to migrate their hotseat when returning from AiAi
- If a user has mostly predicted hotseat, show a snack bar. otherwise, show migration option.
- Guard onboarding activity with permission `com.google.android.apps.nexuslauncher.permission.HOTSEAT_EDU`

Bug: 158569583
Test: Manual
Change-Id: Id0c1c812233fcf288a2f49848720199dedd2015d
2020-06-18 16:38:58 -07:00
TreeHugger Robot c471a9a6bb Merge "Show a snackbar on predicted icon longpress" into ub-launcher3-rvc-dev 2020-06-18 23:34:58 +00:00
thiruram ffb55ddece Deprecates LAUNCHER_ALL_APPS_RANKED event.
LauncherUiChanged.rank field is repurposed to store all apps rank.

Change-Id: Iabad98312589d8f53b6547433540f3ec9dff0b3f
2020-06-18 15:08:16 -07:00
TreeHugger Robot 8e9405d7cd Merge "Fix bug where All Apps Edu gets closed via user input before animation ends." into ub-launcher3-rvc-dev 2020-06-18 21:20:36 +00:00
TreeHugger Robot d4de6d4bba Merge "Avoid hotseat edu button overlapping" into ub-launcher3-rvc-dev 2020-06-18 21:06:44 +00:00
TreeHugger Robot 3b80398889 Merge "Add flag Intent.FLAG_ACTIVITY_NEW_TASK when launching suggestion settings" into ub-launcher3-rvc-dev 2020-06-18 20:48:52 +00:00
Jon Miranda 1bbd2831f3 Fix bug where All Apps Edu gets closed via user input before animation ends.
Also fixes bug where user continuously swipes to hint view causes count
to increase more than the max count which prevents all apps edu from showing.

Bug: 151768994
Change-Id: I3186398d441e723a2cfb6e396b03944502a65cf5
2020-06-18 13:40:33 -07:00
Samuel Fufa 9058e305e5 Avoid hotseat edu button overlapping
Screenshot: https://screenshot.googleplex.com/cCNn6hdrqu1
Bug: 158194467
Change-Id: I465ab73be2079f20994b3f2bbe57f64e46d05777
2020-06-18 13:32:17 -07:00
Samuel Fufa c376a1de2c Add flag Intent.FLAG_ACTIVITY_NEW_TASK when launching suggestion settings
Bug: 158604370
Test: Manual
Change-Id: I01e313d29cbc9b7ea2413547d9a7b4940d126ce8
2020-06-18 13:13:45 -07:00
Samuel Fufa 44c1b5e03d Show a snackbar on predicted icon longpress
The first time a user long presses a predicted icon, suppress drag/drop and show a snackbar about app predictions.

Bug: 159170242
Test: Manual
Change-Id: I5f853a9774b38ad9fad22ff55feff417a801f52c
2020-06-18 10:57:32 -07:00
TreeHugger Robot fcc4a2d83f Merge "Avoid Crash when longpressing disabled predicted item" into ub-launcher3-rvc-dev 2020-06-18 17:45:57 +00:00
Jonathan Miranda 42dd4f4afd Merge "Use screenSpaceBounds to position the target window for recents mw animation." into ub-launcher3-rvc-dev 2020-06-18 17:03:18 +00:00
Hyunyoung Song 714659f6d0 Add LAUNCHER_WORKSPACE_SNAPSHOT event_id
Bug: 159210161
Change-Id: Ie8e843ee10bf4ab0761232a3e61eb28e487666ab
2020-06-17 22:39:36 -07:00
TreeHugger Robot adb6352bac Merge "Don't rely on nav mode change listener for oriented state" into ub-launcher3-rvc-dev 2020-06-18 04:44:31 +00:00
TreeHugger Robot 9c126682d7 Merge "Snapshot logging only use cloned model thread folder contents Bug: 158826147" into ub-launcher3-rvc-dev 2020-06-18 04:34:56 +00:00
Hyunyoung Song 398c42fe6b Snapshot logging only use cloned model thread folder contents
Bug: 158826147

Change-Id: I9aea9fbc706b0dffa3f6abeaac663b072d62ad58
2020-06-17 20:59:45 -07:00
TreeHugger Robot 27ed32ac7e Merge "Updated recents oriented state on split screen" into ub-launcher3-rvc-dev 2020-06-18 02:35:16 +00:00
Jon Miranda 2a8093e5fd Use screenSpaceBounds to position the target window for recents mw animation.
Verified window is moving as expected using winscope.

Note: Position is off when launching non-center task.

Bug: 159171509
Change-Id: Ib11ed7df9a877348d76543279203f9bfc25f7829
2020-06-17 17:55:26 -07:00
Andy Wickham 4a85948843 Merge "Removes Sandbox from launcher task." into ub-launcher3-rvc-dev 2020-06-17 22:56:44 +00:00
TreeHugger Robot c0c0991231 Merge "Disabling OverviewActions when rotated." into ub-launcher3-rvc-dev 2020-06-17 20:40:56 +00:00
TreeHugger Robot d6e3775726 Merge "Fixing broken tests on 2 and 3 button devices." into ub-launcher3-rvc-dev 2020-06-17 20:38:25 +00:00
Sreyas f91c1d0ef1 Disabling OverviewActions when rotated.
Bug: 157272300
Bug: 159135247
Change-Id: I9c9eeb49b7d18c1c81a830b7a35113070e7ac793
2020-06-17 12:37:14 -07:00
TreeHugger Robot 1f325ab01e Merge "Don't reset RecentsView in onIdpChanged()" into ub-launcher3-rvc-dev 2020-06-17 18:15:39 +00:00
TreeHugger Robot 349194569f Merge "Replaces StatsLogManager.log with StatsLogManager.logger()" into ub-launcher3-rvc-dev 2020-06-17 18:11:32 +00:00
Becky Qiu ff6bc2ab5f [Overview Actions] For in-place landscape, add select only when aiai works.
When display orientation is not the same as device orientation, aiai won't work for select mode highlight. So we should only show the select button in task menu for in-place landscape when the display rotation is the same as the device rotation which is portrait.

Screenshot would be in the task menu for in-place landscape all the time.

Test: demo video: https://drive.google.com/file/d/1OQrjww2lFTTsthz4dB3BSa-jw943KLWp/view?usp=sharing
Change-Id: I58b6f6da234ea36eef0af5bb966c33ebda3625b8
2020-06-17 17:39:56 +00:00
thiruram c6a38ba5d8 Replaces StatsLogManager.log with StatsLogManager.logger()
Bug: 159170445
Change-Id: Ice6c8a9ae30d8e6b3843bfe42926053849bf9fe0
2020-06-17 17:32:54 +00:00
TreeHugger Robot 4de12a2424 Merge "Fixing OAV buttons not working and removing logs." into ub-launcher3-rvc-dev 2020-06-17 17:26:14 +00:00
vadimt d8e5660b13 Fixing broken tests on 2 and 3 button devices.
Bug: 143488140
Change-Id: I30886da129825b800984baa08742ac4dfcf4a599
2020-06-17 10:19:51 -07:00
thiruram d8405a63d2 Replace StatsLogManager with builder pattern.
Follow up CLs will remove the deprecating log methods and update their references.

Bug: 159170445
Change-Id: I5dfd30209eeba561df1b528a6305ca5923ba42a2
2020-06-17 08:46:43 -07:00
Vinit Nayak 8401308c14 Don't rely on nav mode change listener for oriented state
When nav mode state changes, launcher gets
re-instantiated, which means the listener for
nav mode changes often gets destroyed before it
even gets fired. Rely on the initial setup to
set the correct nav mode.

The other bug with relying
on the initial value was that we were initially
getting the old nav mode when initFlags was called
from the ctor, but then the correct updated nav
mode when called from initListeners(). The first
call would enable rotation but then the second
call wasn't disabling it. Now we toggled based on
nav mode each time.

Another bug fix in RecentsView was not calling
update when launcher rotation is enabled. That was
added when previously we were using HOME_ROTATED
and PORTRAIT as different PagedViewHandlers to
differentiate when launcher rotation was enabled.
HOME_ROTATED is now removed, so we no longer need
to change the internal state of RecentsOrientedState.

Fixes: 159176222
Change-Id: I2a37880ce3cf835ca5b9b165ce3840537facee6c
2020-06-16 19:41:16 -07:00
Samuel Fufa e8c0f83fb2 Avoid Crash when longpressing disabled predicted item
If a view does not handle its long press and return true, View.java calls getParent().showContextMenuForChild(this). However, in Hybrid hotseat case, predicted icons are removed from the hotseat when user long presses an icon. This will result in getParent() returning null.

Bug: 159064799
Change-Id: I80d8f27cbc20b94b0381e767584a1f6854d17e2c
2020-06-16 16:28:37 -07:00
TreeHugger Robot cbe1251ce7 Merge "[Overview Actions] Disable swiping on modal recentsView for talkback." into ub-launcher3-rvc-dev 2020-06-16 23:23:12 +00:00
TreeHugger Robot ded59ac331 Merge "Increase Predicted app icon sing size" into ub-launcher3-rvc-dev 2020-06-16 23:18:45 +00:00
Becky Qiu 8798440600 [Overview Actions] Disable swiping on modal recentsView for talkback.
When it is select mode, disabling swiping on the parent container for a11y to avoid exiting select mode UI.
This will only disable swiping and talkback on other tasks and the cleanall button, but will keep the modal task container app info and content description, also keep the action buttons description working.

Test: local
Bug: 155947513
Change-Id: I6d513c7eb3e7deeaa233550749f8be0d95e56daf
2020-06-16 15:47:20 -07:00
Tony Wickham f2b8c927a9 Merge "Fix qsb when flinging to home during gesture to overview from home" into ub-launcher3-rvc-dev 2020-06-16 22:12:28 +00:00
TreeHugger Robot 89e39a6dfa Merge "Create hotseat predictor onCreate" into ub-launcher3-rvc-dev 2020-06-16 22:11:56 +00:00
Samuel Fufa eb957403a8 Increase Predicted app icon sing size
Bug: 159041772
Change-Id: I0b71c6a2b2da9e4b058554e60cf0c59d242368c6
2020-06-16 14:34:36 -07:00
Samuel Fufa 345f728f2c Create hotseat predictor onCreate
ModelTask posted in setupViews does not get called.
Bug: 159151258

Change-Id: I45bfe7cf8ea18b09faaf3c0e612be90722e1e410
2020-06-16 14:22:02 -07:00
TreeHugger Robot 9354de6c91 Merge "Attempt to workaround a leak on Taimen" into ub-launcher3-rvc-dev 2020-06-16 20:58:39 +00:00
vadimt 6a3de331af Attempt to workaround a leak on Taimen
It's a flake.
It was likely caused by enabling fallback tests, and we don't know
what's leaked and why.

Bug: 143488140
Change-Id: I0d0c88ac9b0de316861f16ba023a596c1f39cde4
2020-06-16 20:21:49 +00:00
Sreyas 826bb2e932 Fixing OAV buttons not working and removing logs.
Bug: 154838868
Change-Id: Icde83dc527a1aacf6a8a79325e6a33c5235a64fb
2020-06-16 12:20:25 -07:00
TreeHugger Robot cf4e6cd055 Merge "Fixing sysui scrim not updating in landscape UI" into ub-launcher3-rvc-dev 2020-06-16 19:00:24 +00:00
Vinit Nayak 746b82e831 Updated recents oriented state on split screen
Launcher defaults to sensor rotation when in split
screen instead of the fixed portrait orientation.
We were setting the multi window flag but never
updating RecentsOrientedState's internal state to
reflect it.

Fixes: 158537350
Change-Id: Ib0e1cf4c2e0674a5af41ac11c532a50db0a6f0fa
2020-06-16 11:57:47 -07:00
TreeHugger Robot a36605ee90 Merge "Preventing parallel motion event dispatching from view system and event proxy" into ub-launcher3-rvc-dev 2020-06-16 18:20:51 +00:00
Samuel Fufa dc122e816a Merge "[WW logging] Log rankings for app launches" into ub-launcher3-rvc-dev 2020-06-16 04:41:54 +00:00
Tony Wickham 80846543b5 Fix qsb when flinging to home during gesture to overview from home
- AllAppsTransitionController should not animate alphas for atomic
  components even when failing fast (we already had this check for
  the normal flow where mProgress != targetProgress).
- Don't set state to NORMAL until both the workspace stagger anim
  and overview peek anim are finished

Test: swipe up and hold from the nav bar on the home screen, then,
without lifting finger, fling upwards to return home; ensure qsb
springs in staggered formation with rest of workspace, and alpha
matches accordingly

Bug: 154637581
Change-Id: Iafeaeac50ee8bce05492628d443c3ca4ab3d26df
2020-06-15 19:27:45 -05:00
Samuel Fufa e9c4f401bd [WW logging] Log rankings for app launches
Bug: 158219113
Change-Id: Ib6db4e73e48ff27ca9d3a5348eea42e1f534dba1
2020-06-15 17:17:47 -07:00
TreeHugger Robot eb9f60adab Merge "Add null check before applying fullscreen params" into ub-launcher3-rvc-dev 2020-06-15 22:37:26 +00:00
Pinyao Ting 817054d000 fix a11y issue where scroll next can still be triggered on final page in
RecentsView

Bug: 151450844
Test: manual verification with following steps
1. launch a few apps
2. swipe up from bottom to bring up RecentsView
3. enable talkback
4. perform a scroll next a11y gesture (without lifting finger, swipe
right then left)
5. verify nothing happens (as opposed to pushing the page back a little)

Change-Id: I6dea2559592bdaa7227a2e12ce0565d6d7b7f4a1
2020-06-15 14:51:04 -07:00