Commit Graph

11086 Commits

Author SHA1 Message Date
TreeHugger Robot 3b908345d3 Merge "Add CUJ_RECENTS_SCROLLING" into tm-qpr-dev am: 26e7dc1789
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20224650

Change-Id: Ife5fb1ef7445177398bc3daf2e7a6f68897fb1a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 16:38:27 +00:00
TreeHugger Robot 26e7dc1789 Merge "Add CUJ_RECENTS_SCROLLING" into tm-qpr-dev 2022-10-20 16:35:52 +00:00
Sunny Goyal a18e285fe7 Removing unnecessary RemoteAnimationTargetCompat
Bug: 221961069
Test: Presubmit
Change-Id: I12a4c29eaf9bd7d97d3c02074b4cc1ca452fc88a
2022-10-20 16:25:21 +00:00
Thales Lima a64a914ddf Calculate taskbar content size for edu
Using the value calculated in layout was not working because TaskbarView onLayout() was being called after TaskbarEduView onMeasure(). Now uses the same value on all orientations based on taskbar icon size.

Fixes: 252945031
Test: manual
Change-Id: Ib6914901638c82f3b3ec4c9b86f6c20e84d34d0f
2022-10-20 11:48:06 +01:00
Tony Huang 0fb921ef36 Snapshot 2 tasks when swipe up split case
Swipe up snapshot only capture the top one task, but for split
screen case it should capture two tasks otherwise the snapshot
in overview would be empty in some cases.

Fix: 247420799
Test: manual
Test: pass existing tests
Change-Id: I3acd477eaca3cb98d86e2446dbb2dbd6295c687d
2022-10-20 14:10:06 +08:00
TreeHugger Robot a826533ee2 Merge "Remove redundant createAdapter override." into tm-qpr-dev am: 8a40f0557b am: 9ae49dcbca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20240748

Change-Id: I932219ddafcfb80ae866c5b25a90ff6e78c88653
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 05:59:39 +00:00
TreeHugger Robot 9ae49dcbca Merge "Remove redundant createAdapter override." into tm-qpr-dev am: 8a40f0557b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20240748

Change-Id: I181c471339e2bf293ec19cb5c2ce25cc59b1e4fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 05:26:36 +00:00
TreeHugger Robot 8a40f0557b Merge "Remove redundant createAdapter override." into tm-qpr-dev 2022-10-20 04:57:15 +00:00
Vinit Nayak 981034687a Scale screenWidth for split proportionally for thumbnail matrix
* Instead of passing in screenWidth to be that
of entire screen when using split, scale screenWidth
to that of only the amount that the given split app
is taking.
* Created TODO(b/254378592) to consolidate different
SplitBounds classes

Fixes: 250817893
Test: Checked phone/tablet swiping quickswitching
portrait and landscape

Change-Id: I5c3b2076110e358366284b2c794fd8df8a79f034
2022-10-19 21:39:50 -07:00
Sunny Goyal 361da47493 Merge "Revert "Revert "Using Transaction directly instead of building s..."" into tm-qpr-dev am: d79f84fffe am: cc6290d81f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20215466

Change-Id: Iee38fc975ce911b3a0fa3b43a97047dd094ce956
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 01:33:32 +00:00
Sunny Goyal cc6290d81f Merge "Revert "Revert "Using Transaction directly instead of building s..."" into tm-qpr-dev am: d79f84fffe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20215466

Change-Id: Ic6c00cea6febb0e36e147a4811e73f89fbfd4a78
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 01:00:10 +00:00
Brian Isganitis 9ca7744877 Remove redundant createAdapter override.
It is the same as ActivityAllAppsContainerView#createAdapter, so it can
be cleaned up.

Test: Manual
Fix: 254545341
Change-Id: Ib23369a53c8c0a1f8f05b671526eb82a07b6f0e3
2022-10-20 00:41:59 +00:00
Sunny Goyal d79f84fffe Merge "Revert "Revert "Using Transaction directly instead of building s..."" into tm-qpr-dev 2022-10-20 00:26:13 +00:00
TreeHugger Robot 8831852781 Merge "Decouple taskbar background from overveiw scrim if taskbar is in overview" into tm-qpr-dev am: 913b5afb43 am: e260265fe2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20189272

Change-Id: I38e2678daed46f612f14470b8c9629da27604405
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 18:33:18 +00:00
Zimuzo Ezeozue c6117e0d60 Merge "Disable Launcher AIDL_TAG tracing special case" am: cf36563f87 am: 6b07d27bbf
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2253778

Change-Id: I70a65c7e3608e27c38323ff06bb316728a9b2b62
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 18:12:35 +00:00
Zimuzo Ezeozue 6b07d27bbf Merge "Disable Launcher AIDL_TAG tracing special case" am: cf36563f87
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2253778

Change-Id: I644c8c0431a1f5a71cc54ecf543bbfbeee824c6b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 17:44:56 +00:00
Sunny Goyal 5fd67c75fa Removing the dependency on LooperExecutor in ViewCapture
Bug: 254487496
Test: Verified that the frame time stays the same
Change-Id: Ib6ffc209e6df5b1293245971cc12d085549bcd1d
2022-10-19 10:27:53 -07:00
TreeHugger Robot 913b5afb43 Merge "Decouple taskbar background from overveiw scrim if taskbar is in overview" into tm-qpr-dev 2022-10-19 17:18:25 +00:00
TreeHugger Robot 1aaca4097e Merge "Implement overlay window for Taskbar EDU and All Apps." into tm-qpr-dev am: c9928a1ddf am: 08092b2cfb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20154536

Change-Id: Ifad418ad73a6bf4a98d6bdfce80d0cbbdfb90790
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 15:00:57 +00:00
Pat Manning 4b1961c76e Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev am: ded9a7485e am: 986e5dde13
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19697622

Change-Id: I388e72836de3213a06e638f8c329836c79fc3296
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 15:00:08 +00:00
Nicolo' Mazzucato 9d4b775b1d Add CUJ_RECENTS_SCROLLING
This adds Jank instrumentation every time recent tasks are scrolled.

Bug: 231130484
Bug: 228969045
Test: recorded prefetto trace while scrolling
Change-Id: I3904257ef60a4e09c91a0d5297beadad0bce8785
2022-10-19 14:25:10 +00:00
Thales Lima 994b181676 Merge "Remove KtR workaround" into tm-qpr-dev 2022-10-19 14:04:48 +00:00
TreeHugger Robot c9928a1ddf Merge "Implement overlay window for Taskbar EDU and All Apps." into tm-qpr-dev 2022-10-19 14:01:56 +00:00
Pat Manning ded9a7485e Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev 2022-10-19 13:36:56 +00:00
Alex Chau f643a9b683 Fix STATE_DEPTH stuck at 1 after setting wallpaper am: 950a10738b am: 7b815365ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19967480

Change-Id: I1751b4a746d91ad6a4206114437b483b9b14d4a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 10:50:51 +00:00
Alex Chau 7b815365ea Fix STATE_DEPTH stuck at 1 after setting wallpaper am: 950a10738b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19967480

Change-Id: I00d40ac79fd33db656ae72fe492964cc1e46f8c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 10:01:18 +00:00
Alex Chau 8dac89d235 Merge changes from topic "widget_blur" into tm-qpr-dev
* changes:
  Enable wallpaper blur for widget picker
  Fix STATE_DEPTH stuck at 1 after setting wallpaper
2022-10-19 09:37:39 +00:00
TreeHugger Robot c589595b0a Merge "Fix missing screenshots on rotate from recents view select state" into tm-qpr-dev am: a473ff6c23 am: a3bd0797e6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20196922

Change-Id: Ie42d2366d6f248d223fe8c52c425adea66cbe4b6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 07:52:39 +00:00
TreeHugger Robot a473ff6c23 Merge "Fix missing screenshots on rotate from recents view select state" into tm-qpr-dev 2022-10-19 03:48:11 +00:00
Holly Sun dbd01bf6f9 Log a-z apps count.
Test: manual
Bug: 247432075
Change-Id: I9538a75bc3cb3d1e8e9089fc5e27d5d770cafb62
2022-10-18 15:57:53 -07:00
Vinit Nayak 18378f5ea6 Merge "Prevent restoring split selection state for fallback overview" into tm-qpr-dev am: 44e788a9d3 am: 4ce144eaa7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20217203

Change-Id: Ia2729d7afc11a0e3378678079bae6f661d71b675
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-18 20:16:46 +00:00
Vinit Nayak 44e788a9d3 Merge "Prevent restoring split selection state for fallback overview" into tm-qpr-dev 2022-10-18 18:50:19 +00:00
Sunny Goyal dd11f089cc Revert "Revert "Using Transaction directly instead of building s..."
Revert^2 "Removing unused surface transaction wrappers"

2460910c8c454bc2d3c9ae35bd32eeb590851788

Bug: 221961069
Test: Presubmit
Change-Id: I0028c9fe0de6fde6a77de84e4858fda14cd578dd
2022-10-18 16:30:26 +00:00
Alex Chau 950a10738b Fix STATE_DEPTH stuck at 1 after setting wallpaper
- Made BaseDepthController.setDepth/mDepth private, all get/set should be done through STATE_DEPTH or WIDGET_DEPTH
- Generified ClampedDepthProperty into Utilities.ClampedProperty to apply on STATE_DEPTH

Bug: 240580498
Test: Go to walppaper&style, set new wallpaper, then go to widget picker, wallpaper depth should transition smoothly
Change-Id: I53cdedf970fd7ffba6a952c4edf4b34251b01f07
2022-10-18 17:07:17 +01:00
Thales Lima e9d4044483 Remove KtR workaround
Bug: 229947409
Test: m -j128 Launcher3QuickStep Launcher3QuickStepGo Launcher3 Launcher3Go NexusLauncherRelease NexusLauncherDebug SearchLauncherQuickStep SearchLauncher LauncherGoGoogle
Change-Id: I5792cc6b30dfa856747a1576ef3cb195952c25c7
(cherry picked from commit 51e164688e)
Merged-In: I5792cc6b30dfa856747a1576ef3cb195952c25c7
2022-10-18 13:06:23 +00:00
Vinit Nayak 392f8878cd Prevent restoring split selection state for fallback overview
* Add flag to explicitly not restore
OVERVIEW_SPLIT_SELECT
* FallbackRecentsView then resets state in
RecentsView if our endState is ever not split selection

Fixes: 253178217
Test: Used launcher developer option to
force use separate recents activity. Tested w/
3 button nav + gesture.

Change-Id: I26c9994bf853e9a005300a02aa143991958fc461
2022-10-17 17:52:16 -07:00
Vinit Nayak d6c5147524 Landscape 3 button nav on taskbar phone supported
* TODO: Seascape bar positioning, add tests

Change-Id: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
Merged-In: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
2022-10-17 13:59:18 -07:00
Vinit Nayak 391b79c084 Merge "Landscape 3 button nav on taskbar phone supported" 2022-10-17 20:14:36 +00:00
Schneider Victor-tulias e738336001 Fix missing screenshots on rotate from recents view select state
Rotating while in the recents view select state causes all taskview screenshots to disappear. Removing the transition to overview also fixes this, but leaves launcher in an incorrect state.

- Updated API to allow transitioning states without animation.
- Removed the animation to update the state correctly while keeping the ui working.

Fixes: 251067808
Test: rotated back and forth on large and small devices, before and after entering select mode
Change-Id: I5bf89ceb1f6b27cde9f7638f32fee3a78ad85ff6
2022-10-17 09:56:03 -07:00
Pat Manning 5889bc3729 Add launcher metrics for tracking kids nav mode change events.
Fix: 241762670
Test: wwdebug && wwlogcat
Change-Id: I24432f2cd0dddbcc5991645b60a1a8e91dc431e5
2022-10-17 14:06:38 +01:00
Cole Faust 50ec4afe25 Fix errorprone warnings that should be errors
This commit is part of a large scale change to fix errorprone
errors that have been downgraded to warnings in the android
source tree, so that they can be promoted to errors again.
The full list of changes include the following, but not all
will be present in any one individual commit:

BadAnnotationImplementation
BadShiftAmount
BanJNDI
BoxedPrimitiveEquality
ComparableType
ComplexBooleanConstant
CollectionToArraySafeParameter
ConditionalExpressionNumericPromotion
DangerousLiteralNull
DoubleBraceInitialization
DurationFrom
DurationTemporalUnit
EmptyTopLevelDeclaration
EqualsNull
EqualsReference
FormatString
FromTemporalAccessor
GetClassOnAnnotation
GetClassOnClass
HashtableContains
IdentityBinaryExpression
IdentityHashMapBoxing
InstantTemporalUnit
InvalidTimeZoneID
InvalidZoneId
IsInstanceIncompatibleType
JUnitParameterMethodNotFound
LockOnBoxedPrimitive
MathRoundIntLong
MislabeledAndroidString
MisusedDayOfYear
MissingSuperCall
MisusedWeekYear
ModifyingCollectionWithItself
NoCanIgnoreReturnValueOnClasses
NonRuntimeAnnotation
NullableOnContainingClass
NullTernary
OverridesJavaxInjectableMethod
ParcelableCreator
PeriodFrom
PreconditionsInvalidPlaceholder
ProtoBuilderReturnValueIgnored
ProtoFieldNullComparison
RandomModInteger
RectIntersectReturnValueIgnored
ReturnValueIgnored
SelfAssignment
SelfComparison
SelfEquals
SizeGreaterThanOrEqualsZero
StringBuilderInitWithChar
TreeToString
TryFailThrowable
UnnecessaryCheckNotNull
UnusedCollectionModifiedInPlace
XorPower

See https://errorprone.info/bugpatterns for more
information on the checks.

Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: If17d2944bfd3e7ab10592a4c74c956203c356f81
2022-10-16 13:35:16 -07:00
Brian Isganitis 2d6371aa34 Implement overlay window for Taskbar EDU and All Apps.
Having EDU in the same window as Taskbar causes it to be above All Apps
and other system views such as the notification tray. This change
refactors the existing All Apps window to accomodate more AFVs so that
EDU can also exist in it.

Demo: http://shortn/_Qcki3gwvf7

Test: Manual
Fix: 232177330
Change-Id: I1bef31d798041a90a0c3e033e71be63898fa5fbc
2022-10-14 22:36:14 +00:00
Sebastián Franco 8f357c149e Merge "Moving the class LayoutParams to a file outside CellLayout" into tm-qpr-dev am: 73b8ee9390 am: 5e8c248e1f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20122918

Change-Id: I51de393340bf6fa5537a145a71ec9d46d4e2beff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 21:46:41 +00:00
Sebastián Franco 73b8ee9390 Merge "Moving the class LayoutParams to a file outside CellLayout" into tm-qpr-dev 2022-10-14 20:43:34 +00:00
TreeHugger Robot 77041294ee Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev am: 6ccf536f94 am: 22b6d5112b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20164543

Change-Id: I37a6bdf3a792e1861d1e57b5f8b41fa3178a6885
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 19:49:27 +00:00
TreeHugger Robot 6ccf536f94 Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev 2022-10-14 18:42:05 +00:00
Zim 83776629df Disable Launcher AIDL_TAG tracing special case
Since we enable generate_traces by default for the system and
signature apps, we can remove this special case

Test: Manual
Bug: 161393989
Change-Id: Iff92c0a729a9b9b038fb6310c7509925c59547b6
Merged-In: Iff92c0a729a9b9b038fb6310c7509925c59547b6
2022-10-14 19:28:50 +01:00
Alex Chau 47a07bc704 Decouple taskbar background from overveiw scrim if taskbar is in overview
- Removed all forceHideBackground calls if taskbar would be in overview
- Make overview scrim transparent regardless of stash state if taskbar would be in overview

Fix: 234139692
Test: Go to overview from app with ENABLE_TASKBAR_IN_OVERVIEW on/off and taskbar stashed/unstashed
Change-Id: I29e811cb93894e6c9e7a75c0ea493719f15eeccb
2022-10-14 17:45:41 +01:00
Pat Manning 31cf44c48c Add launcher metrics for tracking kids nav mode change events.
Bug: 241762670
Test: wwdebug && wwlogcat
Change-Id: I5bf05ce1660078951896e0e331bbe74f8f2ebc5f
2022-10-14 16:24:32 +00:00
TreeHugger Robot 3b13487a07 Merge "Update taskbar state when launcher pauses" into tm-qpr-dev am: a1734ad12e am: 8d7387042f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20192617

Change-Id: I2f777edae7bf0c81b3eed62ba391a8f6d863fd02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 04:27:21 +00:00