2248a0e941
Merge "Fix various animation issues when total width of grid tasks < screen width" into tm-qpr-dev am: a8c2ffc128
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21549707
Change-Id: Id3f5805bdda91219419b0a1b784dae6655d6d2bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-24 21:57:58 +00:00
346b970942
Merge "Set split button drawable to start instead of left" into tm-qpr-dev
2023-02-24 21:44:02 +00:00
a8c2ffc128
Merge "Fix various animation issues when total width of grid tasks < screen width" into tm-qpr-dev
2023-02-24 21:42:58 +00:00
3e3f308e60
Merge "Hide overview actions when desktop is focused" into tm-qpr-dev am: 8fc3a1df82 am: d12b90b711
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21568620
Change-Id: I889ec039a93b45eaac85b47f8eeb8e05cd40c876
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-24 20:24:05 +00:00
d12b90b711
Merge "Hide overview actions when desktop is focused" into tm-qpr-dev am: 8fc3a1df82
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21568620
Change-Id: If4b3739c2f1aa855a33d1f721872851a60df9382
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-24 19:46:22 +00:00
8fc3a1df82
Merge "Hide overview actions when desktop is focused" into tm-qpr-dev
2023-02-24 18:45:28 +00:00
aec9d3136f
Remove focus task
...
- Focus task is only removed under ENABLE_GRID_ONLY_OVERVIEW, but many fixes/refactoring are generic and apply with the flag off
- Keep moving running task to front if go to overvied after quick switch, so live tile is always on top right
Grid calculation:
- Fixed some top/bottom calculation assumption that assume focus task is always present
Size calculation:
- With ENABLE_GRID_ONLY_OVERVIEW, taskSize == gridTaskSize, and task is aligned to top-right of gridRect (instead of focusTaskRect)
Bug: 257952455
Test: Enter overview from home
Test: Enter overview from app, with variations that quick switch and enter
Test: Dismiss task from different position
Test: Split select task from different position
Test: Repeat with/without GRID_ONLY_OVERVIEW flag
Test: Repeat with handheld
Change-Id: I6580a8ac6c2c2059c33c4daca05b7d0354513e74
2023-02-24 18:43:30 +00:00
359ac14d13
Fix various animation issues when total width of grid tasks < screen width
...
Bug fixes:
- Unusual long scroll when only focus task left after split select
- Animation jump when tasks cannot fit screen width after dismiss or split select
To fix the above issue, generified calculations when total grid task width < screen width:
- Removed some special case handling when only focus task left (getSnapToFocusedTaskScrollDiff), and instead replace with generic logic that calculation that extra scroll position (shortTotalCompensation) needed when long row width is smaller than the grid size
- Fixed snapped task grid translation calculation to account for shortTotalCompensation
- Last task scroll calculation should account for shortTotalCompensation too
- Calculate the expected shortTotalCompensation after dismiss, and use that to adjust the close gap between clearAll distance
splitScrollOffset that we applied during split screen does not work well when shortTotalCompensation != 0. splitScrollOffset is not a good solution to handle split placeholder, as it allow tasks to scroll to weird position. I removed splitScrollOffset completely, and only apply split translation when split placeholder covers the tasks:
- Removed splitScrollOffset on TaskView/ClearAll, so scroll position of TaskView will not change while in split to splify things.
- When split placehodler will cover task's natural position (taskSize) in overview grid, apply split translation on all tasks similar to handheld
- Removed isSplitPlaceholderFirstInGrid/isSplitPlaceholderLastInGrid adjustments
Bug: 257952455
Test: Enter overview from home
Test: Enter overview from app, with variations that quick switch and enter
Test: Dismiss task from different position
Test: Split select task from different position
Test: Repeat with/without GRID_ONLY_OVERVIEW flag
Test: Repeat with handheld
Change-Id: I7689b5384845f03491041b6d910835c9ac4fab08
2023-02-24 18:42:13 +00:00
49863356e2
Set split button drawable to start instead of left
...
Fix: 269493214
Test: Check overview actions in regulard and RTL
Change-Id: Ice474294c482de8c552bda5e14efdce989fce4e7
2023-02-24 12:00:48 +00:00
560e494f29
Hide overview actions when desktop is focused
...
Use same logic for desktop as split screen is using. If focused task is
the desktop task, hide overview actions.
Bug: 269658609
Test: Enable desktop proto 2, have some apps on desktop, focus on a
fullscreen app, open overview, observe actions visible
Test: have some apps on desktop, open desktop, open overview, observe
actions are not visible
Test: open two apps in split screen, go to overview, observe no actions
visible
Change-Id: I7de28ea7af93b58379bb539c5a1b1bcbf6d13b83
2023-02-23 16:02:30 -08:00
0aa1de56cd
Merge "[Gesture Library Integration] Update the check for motion events on trackpad" into udc-dev
2023-02-23 23:15:59 +00:00
3fbaaf9628
Prevent Taskbar from stashing in immersive mode overview.
...
Test: Visual, Video in Buganizer
Bug: 262589756
Change-Id: Ifbdfb3a4104817e5f50833c42c3c6fc5964388b7
2023-02-23 14:19:10 -08:00
712fd6e1bc
Adds new motion animation for U popups am: 6259084496 am: 2010ea7b27
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21338099
Change-Id: I1516ae6ba070c2736971b333fedfb0220f3c0bdb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 22:03:19 +00:00
2010ea7b27
Adds new motion animation for U popups am: 6259084496
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21338099
Change-Id: I5709bd1af46af09f567ff2f23ab0a2165ade7683
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 21:26:04 +00:00
d248ee7507
[Gesture Library Integration] Update the check for motion events on
...
trackpad
The gesture library is ported and enabled, thus we are updating our
check for motion events on trackpad.
Bug: 254783214
Test: Swipe up and hold to go to overview; swipe up to go home
Change-Id: I4b74e88c7f8b6ef86c779391b0f8064ea828ed8f
2023-02-23 20:58:22 +00:00
93e3b7be9b
Merge "ENABLE_WIDGET_PICKER_DEPTH" into tm-qpr-dev am: 01c1dff441 am: 9fc14b94cd
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21539136
Change-Id: I283fc2baa17b5d75f1eb28bd95b39330d97bb61c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 16:43:31 +00:00
6259084496
Adds new motion animation for U popups
...
Bug: b/247880037
Test: manually on tablet
Change-Id: I8677cef39a5dc4094cad38f42b9314ac37b95fc2
2023-02-23 15:38:26 +00:00
9fc14b94cd
Merge "ENABLE_WIDGET_PICKER_DEPTH" into tm-qpr-dev am: 01c1dff441
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21539136
Change-Id: Ic134a1cd2780c2f2ff5f294f33a1f8367b3b6eb9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 15:10:37 +00:00
01c1dff441
Merge "ENABLE_WIDGET_PICKER_DEPTH" into tm-qpr-dev
2023-02-23 13:22:15 +00:00
5b1a6cc137
Merge "Removing some obsolete features" into tm-qpr-dev am: b3a95149f5 am: 51eb7b611b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21537730
Change-Id: I861e29f63df948aca8a6b7c05fa1b31b612cdc7a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 09:22:11 +00:00
51eb7b611b
Merge "Removing some obsolete features" into tm-qpr-dev am: b3a95149f5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21537730
Change-Id: Ia7fb81792677cbc3979f138dcea93a77cc44af14
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 08:47:16 +00:00
ee18c2cf6f
Merge "Expose taskbar toggled signal to Launcher" into udc-dev
2023-02-23 07:27:21 +00:00
210c689996
Merge "Use insetsRoundedCornerFrame to check if taskbar is expanded or not" into udc-dev
2023-02-23 04:37:01 +00:00
26016622c1
Merge "Refactor SplitSelectStateController to add testing" into tm-qpr-dev am: c9120521ff am: 2fea4c6f1b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21487925
Change-Id: I418fa47df9af8c94a31d3c30124c96cc78e6d758
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 00:53:05 +00:00
171bb04407
Removing some obsolete features
...
Bug: 270386012
Test: Presubmit
Change-Id: I9d68b3d17e02d6e79ab726eb7c8da1e5a4d337ef
2023-02-22 23:17:15 +00:00
2fea4c6f1b
Merge "Refactor SplitSelectStateController to add testing" into tm-qpr-dev am: c9120521ff
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21487925
Change-Id: Id91fe8d96fbcc1cdad9ef59610c934e59c441410
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 22:30:50 +00:00
c9120521ff
Merge "Refactor SplitSelectStateController to add testing" into tm-qpr-dev
2023-02-22 21:45:42 +00:00
f6ec235504
Merge "Add empty view to desktop tile in overview" into tm-qpr-dev am: 431c0c05fd am: 0a5f12dd95
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21452617
Change-Id: I1fdf09d5674c71cd20539c6d462dd76850665b56
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 20:52:20 +00:00
ce9766da2d
ENABLE_WIDGET_PICKER_DEPTH
...
Fix: 270393895
Test: manual
Change-Id: I167354425e5469663c283919f84c8bdf664cceec
2023-02-22 20:18:39 +00:00
0a5f12dd95
Merge "Add empty view to desktop tile in overview" into tm-qpr-dev am: 431c0c05fd
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21452617
Change-Id: Ifbee23ade3029a38155884f8d5f270d4acc1c3f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 20:13:59 +00:00
431c0c05fd
Merge "Add empty view to desktop tile in overview" into tm-qpr-dev
2023-02-22 19:30:55 +00:00
4e3636e8d0
Refactor SplitSelectStateController to add testing
...
Bug: 266482558
Change-Id: I2d62a3a310043710d66a26bc533df2309084b81e
2023-02-22 10:51:49 -08:00
b83d56bc27
Merge "Fix taskbar drag view scale when returning to original icon" into tm-qpr-dev am: 3d1bb16493 am: c8207a7e23
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21533764
Change-Id: I4af1a2fe1e79d2f36d275a057178efd7e750b0e1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 18:10:26 +00:00
c8207a7e23
Merge "Fix taskbar drag view scale when returning to original icon" into tm-qpr-dev am: 3d1bb16493
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21533764
Change-Id: I04cbb24dc071677a8e6f5c4fa8981efc5bec6d34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 16:59:30 +00:00
3d1bb16493
Merge "Fix taskbar drag view scale when returning to original icon" into tm-qpr-dev
2023-02-22 16:24:48 +00:00
4de6d066df
Merge "Introduce launchable versions of common view types." into tm-qpr-dev am: 8ca28c4e63 am: 1252e573af
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21150245
Change-Id: Iff2bfcbfbca642edf503c5ed481d6f0855ee9315
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 14:14:15 +00:00
f6fc3019a6
Merge "[Unfold transition] Hide invisible workspaces during animation" into tm-qpr-dev am: 92c93bdda5 am: de32174e7f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21335338
Change-Id: I6176aa0c3e5a472c3e57793bb26039f6e74baeba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 14:09:56 +00:00
4faa11aea1
Merge "Animate grid tasks to modal state." into tm-qpr-dev am: 1b27affb03 am: 3eadaa7d77
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21060663
Change-Id: Icd9a71482cfbb235d03b0fadfbfd6f74d4bc44d8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 14:09:34 +00:00
1252e573af
Merge "Introduce launchable versions of common view types." into tm-qpr-dev am: 8ca28c4e63
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21150245
Change-Id: I23b0a77aa6ad256360e0bca7e2eb8556fff0abb5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 13:02:04 +00:00
de32174e7f
Merge "[Unfold transition] Hide invisible workspaces during animation" into tm-qpr-dev am: 92c93bdda5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21335338
Change-Id: I6392ab3ad9873eacecc03291a5af1f06f42853a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 13:01:45 +00:00
3eadaa7d77
Merge "Animate grid tasks to modal state." into tm-qpr-dev am: 1b27affb03
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21060663
Change-Id: I3fc5d3fde2fadf3e95383c3827be7901b3712ef5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 13:00:42 +00:00
8ca28c4e63
Merge "Introduce launchable versions of common view types." into tm-qpr-dev
2023-02-22 12:19:50 +00:00
92c93bdda5
Merge "[Unfold transition] Hide invisible workspaces during animation" into tm-qpr-dev
2023-02-22 11:20:16 +00:00
1b27affb03
Merge "Animate grid tasks to modal state." into tm-qpr-dev
2023-02-22 11:18:47 +00:00
87a93c6ecb
Expose taskbar toggled signal to Launcher
...
Bug: 246660615
Test: N/A
Change-Id: I6051bffa1097c43c617cbb9e8a6b8815dd065a30
2023-02-22 08:55:38 +00:00
3a36d4890a
Merge "Fix a couple of drag and drop issues from transient taskbar" into tm-qpr-dev am: 2a567ec85a am: b506ae73b0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21527497
Change-Id: I51be618db419357a60d0597f3f195ad284bd2c83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 06:22:44 +00:00
b506ae73b0
Merge "Fix a couple of drag and drop issues from transient taskbar" into tm-qpr-dev am: 2a567ec85a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21527497
Change-Id: Ica30f4d7a313b5966b8ca72654f4002e581faf31
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 05:23:21 +00:00
8e17afacdd
Merge "Move split functions from RecentsView to SplitSelectStateController" into tm-qpr-dev am: 54c262cd67 am: 06ed4db282
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21468212
Change-Id: I4f8fab35c7c4c1de91927fc01a3b8a90d8d4aacd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 03:51:29 +00:00
00f89fbbf6
Fix taskbar drag view scale when returning to original icon
...
- Use getSourceVisualDragBounds() if the target view is BubbleTextView;
this accounts for padding as well as extra ring inset for
PredictedAppIcon
- Also ensure we always use the final drag view scale when switching to
the system drag and drop, instead of using the current scale which
might be in the process of animating
Test: drag regular and predicted icons in taskbar, but drop it in a
region that doesn't accept it (e.g. the taskbar itself), check that the
return animation scales and offsets more correctly than before
Bug: 269814838
Change-Id: Ie8398b2617340e1d2568773563aa0263a3366940
2023-02-22 03:41:03 +00:00
2a567ec85a
Merge "Fix a couple of drag and drop issues from transient taskbar" into tm-qpr-dev
2023-02-22 03:38:38 +00:00
Alex Chau
Ats Jenk
TreeHugger Robot
Jagrut Desai
Charlie Anderson
Tracy Zhou
Sunny Goyal
Tiger Huang
Vinit Nayak
Tony Wickham
Luca Zuccarini
Nick Chameyev
Pat Manning