When swiping up from desktop, we need to temporarily show launcher views
when user may go to overview. Hide them again when user just swiped up for
taskbar. But not hide them user is swiping home.
Previously we were always hiding launcher views when user swiped up from
desktop and that led to home or transient taskbar.
This change ensures that we only change the visibility of launcher views
when overview ui is hidden, freeform tasks are still visible, and
gesture has ended.
Otherwise there were flickers when, after swiping home, we were hiding
launcher views and then showing them again shortly after as the freeform
tasks were now hidden.
Bug: 297562634
Test: be on desktop with some open apps
- swipe up to go home, observe that there are no flickers from
home screen icons, widgets or hotseat
- swipe up for transient taskbar, observe desktop apps remain
visible
- swipe up to go to overview, observe the other fullscreen apps
flow in from the side
Change-Id: I14f9f95a3a22fbca6878ecea24848f271dc951d7
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.
This relands I26edfec35dca14abe90b08e3c74de0446eda95d2 with a fix in
SplitSelectDataHolder.kt to call createPackageContext when user is null
instead of asserting that it is not null.
Bug: 294110802
Test: builds
Test: WMShellFlickerServiceTests
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4cc251e6c1bd5e06ef24a92e08aae043cf3f2587)
Merged-In: I4525d0fa83a1db9cc5cff90f340fc3f863537c01
Change-Id: I4525d0fa83a1db9cc5cff90f340fc3f863537c01
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.
Bug: 294110802
Test: builds
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2608381792389b60ba37c08afcea09dca3c6ff9c)
Merged-In: I26edfec35dca14abe90b08e3c74de0446eda95d2
Change-Id: I26edfec35dca14abe90b08e3c74de0446eda95d2
Test: manual - have transient taskbar
- have a bubble
- go to overview
- expand bubbles
=> observe that transient taskbar stashes
- collapse bubbles
=> observe that transient taskbar unstashes
- verify that expanding bubbles in app and on launcher
home behaves as expected (stashes taskbar in app and
don't see taskbar or stashed handle on home)
Bug: 284104811
Change-Id: I3d7057ed651e66ab2a0292725f30153ee4d6d51e
- Add ENABLE_TASKBAR_NO_RECREATION flag
When the flag is turned on,
* Always destroy and recreate
* Move task bar drag layer lifecycle from TaskbarActivityContext to TaskbarManager
* Wrap the drag layer into a fullscreen root view
Note that in order to preserve the window across multiple TaskbarActivityContext creations, the inset types and ids must stay the same, so it's extracted out.
Bug: 274517647
Test: Fold and unfold a few times. Use a few applications. Make sure the task bar is visible and in the right place (tested with ENABLE_TASKBAR_NO_RECREATION and FLAG_HIDE_NAVBAR_WINDOW both on, both off, and one on and one off)
Change-Id: Ic3f0aa3d056fe178a53b76b2ad6cc6b9bffd5898
We have too many cases where All Apps can relaunch the current task
behind it to the point where it will not be sustainable to manually
close AFVs in all of these cases.
Test: Manual
Fix: 299169192
Fix: 299169075
Fix: 299169073
Flag: No
Change-Id: If3d9aa756ff5e5d6fbaf5f91d2ccc0c5c11a5c23
If we do the reverse, there is a change onAttach will occur before the
callback is registered and invokable (e.g. overlay window already exists
for EDU).
Test: Manual
Fix: 299335210
Flag: None
Change-Id: Ic4befe900c9582e1b01c2bc4699b431f95efa617
- Breakout CL part 4
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist of clearing callbacks after calling close once, so that we don't run into scenario where user is able to close popup multiple times leading to crash.
Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: Ie4cd95c69a559a17b7c19a64a71ccf6ac20542d7
Launcher support for the user education logic described in ag/24587530.
Bug: 275077944
Test: TBD
Flag: WM_BUBBLE_BAR
Change-Id: I2b9a6ecde332de6305ad574c41d8322d8bb5d7ad
ActivityLaunchAnimator.Controller.fromView requires an instance of LaunchableView, however findViewWithBackground had no checks to return one. updated the check to make the exception less likely.
Flag: not needed
Fixes: 297564681
Test: ran launcher and launched apps
Change-Id: Iddbe55c1ff66b067f8456d058cbc60a2a698c4ae
Merged-In: Iddbe55c1ff66b067f8456d058cbc60a2a698c4ae
ActivityLaunchAnimator.Controller.fromView requires an instance of LaunchableView, however findViewWithBackground had no checks to return one. updated the check to make the exception less likely.
Flag: not needed
Fixes: 297564681
Test: ran launcher and launched apps
Change-Id: Iddbe55c1ff66b067f8456d058cbc60a2a698c4ae
Tracy Zhou
Jagrut Desai
Mady Mellor
Ats Jenk
Colin Cross
Brian Isganitis
Ivan Tkachenko
Schneider Victor-tulias
Andy Wickham
fbaron
Vinit Nayak
Brandon Dayauon
Saumya Prakash
Sunny Goyal
Tony Wickham