Commit Graph

11086 Commits

Author SHA1 Message Date
Hyunyoung Song 5eae3c0a0a Remove ConcurrentModificationException for snapshot logging
Bug: 159282737

Change-Id: I37edcf6aa11272b488a0633716567c48e56e5433
2020-06-19 16:12:43 -07:00
Zak Cohen aef8b86b4a Image actions - fix uri permissions.
Feedback wasn't working, also Share wasn't showing its preview.

Bug: 159122067
Test: built and run locally
Change-Id: Iccea012a8fc0009a6a980f6233f42c4e7619f4ec
2020-06-19 18:02:44 +00:00
TreeHugger Robot a5e45ad485 Merge "Fixing jump when swiping up in landscape and in waterfall cutout" into ub-launcher3-rvc-dev 2020-06-19 07:17:02 +00:00
Bill Lin 70b5ca2505 Update state and touch region after one handed overlay changed
The matrix for overall modes x state changes:
-----------------------------------------------------
   Mode     |      State changed     | *Before|*After
-----------------------------------------------------
  OneHanded |  Portrait->Landscape   |  80dp  |  32dp
  OneHanded |  Landscape->Portrait   |  32dp  |  80dp
-----------------------------------------------------
  OneHanded |  Disable->Enable       |  32dp  |  32dp
 (Landscape)|  Enable->Disable       |  32dp  |  32dp
-----------------------------------------------------
  OneHanded |  Disable->Enable       |  32dp  |  80dp
 (Portrait) |  Enable->Disable       |  80dp  |  32dp
-----------------------------------------------------
  NO_BUTTON |  Portrait->Landscape   |  32dp  |  32dp
  NO_BUTTON |  Landscape->Portrait   |  32dp  |  32dp
  2 BUTTON  |  Portrait->Landscape   |  48dp  |  48dp
  2 BUTTON  |  Landscape->Portrait   |  48dp  |  48dp
  3 BUTTON  |  Portrait->Landscape   |  48dp  |  48dp
  3 BUTTON  |  Landscape->Portrait   |  48dp  |  48dp
-----------------------------------------------------
* dimen : navigation_bar_gesture_height

Test: adb bugrepot | grep mOneHandedModeRegion
Test: manually triger one handed
Test: atest WindowInsetsBehaviorTests
Test: atest com.android.launcher3.memory.MemoryTests
Test: flake -once
Test: rnlot -t com.android.launcher3.memory.MemoryTests
Bug: 157958539
Bug: 159183864
Change-Id: I19755938c3c93eb59a9f621af5722f5679c1da14
2020-06-19 10:23:43 +08:00
Samuel Fufa a529cd0f5f Merge "Allow Users to migrate their hotseat when returning from AiAi" into ub-launcher3-rvc-dev 2020-06-19 00:51:18 +00:00
Samuel Fufa d25a112b0e Allow Users to migrate their hotseat when returning from AiAi
- If a user has mostly predicted hotseat, show a snack bar. otherwise, show migration option.
- Guard onboarding activity with permission `com.google.android.apps.nexuslauncher.permission.HOTSEAT_EDU`

Bug: 158569583
Test: Manual
Change-Id: Id0c1c812233fcf288a2f49848720199dedd2015d
2020-06-18 16:38:58 -07:00
thiruram ffb55ddece Deprecates LAUNCHER_ALL_APPS_RANKED event.
LauncherUiChanged.rank field is repurposed to store all apps rank.

Change-Id: Iabad98312589d8f53b6547433540f3ec9dff0b3f
2020-06-18 15:08:16 -07:00
Jon Miranda 1bbd2831f3 Fix bug where All Apps Edu gets closed via user input before animation ends.
Also fixes bug where user continuously swipes to hint view causes count
to increase more than the max count which prevents all apps edu from showing.

Bug: 151768994
Change-Id: I3186398d441e723a2cfb6e396b03944502a65cf5
2020-06-18 13:40:33 -07:00
Sunny Goyal b64fc6c26f Fixing jump when swiping up in landscape and in waterfall cutout
> Adding tests for TaskViewSimulator to ensure proper calculations
> Disabling orientation listener while user is interacting with quickstep

Bug: 158781568
Bug: 156891776
Change-Id: I299c3b1243ac0dbf28faee1b8566c77ea3954e33
2020-06-18 00:29:00 -07:00
Hyunyoung Song 714659f6d0 Add LAUNCHER_WORKSPACE_SNAPSHOT event_id
Bug: 159210161
Change-Id: Ie8e843ee10bf4ab0761232a3e61eb28e487666ab
2020-06-17 22:39:36 -07:00
TreeHugger Robot adb6352bac Merge "Don't rely on nav mode change listener for oriented state" into ub-launcher3-rvc-dev 2020-06-18 04:44:31 +00:00
TreeHugger Robot 9c126682d7 Merge "Snapshot logging only use cloned model thread folder contents Bug: 158826147" into ub-launcher3-rvc-dev 2020-06-18 04:34:56 +00:00
Hyunyoung Song 398c42fe6b Snapshot logging only use cloned model thread folder contents
Bug: 158826147

Change-Id: I9aea9fbc706b0dffa3f6abeaac663b072d62ad58
2020-06-17 20:59:45 -07:00
TreeHugger Robot 27ed32ac7e Merge "Updated recents oriented state on split screen" into ub-launcher3-rvc-dev 2020-06-18 02:35:16 +00:00
Miranda Kephart 1bb17f2658 Merging from ub-launcher3-rvc-dev @ build 6595814 am: efdc4e2318 am: 9cb1795a71 am: ad4bd43b8f am: 9269333de9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11885879

Change-Id: Ie7d2e841b2d41504e07633f116d80b4e3adde59f
2020-06-17 20:49:31 +00:00
TreeHugger Robot c0c0991231 Merge "Disabling OverviewActions when rotated." into ub-launcher3-rvc-dev 2020-06-17 20:40:56 +00:00
Sreyas f91c1d0ef1 Disabling OverviewActions when rotated.
Bug: 157272300
Bug: 159135247
Change-Id: I9c9eeb49b7d18c1c81a830b7a35113070e7ac793
2020-06-17 12:37:14 -07:00
thiruram c6a38ba5d8 Replaces StatsLogManager.log with StatsLogManager.logger()
Bug: 159170445
Change-Id: Ice6c8a9ae30d8e6b3843bfe42926053849bf9fe0
2020-06-17 17:32:54 +00:00
thiruram d8405a63d2 Replace StatsLogManager with builder pattern.
Follow up CLs will remove the deprecating log methods and update their references.

Bug: 159170445
Change-Id: I5dfd30209eeba561df1b528a6305ca5923ba42a2
2020-06-17 08:46:43 -07:00
Bill Lin f69563e935 Revert "Update state and touch region after one handed overlay changed"
This reverts commit a66dafe617.

Reason for revert: b/159183864 introduce com.android.launcher3.memory.MemoryTests failed after this CL merged.

Due to I need more time to investigate the root cause and do not block MemoryTests, revert this CL temporary. 

Change-Id: I0408123e36c55a262ee0f1080cd6612785b3f527
2020-06-17 11:21:24 +00:00
Vinit Nayak 8401308c14 Don't rely on nav mode change listener for oriented state
When nav mode state changes, launcher gets
re-instantiated, which means the listener for
nav mode changes often gets destroyed before it
even gets fired. Rely on the initial setup to
set the correct nav mode.

The other bug with relying
on the initial value was that we were initially
getting the old nav mode when initFlags was called
from the ctor, but then the correct updated nav
mode when called from initListeners(). The first
call would enable rotation but then the second
call wasn't disabling it. Now we toggled based on
nav mode each time.

Another bug fix in RecentsView was not calling
update when launcher rotation is enabled. That was
added when previously we were using HOME_ROTATED
and PORTRAIT as different PagedViewHandlers to
differentiate when launcher rotation was enabled.
HOME_ROTATED is now removed, so we no longer need
to change the internal state of RecentsOrientedState.

Fixes: 159176222
Change-Id: I2a37880ce3cf835ca5b9b165ce3840537facee6c
2020-06-16 19:41:16 -07:00
Miranda Kephart efdc4e2318 Merging from ub-launcher3-rvc-dev @ build 6595814
Bug:150504032
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-rvc-dev_rvc-dev_6595814.html

Change-Id: I4be85d0e52cc3cb8801012a7313a269851680c8b
2020-06-16 20:52:28 +00:00
TreeHugger Robot cf4e6cd055 Merge "Fixing sysui scrim not updating in landscape UI" into ub-launcher3-rvc-dev 2020-06-16 19:00:24 +00:00
Vinit Nayak 746b82e831 Updated recents oriented state on split screen
Launcher defaults to sensor rotation when in split
screen instead of the fixed portrait orientation.
We were setting the multi window flag but never
updating RecentsOrientedState's internal state to
reflect it.

Fixes: 158537350
Change-Id: Ib0e1cf4c2e0674a5af41ac11c532a50db0a6f0fa
2020-06-16 11:57:47 -07:00
Bill Lin a66dafe617 Update state and touch region after one handed overlay changed
The matrix for overall modes x state changes:
-----------------------------------------------------
   Mode     |      State changed     | *Before|*After
-----------------------------------------------------
  OneHanded |  Portrait->Landscape   |  80dp  |  32dp
  OneHanded |  Landscape->Portrait   |  32dp  |  80dp
-----------------------------------------------------
  OneHanded |  Disable->Enable       |  32dp  |  32dp
 (Landscape)|  Enable->Disable       |  32dp  |  32dp
-----------------------------------------------------
  OneHanded |  Disable->Enable       |  32dp  |  80dp
 (Portrait) |  Enable->Disable       |  80dp  |  32dp
-----------------------------------------------------
  NO_BUTTON |  Portrait->Landscape   |  32dp  |  32dp
  NO_BUTTON |  Landscape->Portrait   |  32dp  |  32dp
  2 BUTTON  |  Portrait->Landscape   |  48dp  |  48dp
  2 BUTTON  |  Landscape->Portrait   |  48dp  |  48dp
  3 BUTTON  |  Portrait->Landscape   |  48dp  |  48dp
  3 BUTTON  |  Landscape->Portrait   |  48dp  |  48dp
-----------------------------------------------------
* dimen : navigation_bar_gesture_height

Test: adb bugrepot | grep mOneHandedModeRegion
Test: manually triger one handed
Test: atest WindowInsetsBehaviorTests
Bug: 157958539

Change-Id: I0f4b5d18053058730a06c3c216e849850c0390f4
2020-06-16 14:11:21 +08:00
Samuel Fufa dc122e816a Merge "[WW logging] Log rankings for app launches" into ub-launcher3-rvc-dev 2020-06-16 04:41:54 +00:00
Samuel Fufa e9c4f401bd [WW logging] Log rankings for app launches
Bug: 158219113
Change-Id: Ib6db4e73e48ff27ca9d3a5348eea42e1f534dba1
2020-06-15 17:17:47 -07:00
Sunny Goyal 8cd8d15886 Fixing sysui scrim not updating in landscape UI
Bug: 156422012
Change-Id: I2e1e9149e8337dd663bf564bd1b7f661ec2864e9
2020-06-15 13:42:07 -07:00
TreeHugger Robot 8555146d9a Merge "Gates blur code behind BlurUtils#supportsBlursOnWindows." into ub-launcher3-rvc-dev 2020-06-15 18:14:01 +00:00
thiruram 8da127f175 Updates StatsLogManager to log LauncherAtom.ItemInfo directly.
This method is requied for logging tap on QSB with just container info.

Bug: 154717227

Change-Id: I0c61c86724b4faafe4073a578b92a654ca23727a
2020-06-14 02:02:08 +00:00
TreeHugger Robot e3a51fec39 Merge "Fixing sysui visibility changing multiple times on startup" into ub-launcher3-rvc-dev 2020-06-12 18:45:41 +00:00
TreeHugger Robot 1eb6b2acf6 Merge "Creating correct device profile when appContext and launcher context do not match" into ub-launcher3-rvc-dev 2020-06-12 18:37:30 +00:00
Jon Miranda 7c57559930 Gates blur code behind BlurUtils#supportsBlursOnWindows.
This "fixes" the bug where wallpaper zoom does not reset to 0 when
screen turns off since we no longer require a valid surface to set the depth
when blur is disabled.

Note that the bug still exists when blur is enabled, which will need to be
fixed in a follow up CL.

Bug: 157946272
Change-Id: I43179435885c95eb2ecf406fa5c291badf5a1ed3
2020-06-12 11:03:10 -07:00
Vinit Nayak 84dc3a45ee Notify SysUi on device rotation for back gesture
Whenever device rotates, we notify sysui to hide/show
the back gesture if the foreground app also rotates.
We also notify sysui when device rotates to match
the orientation of the current foreground app (this
is for apps with fixed rotations).

Fixes: 154580671
Test: Created test apps of different rotations
and ensured that back functionality was present when
attempting to go back.

Change-Id: I33a71698411d9bc2416b6660f8dbd53233628917
(cherry picked from commit 80303ac4b9)
Merged-In: I33a71698411d9bc2416b6660f8dbd53233628917
2020-06-12 17:25:37 +00:00
TreeHugger Robot 7183b2786c Merge "Notify SysUi on device rotation for back gesture" 2020-06-12 17:25:11 +00:00
Hyunyoung Song 13c2bc7303 LAUNCHER_APP_LAUNCH_TAP should log correctly for icons inside folder
Bug: 137777105

Change-Id: I5c1552481fc1b788ba41c57bfe97f126f55e5b16
2020-06-11 23:51:17 -07:00
TreeHugger Robot fb51d87e84 Merge "Hook one-handed gesture to expand notification panel by default" 2020-06-12 06:43:52 +00:00
TreeHugger Robot 662796d18b Merge "Fix quick switching to any task that already appeared" into ub-launcher3-rvc-dev 2020-06-12 05:22:44 +00:00
Vinit Nayak 05cd0aedf3 Notify SysUi on device rotation for back gesture
Whenever device rotates, we notify sysui to hide/show
the back gesture if the foreground app also rotates.
We also notify sysui when device rotates to match
the orientation of the current foreground app (this
is for apps with fixed rotations).

Fixes: 154580671
Test: Created test apps of different rotations
and ensured that back functionality was present when
attempting to go back.

Change-Id: I33a71698411d9bc2416b6660f8dbd53233628917
(cherry picked from commit 80303ac4b9)
2020-06-11 23:04:55 +00:00
Pinyao Ting 5c2f1a6fa4 Merging from ub-launcher3-rvc-dev @ build 6577335 am: 8020bf2f4b am: e0a0876062 am: af957e82c4 am: cd902c0fc0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11828234

Change-Id: I7def4bc74da0e4bf8ce19bd281d90945f45a6a3d
2020-06-11 09:58:01 +00:00
TreeHugger Robot bb58efabc8 Merge "Remove unused HomeRotatedPageHandler" into ub-launcher3-rvc-dev 2020-06-11 03:10:13 +00:00
Sunny Goyal de52876a2b Fixing sysui visibility changing multiple times on startup
> During startup shelftop is updated after all-apps, causing all-apps to
set the sysuiVisibility according to it's own UI

Bug: 156422012
Change-Id: Idee06249ad45946ed0a9dc84702510ad90a305f4
2020-06-10 19:13:36 -07:00
Vinit Nayak 84f30b213a Remove unused HomeRotatedPageHandler
Transfer functionality of choosing
task menu layout to PortraitPageHandler,
which is what it should have been to
begin with.

Fixes: 158484000
Change-Id: Iadda53e7e1f796c063a111823f7f6278f3fdbf58
2020-06-10 18:47:05 -07:00
TreeHugger Robot 743e25e2d2 Merge "Show discovery tip for hybrid hotseat" into ub-launcher3-rvc-dev 2020-06-10 23:22:14 +00:00
TreeHugger Robot ca5e9cb7ef Merge "Notify SysUi on device rotation for back gesture" into ub-launcher3-rvc-dev 2020-06-10 23:14:06 +00:00
Samuel Fufa 5b2da14e72 Show discovery tip for hybrid hotseat
Doc: go/hybrid-hotseat-tips

Issue 157683315: for fully populated hotseat, count returns to home screen and show discovery tip if Tip action was not tapped.
Issue 158301717: Don't use cached items if client has predicted items.

Test: Manual
Change-Id: I4747a1148caa62a6262fb6592d5185bdf216ede6
2020-06-10 15:12:55 -07:00
thiruram ba0a6b61a3 Log folder open event into WW.
Bug: 158597506

Sample Log: https://paste.googleplex.com/5351626992779264

Change-Id: Ifb2f061924035abc84472a9a03d1b4212588428b
2020-06-10 15:00:19 -07:00
Pinyao Ting 8020bf2f4b Merging from ub-launcher3-rvc-dev @ build 6577335
Bug: 150504032
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-rvc-dev_6577335.html

Change-Id: Ie1f44dd646088759fef66251fe9e5f584b804d73
2020-06-10 21:54:11 +00:00
thiruram 18c2495b8f Adds PredictedHotseatContainer to launcher_atom.proto
Used for differentiating logs from normal hotseat and predicted hotseat.

Bug: 158218197
Change-Id: I011ff724ea0916b32f680dc24e8d6090d3df766d
2020-06-10 10:44:58 -07:00
Jerry Chang dd3eb7d075 Hook one-handed gesture to expand notification panel by default
Notify to expand notification panel through SystemUiProxy when
one-handed mode disabled and one-handed gesture detected.

Bug: 154080211
Test: make and install
Test: manual disable one handed mode and swipe down to trigger
Test: verified the gesture works even outside of home page
Change-Id: Iacc0e506ccd04dd81f6182759c8af7d686a7b77b
2020-06-10 23:26:03 +08:00