Commit Graph

11086 Commits

Author SHA1 Message Date
Sunny Goyal 6cc492941b Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev am: b3eafe97bb am: b6cdee307b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032078

Change-Id: I250b79241b12f23c0f53d1710887bf7327071cfb
2021-06-21 23:11:44 +00:00
Tony Wickham 10018d2191 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev am: 82fc5c83a5 am: 4de1650940
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15052402

Change-Id: I3943bc9286ae242dca9e9256ea34e65937463a10
2021-06-21 23:11:35 +00:00
Sunny Goyal 696c612964 Fixing TaskView.launchTask.onEndCallback is not called
Sometimes onAnimaitonCancelled can be called without onCreate. Calling
onEnd in this case so that the sate is cleared

Removing additional subclassing for the runner

Bug: 190856140
Test: Manual
Change-Id: If105cb343cab446a4eac90a45184ce50c6e4c485
2021-06-21 16:06:40 -07:00
Sunny Goyal 871d435be2 Merge "Finish wrapped launcher animations if impl is gone" into sc-dev 2021-06-21 23:03:27 +00:00
Sunny Goyal a29220f6b6 Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev am: b3eafe97bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032078

Change-Id: I0361531f4ff2695d97b5e48c5abc0c40fe505112
2021-06-21 22:42:06 +00:00
Tony Wickham 16119f5004 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev am: 82fc5c83a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15052402

Change-Id: Ia8a964effbc89754cd7f29986404d6ba1474a668
2021-06-21 22:41:32 +00:00
Sunny Goyal b3eafe97bb Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev 2021-06-21 22:32:23 +00:00
zakcohen 061548668d Fade overview action buttons faster in overview -> home
Spec says transition should take ~80ms, default for this transition is
~300ms, so clamp to a quarter of the range.

Bug: 191699762
Test: Local
Change-Id: I5ef6701eee0d25d5d9987e05cb53aee3e5e8e143
2021-06-21 15:18:16 -07:00
Tony Wickham 82fc5c83a5 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev 2021-06-21 22:15:48 +00:00
Evan Rosky 08c3480b84 Finish wrapped launcher animations if impl is gone
If the runner impl is gone (since it is a weakreference), we
still need to complete the animation contract by calling the
finish callback, so do that.

Bug: 183993924
Test: atest ActivityMetricsLoggerTests
Change-Id: Idce1859f0417cb74bbb9884e0d06750539e4545e
(cherry picked from commit 8a672e15cc)
2021-06-21 20:51:12 +00:00
Sunny Goyal de644313b0 Fixing animation end not-called when cancelling state the animation recursively
Bug: 190856140
Test: Manual
Change-Id: I5d6a00c1d1c0e95e615b7f2115e3e4ebb56b987f
2021-06-21 13:47:49 -07:00
Tony Wickham 9c10d08e1e Ensure mConsumer isn't set to null in reset().
mResetGestureInputConsumer is not initialized until onUserUnlocked(), meaning it might still be null in reset(). Use NO_OP input consumer in that case.

Test: none
Bug: 191669813
Change-Id: Ib9edde50fba0b6164390ec2b5c877d3db74ddfeb
2021-06-21 13:24:01 -07:00
Tony Wickham 29d762fb82 Merge "Initial commit of taskbar stashing" into sc-v2-dev am: 0ac023196d am: a2be8926bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14941111

Change-Id: I3da658073e4ad181c872021f3b4faa8d6a2d1160
2021-06-21 19:56:54 +00:00
Tony Wickham 0ac023196d Merge "Initial commit of taskbar stashing" into sc-v2-dev 2021-06-21 15:56:12 +00:00
Jonathan Miranda db2f0df330 Merge "Fix bug where workspace alpha does not get set to 1 when animation gets cancelled." into sc-dev am: f9df8f3682 am: 24ae397544
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023032

Change-Id: Icc2e06db004672614609b009ffbdb37d092bc7ae
2021-06-20 23:10:13 +00:00
Jonathan Miranda 94df55bada Merge "Fix bug where workspace alpha does not get set to 1 when animation gets cancelled." into sc-dev am: f9df8f3682
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023032

Change-Id: I9ab72caa407fd3e6a2e6130bcf9e924ba2c7726c
2021-06-20 22:59:04 +00:00
Vinit Nayak 0e4375e3b7 Merge "Add IDs to buttons in 3 button nav for Taskbar" into sc-v2-dev am: 3fcc02b8dc am: 7107268df9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15027506

Change-Id: I7fc65aa447ab6ca63b3e5b0ff1802ad056ab4b56
2021-06-19 06:20:53 +00:00
Vinit Nayak b974a86c8f Add IDs to buttons in 3 button nav for Taskbar
Bug: 191449914
Test: testSwitchToOverview passes
See bug for more details

Change-Id: I108bbe7607181680bca7cb5fad5e7289191edde6
2021-06-18 18:20:44 -07:00
Sunny Goyal 63f52f8308 Merge "Fixing out of order taskbar callbacks" into sc-v2-dev am: d7e17a860f am: a5422c8902
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023048

Change-Id: I99bffa51e5d30143acd2805f4c9d4a841967fb99
2021-06-19 01:12:26 +00:00
Tony Wickham 3fd22847ac Initial commit of taskbar stashing
- Added StashedHandleViewController to provide properties such as ViewOutlineProvider to animate the handle that's shown in place of taskbar while it's stashed
- Added TaskbarStashController to coordinate the stashed state, including orchestrating the animation across taskbar controllers
- Added TaskbarStashInput consumer to detect long press in the nav region when taskbar is stashed

Behavior:
- Long pressing taskbar background animates to the stashed state by morphing the TaskbarView into the stashed handle view and offsetting the background offscreen
- We persist the stashed state across app launches and reboot; to unstash, long press the stashed handle
- We also visually unstash when going back home

Test: long press tasbkar background when in an app to stash it, long press the resulting stashed handle to unstash; while stashed, swipe up to home to also unstash until launching another app
Bug: 189503603
Change-Id: I698eff785388dff1ef717c76879719d6af236c2d
2021-06-18 17:51:39 -07:00
Sunny Goyal d7e17a860f Merge "Fixing out of order taskbar callbacks" into sc-v2-dev 2021-06-19 00:40:46 +00:00
Vinit Nayak dcd9a0cdd6 Merge "Default to requesting command type TOGGLE for OverviewCommandHelper" into sc-v2-dev am: 70565c5e7d am: 0d50bfacb9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15017522

Change-Id: I3e010dd812b4b8cc2a3d23081f2fc5328401ef88
2021-06-18 23:20:17 +00:00
Vinit Nayak 70565c5e7d Merge "Default to requesting command type TOGGLE for OverviewCommandHelper" into sc-v2-dev 2021-06-18 22:56:24 +00:00
Jon Miranda 651abb9924 Fix bug where workspace alpha does not get set to 1 when animation gets cancelled.
- Can also remove QSB from app launch animator, since its in the hotseat now.

Bug: 189458349
Test: manual
Change-Id: Ib41376e3f8c58166c6ee6fbfed38bdd443663df4
2021-06-18 15:39:36 -07:00
Sunny Goyal 6e1ce8ccb8 Fixing out of order taskbar callbacks
OnCreate can come before onDestroy for a previous activity which can
cause the callbacks for taskbar to get cleared

Bug: 190170303
Test: Presubmit
Change-Id: I48334605384d4604043a50ffc3d137f84575148a
2021-06-18 12:44:38 -07:00
Vinit Nayak 4d276961be Merge "Enable 3 button nav for taskbar" into sc-v2-dev am: ae7c8cacd5 am: fe043eafee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985475

Change-Id: I409cf319365ee2554236f5113dd8cc464f874367
2021-06-18 05:56:22 +00:00
Vinit Nayak ae7c8cacd5 Merge "Enable 3 button nav for taskbar" into sc-v2-dev 2021-06-18 05:43:41 +00:00
TreeHugger Robot 06292bf289 Merge "Fixing Taskbar not initialized properly on recreate" into sc-v2-dev am: cb207ef236 am: fcd4a6b131
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15019036

Change-Id: I56454821c074a01871452072f22c2c5e852c1f8d
2021-06-18 01:57:12 +00:00
Sunny Goyal deec62378c Fixing Taskbar not initialized properly on recreate
Bug: 187353581
Test: Manual
Change-Id: I6e675937a033a4edcb4fa4e8151c210e14e8f896
2021-06-17 15:19:12 -07:00
Schneider Victor-tulias 03c4fa8342 Update gesture nav tutorial back left and right videos
Bug: 188972959
Test: manual
Change-Id: I03aef0ad47f9a648f7a661c607dd3d4f1f2187c4
2021-06-17 14:07:16 -07:00
Vinit Nayak e91e4f0328 Default to requesting command type TOGGLE for OverviewCommandHelper
Parity with how sysui switches between apps for double
tapping recents button.

Fixes: 190660016
Test: Double tap to switch works, tapping fast also works
Change-Id: If6dda377d8accf564f3385e78c6721c677310361
2021-06-17 12:37:02 -07:00
Alex Chau 4d4dd93e75 Merge "Send TaskBar touch events to tests" into sc-v2-dev am: f77d45cce8 am: 1ffc292ed5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14736370

Change-Id: I01d6bd1faf3c6169a1f45e35458ec699a1d7dfda
2021-06-17 18:35:25 +00:00
Alex Chau f77d45cce8 Merge "Send TaskBar touch events to tests" into sc-v2-dev 2021-06-17 17:52:44 +00:00
Winson Chung 84f273878f Merge "Do some additional cleanup when switching handlers" into sc-dev am: caabfa1519 am: 3df79133f2 am: 1294809bbc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985080

Change-Id: I53529a2f0a90f4c4a71bd36c63b4793c8a683bfd
2021-06-17 17:31:44 +00:00
Winson Chung 3df79133f2 Merge "Do some additional cleanup when switching handlers" into sc-dev am: caabfa1519
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985080

Change-Id: I59c266315e6c5fe8989dcff36fe395457792c189
2021-06-17 17:01:52 +00:00
Winson Chung caabfa1519 Merge "Do some additional cleanup when switching handlers" into sc-dev 2021-06-17 16:48:42 +00:00
Alex Chau d28e78ddb6 Merge "Apply dismissScale on TaskView instead of TaskThumbnailView" into sc-v2-dev am: bdb1de88eb am: 8dfa3870a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15012756

Change-Id: If3ce86467bf800e1123bde7162feced42b0c4e59
2021-06-17 16:06:21 +00:00
Alex Chau 5ca9df757a Apply dismissScale on TaskView instead of TaskThumbnailView
- As icon is hidden while TaskView become focused, there is no need to apply the scaling on TaskThumbnailView only. Apply scaling on TaskView to simplify

Bug: 14622874
Test: manual
Change-Id: Idb5fc8540649d57a071a42d36388dedcdcf893eb
2021-06-17 13:37:10 +01:00
Alex Chau ecc32bd227 Send TaskBar touch events to tests
Bug: 191344757
Test: TaplTestsQuickstep.testOverview
Change-Id: I9e1a4c6d4616e5791762a6340944212e4631862e
2021-06-17 12:56:03 +01:00
Sunny Goyal 787fac692a Merge "Updating taskbar icon alignment state" into sc-v2-dev am: e900ec68d0 am: 95707aa4ed
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985085

Change-Id: Ie6c7f04a21dc7f4b3fcf14dce63062fefdfdc1fc
2021-06-16 22:33:58 +00:00
Sunny Goyal e900ec68d0 Merge "Updating taskbar icon alignment state" into sc-v2-dev 2021-06-16 22:08:07 +00:00
Jonathan Miranda 4ce9952f41 Merge "Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag." into sc-dev am: 28e39335bc am: 95168f389e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14987185

Change-Id: I85c35932622f001fac00a9f0031b2d00bbcf674e
2021-06-16 20:52:50 +00:00
Jonathan Miranda c01e87daf0 Merge "Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag." into sc-dev am: 28e39335bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14987185

Change-Id: Iecfbdc781852e24aafb92744f9a3de4ff5cbbd00
2021-06-16 20:39:08 +00:00
Jonathan Miranda 28e39335bc Merge "Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag." into sc-dev 2021-06-16 20:34:48 +00:00
Sunny Goyal 5cf86b263e Updating taskbar icon alignment state
Icon alignment is only tied to Launcher paused/resumed state
Creating two separate states for this:
  1) Launcher paused/resumed
  2) Active gesture interaction (live-titles can affect paused state)

Removing state handler dependency on taskbar visibility

Bug: 190170303
Bug: 187353581
Bug: 187919439

Test: Manual
Change-Id: Ia97cdf43cec1d9213f5dc2af8d66258b34c57514
2021-06-16 13:30:36 -07:00
Vinit Nayak 58ffbef8f0 Enable 3 button nav for taskbar
Bug: 180046394
Test: Switched between gesture and button nav on
phone and tablet.

Change-Id: Iac2357a3256f8b6b36ca49d3680594a91e824a5f
2021-06-16 13:26:21 -07:00
Jonathan Miranda 3cc034f52d Merge "App Shortcut menu bug fixes and polish." into sc-dev am: c846245f1b am: 5473ae0c18
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985072

Change-Id: I06b7f2356825b2a2672a2787e0a8a4659e9cb3d3
2021-06-16 18:34:08 +00:00
Jonathan Miranda 47f8a1c3ef Merge "App Shortcut menu bug fixes and polish." into sc-dev am: c846245f1b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985072

Change-Id: Icba377c0032eee2dacec8a3c4364fa5b958880b7
2021-06-16 18:19:16 +00:00
Jon Miranda b73e591712 Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag.
Bug: 191088291
Test: manual
Change-Id: Ia144c72e0fe1292ed856a37ee714a1cda50083d5
2021-06-16 18:13:23 +00:00
Jonathan Miranda c846245f1b Merge "App Shortcut menu bug fixes and polish." into sc-dev 2021-06-16 18:06:13 +00:00