When dragging bubble bar in launcher, show drop target when drag passes
middle of the screen.
Bug: 330585397
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: manual
Change-Id: I52c3e9ac0b7c36e2207640baf75dc44300b522ef
This CL changes the save app pair menu icon to the latest spec. It looks good!
Fixes: 331525186
Flag: N/A
Test: Manual
Change-Id: Ic73f78a27372aca565fce2e3be3e9f3b8ef1d942
- http://ag/q/topic:%22b/329255757%22 caused a regression that in landscape, action_buttons shifted up when ShareTarget become visible, because OverviewActionsView become taller when this happens, and the topMargin is no longer valid to put actions_button at the position we want
- Bring back layout_gravity="bottom" solves the issue, as bottomMarign is always correct
Fix: 331517987
Test: manual as ShareTarget requires AiAi interaction and cannot easily be mocked
Flag: None
Change-Id: Iadcdf5731485f42f9586703e34e55ed9b4121bf9
This CL sets gravity="start" and ellipsize="end" so that longer strings in the Overview app dropdown menu are still left-aligned and ellipsized when they are longer than the container.
Fixes: 330426535
Flag: N/A
Test: Manual
Change-Id: I1e62412c9b8be41a8dbb6b0597a69a283a56e3f0
- Removed the weight=3 space on left/right and replace with gracvity=central_horizontal
- Removed unused oav_three_button_space
- Removed irrelevant layout_gravity (gravity within parent), as the LinearLayout is already taking full parent width, and its vertical alignemnt si controlled by `updateVerticalMargin` in code
Bug: 329255757
Test: OverviewImageTest
Flag: None
Change-Id: Ice087dde7d3c36b4536d36ce82c382c31c124855
Increase IME switcher Left Margins to meet specifications for taskbar. Result: https://screenshot.googleplex.com/5Ab33jnZiDY5tqm
Flag: NONE
Test: Manually tested in Felix Landscape mode.
Bug: 324269623
Change-Id: Ife3714c4d22d96851618a88ed217009c4f9c3929
The small size of the screenshots and make text look odd. Implementing new UI specs to improve this.
- Updated icon position and size
- Added some blur to the thumbnail
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328259439
Fixes: 328692456
Test: opened KQS in dark and light mode
Change-Id: I2b20100ddeb562291edf5f0bacbce916002eee45
Bubble bar pointer arrow was being drawn outside of BubbleBarView
bounds.
This caused issues when alpha was applied to the BubbleBarView. With
alpha, BubbleBarView draw was clipped to its bounds and arrow was no
longer visible. This led to the arrow flickering during move animations.
Move animation updates alpha.
Move the pointer arrow inside the bounds of the bar view. Update the bar
height to include the arrow.
Update callers who rely on bubble bar content height to take into
account extra height for the arrow.
Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: move bubble bar left and right, observe arrow is visible
Change-Id: I05866b5c944361b2f10437c3641527ed3c594047
Adds bubble bar location to the update object that is sent by shell.
Allows repositioning the bubble bar if the location changes.
Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: manually sending the update to reposition, dragging coming soon
Change-Id: Id430a98116d860a7badcf607edc166c751e12cf8
Revert submission 26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN
Reason for revert: Test failure in question wasn't related to this topic b/328016248
Reverted changes: /q/submissionid:26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN
Change-Id: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
This CL sets an accessibility title so that TalkBack and other tools will properly read out the instructions on SplitInstructionsView.
Fixes: 323461342
Flag: ACONFIG com.android.wm.shell.enable_split_contextual TRUNKFOOD
Test: TalkBack announces the instructions immediately when the view appears, and is not interrupted.
Change-Id: I1666f0c374d40b31d732d3cca529f03a7f2f7f28
Second attempt at enabling this feature. See ag/25143701, linked bugs, and revert history for details. This patch is tested with mokey devices and does not crash!
This patch includes:
- Ability to "save app pair" from Overview Actions.
- Internally the actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.
- "Save app pair" option does not appear in icon menu when it is visible in the Actions Bar.
- Addition to go/quickstep/res/layout/overview_actions_container.xml to support addition of the new button.
Note: This patch introduces a slight regression where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Fixes: 315545418
Fixes: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I4b4ac525cfd5eb9cfcd757d0bffc7215b04f9a3d
Stash taskbar when
1) Software keybaord is docked
2) Input toolbar is placed at the taskbar area (stash so toolbar and taskbar would not overlap)
Testing result:
https://drive.google.com/file/d/1NMDexHl0FgyHFaOUh_GSEEUU2k08STJH/view?usp=sharing
Bug: 317251202
Test: TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet
Flag: N/A
Change-Id: I90662bc6e68f644e919f5c702059476b02519ed6
Touch targets have to meet a minimum of 48 dp to meet accessibility
requirements. The Done button in taskbar education was previously too short.
Fixes: 320600718
Test: Manual
Flag: N/A
Change-Id: I5fae302b82585e9793d7ede42dbcc6e6395254da
- This avoid diverging code path when animation is off
- Also made sure menuTranslationX and Y always reset when not needed
- Also remove AnimatedVectorDrawable in favour of scale animation in code, as AnimatedVectorDrawable doesn't work well when animation is off
Bug: 319086207
Test: OverviewMenuImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I4a18cf4aac3237031095c2600c777b6c4c3e518f