The problem here is that we are tracking hasWorkApps and usingTabs using the same value.
This leads to work/personal apps showing together when clearing search since mUsingTabs is overridden to false on setLastSearchQuery and later used to determine if tabs should show.
Bug: 198546279
Test: Manual
Change-Id: I7df5d65472703bedcc9dd688847d9ebd146d5f61
Merged-In: I7df5d65472703bedcc9dd688847d9ebd146d5f61
(cherry picked from commit 564e9ca223)
PackageInstallStateChangedTask had some redundant state handling that could lead to invalid states. Removed state handling (potential fix to b/198924992) along with logging to help debug b/198924992.
Test: Started and canceled an app download
Bug: 198924992
Change-Id: I8b8202ceb62a3265186d8d46a0e1be6afc83c080
(cherry picked from commit fbf4178ab7)
Test: Widgets fully load in launcher preview with correct size and color
Fix: 185306338, 191499358
Change-Id: I2d02d7a1328ed9ef5d3dfbec090dc1f9908dd527
Merged-In: I2d02d7a1328ed9ef5d3dfbec090dc1f9908dd527
Test: Flag available in developer options (does nothing)
Bug: 185306338
Change-Id: I74063d0ef29f828f740633ce0dab860672f69d3d
Merged-In: I74063d0ef29f828f740633ce0dab860672f69d3d
- Disables header protection on AOSP
- Fades in/out search box pill instead of sudden movements
- Work tabs protection shows and hides based on scroll position
Bug: 194106968 [APK attached]
Test: Manual
Change-Id: I5532847ddba3d4555003b0934b8fc846dc5a5cc7
The scrim visibility drives whether the launcher window is opaque or
not. We should track it and apply the flag instead of trying to catch it
through other Launcher life cycles.
Fixes: 195365607
Bug: 196403152
Test: tap on home button while launching app from overview
Change-Id: I2a00b86b602b5dd12c901433b92adcf0170be15e
(cherry picked from commit e4a9469156)
Wallpaper will zoom out as you drag the overlay
Test: manually pull overlay
Fixes: 192502999
Change-Id: I9067b70d10497d4e16a5ef601161fbedfa9307e1
Merged-In: I9067b70d10497d4e16a5ef601161fbedfa9307e1
(cherry picked from commit 87d752062e)
When a model preload call was made while the loader task is running
(eg: on enabling/disabling icon theme, Launcher reloads and then
launcher preview start a model-preload), it would cancel the original
loader and then start a new loader with empty callbacks. So the
model indeed get loaded, but the original callbacks never got notified
of it.
> Instead we only start preload if an existing task is not running.
> Also when preloading, we use existing callbacks, instead of using
empty callbacks
Bug: 193851085
Bug: 195155924
Test: Verified repro steps
Change-Id: I0a96310be8489756f364aa2a12e4345e1418733d
After http://ag/14980850, we block updateAppWidget until app widget
is restored. However, PendingAppWidgetHostView constructor relies
on updateAppWidget(null) to trigger set listener in getDefaultView().
We should call super.updateAppWidget(null) in the constructor instead.
Test: manual
Bug: 14980850
Change-Id: I30af9778a636af2ad822e7abc152b6f0bfdea1bf
- Take less space from cells
- Distribute some of the empty space above the workspace
- Already confirmed from previous testing that these thresholds
only affect taller devices
Bug: 194688362
Test: long press on app icons,
test drag and drop bounds
test drop target bounds
test folder opening bounds
test all grids on taller devices
Change-Id: If90b7663ab4afedca1193bdd73a0ae38a1f25243
If the qsb bottom margin is smaller than the bottom insets,
we'll fall back to centering the qsb in the available freespace.
Bug: 194435265
Test: 4x5 grid
multiple devices,
with: gesture nav enabled
3 button nav enabled
Merged-In: I9fd4f0da3f2bc9f0b38a621ad1192533260379e3
Change-Id: I711e7d168b80254e73df0d4e1854756d819a705b
- Ensure folder items are scaled to fit within the height/width in 4x5 mode.
- This bug surfaced now since we increased the icon size.
Bug: 194356039
Test: set display to large, set font to large
Change-Id: Ie360ca67c3c91649a471bce920b2fc6a82fb9661
=> We were not account for mBorderSpacing in the outline calculation
=> This was fine in most cases as this value is 0, but 4x5 appears to be the exception
Bug: 194227752
Test: manual, see video in bug.
Change-Id: Ib590bc142a0f65e75f92ee057f8b4f4b0f81521b
size
Issue: The header view height was obtained before any measurement.
Test: On Pixel 5 4x5 gird with Photo widget shown in recommended
table, make the device in landscape. Then open the full widgets
picker. The widgets picker can be scrolled. Before this fix,
scrolling is not possible.
Fix: 194172597
Change-Id: Ib30cf4b95d2ed23ff28f3d24e103f0e919b3a551
- Increase the overlap between the preview items and the background
so that it appears more intentional (lots of reports of users
thinking that its a bug)
- Fix bug where clip path was still clipping icons when
dragging and swiping to home.
Bug: 193701705
Bug: 191225536
Test: test 2 icon, 3 icon, and 4 icon folders
close folder on 2nd page, ensure clipping
ensure no preview items are clipped in drag view
ensure no preview items are clipped in swipe up to home
test 2x2, 3x3, 4x4, 4x5, and 5x5 grids to ensure no clipping
of folder icons
drag and drop folder in and out of hotseat
create folders (2 icon, 3 icon, 4 icon)
Merged-In: Id49bae33438e10248bef05450d7e2c92c2140748
Change-Id: Ic3708bd402704f0a6f57ae5315ef602e2bbc6d82
Steven Ng
Samuel Fufa
Hyunyoung Song
Andy Wickham
Schneider Victor-tulias
synch
Brian Isganitis
Sunny Goyal
Tony Wickham
TreeHugger Robot
Jon Miranda
Lucas Dupin
Adam Cohen