Commit Graph

370 Commits

Author SHA1 Message Date
sfufa@google.com dda4f2c602 [Work Profile] Fix NPE on WorkModeSwitch
Bug: 202868251
Test: manual
Change-Id: I16e149e0aab1b53f7a0e753f353ccace08cf6b71
2021-10-19 11:22:55 -07:00
sfufa@google.com 9f0981dc4f [Work profile][Test] Remove tracing logs for testWorkeduFlow
Bug: 159671700
Test: NA
Change-Id: I097134c45155f0e65ef4376fab803796f3fdb12a
2021-10-07 16:48:41 -07:00
sfufa@google.com 01e0009b71 [Work profile] Fix flickering work mode switch
Since there is no system broadcast with Intent.ACTION_MANAGED_PROFILE_ADDED, UserCache's user list does not get updated when a new profile is installed until launcher is restarted. This change fixes that problem by getting the freshest list of users directly from UserManager.

This change also applies the proper padding to work apps recycler-view after work mode switch is attached.

Test: Manual
Bug: 201191227
Change-Id: I0f570eba44ebb845d0d6f8c5f14a63f9a8c18539
2021-10-06 14:27:55 -07:00
Samuel Fufa abb827b376 Merge "[Foldable] Apply max width to AllApps in unfolded state." into sc-v2-dev 2021-09-29 22:07:42 +00:00
sfufa@google.com de0132939b [Foldable] Apply max width to AllApps in unfolded state.
Since we are applying the same iconWidth in AllApps as Workspace in unfolded state, this change restricts AllApps to span only the area required to display AllApps contents and not span full available width. Unfolded/phone behavior remains the same.

Bug: 199959857
Bug: 194259694
Test: visual
Change-Id: Ie5658d566f20e825e666ef17db79a87b07dc2936
2021-09-24 15:18:01 -07:00
Samuel Fufa 9ac78866d3 Merge "[Refactor] Extract work profile related logic from AllAppsContainerView to WorkProfileManager" into sc-v2-dev 2021-09-23 20:11:15 +00:00
y eb52419282 [Refactor] Extract work profile related logic from AllAppsContainerView to WorkProfileManager
Bug: 195623679
Test: presubmit
Change-Id: I9954fb40034d1804aaf19f0778f95477e48ccc8f
2021-09-22 16:35:56 -07:00
Alex Chau 8f990b94a2 Merge "Keep insets stable when taskbar is destroyed/recreated" into sc-v2-dev 2021-09-22 13:34:12 +00:00
Tony Wickham 7eb5b53865 Keep insets stable when taskbar is destroyed/recreated
- Calculate nav bar insets ourselves. Currently when taskbar is going to be present, we use taskbarSize as the nav bar insets. This is consistent with other existing calculations, but going forward we should instead always use the nav bar size instead of taskbar size, given we don't want taskbar to inset launcher (since taskbar is hidden).
- Also update tappable insets to be 0 in gesture mode. Test: Swipe to all apps, ensure there's no background protection at the bottom.

Test: Rotate device, no visual jumps
Test: Stash taskbar, quick switch a couple times without settling, and swipe up to overview; no jank due to reapplyState()

Bug: 198798034
Fixes: 197232424
Fixes: 197212581
Change-Id: I4c2bb5816dbb214846bd9f2a46c6f759c0545911
2021-09-21 13:52:36 -07:00
TreeHugger Robot 3b90e1099b Merge "[Search] Sync header Y translation with AllApps y scroll" into sc-v2-dev 2021-09-21 20:51:08 +00:00
TreeHugger Robot 0f4e4856a2 Merge "[AllApps] NORMAL <-> ALL_APPS motion clean fixes for AOSP" into sc-v2-dev 2021-09-20 21:50:58 +00:00
sfufa@google.com 6e91ccbe82 [Search] Sync header Y translation with AllApps y scroll
Instead of calling scrollToTop directly, calling  mHeader.reset scrolls recylcerview to top and reset headerView y translation

Bug: 195365449
Test: enable three button mode, open AllApps, slightly scroll so predictions are partially visible, tap on search box and then outside; verify AllApps is scrolled to top and header is reset appropriately.
Change-Id: I9ba7cf019cb23dd259356243dc2a6294ca5481fe
2021-09-19 22:37:06 -07:00
TreeHugger Robot 7b5aedc72d Merge "[Search] Apply background to entire SearchInput view instead of just EditText" into sc-v2-dev 2021-09-16 17:11:52 +00:00
Samuel Fufa 2397d60074 Scroll AllApps to top when new padding is set.
Bug: 198212488
Test: presubmit
Change-Id: I084939e3c7685531c56b1478887fd872e0e101e9
2021-09-15 14:40:39 -07:00
Samuel Fufa 776443b337 [AllApps] NORMAL <-> ALL_APPS motion clean fixes for AOSP
- Avoids drawing on scrim when headerProtection is not enabled.
- Defines a default staggered animation for all apps scrim and content per S design guidelines

[preview attached to bug]

Bug: 191259805
Test: visual
Change-Id: I0d625c9f0caba158ff58f12a39b4f18aedead84b
2021-09-10 18:30:33 -07:00
Samuel Fufa 47f80b5c9a [Search] Apply background to entire SearchInput view instead of just EditText
Bug: 199555357
Test: visual
Change-Id: Ice966416e901e7c601b44529d0422798e943e222
2021-09-10 16:29:53 -07:00
Samuel Fufa 564e9ca223 [Work] Fix work apps showing in personal tab
The problem here is that we are tracking hasWorkApps and usingTabs using the same value.
 This leads to work/personal apps showing together when clearing search since mUsingTabs is overridden to false on setLastSearchQuery and later used to determine if tabs should show.
Bug: 198546279
Test: Manual

Change-Id: I7df5d65472703bedcc9dd688847d9ebd146d5f61
2021-09-08 15:02:24 -07:00
Samuel Fufa e34c2f8272 Merge "[Search] Update AllApps header protection" into sc-v2-dev 2021-08-31 18:08:34 +00:00
Samuel Fufa 966e0507d6 Merge "[Work] Fix duplicate work button issue" into sc-v2-dev 2021-08-30 16:25:40 +00:00
y cb5bb989e3 [Work] Fix duplicate work button issue
Bug: 195623679
Test: manual
Change-Id: I882c5f7a196e07fa0dab3a2f27437abd233ec782
2021-08-30 00:27:21 -07:00
y 8dcd7e0ce7 [Search] Update AllApps header protection
- Disables header protection on AOSP
- Fades in/out search box pill instead of sudden movements
- Work tabs protection shows and hides based on scroll position

Bug: 194106968 [APK attached]
Test: Manual
Change-Id: I5532847ddba3d4555003b0934b8fc846dc5a5cc7
2021-08-29 22:56:54 -07:00
Hyunyoung Song 6e72c8bbba All apps memory leak fix / unregister data observer
Bug: 197702957

Test: adb shell dumpsys meminfo com.google.android.apps.nexuslauncher, ahat

Change-Id: Ia5732cced959e4a199d9c2b59f1f3941a2e23552
2021-08-26 15:18:47 -07:00
Hyunyoung Song 44424572b4 Fix work profile disable button falsing
Bug: 191996677

Test: before this CL: when tapping on immediately above keyboard when
keyboard is translating or when onApplyWindowInset is called, the
hidden (GONE) view handles touch and triggers work profile to be disabled.

After the CL, the button view is not attached to the parent container
when on personal tab. Also, the onApplyWindowInsets method translations
can only be called when work tab is selected.

Change-Id: Ib3e9a5c4b3280052f9ccb62a199ed256ae4e094f
2021-07-14 15:09:26 -07:00
Hyunyoung Song 2d8856537e Merge "Remove flicker when dismissing snackbar" into sc-dev 2021-07-02 20:29:59 +00:00
Hyunyoung Song 1b68cbb822 Remove flicker when dismissing snackbar
Bug: 191972314
Test: manual

Change-Id: Icf185b89c07b363ec44c77ba3ac1bdeb34e30e59
2021-07-02 11:35:53 -07:00
Hyunyoung Song 9804c0472e Fix NPE inside dispatchRestoreInstanceState
Bug: 192559704
Test: manual
Change-Id: I212518ac4a7feddd8e87f4be601332ea62e99313
2021-07-01 23:26:57 -07:00
Hyunyoung Song 0b9537e6fc Rebind recycler views if launcher activity restarted
Bug: 185038312
Test: manual
TL;DR;;
What was attempted but was too much refactoring of the code.

Failed attempt #1: try re triggering the search.
This was not trivial as SearchSession object is yet created.

Failed attempt #2: Restoring AdapterItems in AlphabeticalAppsList
This meant AdapterItems class and also it's children
had to extend Parceleable object.

Ultimate fix:
Original issue of dupe view id among slice and work recyclerview
should be fixed. And restoring should just work.

Change-Id: I1bddd6aa5bc736ade3b02f69aa947d64cfa467d6
2021-06-29 14:52:57 -07:00
Samuel Fufa 1e70c235cf Merge "Polish work for work profile" into sc-dev 2021-06-23 18:58:29 +00:00
Samuel Fufa ce820f51e2 Polish work for work profile
Bug: 191478900 Work profile toggle specs
Bug: 187761192 Fix issue where Installing app scrolling apps to top
Bug: 191121890	Fix issue where top of AllApps becomes empty when returning to AllApps
Bug: 191477329 String change for work profile paused state
Test: local
Change-Id: Idbaab333566b54afa3dc879f5bea98e1f77c44fc
2021-06-23 16:46:52 +00:00
Hyunyoung Song 7d3b25734a Hide searchbox when header protection is on.
Bug: 191726215
Test: manual
Change-Id: I086a05654faf718683ebe5dfbcf64b6bd6347ca8
2021-06-23 00:44:49 -07:00
Samuel Fufa e79b469986 Allow AllApps to restore current selected tab on activity recreate
This CL also fixes:

- Wrong tab selection on RTL
- Fixes header protection hydraulic scroll issue
- Work toggle button text background contrast

Bug: 186005219
Bug: 191250799
Bug: 191227662
Bug: 191349226
Test: Manual
Change-Id: I3777474c954ed0d542ac38ff552367904be147d3
2021-06-17 16:59:56 -05:00
Samuel Fufa efa5df380c Merge "Refactor FolderInsetAnimationCallback to be used with any view" into sc-dev 2021-06-17 18:48:49 +00:00
Samuel Fufa d04a92d1ed Refactor FolderInsetAnimationCallback to be used with any view
- Update ic_corp_off icon to outline
- Remove shadow from work toggle
- Translate work fab when keyboard is shown

Screenshot: https://screenshot.googleplex.com/593tEg7bE4kSS4y

Bug: 191251404
Bug: 191250785
Test: local
Change-Id: Ie7dddfd17eb90575a1e1f67e281070dd8d268f8d
2021-06-16 17:25:53 -05:00
Hyunyoung Song d2ad97989c Merge "All apps motion" into sc-dev 2021-06-16 20:14:46 +00:00
Hyunyoung Song 54a44d4c44 All apps motion
Bug: 189970327
Test: manual

TL;DR;;

equation: settleVelocity = releaseVelocity + interpolator 2nd deritive * t

Change-Id: I86fec339523fbc3bb347dec4affbd2d1c063d13d
2021-06-16 11:17:59 -07:00
Samuel Fufa dfc274364e Add work toggle to work apps paused message
This also fixes scrolling issues in landscape

Bug: 186857875
Bug: 161929312
Bug: 189983516
Bug: 190567199
screenshot: https://screenshot.googleplex.com/BCjcyJFqJo6W4Tr
Test: local
Change-Id: I7bcf23cc4be2fca936eba41342731789eb8f3292
2021-06-15 14:58:05 -05:00
Samuel Fufa 154ad76f40 Introduce inline education for work profile
Bug: 186857875
Test: local
Change-Id: I796b04fbb3ffc714a01104107774819d35034f93
2021-06-14 01:01:42 -05:00
Samuel Fufa 2f346b8666 Merge "[AllApps][Work] Introduce work toggle Fab" into sc-dev 2021-06-14 02:34:58 +00:00
Samuel Fufa 45e0e26971 [AllApps][Work] Introduce work toggle Fab
Screenshot: https://screenshot.googleplex.com/C4r7kKPxv3PKdyN
Bug: 186856928
Test: on-device
Change-Id: Ifd8ce20fcf2247a6e80537dc7631458e594a8a63
2021-06-13 20:01:20 -05:00
Anton Hansson 17ef90b2cb Merge "Revert "[AllApps][Work] Introduce work toggle Fab"" into sc-dev 2021-06-11 15:02:25 +00:00
Anton Hansson fc235903ab Revert "[AllApps][Work] Introduce work toggle Fab"
This reverts commit 08cca82eca.

Reason for revert: broke errorprone build
Bug: 190150515

Change-Id: I1d8707392310e745713b8780bdb957299b88a3a6
2021-06-11 14:05:07 +00:00
Hyunyoung Song 8f3d9eba02 Merge "Revert the squish translate from all apps" into sc-dev 2021-06-10 03:53:33 +00:00
Samuel Fufa 08cca82eca [AllApps][Work] Introduce work toggle Fab
Screenshot: https://screenshot.googleplex.com/C4r7kKPxv3PKdyN
Bug: 186856928
Test: on-device
Change-Id: I69ffa0ef367b182688e69c730fc9dee1afa7cadd
2021-06-09 17:13:07 +00:00
Hyunyoung Song afa327d176 Revert the squish translate from all apps
Bug: 189973274
Bug: 189975416

Test: manual, attached video on the bug
Change-Id: I881a2b79462e8d420b3dcb6a6b98adbe9e8e0394
2021-06-09 09:47:29 -07:00
Samuel Fufa 41f15a107f [Search] Resolve afterimage when closing allapps
Preview: https://drive.google.com/file/d/1AM6WAY4kImCgHueNvH6eXUtnHgK3U6vo/view?usp=sharing&resourcekey=0-3mzBobzFuzQXCNZRUlToYA
Test: Manual
Bug: 184711608
Bug: 188556051
Change-Id: Ib43c71083460c236347dd1f340b1ad95d7d4aa15
2021-05-25 17:34:18 -05:00
Samuel Fufa 76b33404b5 [Search] Update all apps header protection
- Introduce spacing between header protection and search box
- introduce vertical padding for "personal | work" tab
- animate tab header protection color change when docking

Test: Manual
preview: https://drive.google.com/file/d/1eS4B7hcLExxCdjSp1IzBcziKm-9w87UR/view?usp=sharing&resourcekey=0--mtY6bCC9GJpFSUC8I5d6w
Bug: 184946772
Change-Id: I840af27c7557f1dffd7a15874aa09833514b4bb1
2021-05-18 17:14:14 -05:00
Samuel Fufa 0a709374ae Fix header protection interactions
Bug: 184711608
Bug: 187790639
Preview: https://drive.google.com/file/d/1MDh71t8DQn0SxTQY3-GZTfIlGECQs_Kn/view?usp=sharing&resourcekey=0-ep9C3q9Meo8cQShVJqnKEw
Test: Manual
Change-Id: I9c939a894adc3e9cd1ed1beb7c11f9c2dd673824
2021-05-18 16:28:55 +00:00
Hyunyoung Song b83e8f614a Merge "Catch NPE for AllAppsContainerView.dispatchRestoreInstanceState" into sc-dev 2021-05-17 21:44:16 +00:00
Hyunyoung Song 05d3e86401 Fix searchbox font and other specs
Bug: 187654557
Test: manual, see attached image on the bug

Change-Id: I570df1bcc926258ca406810ea10b3d1fdd3cd2ec
2021-05-17 01:08:44 -07:00
Hyunyoung Song 2cecad8e75 Catch NPE for AllAppsContainerView.dispatchRestoreInstanceState
TL;DR;;
Missing view id for work profile recycler view
caused restore failure as there are different type of
views that contains same id. However, even after that fix,
lack of view id in slice views generated by other process
causes failure when mFlags on these not restored slice
views needs to be accessed.

Bug: 186596139
Test: manual
Change-Id: I8a97598c27acbc05ac8a39c50fe5862e541d62ad
2021-05-17 00:47:28 -07:00